From 8a6cb81d3a5cfd22859ac7c95a7085fcb6b42965 Mon Sep 17 00:00:00 2001
From: Miguel Palhas <mpalhas@gmail.com>
Date: Mon, 24 Aug 2026 15:50:28 +0100
Subject: [PATCH] feat(maestro): Enter submits the TUI draft pane from any
 field (#97)

DirPicker mirrors the web filter/picker split: typing narrows and the
next Enter submits with the highlighted project directly (nothing was
chosen yet); an explicit Up/Down move onto a different row is
mid-selection, so Enter there only chooses it and a further Enter (now
the active pick) submits. WorktreeChoice, BranchExisting, Preset and
BranchMode already apply their highlight eagerly on Up/Down/Left/Right,
so Enter always submits there. Advanced and WorktreeToggle keep
activating on Enter, matching the web form's own button controls.
---
 crates/maestro-tui/src/draft.rs | 177 ++++++++++++++++++++++++++++----
 1 file changed, 157 insertions(+), 20 deletions(-)

diff --git a/crates/maestro-tui/src/draft.rs b/crates/maestro-tui/src/draft.rs
index 9a4c360..cbc074c 100644
--- a/crates/maestro-tui/src/draft.rs
+++ b/crates/maestro-tui/src/draft.rs
@@ -199,6 +199,12 @@ pub struct DraftPane {
     /// Highlighted entry within the visible step-one list; the implicit
     /// `Other directory…` entry sits at index `visible_groups().len()`.
     pub highlighted: usize,
+    /// Set by an explicit Up/Down move, cleared by typing (#97): typing
+    /// mirrors the web form's plain filter input, where Enter always
+    /// resolves and submits; an explicit arrow move mirrors Tab landing on
+    /// a not-yet-active picker button there, where a first Enter only
+    /// chooses. See `dir_picker_choice_active` at the Enter match arm.
+    dir_picker_navigated: bool,
     pub cwd_raw_visible: bool,
     pub cwd_raw: crate::text_input::TextInput,
     pub picked_cwd: Option<PathBuf>,
@@ -270,6 +276,7 @@ impl Default for DraftPane {
             groups: Vec::new(),
             filter: crate::text_input::TextInput::default(),
             highlighted: 0,
+            dir_picker_navigated: false,
             cwd_raw_visible: false,
             cwd_raw: crate::text_input::TextInput::default(),
             picked_cwd: None,
@@ -769,6 +776,7 @@ impl DraftPane {
         if count == 0 {
             return;
         }
+        self.dir_picker_navigated = true;
         self.highlighted = ((self.selection() as i32) + delta).rem_euclid(count) as usize;
     }
 
@@ -804,6 +812,17 @@ impl DraftPane {
         rows
     }
 
+    /// Whether the highlighted step-one row is already the picked group
+    /// (#97): once true, a further Enter submits instead of re-picking it.
+    /// Always false on the trailing "Other directory…" row — picking it is
+    /// never a no-op, so it always takes the Enter to reveal the raw field.
+    fn dir_picker_choice_active(&self) -> bool {
+        let visible = self.visible_groups();
+        let sel = self.selection();
+        sel < visible.len()
+            && self.selected_group_key.as_ref() == Some(&group_key(&visible[sel].main))
+    }
+
     /// Act on the highlighted step-one box: reveals step two, defaulting per
     /// rule 4. The trailing entry reveals the free-text path input and
     /// clears both steps (rule 3).
@@ -933,27 +952,33 @@ impl DraftPane {
                 self.prev_field();
                 DraftInputResult::Consumed
             }
-            InputKey::Enter => match self.focused_field {
-                DraftField::Submit => DraftInputResult::Submit,
-                DraftField::DirPicker => {
-                    self.select_entry();
+            // Enter submits from any field (#97), mirroring web/src/spawnForm.ts.
+            // Two fields keep their own Enter instead: `DirPicker`, whose
+            // highlighted row isn't the picked one until a first Enter chooses
+            // it (the next Enter, now that it's active, falls through to
+            // submit); and the disclosure/toggle pair (`Advanced`,
+            // `WorktreeToggle`), which activate on Enter like a button rather
+            // than submitting, same as the web form's own `<button>` controls.
+            InputKey::Enter if self.focused_field == DraftField::DirPicker => {
+                let is_other_row = self.selection() >= self.visible_groups().len();
+                let choose_only =
+                    is_other_row || (self.dir_picker_navigated && !self.dir_picker_choice_active());
+                self.select_entry();
+                if choose_only {
                     DraftInputResult::Consumed
+                } else {
+                    DraftInputResult::Submit
                 }
-                DraftField::Advanced => {
-                    self.toggle_advanced();
-                    DraftInputResult::Consumed
-                }
-                DraftField::WorktreeToggle => {
-                    self.toggle_worktree();
-                    DraftInputResult::Consumed
-                }
-                // The existing-branch selection is live; Enter just confirms.
-                DraftField::BranchExisting => DraftInputResult::Consumed,
-                _ => {
-                    self.next_field();
-                    DraftInputResult::Consumed
-                }
-            },
+            }
+            InputKey::Enter if self.focused_field == DraftField::Advanced => {
+                self.toggle_advanced();
+                DraftInputResult::Consumed
+            }
+            InputKey::Enter if self.focused_field == DraftField::WorktreeToggle => {
+                self.toggle_worktree();
+                DraftInputResult::Consumed
+            }
+            InputKey::Enter => DraftInputResult::Submit,
             InputKey::Char {
                 c: ' ',
                 ctrl: false,
@@ -1025,6 +1050,7 @@ impl DraftPane {
                     DraftField::DirPicker => {
                         self.filter.handle_key(other);
                         self.highlighted = 0;
+                        self.dir_picker_navigated = false;
                     }
                     DraftField::CwdRaw => {
                         self.cwd_raw.handle_key(other);
@@ -1747,7 +1773,11 @@ mod tests {
             1,
             "type-to-filter narrows the list"
         );
-        draft.on_input(&InputKey::Enter);
+        assert_eq!(
+            draft.on_input(&InputKey::Enter),
+            DraftInputResult::Submit,
+            "#97: the project filter submits with the highlighted project in one Enter"
+        );
         assert_eq!(
             draft.picked_cwd.as_deref(),
             Some(Path::new("/repos/maestro"))
@@ -1759,6 +1789,113 @@ mod tests {
         );
     }
 
+    #[test]
+    fn enter_submits_immediately_from_ordinary_fields_97() {
+        let mut draft = DraftPane {
+            picked_cwd: Some(PathBuf::from("/repos/maestro")),
+            base_repo: Some(PathBuf::from("/repos/maestro")),
+            probed_cwd: Some(PathBuf::from("/repos/maestro")),
+            ..DraftPane::default()
+        };
+
+        for field in [
+            DraftField::Preset,
+            DraftField::Name,
+            DraftField::BranchNew,
+            DraftField::BranchMode,
+        ] {
+            draft.focused_field = field;
+            assert_eq!(
+                draft.on_input(&InputKey::Enter),
+                DraftInputResult::Submit,
+                "{field:?} should submit on Enter"
+            );
+        }
+
+        draft.selected_preset = draft.presets.len() - 1; // custom
+        draft.focused_field = DraftField::CustomCommand;
+        assert_eq!(draft.on_input(&InputKey::Enter), DraftInputResult::Submit);
+    }
+
+    #[test]
+    fn enter_submits_immediately_from_eager_apply_pickers_97() {
+        // WorktreeChoice and BranchExisting apply their highlight the moment
+        // Up/Down moves it (#96 rule 3/#54) — there is no separate "chosen
+        // vs highlighted" state left to confirm, so Enter always submits.
+        let mut draft = DraftPane::default();
+        draft.set_projects(
+            vec![repo_project(
+                "maestro",
+                "/repos/maestro",
+                "/repos/maestro",
+                1,
+                None,
+            )],
+            Utc::now(),
+        );
+        draft.focused_field = DraftField::DirPicker;
+        draft.on_input(&InputKey::Enter); // picks "maestro", reveals step two
+
+        draft.focused_field = DraftField::WorktreeChoice;
+        assert_eq!(draft.on_input(&InputKey::Enter), DraftInputResult::Submit);
+
+        draft.focused_field = DraftField::BranchExisting;
+        assert_eq!(draft.on_input(&InputKey::Enter), DraftInputResult::Submit);
+    }
+
+    #[test]
+    fn dir_picker_enter_chooses_then_submits_once_the_highlight_is_the_active_pick_97() {
+        let mut draft = DraftPane::default();
+        draft.set_projects(
+            vec![
+                project("maestro", "/repos/maestro", 1, Some("claude")),
+                project("other", "/repos/other", 2, Some("zsh")),
+            ],
+            Utc::now(),
+        );
+        draft.focused_field = DraftField::DirPicker;
+        draft.on_input(&InputKey::Enter); // picks "maestro" (nothing chosen yet, submits)
+        assert_eq!(
+            draft.picked_cwd.as_deref(),
+            Some(Path::new("/repos/maestro"))
+        );
+
+        // Arrow onto the other row: an explicit navigation away from the
+        // active pick is "mid-selection" — Enter here only chooses it.
+        draft.move_selection(1);
+        assert_eq!(
+            draft.on_input(&InputKey::Enter),
+            DraftInputResult::Consumed,
+            "navigating to a different row must not submit the old pick"
+        );
+        assert_eq!(
+            draft.picked_cwd.as_deref(),
+            Some(Path::new("/repos/other")),
+            "the new row is chosen"
+        );
+
+        // The highlight is now the active pick: the next Enter submits.
+        assert_eq!(draft.on_input(&InputKey::Enter), DraftInputResult::Submit);
+    }
+
+    #[test]
+    fn dir_picker_enter_on_other_directory_never_submits_directly_97() {
+        let mut draft = DraftPane::default();
+        draft.set_projects(
+            vec![project("maestro", "/repos/maestro", 1, None)],
+            Utc::now(),
+        );
+        draft.focused_field = DraftField::DirPicker;
+        draft.move_selection(1); // onto "Other directory…"
+
+        assert_eq!(
+            draft.on_input(&InputKey::Enter),
+            DraftInputResult::Consumed,
+            "reveals the raw field instead of submitting, like the web form's own button"
+        );
+        assert_eq!(draft.focused_field, DraftField::CwdRaw);
+    }
+
     #[test]
     fn up_down_moves_the_highlight_within_the_list() {
         let mut draft = DraftPane::default();