fix(maestro): re-pipe pane on recover so attach sees output (NAP-228)
`Tmux::pipe_pane` used `tmux pipe-pane -o`, which tmux documents as "only open a new pipe if no previous pipe exists." When `maestrod` restarts and `SessionManager::recover` re-issues `pipe-pane` against the adopted tmux session, the previous daemon process's pipe to a now-orphan FIFO is still active — so `-o` makes the call a no-op. The revived manager's PtyBridge reads from a fresh FIFO that tmux never feeds, and attach clients see input land in the pane but no output flow back. Drop the `-o`. tmux closes any existing pipe before opening the new one, which is what `pipe_pane` callers always wanted: `create` runs on a fresh session (nothing to clobber), `recover` actively needs the clobber. Test: `recover_re_pipes_pane_so_output_reaches_subscribers` creates a bash session under one manager, drops it, recovers under a second manager, sends keys, and asserts the echo bytes reach a fresh subscriber within 5s. Fails before the fix (stale pipe), passes after. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -335,7 +335,9 @@ impl SessionManager {
|
||||
let fifo_path = self.inner.fifo_dir.join(format!("{id}.fifo"));
|
||||
let bridge =
|
||||
PtyBridge::start_with_replay(fifo_path.clone(), self.inner.replay_bytes).await?;
|
||||
// Best-effort: re-pipe so output starts flowing again.
|
||||
// Re-pipe so output starts flowing again. `Tmux::pipe_pane` runs
|
||||
// without tmux's `-o` flag, so any stale pipe the previous daemon
|
||||
// left running to a now-unread FIFO is replaced (NAP-228).
|
||||
let _ = self
|
||||
.inner
|
||||
.tmux
|
||||
|
||||
Reference in New Issue
Block a user