naps62/maestro
Archived
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

tests: umbrella maestro binary has zero coverage of feature-gate combinations #10

New Issue
Closed
opened 2026-06-20 13:18:41 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-06-20 13:18:41 +01:00
Collaborator
Copy Link
Copy Source

The NAP-245 umbrella binary at crates/maestro/src/main.rs has no tests. The compile_error! guard near the top and the feature-gated subcommand routing are unverified.

What's missing:

  • An integration test (or CI matrix) that invokes cargo build --no-default-features --features {cli|daemon|tui} for each feature subset.
  • A umbrella_binary_dispatches_each_subcommand test that spawns the built binary with daemon, tui, and a CLI subcommand and asserts it routes correctly.
  • A test that the is_cli_subcommand tracing-filter selection matches the actual subcommand category.

Failure scenario:
A future change that breaks one feature subset (e.g. a daemon-gated dep accidentally becoming required) only surfaces when a user tries cargo install --no-default-features --features daemon maestro and gets a confusing error.

Updated 2026-08-22: the single-host refactor dropped the registry feature and subcommand; the feature set is now cli, daemon, tui (all three on by default).

Migrated from Linear NAP-271 - original status: In Progress

The NAP-245 umbrella binary at `crates/maestro/src/main.rs` has no tests. The `compile_error!` guard near the top and the feature-gated subcommand routing are unverified. **What's missing:** * An integration test (or CI matrix) that invokes `cargo build --no-default-features --features {cli|daemon|tui}` for each feature subset. * A `umbrella_binary_dispatches_each_subcommand` test that spawns the built binary with `daemon`, `tui`, and a CLI subcommand and asserts it routes correctly. * A test that the `is_cli_subcommand` tracing-filter selection matches the actual subcommand category. **Failure scenario:** A future change that breaks one feature subset (e.g. a `daemon`-gated dep accidentally becoming required) only surfaces when a user tries `cargo install --no-default-features --features daemon maestro` and gets a confusing error. **Updated 2026-08-22:** the single-host refactor dropped the `registry` feature and subcommand; the feature set is now `cli`, `daemon`, `tui` (all three on by default). --- *Migrated from Linear **NAP-271** - original status: In Progress*
naps62-yolo added the code-review label 2026-06-20 13:18:41 +01:00
naps62-yolo self-assigned this 2026-09-04 19:39:20 +01:00
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/android
area/cli
area/config
area/daemon
area/protocol
area/tui
area/web
code-review
difficulty/easy
difficulty/hard
difficulty/medium
epic
Tracks a multi-issue epic / parent work item
 tui
type/docs
type/feat
type/fix
type/refactor
type/test
No labels code-review
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62-yolo (naps62-yolo (agent)) resende (Resende) naps62 (Miguel Palhas)
No Assignees naps62-yolo
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: naps62/maestro#10