naps62/maestro
Archived
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Correct the documented ACP unknown-update compatibility contract #186

New Issue
Closed
opened 2026-09-05 04:25:41 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-09-05 04:25:41 +01:00
Collaborator
Copy Link
Copy Source

The accumulated Structured view integration review found that docs/STRUCTURED-VIEW.md says every unrecognised ACP update becomes a Notice. The projection receives an already-deserialized SessionUpdate, and the dependency enum has no unknown-value fallback, so a genuinely new wire variant fails before projection.\n\nEither preserve/decode unknown updates as raw JSON and project them to Notice, with compatibility coverage, or narrow the contract so Notice only covers known but unspecialized variants. Choose the smallest behaviorally honest fix before the web/TUI renderers rely on this contract.\n\nFound after: #137\nBlocks: #140, #141

The accumulated Structured view integration review found that `docs/STRUCTURED-VIEW.md` says every unrecognised ACP update becomes a `Notice`. The projection receives an already-deserialized `SessionUpdate`, and the dependency enum has no unknown-value fallback, so a genuinely new wire variant fails before projection.\n\nEither preserve/decode unknown updates as raw JSON and project them to `Notice`, with compatibility coverage, or narrow the contract so `Notice` only covers known but unspecialized variants. Choose the smallest behaviorally honest fix before the web/TUI renderers rely on this contract.\n\nFound after: #137\nBlocks: #140, #141
naps62-yolo added this to the Structured view milestone 2026-09-05 04:25:41 +01:00
naps62-yolo added the area/protocoldifficulty/easytype/docs labels 2026-09-05 04:25:41 +01:00
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/android
area/cli
area/config
area/daemon
area/protocol
area/tui
area/web
code-review
difficulty/easy
difficulty/hard
difficulty/medium
epic
Tracks a multi-issue epic / parent work item
 tui
type/docs
type/feat
type/fix
type/refactor
type/test
No labels area/protocol difficulty/easy type/docs
Milestone
No items
No Milestone Structured view
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62-yolo (naps62-yolo (agent)) resende (Resende) naps62 (Miguel Palhas)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: naps62/maestro#186