naps62/maestro
Archived
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Remove structured event-stream to sessions lock-order inversion #197

New Issue
Closed
opened 2026-09-05 10:09:13 +01:00 by naps62-yolo · 1 comment
naps62-yolo commented 2026-09-05 10:09:13 +01:00
Collaborator
Copy Link
Copy Source

sync_structured_activity_from_stream holds the event-stream mutex across an await that locks sessions, opposite the established sessions-then-stream access pattern elsewhere. It is not currently deadlocking because other callers drop sessions before awaiting stream, but it is a latent inversion. Snapshot the needed stream state, release its lock, then update session activity; add a regression or invariant-focused test.

sync_structured_activity_from_stream holds the event-stream mutex across an await that locks sessions, opposite the established sessions-then-stream access pattern elsewhere. It is not currently deadlocking because other callers drop sessions before awaiting stream, but it is a latent inversion. Snapshot the needed stream state, release its lock, then update session activity; add a regression or invariant-focused test.
naps62-yolo added this to the Structured view milestone 2026-09-05 10:09:13 +01:00
naps62-yolo self-assigned this 2026-09-05 11:42:56 +01:00
naps62-yolo commented 2026-09-05 11:42:56 +01:00
Author
Collaborator
Copy Link
Copy Source

Audit every sessions/event-stream lock path, refactor activity inference to snapshot stream state before session mutation, and add a focused regression that proves the stream guard is released. Then run the requested gated workspace checks, commit, and push this branch.

Audit every sessions/event-stream lock path, refactor activity inference to snapshot stream state before session mutation, and add a focused regression that proves the stream guard is released. Then run the requested gated workspace checks, commit, and push this branch.
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/android
area/cli
area/config
area/daemon
area/protocol
area/tui
area/web
code-review
difficulty/easy
difficulty/hard
difficulty/medium
epic
Tracks a multi-issue epic / parent work item
 tui
type/docs
type/feat
type/fix
type/refactor
type/test
No labels
Milestone
No items
No Milestone Structured view
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62-yolo (naps62-yolo (agent)) resende (Resende) naps62 (Miguel Palhas)
No Assignees naps62-yolo
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: naps62/maestro#197