naps62/maestro
Archived
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

web: an unrelated session exiting tears down a draft form mid-edit #68

New Issue
Closed
opened 2026-08-23 21:37:15 +01:00 by naps62-yolo · 1 comment
naps62-yolo commented 2026-08-23 21:37:15 +01:00
Collaborator
Copy Link
Copy Source

multiview.render() destroys every draft form and rebuilds it. render() is reached from store.subscribe → closePane → mv.closeSession, so a session exiting anywhere — nothing to do with the pane being typed in — tears down a draft mid-edit.

The typed text survives, because emit() writes to leaf.draft and the rebuilt form re-seeds from it. What does not survive: focus, caret position, and selection. The rebuild also re-issues GET /api/info, GET /api/projects and GET /api/names for a form that was already sitting there.

Reuse the existing form when the leaf still has no sessionId instead of rebuilding it. The draft form already owns its own state and has a destroy(); the render path just needs to stop calling it for a leaf whose draft is unchanged.

Found by the integration review of blitz/spawn-v2. Not folded into #61 because it is a change to the render path rather than to the form, and #61 was in flight in the same file.

Depends on: #61

`multiview.render()` destroys every draft form and rebuilds it. `render()` is reached from `store.subscribe` → `closePane` → `mv.closeSession`, so a session exiting anywhere — nothing to do with the pane being typed in — tears down a draft mid-edit. The typed text survives, because `emit()` writes to `leaf.draft` and the rebuilt form re-seeds from it. What does not survive: focus, caret position, and selection. The rebuild also re-issues `GET /api/info`, `GET /api/projects` and `GET /api/names` for a form that was already sitting there. Reuse the existing form when the leaf still has no `sessionId` instead of rebuilding it. The draft form already owns its own state and has a `destroy()`; the render path just needs to stop calling it for a leaf whose draft is unchanged. Found by the integration review of `blitz/spawn-v2`. Not folded into #61 because it is a change to the render path rather than to the form, and #61 was in flight in the same file. Depends on: #61
naps62-yolo added this to the Spawn v2 milestone 2026-08-23 21:37:15 +01:00
naps62-yolo added the area/webdifficulty/mediumtype/fix labels 2026-08-23 21:37:15 +01:00
naps62-yolo commented 2026-08-23 22:45:35 +01:00
Author
Collaborator
Copy Link
Copy Source

Integrated into blitz/spawn-v2.

render() reuses the existing draft form when the leaf still has no session, so a session exiting elsewhere no longer costs the caret or re-issues the three fetches. Regression test in web/src/multiview.test.ts.

Verified on the integration branch: typecheck clean, 94 web tests.

Integrated into `blitz/spawn-v2`. `render()` reuses the existing draft form when the leaf still has no session, so a session exiting elsewhere no longer costs the caret or re-issues the three fetches. Regression test in `web/src/multiview.test.ts`. Verified on the integration branch: typecheck clean, 94 web tests.
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/android
area/cli
area/config
area/daemon
area/protocol
area/tui
area/web
code-review
difficulty/easy
difficulty/hard
difficulty/medium
epic
Tracks a multi-issue epic / parent work item
 tui
type/docs
type/feat
type/fix
type/refactor
type/test
No labels area/web difficulty/medium type/fix
Milestone
No items
No Milestone Spawn v2
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62-yolo (naps62-yolo (agent)) resende (Resende) naps62 (Miguel Palhas)
No Assignees
1 Participants
Due Date
No due date set.
Depends on
#61 web: worktree on by default in a repo, with new-or-existing branch
naps62/maestro
Reference: naps62/maestro#68