naps62/maestro
Archived
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

daemon: the shared-checkout guard is racy between the lock and the create #71

New Issue
Closed
opened 2026-08-24 00:41:38 +01:00 by naps62-yolo · 1 comment
naps62-yolo commented 2026-08-24 00:41:38 +01:00
Collaborator
Copy Link
Copy Source

crates/maestro-daemon/src/session.rs — the "two sessions must not share a checkout" check is racy.

create takes the sessions lock, tests whether any live record already owns the planned worktree path, then releases the lock before calling add_new/add_existing.

Two concurrent POST /api/sessions for the same base repo and branch both pass the test. The first creates the worktree; the second reaches run_add, finds the path present and registered for that branch, and adopts it. Two live sessions then run in one checkout — exactly what the check was added to prevent.

Hold the lock across the create, or reserve the planned path in the map before releasing it.

`crates/maestro-daemon/src/session.rs` — **the "two sessions must not share a checkout" check is racy.** `create` takes the sessions lock, tests whether any live record already owns the planned worktree path, then releases the lock before calling `add_new`/`add_existing`. Two concurrent `POST /api/sessions` for the same base repo and branch both pass the test. The first creates the worktree; the second reaches `run_add`, finds the path present and registered for that branch, and adopts it. Two live sessions then run in one checkout — exactly what the check was added to prevent. Hold the lock across the create, or reserve the planned path in the map before releasing it.
naps62-yolo added this to the Spawn v2 milestone 2026-08-24 00:41:38 +01:00
naps62-yolo added the area/daemondifficulty/mediumtype/fix labels 2026-08-24 00:41:38 +01:00
naps62-yolo commented 2026-08-24 09:39:21 +01:00
Author
Collaborator
Copy Link
Copy Source

Superseded by the Worktree lifecycle milestone, specifically #77.

This dissolves rather than gets fixed: once nothing is ever adopted and a path collision is sidestepped with a numeric suffix, there is no adoption path that could take over a hand-made worktree, and no single directory for two concurrent creates to contend over.

Superseded by the **Worktree lifecycle** milestone, specifically #77. This dissolves rather than gets fixed: once nothing is ever adopted and a path collision is sidestepped with a numeric suffix, there is no adoption path that could take over a hand-made worktree, and no single directory for two concurrent creates to contend over.
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/android
area/cli
area/config
area/daemon
area/protocol
area/tui
area/web
code-review
difficulty/easy
difficulty/hard
difficulty/medium
epic
Tracks a multi-issue epic / parent work item
 tui
type/docs
type/feat
type/fix
type/refactor
type/test
No labels area/daemon difficulty/medium type/fix
Milestone
No items
No Milestone Spawn v2
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62-yolo (naps62-yolo (agent)) resende (Resende) naps62 (Miguel Palhas)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: naps62/maestro#71