naps62/maestro
Archived
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

flake: the pnpmDeps hash has been stale since happy-dom was added #98

New Issue
Closed
opened 2026-08-24 14:42:03 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-24 14:42:03 +01:00
Collaborator
Copy Link
Copy Source

The flake pins `pnpmDeps.hash`, but the pin has not moved since the flake was first added in `401afbc`, while `web/pnpm-lock.yaml` last changed in `7130186` (adding happy-dom). A fixed-output derivation whose input has changed cannot build, so `nix build .#maestro-web` — and therefore the packaged install path and the Home Manager module — has been broken since then.

Found while implementing #72, which had to bump the hash to get a working tree. Recorded here because the cause has nothing to do with that issue and the fix rode in on its merge.

The lasting fix is not another manual bump: any lockfile change silently breaks the build again, and nothing in CI notices. Either build the flake package in CI so a stale hash fails loudly, or drop the pinned-hash approach for one that derives from the lockfile.

Verify with nix build .#maestro-web.

The flake pins \`pnpmDeps.hash\`, but the pin has not moved since the flake was first added in \`401afbc\`, while \`web/pnpm-lock.yaml\` last changed in \`7130186\` (adding happy-dom). A fixed-output derivation whose input has changed cannot build, so \`nix build .#maestro-web\` — and therefore the packaged install path and the Home Manager module — has been broken since then. Found while implementing #72, which had to bump the hash to get a working tree. Recorded here because the cause has nothing to do with that issue and the fix rode in on its merge. The lasting fix is not another manual bump: any lockfile change silently breaks the build again, and nothing in CI notices. Either build the flake package in CI so a stale hash fails loudly, or drop the pinned-hash approach for one that derives from the lockfile. Verify with `nix build .#maestro-web`.
naps62-yolo added this to the Spawn v2 milestone 2026-08-24 14:42:03 +01:00
naps62-yolo added the type/fixdifficulty/easyarea/config labels 2026-08-24 14:42:03 +01:00
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/android
area/cli
area/config
area/daemon
area/protocol
area/tui
area/web
code-review
difficulty/easy
difficulty/hard
difficulty/medium
epic
Tracks a multi-issue epic / parent work item
 tui
type/docs
type/feat
type/fix
type/refactor
type/test
No labels area/config difficulty/easy type/fix
Milestone
No items
No Milestone Spawn v2
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62-yolo (naps62-yolo (agent)) resende (Resende) naps62 (Miguel Palhas)
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: naps62/maestro#98