yolo/agent-skills
3
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(pr-daemon): review only when a review is requested

Browse Source 
Auto-review paid off on daemon and core PRs and reviewed clean on most
small ones, so spawning a reviewer on every non-draft PR spent tokens for
nothing. A review session now needs github plus one of your logins in the
PR's requested_reviewers; gitea spawns none.
This commit is contained in:
Miguel Palhas
2026-08-23 10:06:44 +01:00
parent 0f131f00a4
commit dba8416192
2 changed files with 36 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
README.md
+11 -2
View File
@@ -153,8 +153,17 @@ run and sets a later epoch, which filters more, never less.
| PR | skill | session |
|----|-------|---------|
| yours | `land` | default profile, `--yolo --trust-hooks` |
| yours, with `selfReview` | both | plus a reviewer on a different agent |
| someone else's | `review-pr` | `review` profile, no yolo, no trusted hooks, sandboxed |
| github, review requested from you | `review-pr` | `review` profile, no yolo, no trusted hooks, sandboxed |
| yours on github, review requested, with `selfReview` | both | plus a reviewer on a different agent |
**A reviewer needs an explicit request.** Two conditions, both required: the
forge is github, and one of your logins sits in the PR's `requested_reviewers`.
Gitea never spawns one, and a merely non-draft PR doesn't either. An audit of 47
closed PRs is where that came from — roughly a third of the findings paid for
themselves and nearly all of those were daemon and core changes, while small
PRs reviewed clean often enough that the reviewing cost bought nothing. Github
won't let you request a review from a PR's own author, so `selfReview` now only
fires when another of your logins opened the PR.
Both roles can run on one PR because the role is carried by the worktree
branch: the author side works on the head branch, the reviewer on a local