From 03ca4a26e8216a14ea5b7a4c7fc0733388199e70 Mon Sep 17 00:00:00 2001 From: "naps62-yolo (agent)" Date: Sat, 22 Aug 2026 19:52:57 +0100 Subject: [PATCH] feat(meta): TMDB search and movie lookup (#49) --- Cargo.lock | 744 +++++++++++++++++- crates/arr-meta/Cargo.toml | 10 + crates/arr-meta/src/cache.rs | 69 ++ crates/arr-meta/src/client.rs | 275 +++++++ crates/arr-meta/src/error.rs | 56 ++ crates/arr-meta/src/lib.rs | 27 +- crates/arr-meta/src/model.rs | 257 ++++++ .../tests/fixtures/movie_cidade_de_deus.json | 51 ++ .../arr-meta/tests/fixtures/movie_dune.json | 83 ++ .../tests/fixtures/movie_future_digital.json | 51 ++ .../tests/fixtures/movie_theatrical_only.json | 43 + .../tests/fixtures/movie_unreleased.json | 27 + .../arr-meta/tests/fixtures/search_dune.json | 39 + crates/arr-meta/tests/tmdb.rs | 463 +++++++++++ 14 files changed, 2177 insertions(+), 18 deletions(-) create mode 100644 crates/arr-meta/src/cache.rs create mode 100644 crates/arr-meta/src/client.rs create mode 100644 crates/arr-meta/src/error.rs create mode 100644 crates/arr-meta/src/model.rs create mode 100644 crates/arr-meta/tests/fixtures/movie_cidade_de_deus.json create mode 100644 crates/arr-meta/tests/fixtures/movie_dune.json create mode 100644 crates/arr-meta/tests/fixtures/movie_future_digital.json create mode 100644 crates/arr-meta/tests/fixtures/movie_theatrical_only.json create mode 100644 crates/arr-meta/tests/fixtures/movie_unreleased.json create mode 100644 crates/arr-meta/tests/fixtures/search_dune.json create mode 100644 crates/arr-meta/tests/tmdb.rs diff --git a/Cargo.lock b/Cargo.lock index 5040cca..27fab92 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2,6 +2,15 @@ # It is not intended for manual editing. version = 4 +[[package]] +name = "aho-corasick" +version = "1.1.5" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "c982642fa9e8606056828ee9a8505737230110bb1099153c79efe865c59d12ba" +dependencies = [ + "memchr", +] + [[package]] name = "allocator-api2" version = "0.2.21" @@ -63,6 +72,16 @@ version = "0.1.0" [[package]] name = "arr-meta" version = "0.1.0" +dependencies = [ + "chrono", + "reqwest", + "serde", + "serde_json", + "thiserror", + "tokio", + "tracing", + "wiremock", +] [[package]] name = "arr-parse" @@ -75,6 +94,16 @@ dependencies = [ name = "arr-probe" version = "0.1.0" +[[package]] +name = "assert-json-diff" +version = "2.0.2" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "47e4f2b81832e72834d7518d8487a0396a28cc408186a2e8854c0f98011faf12" +dependencies = [ + "serde", + "serde_json", +] + [[package]] name = "atoi" version = "2.0.0" @@ -84,6 +113,12 @@ dependencies = [ "num-traits", ] +[[package]] +name = "atomic-waker" +version = "1.1.2" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "1505bd5d3d116872e7271a6d4e16d81d0c8570876c8de68093a09ac269d8aac0" + [[package]] name = "autocfg" version = "1.5.1" @@ -154,6 +189,23 @@ version = "1.0.4" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "9330f8b2ff13f34540b44e946ef35111825727b38d33286ef986142615121801" +[[package]] +name = "cfg_aliases" +version = "0.2.2" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "f079e83a288787bcd14a6aea84cee5c87a67c5a3e660c30f557a3d24761b3527" + +[[package]] +name = "chacha20" +version = "0.10.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "d524456ba66e72eb8b115ff89e01e497f8e6d11d78b70b1aa13c0fbd97540a81" +dependencies = [ + "cfg-if", + "cpufeatures 0.3.0", + "rand_core 0.10.1", +] + [[package]] name = "chrono" version = "0.4.45" @@ -162,6 +214,7 @@ checksum = "1aa79e62e7697b8e29b513a68abacf485adcd1fe8284a4316c5ae868e6633327" dependencies = [ "iana-time-zone", "num-traits", + "serde", "windows-link", ] @@ -186,6 +239,15 @@ dependencies = [ "libc", ] +[[package]] +name = "cpufeatures" +version = "0.3.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "8b2a41393f66f16b0823bb79094d54ac5fbd34ab292ddafb9a0456ac9f87d201" +dependencies = [ + "libc", +] + [[package]] name = "crc" version = "3.4.0" @@ -226,6 +288,24 @@ dependencies = [ "typenum", ] +[[package]] +name = "deadpool" +version = "0.12.3" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "0be2b1d1d6ec8d846f05e137292d0b89133caf95ef33695424c09568bdd39b1b" +dependencies = [ + "deadpool-runtime", + "lazy_static", + "num_cpus", + "tokio", +] + +[[package]] +name = "deadpool-runtime" +version = "0.1.4" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "092966b41edc516079bdf31ec78a2e0588d1d0c08f78b91d8307215928642b2b" + [[package]] name = "der" version = "0.7.10" @@ -335,6 +415,12 @@ dependencies = [ "spin", ] +[[package]] +name = "fnv" +version = "1.0.7" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "3f9eec918d3f24069decb9af1554cad7c880e2da24a9afd88aca000531ab82c1" + [[package]] name = "foldhash" version = "0.1.5" @@ -350,6 +436,21 @@ dependencies = [ "percent-encoding", ] +[[package]] +name = "futures" +version = "0.3.34" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "9a31d2a3fbaaeb2af2368bbdd904aa8e812d3c04a1ee10d3171f52d556e5d0a3" +dependencies = [ + "futures-channel", + "futures-core", + "futures-executor", + "futures-io", + "futures-sink", + "futures-task", + "futures-util", +] + [[package]] name = "futures-channel" version = "0.3.34" @@ -394,6 +495,17 @@ version = "0.3.34" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "53c0fa8157de1303bfffdaa1cc2a673bfffb60102f76b0ef4441659124373fed" +[[package]] +name = "futures-macro" +version = "0.3.34" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "9fb9654ba8355388abeb8dcb4fc62f511300867002afc858860463bdd9fe0c44" +dependencies = [ + "proc-macro2", + "quote", + "syn 3.0.3", +] + [[package]] name = "futures-sink" version = "0.3.34" @@ -412,8 +524,10 @@ version = "0.3.34" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "0d50a92467f8ba5dd6e3ee5d4bd04d73ab2e4e1c44474a0674821dfce14b79bc" dependencies = [ + "futures-channel", "futures-core", "futures-io", + "futures-macro", "futures-sink", "futures-task", "memchr", @@ -438,8 +552,10 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "ff2abc00be7fca6ebc474524697ae276ad847ad0a6b3faa4bcb027e9a4614ad0" dependencies = [ "cfg-if", + "js-sys", "libc", "wasi", + "wasm-bindgen", ] [[package]] @@ -449,8 +565,30 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "300e883d756b2e4ec94e02791f39b04b522276138852cfc41d9fb7e904106099" dependencies = [ "cfg-if", + "js-sys", "libc", "r-efi", + "rand_core 0.10.1", + "wasm-bindgen", +] + +[[package]] +name = "h2" +version = "0.4.18" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "839c0e8a181239723652be9062bb56ca5bf5f64011f73b623f6f4fc59086a228" +dependencies = [ + "atomic-waker", + "bytes", + "fnv", + "futures-core", + "futures-sink", + "http", + "indexmap", + "slab", + "tokio", + "tokio-util", + "tracing", ] [[package]] @@ -485,6 +623,12 @@ version = "0.5.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "2304e00983f87ffb38b55b444b5e3b60a884b5d30c0fca7d82fe33449bbe55ea" +[[package]] +name = "hermit-abi" +version = "0.5.2" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "fc0fef456e4baa96da950455cd02c081ca953b141298e41db3fc7e36b1da849c" + [[package]] name = "hex" version = "0.4.3" @@ -518,6 +662,112 @@ dependencies = [ "windows-sys 0.61.2", ] +[[package]] +name = "http" +version = "1.5.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "918d3568bebf352712bc2ef3d46a8bcf1a75b373be6539de198e9105cbbf9ce0" +dependencies = [ + "bytes", + "itoa", +] + +[[package]] +name = "http-body" +version = "1.1.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "ca2a8f2913ee65f60facd6a5905613afaa448497a0230cc41ce022d93290bc2c" +dependencies = [ + "bytes", + "http", +] + +[[package]] +name = "http-body-util" +version = "0.1.5" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "23169fe34a5fbcdd3f3862e78fb9b6fccd5f02a6dc6f732547005d45631ce71c" +dependencies = [ + "bytes", + "futures-core", + "http", + "http-body", + "pin-project-lite", +] + +[[package]] +name = "httparse" +version = "1.10.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "6dbf3de79e51f3d586ab4cb9d5c3e2c14aa28ed23d180cf89b4df0454a69cc87" + +[[package]] +name = "httpdate" +version = "1.0.3" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "df3b46402a9d5adb4c86a0cf463f42e19994e3ee891101b1841f30a545cb49a9" + +[[package]] +name = "hyper" +version = "1.11.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "d22053281f852e11534f5198498373cbb59295120a20771d90f7ed1897490a72" +dependencies = [ + "atomic-waker", + "bytes", + "futures-channel", + "futures-core", + "h2", + "http", + "http-body", + "httparse", + "httpdate", + "itoa", + "pin-project-lite", + "smallvec", + "tokio", + "want", +] + +[[package]] +name = "hyper-rustls" +version = "0.27.9" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "33ca68d021ef39cf6463ab54c1d0f5daf03377b70561305bb89a8f83aab66e0f" +dependencies = [ + "http", + "hyper", + "hyper-util", + "rustls", + "tokio", + "tokio-rustls", + "tower-service", + "webpki-roots", +] + +[[package]] +name = "hyper-util" +version = "0.1.20" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "96547c2556ec9d12fb1578c4eaf448b04993e7fb79cbaad930a656880a6bdfa0" +dependencies = [ + "base64", + "bytes", + "futures-channel", + "futures-util", + "http", + "http-body", + "hyper", + "ipnet", + "libc", + "percent-encoding", + "pin-project-lite", + "socket2", + "tokio", + "tower-service", + "tracing", +] + [[package]] name = "iana-time-zone" version = "0.1.65" @@ -656,6 +906,12 @@ dependencies = [ "hashbrown 0.17.1", ] +[[package]] +name = "ipnet" +version = "2.12.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "6a756c3fac73139e83f14c2d742155dd2b78d3ee56597b419a0579b7bdd6dd78" + [[package]] name = "itoa" version = "1.0.18" @@ -744,6 +1000,12 @@ version = "0.4.34" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "f9f8bd3e56ce4dfc153cf470fffbfa98c7620958b312ca5c3a4b8d5181fd13c6" +[[package]] +name = "lru-slab" +version = "0.1.2" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "112b39cec0b298b6c1999fee3e31427f74f676e4cb9879ed1a121b43661a4154" + [[package]] name = "md-5" version = "0.10.6" @@ -782,7 +1044,7 @@ dependencies = [ "num-integer", "num-iter", "num-traits", - "rand", + "rand 0.8.7", "smallvec", "zeroize", ] @@ -816,6 +1078,16 @@ dependencies = [ "libm", ] +[[package]] +name = "num_cpus" +version = "1.17.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "91df4bbde75afed763b708b7eee1e8e7651e02d97f6d5dd763e89367e957b23b" +dependencies = [ + "hermit-abi", + "libc", +] + [[package]] name = "once_cell" version = "1.21.4" @@ -932,6 +1204,62 @@ dependencies = [ "unicode-ident", ] +[[package]] +name = "quinn" +version = "0.11.11" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "0c1a41e437b6bbd489372cd4971de128e85c855f56c57f283d20ff016cf7c0a8" +dependencies = [ + "bytes", + "cfg_aliases", + "pin-project-lite", + "quinn-proto", + "quinn-udp", + "rustc-hash", + "rustls", + "socket2", + "thiserror", + "tokio", + "tracing", + "web-time", +] + +[[package]] +name = "quinn-proto" +version = "0.11.17" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "04759210543be93709136e28212294a659ef5001836ff4eab4d663e4529bba83" +dependencies = [ + "bytes", + "getrandom 0.4.3", + "lru-slab", + "rand 0.10.2", + "rand_pcg", + "ring", + "rustc-hash", + "rustls", + "rustls-pki-types", + "slab", + "thiserror", + "tinyvec", + "tracing", + "web-time", +] + +[[package]] +name = "quinn-udp" +version = "0.5.15" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "35a133f956daabe89a61a685c2649f13d82d5aa4bd5d12d1277e1072a21c0694" +dependencies = [ + "cfg_aliases", + "libc", + "once_cell", + "socket2", + "tracing", + "windows-sys 0.61.2", +] + [[package]] name = "quote" version = "1.0.47" @@ -955,7 +1283,18 @@ checksum = "22f6172bdec972074665ed81ed53b71da00bfc44b65a753cfde883ec4c702a1a" dependencies = [ "libc", "rand_chacha", - "rand_core", + "rand_core 0.6.4", +] + +[[package]] +name = "rand" +version = "0.10.2" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "c7f5fa3a058cd35567ef9bfa5e75732bee0f9e4c55fa90477bef2dfcdbc4be80" +dependencies = [ + "chacha20", + "getrandom 0.4.3", + "rand_core 0.10.1", ] [[package]] @@ -965,7 +1304,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "e6c10a63a0fa32252be49d21e7709d4d4baf8d231c2dbce1eaa8141b9b127d88" dependencies = [ "ppv-lite86", - "rand_core", + "rand_core 0.6.4", ] [[package]] @@ -977,6 +1316,21 @@ dependencies = [ "getrandom 0.2.17", ] +[[package]] +name = "rand_core" +version = "0.10.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "63b8176103e19a2643978565ca18b50549f6101881c443590420e4dc998a3c69" + +[[package]] +name = "rand_pcg" +version = "0.10.2" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "caa0f4137e1c0a72f4c651489402276c8e8e1cf081f3b0ba156d2cbeef09e86a" +dependencies = [ + "rand_core 0.10.1", +] + [[package]] name = "redox_syscall" version = "0.5.18" @@ -995,6 +1349,87 @@ dependencies = [ "bitflags", ] +[[package]] +name = "regex" +version = "1.13.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "f020237b6c8eed93db2e2cb53c00c60a8e1bc73da7d073199a1180401450218d" +dependencies = [ + "aho-corasick", + "memchr", + "regex-automata", + "regex-syntax", +] + +[[package]] +name = "regex-automata" +version = "0.4.18" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "ad8553b9b26413251cbf30e620595c7a41b3887f03da04579c0e6b0d6a06b4b2" +dependencies = [ + "aho-corasick", + "memchr", + "regex-syntax", +] + +[[package]] +name = "regex-syntax" +version = "0.8.11" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "d6f6ff9a378485b298a5286656da665ba74413d36db0979633275d2e708145d4" + +[[package]] +name = "reqwest" +version = "0.12.28" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "eddd3ca559203180a307f12d114c268abf583f59b03cb906fd0b3ff8646c1147" +dependencies = [ + "base64", + "bytes", + "futures-core", + "http", + "http-body", + "http-body-util", + "hyper", + "hyper-rustls", + "hyper-util", + "js-sys", + "log", + "percent-encoding", + "pin-project-lite", + "quinn", + "rustls", + "rustls-pki-types", + "serde", + "serde_json", + "serde_urlencoded", + "sync_wrapper", + "tokio", + "tokio-rustls", + "tower", + "tower-http", + "tower-service", + "url", + "wasm-bindgen", + "wasm-bindgen-futures", + "web-sys", + "webpki-roots", +] + +[[package]] +name = "ring" +version = "0.17.14" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "a4689e6c2294d81e88dc6261c768b63bc4fcdb852be6d1352498b114f61383b7" +dependencies = [ + "cc", + "cfg-if", + "getrandom 0.2.17", + "libc", + "untrusted", + "windows-sys 0.52.0", +] + [[package]] name = "rsa" version = "0.9.10" @@ -1008,13 +1443,19 @@ dependencies = [ "num-traits", "pkcs1", "pkcs8", - "rand_core", + "rand_core 0.6.4", "signature", "spki", "subtle", "zeroize", ] +[[package]] +name = "rustc-hash" +version = "2.1.3" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "6b1e7f9a428571be2dc5bc0505c13fb6bf936822b894ec87abf8a08a4e51742d" + [[package]] name = "rustix" version = "1.1.4" @@ -1028,6 +1469,41 @@ dependencies = [ "windows-sys 0.61.2", ] +[[package]] +name = "rustls" +version = "0.23.43" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "0283386ce02abc0151e1761d08802dfe86c173b0b494af5cbc086574e453da06" +dependencies = [ + "once_cell", + "ring", + "rustls-pki-types", + "rustls-webpki", + "subtle", + "zeroize", +] + +[[package]] +name = "rustls-pki-types" +version = "1.15.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "2f4925028c7eb5d1fcdaf196971378ed9d2c1c4efc7dc5d011256f76c99c0a96" +dependencies = [ + "web-time", + "zeroize", +] + +[[package]] +name = "rustls-webpki" +version = "0.103.15" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "f3c3cf1d8b1e7d4927e2d154c3fcb02979afb9939629c62cd9048d4f07b60ac2" +dependencies = [ + "ring", + "rustls-pki-types", + "untrusted", +] + [[package]] name = "rustversion" version = "1.0.23" @@ -1117,7 +1593,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "a978451301f4db1d02937a4ab3ccce137717b81826e79b7d49ffe3244a13c3b8" dependencies = [ "cfg-if", - "cpufeatures", + "cpufeatures 0.2.17", "digest", ] @@ -1128,7 +1604,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "a7507d819769d01a365ab707794a4084392c824f54a7a6a7862f8c3d0892b283" dependencies = [ "cfg-if", - "cpufeatures", + "cpufeatures 0.2.17", "digest", ] @@ -1155,7 +1631,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "77549399552de45a898a580c1b41d445bf730df867cc44e6c0233bbc4b8329de" dependencies = [ "digest", - "rand_core", + "rand_core 0.6.4", ] [[package]] @@ -1318,7 +1794,7 @@ dependencies = [ "memchr", "once_cell", "percent-encoding", - "rand", + "rand 0.8.7", "rsa", "serde", "sha1", @@ -1357,7 +1833,7 @@ dependencies = [ "md-5", "memchr", "once_cell", - "rand", + "rand 0.8.7", "serde", "serde_json", "sha2", @@ -1439,6 +1915,15 @@ dependencies = [ "unicode-ident", ] +[[package]] +name = "sync_wrapper" +version = "1.0.2" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "0bf256ce5efdfa370213c1dabab5935a12e49f2c58d15e9eac2870d3b4f27263" +dependencies = [ + "futures-core", +] + [[package]] name = "synstructure" version = "0.13.2" @@ -1535,6 +2020,16 @@ dependencies = [ "syn 3.0.3", ] +[[package]] +name = "tokio-rustls" +version = "0.26.4" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "1729aa945f29d91ba541258c8df89027d5792d85a8841fb65e8bf0f4ede4ef61" +dependencies = [ + "rustls", + "tokio", +] + [[package]] name = "tokio-stream" version = "0.1.19" @@ -1546,6 +2041,20 @@ dependencies = [ "tokio", ] +[[package]] +name = "tokio-util" +version = "0.7.19" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "494815d09bf52b5548659851081238f0ca39ff638363907596da739561c62c52" +dependencies = [ + "bytes", + "futures-core", + "futures-sink", + "libc", + "pin-project-lite", + "tokio", +] + [[package]] name = "toml" version = "0.8.23" @@ -1587,6 +2096,51 @@ version = "0.1.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "5d99f8c9a7727884afe522e9bd5edbfc91a3312b36a77b5fb8926e4c31a41801" +[[package]] +name = "tower" +version = "0.5.3" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "ebe5ef63511595f1344e2d5cfa636d973292adc0eec1f0ad45fae9f0851ab1d4" +dependencies = [ + "futures-core", + "futures-util", + "pin-project-lite", + "sync_wrapper", + "tokio", + "tower-layer", + "tower-service", +] + +[[package]] +name = "tower-http" +version = "0.6.11" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "4cfcf7e2740e6fc6d4d688b4ef00650406bb94adf4731e43c096c3a19fe40840" +dependencies = [ + "bitflags", + "bytes", + "futures-util", + "http", + "http-body", + "pin-project-lite", + "tower", + "tower-layer", + "tower-service", + "url", +] + +[[package]] +name = "tower-layer" +version = "0.3.3" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "121c2a6cda46980bb0fcd1647ffaf6cd3fc79a013de288782836f6df9c48780e" + +[[package]] +name = "tower-service" +version = "0.3.3" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "8df9b6e13f2d32c91b9bd719c00d1958837bc7dec474d94952798cc8e69eeec3" + [[package]] name = "tracing" version = "0.1.44" @@ -1619,6 +2173,12 @@ dependencies = [ "once_cell", ] +[[package]] +name = "try-lock" +version = "0.2.5" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "e421abadd41a4225275504ea4d6566923418b7f05506fbc9c0fe86ba7396114b" + [[package]] name = "typenum" version = "1.20.1" @@ -1652,6 +2212,12 @@ version = "0.1.4" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "7df058c713841ad818f1dc5d3fd88063241cc61f49f5fbea4b951e8cf5a8d71d" +[[package]] +name = "untrusted" +version = "0.9.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "8ecb6da28b8a351d773b68d5825ac39017e680750f980f3a1a85cd8dd28a47c1" + [[package]] name = "url" version = "2.5.8" @@ -1682,6 +2248,15 @@ version = "0.9.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "0b928f33d975fc6ad9f86c8f283853ad26bdd5b10b7f1542aa2fa15e2289105a" +[[package]] +name = "want" +version = "0.3.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "bfa7760aed19e106de2c7c0b581b509f2f25d3dacaf737cb82ac61bc6d760b0e" +dependencies = [ + "try-lock", +] + [[package]] name = "wasi" version = "0.11.1+wasi-snapshot-preview1" @@ -1707,6 +2282,16 @@ dependencies = [ "wasm-bindgen-shared", ] +[[package]] +name = "wasm-bindgen-futures" +version = "0.4.77" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "6b7777d5cc23d0e91404e53ce2d5e8ec7acae3026b16233dba62cd3246457950" +dependencies = [ + "js-sys", + "wasm-bindgen", +] + [[package]] name = "wasm-bindgen-macro" version = "0.2.127" @@ -1739,6 +2324,35 @@ dependencies = [ "unicode-ident", ] +[[package]] +name = "web-sys" +version = "0.3.104" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "c435338968042f4f59a557f690a253676d47ce13ceb55d70100e7facf6620a30" +dependencies = [ + "js-sys", + "wasm-bindgen", +] + +[[package]] +name = "web-time" +version = "1.1.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "5a6580f308b1fad9207618087a65c04e7a10bc77e02c8e84e9b00dd4b12fa0bb" +dependencies = [ + "js-sys", + "wasm-bindgen", +] + +[[package]] +name = "webpki-roots" +version = "1.0.9" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "7dcd9d09a39985f5344844e66b0c530a33843579125f23e21e9f0f220850f22a" +dependencies = [ + "rustls-pki-types", +] + [[package]] name = "whoami" version = "1.6.1" @@ -1814,7 +2428,16 @@ version = "0.48.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "677d2418bec65e3338edb076e806bc1ec15693c5d0104683f2efe857f61056a9" dependencies = [ - "windows-targets", + "windows-targets 0.48.5", +] + +[[package]] +name = "windows-sys" +version = "0.52.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "282be5f36a8ce781fad8c8ae18fa3f9beff57ec1b52cb3de0789201425d9a33d" +dependencies = [ + "windows-targets 0.52.6", ] [[package]] @@ -1832,13 +2455,29 @@ version = "0.48.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "9a2fa6e2155d7247be68c096456083145c183cbbbc2764150dda45a87197940c" dependencies = [ - "windows_aarch64_gnullvm", - "windows_aarch64_msvc", - "windows_i686_gnu", - "windows_i686_msvc", - "windows_x86_64_gnu", - "windows_x86_64_gnullvm", - "windows_x86_64_msvc", + "windows_aarch64_gnullvm 0.48.5", + "windows_aarch64_msvc 0.48.5", + "windows_i686_gnu 0.48.5", + "windows_i686_msvc 0.48.5", + "windows_x86_64_gnu 0.48.5", + "windows_x86_64_gnullvm 0.48.5", + "windows_x86_64_msvc 0.48.5", +] + +[[package]] +name = "windows-targets" +version = "0.52.6" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "9b724f72796e036ab90c1021d4780d4d3d648aca59e491e6b98e725b84e99973" +dependencies = [ + "windows_aarch64_gnullvm 0.52.6", + "windows_aarch64_msvc 0.52.6", + "windows_i686_gnu 0.52.6", + "windows_i686_gnullvm", + "windows_i686_msvc 0.52.6", + "windows_x86_64_gnu 0.52.6", + "windows_x86_64_gnullvm 0.52.6", + "windows_x86_64_msvc 0.52.6", ] [[package]] @@ -1847,42 +2486,90 @@ version = "0.48.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "2b38e32f0abccf9987a4e3079dfb67dcd799fb61361e53e2882c3cbaf0d905d8" +[[package]] +name = "windows_aarch64_gnullvm" +version = "0.52.6" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "32a4622180e7a0ec044bb555404c800bc9fd9ec262ec147edd5989ccd0c02cd3" + [[package]] name = "windows_aarch64_msvc" version = "0.48.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "dc35310971f3b2dbbf3f0690a219f40e2d9afcf64f9ab7cc1be722937c26b4bc" +[[package]] +name = "windows_aarch64_msvc" +version = "0.52.6" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "09ec2a7bb152e2252b53fa7803150007879548bc709c039df7627cabbd05d469" + [[package]] name = "windows_i686_gnu" version = "0.48.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "a75915e7def60c94dcef72200b9a8e58e5091744960da64ec734a6c6e9b3743e" +[[package]] +name = "windows_i686_gnu" +version = "0.52.6" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "8e9b5ad5ab802e97eb8e295ac6720e509ee4c243f69d781394014ebfe8bbfa0b" + +[[package]] +name = "windows_i686_gnullvm" +version = "0.52.6" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "0eee52d38c090b3caa76c563b86c3a4bd71ef1a819287c19d586d7334ae8ed66" + [[package]] name = "windows_i686_msvc" version = "0.48.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "8f55c233f70c4b27f66c523580f78f1004e8b5a8b659e05a4eb49d4166cca406" +[[package]] +name = "windows_i686_msvc" +version = "0.52.6" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "240948bc05c5e7c6dabba28bf89d89ffce3e303022809e73deaefe4f6ec56c66" + [[package]] name = "windows_x86_64_gnu" version = "0.48.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "53d40abd2583d23e4718fddf1ebec84dbff8381c07cae67ff7768bbf19c6718e" +[[package]] +name = "windows_x86_64_gnu" +version = "0.52.6" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "147a5c80aabfbf0c7d901cb5895d1de30ef2907eb21fbbab29ca94c5b08b1a78" + [[package]] name = "windows_x86_64_gnullvm" version = "0.48.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "0b7b52767868a23d5bab768e390dc5f5c55825b6d30b86c844ff2dc7414044cc" +[[package]] +name = "windows_x86_64_gnullvm" +version = "0.52.6" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "24d5b23dc417412679681396f2b49f3de8c1473deb516bd34410872eff51ed0d" + [[package]] name = "windows_x86_64_msvc" version = "0.48.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "ed94fce61571a4006852b7389a063ab983c02eb1bb37b47f8272ce92d06d9538" +[[package]] +name = "windows_x86_64_msvc" +version = "0.52.6" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "589f6da84c646204747d1270a2a5661ea66ed1cced2631d546fdfb155959f9ec" + [[package]] name = "winnow" version = "0.7.15" @@ -1892,6 +2579,29 @@ dependencies = [ "memchr", ] +[[package]] +name = "wiremock" +version = "0.6.5" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "08db1edfb05d9b3c1542e521aea074442088292f00b5f28e435c714a98f85031" +dependencies = [ + "assert-json-diff", + "base64", + "deadpool", + "futures", + "http", + "http-body-util", + "hyper", + "hyper-util", + "log", + "once_cell", + "regex", + "serde", + "serde_json", + "tokio", + "url", +] + [[package]] name = "writeable" version = "0.6.4" diff --git a/crates/arr-meta/Cargo.toml b/crates/arr-meta/Cargo.toml index ef9c70f..d6e9525 100644 --- a/crates/arr-meta/Cargo.toml +++ b/crates/arr-meta/Cargo.toml @@ -7,6 +7,16 @@ repository.workspace = true publish = false [dependencies] +chrono.workspace = true +reqwest.workspace = true +serde.workspace = true +serde_json.workspace = true +thiserror.workspace = true +tracing.workspace = true + +[dev-dependencies] +tokio.workspace = true +wiremock.workspace = true [lints] workspace = true diff --git a/crates/arr-meta/src/cache.rs b/crates/arr-meta/src/cache.rs new file mode 100644 index 0000000..7519272 --- /dev/null +++ b/crates/arr-meta/src/cache.rs @@ -0,0 +1,69 @@ +//! A small time-to-live cache over raw response bodies. +//! +//! Keyed on a logical request key rather than the URL, so the API key never +//! becomes part of a cache key. Bodies are stored unparsed: parsing again on a +//! hit costs microseconds and keeps one cache serving every endpoint. + +use std::collections::HashMap; +use std::sync::Arc; +use std::sync::{Mutex, PoisonError}; +use std::time::{Duration, Instant}; + +#[derive(Debug)] +struct Entry { + stored_at: Instant, + body: Arc, +} + +#[derive(Debug)] +pub(crate) struct Cache { + ttl: Duration, + entries: Mutex>, +} + +impl Cache { + pub(crate) fn new(ttl: Duration) -> Self { + Self { + ttl, + entries: Mutex::new(HashMap::new()), + } + } + + /// The cached body for `key`, if one is present and still fresh. + pub(crate) fn get(&self, key: &str) -> Option> { + let mut entries = self.entries.lock().unwrap_or_else(PoisonError::into_inner); + let entry = entries.get(key)?; + if entry.stored_at.elapsed() < self.ttl { + return Some(Arc::clone(&entry.body)); + } + entries.remove(key); + None + } + + pub(crate) fn insert(&self, key: String, body: Arc) { + let mut entries = self.entries.lock().unwrap_or_else(PoisonError::into_inner); + entries.insert( + key, + Entry { + stored_at: Instant::now(), + body, + }, + ); + } + + pub(crate) fn remove(&self, key: &str) { + self.entries + .lock() + .unwrap_or_else(PoisonError::into_inner) + .remove(key); + } + + /// Drop everything. The daily metadata refresh does not need this — entries + /// expire on their own — but a forced refresh from the UI does. + pub(crate) fn clear(&self) { + self.entries + .lock() + .unwrap_or_else(PoisonError::into_inner) + .clear(); + } +} diff --git a/crates/arr-meta/src/client.rs b/crates/arr-meta/src/client.rs new file mode 100644 index 0000000..93550e7 --- /dev/null +++ b/crates/arr-meta/src/client.rs @@ -0,0 +1,275 @@ +//! The TMDB HTTP client. + +use std::sync::Arc; +use std::time::Duration; + +use reqwest::{StatusCode, Url}; +use serde::de::DeserializeOwned; + +use crate::cache::Cache; +use crate::error::{Error, Result}; +use crate::model::{Movie, MovieSearchResult, RawMovie, RawSearchPage}; + +/// TMDB's v3 API root. +pub const DEFAULT_BASE_URL: &str = "https://api.themoviedb.org/3/"; + +/// One day. Metadata refresh is a daily tick (§8), not a per-request cost. +pub const DEFAULT_CACHE_TTL: Duration = Duration::from_hours(24); + +const DEFAULT_TIMEOUT: Duration = Duration::from_secs(10); + +/// How much of an unexpected response body is worth keeping in an error. +const MAX_ERROR_BODY: usize = 512; + +/// A TMDB client with an in-process response cache. +/// +/// Deliberately not `Clone`: the cache lives inside it, so build one and share +/// it behind an `Arc` rather than handing out copies that each miss. +pub struct TmdbClient { + http: reqwest::Client, + base_url: Url, + api_key: String, + cache: Cache, +} + +/// Deliberately hand-written: a derived `Debug` would print the API key. +impl std::fmt::Debug for TmdbClient { + fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + f.debug_struct("TmdbClient") + .field("http", &self.http) + .field("base_url", &self.base_url.as_str()) + .field("api_key", &"") + .field("cache", &self.cache) + .finish() + } +} + +impl TmdbClient { + /// A client against the real TMDB with default timeouts and cache lifetime. + /// + /// # Errors + /// + /// Fails if the HTTP client cannot be constructed. + pub fn new(api_key: impl Into) -> Result { + Self::builder(api_key).build() + } + + /// Start configuring a client. + #[must_use] + pub fn builder(api_key: impl Into) -> TmdbClientBuilder { + TmdbClientBuilder { + api_key: api_key.into(), + base_url: DEFAULT_BASE_URL.to_owned(), + cache_ttl: DEFAULT_CACHE_TTL, + timeout: DEFAULT_TIMEOUT, + } + } + + /// Search TMDB for movies by title, optionally narrowed to a year. + /// + /// Returns the first page of results, which is what a search box shows. + /// + /// # Errors + /// + /// Any of [`Error`]; see its variants for what callers should distinguish. + pub async fn search_movies( + &self, + query: &str, + year: Option, + ) -> Result> { + let mut params = vec![ + ("query", query.trim().to_owned()), + ("include_adult", "false".to_owned()), + ]; + if let Some(year) = year { + params.push(("year", year.to_string())); + } + + let page: RawSearchPage = self.get_json("search/movie", ¶ms).await?; + Ok(page.results.into_iter().map(Into::into).collect()) + } + + /// Full detail for one movie, including the digital release date. + /// + /// One HTTP call: release dates come back appended to the same response + /// rather than costing a second round trip. + /// + /// # Errors + /// + /// [`Error::NotFound`] when TMDB has no such id, otherwise any of [`Error`]. + pub async fn movie(&self, tmdb_id: u32) -> Result { + let path = format!("movie/{tmdb_id}"); + let params = [("append_to_response", "release_dates".to_owned())]; + let raw: RawMovie = self.get_json(&path, ¶ms).await?; + Ok(raw.into()) + } + + /// Drop every cached response. For a user-initiated "refresh metadata". + pub fn clear_cache(&self) { + self.cache.clear(); + } + + /// Fetch and decode, caching only what decoded. + /// + /// Decoding before the insert matters: a malformed response that got into + /// the cache would keep returning [`Error::Decode`] for the whole + /// time-to-live, turning one bad response into a day-long outage for that + /// title. + async fn get_json( + &self, + path: &str, + params: &[(&str, String)], + ) -> Result { + let (url, cache_key) = self.request_url(path, params)?; + + if let Some(hit) = self.cache.get(&cache_key) { + tracing::trace!(cache_key, "TMDB cache hit"); + return serde_json::from_str(&hit).map_err(|err| { + // Unreachable in practice — nothing enters the cache until it + // has decoded once — but evicting beats serving a stuck error. + self.cache.remove(&cache_key); + Error::from(err) + }); + } + + let body = self.fetch(url, path).await?; + let value = serde_json::from_str(&body)?; + self.cache.insert(cache_key, Arc::from(body)); + Ok(value) + } + + /// The request URL, and the cache key derived from it. + /// + /// Both come from the same `Url`, so the key is percent-encoded exactly as + /// the request is. Building the key separately by string concatenation is + /// how `query = "dune&year=2024"` collides with `query = "dune", year = + /// 2024` — two different requests, one cache entry. + /// + /// The API key is deliberately not in the URL yet: it is appended at send + /// time so it can never reach a cache key or a log line. + fn request_url(&self, path: &str, params: &[(&str, String)]) -> Result<(Url, String)> { + let mut url = self + .base_url + .join(path) + .map_err(|err| Error::BaseUrl(err.to_string()))?; + { + let mut pairs = url.query_pairs_mut(); + for (name, value) in params { + pairs.append_pair(name, value); + } + } + + let cache_key = match url.query() { + Some(query) => format!("{}?{}", url.path(), query), + None => url.path().to_owned(), + }; + + Ok((url, cache_key)) + } + + /// `resource` names the thing being fetched for [`Error::NotFound`], in the + /// caller's terms rather than as a URL. + async fn fetch(&self, mut url: Url, resource: &str) -> Result { + url.query_pairs_mut().append_pair("api_key", &self.api_key); + + tracing::debug!(resource, "TMDB request"); + let response = self.http.get(url).send().await?; + let status = response.status(); + + if status.is_success() { + return Ok(response.text().await?); + } + + // Failures are never cached: a rate limit or an outage must not pin a + // title into a bad state for a day. + Err(match status { + StatusCode::UNAUTHORIZED | StatusCode::FORBIDDEN => Error::Unauthorized, + StatusCode::NOT_FOUND => Error::NotFound { + resource: resource.to_owned(), + }, + StatusCode::TOO_MANY_REQUESTS => Error::RateLimited { + retry_after: retry_after(&response), + }, + other => { + let body = response.text().await.unwrap_or_default(); + Error::Unexpected { + status: other.as_u16(), + body: body.chars().take(MAX_ERROR_BODY).collect(), + } + } + }) + } +} + +fn retry_after(response: &reqwest::Response) -> Option { + response + .headers() + .get(reqwest::header::RETRY_AFTER)? + .to_str() + .ok()? + .trim() + .parse::() + .ok() + .map(Duration::from_secs) +} + +/// Configuration for a [`TmdbClient`]. +#[derive(Debug, Clone)] +pub struct TmdbClientBuilder { + api_key: String, + base_url: String, + cache_ttl: Duration, + timeout: Duration, +} + +impl TmdbClientBuilder { + /// Point the client somewhere other than TMDB. Tests use this; nothing else + /// should. + #[must_use] + pub fn base_url(mut self, base_url: impl Into) -> Self { + self.base_url = base_url.into(); + self + } + + /// How long a cached response stays fresh. + #[must_use] + pub fn cache_ttl(mut self, cache_ttl: Duration) -> Self { + self.cache_ttl = cache_ttl; + self + } + + /// Per-request timeout. + #[must_use] + pub fn timeout(mut self, timeout: Duration) -> Self { + self.timeout = timeout; + self + } + + /// Build the client. + /// + /// # Errors + /// + /// [`Error::BaseUrl`] if the base URL will not parse, [`Error::Transport`] + /// if the HTTP client cannot be built. + pub fn build(self) -> Result { + // Without a trailing slash `Url::join` replaces the last path segment + // instead of appending, which silently drops the `/3`. + let mut base_url = self.base_url; + if !base_url.ends_with('/') { + base_url.push('/'); + } + let base_url = Url::parse(&base_url).map_err(|err| Error::BaseUrl(err.to_string()))?; + + let http = reqwest::Client::builder() + .timeout(self.timeout) + .user_agent(concat!("arr/", env!("CARGO_PKG_VERSION"))) + .build()?; + + Ok(TmdbClient { + http, + base_url, + api_key: self.api_key, + cache: Cache::new(self.cache_ttl), + }) + } +} diff --git a/crates/arr-meta/src/error.rs b/crates/arr-meta/src/error.rs new file mode 100644 index 0000000..38716da --- /dev/null +++ b/crates/arr-meta/src/error.rs @@ -0,0 +1,56 @@ +//! Errors the TMDB client can produce. + +use std::time::Duration; + +/// Result alias for every fallible operation in this crate. +pub type Result = std::result::Result; + +/// Everything that can go wrong talking to TMDB. +/// +/// The distinction that matters to callers is between "this title does not +/// exist" ([`Error::NotFound`]), "back off" ([`Error::RateLimited`]) and +/// "TMDB is unreachable" ([`Error::Transport`]) — the last is a §9.5 *broken* +/// notification, the first two are not. +#[derive(Debug, thiserror::Error)] +#[non_exhaustive] +pub enum Error { + /// The request never completed: DNS, TLS, connection or timeout. + #[error("TMDB request failed")] + Transport(#[from] reqwest::Error), + + /// TMDB rejected the API key. + #[error("TMDB rejected the API key")] + Unauthorized, + + /// TMDB has no record of the thing that was asked for. + #[error("TMDB has no record of {resource}")] + NotFound { + /// The logical resource that was requested, e.g. `movie/693134`. + resource: String, + }, + + /// TMDB is rate limiting. `retry_after` is the `Retry-After` header when + /// TMDB sent one. + #[error("TMDB rate limit reached")] + RateLimited { + /// How long TMDB asked us to wait, when it said. + retry_after: Option, + }, + + /// Any other non-success status. + #[error("TMDB returned HTTP {status}")] + Unexpected { + /// The HTTP status code. + status: u16, + /// The response body, truncated to something loggable. + body: String, + }, + + /// The response parsed as JSON but not into the shape expected. + #[error("TMDB response did not match the expected shape")] + Decode(#[from] serde_json::Error), + + /// The configured base URL is not a URL. + #[error("invalid TMDB base URL: {0}")] + BaseUrl(String), +} diff --git a/crates/arr-meta/src/lib.rs b/crates/arr-meta/src/lib.rs index 551be62..aa218ff 100644 --- a/crates/arr-meta/src/lib.rs +++ b/crates/arr-meta/src/lib.rs @@ -1 +1,26 @@ -//! arr-meta — see DESIGN.md. +//! arr-meta — TMDB client. See `DESIGN.md` §5.2, §6.2 and §12. +//! +//! Two fields carry the weight here and neither is decoration: +//! +//! - `original_language` (plus the origin country that disambiguates `pt`) is +//! what the whole dub rule in §5.2 is expressed against. +//! - The digital release date gates targeted search (§6.2). A movie with no +//! digital release date must get zero searches. +//! +//! Responses are cached in process with a time-to-live, defaulting to a day, +//! because metadata refresh is a daily tick (§8) and not a per-request cost. + +// `unused_crate_dependencies` is a per-target lint and the library's own test +// target links the dev-dependencies without using them. The real uses are in +// `tests/`. +#[cfg(test)] +use {tokio as _, wiremock as _}; + +mod cache; +mod client; +mod error; +mod model; + +pub use client::{TmdbClient, TmdbClientBuilder, DEFAULT_BASE_URL, DEFAULT_CACHE_TTL}; +pub use error::{Error, Result}; +pub use model::{Movie, MovieSearchResult}; diff --git a/crates/arr-meta/src/model.rs b/crates/arr-meta/src/model.rs new file mode 100644 index 0000000..a1d8cd9 --- /dev/null +++ b/crates/arr-meta/src/model.rs @@ -0,0 +1,257 @@ +//! The slice of TMDB's schema this project actually reads. +//! +//! TMDB returns a great deal more than this. Everything kept here is either +//! shown to a person or fed to the policy engine; the rest is dropped at the +//! edge so nothing downstream has to know TMDB's field names. + +use chrono::{Datelike, NaiveDate}; +use serde::{Deserialize, Serialize}; + +/// TMDB's release-date type for a digital release. See §6.2 — this is the one +/// that gates targeted search. +const RELEASE_TYPE_DIGITAL: u8 = 4; + +/// One row of a TMDB search. +#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)] +pub struct MovieSearchResult { + /// TMDB's own id, the key everything else hangs off. + pub tmdb_id: u32, + /// Title in the requested language. + pub title: String, + /// Title in the original language. + pub original_title: String, + /// ISO 639-1, e.g. `en` or `pt`. See [`Movie::original_language`] for why + /// this alone is not enough for Portuguese. + pub original_language: String, + /// Primary (theatrical) release date. Absent for announced-but-undated + /// titles, where TMDB sends an empty string. + pub release_date: Option, + /// TMDB's synopsis, empty string normalised away. + pub overview: Option, + /// Path fragment, not a URL. TMDB's image base is a separate concern. + pub poster_path: Option, +} + +impl MovieSearchResult { + /// Release year, when TMDB has a release date at all. + #[must_use] + pub fn year(&self) -> Option { + self.release_date.map(|date| date.year()) + } +} + +/// A movie as TMDB describes it, reduced to what this project uses. +#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)] +pub struct Movie { + /// TMDB's own id. + pub tmdb_id: u32, + /// `IMDb` id, when TMDB knows one. Torznab `t=movie` searches take it. + pub imdb_id: Option, + /// Title in the requested language. + pub title: String, + /// Title in the original language. + pub original_title: String, + /// ISO 639-1, e.g. `en` or `pt`. + /// + /// The dub rule in §5.2 compares a track's language against this. ISO + /// 639-1 has one code for both Portuguese variants, so `pt` on its own + /// cannot tell a Brazilian film from a Portuguese one — pair it with + /// [`Movie::origin_countries`] to resolve that. + pub original_language: String, + /// ISO 3166-1 alpha-2 country codes the title originates from. Needed to + /// read `pt` as pt-BR or pt-PT. + pub origin_countries: Vec, + /// Primary (theatrical) release date. + pub release_date: Option, + /// Earliest digital release date TMDB records, across every country. + /// + /// §6.2: a movie with no digital release date gets zero targeted searches. + /// Earliest-anywhere is the right reading of that — a release existing in + /// one region is a release that exists on the indexers. + pub digital_release: Option, + /// Runtime in minutes, when known. + pub runtime: Option, + /// TMDB's own status string: `Released`, `Post Production`, and so on. + pub status: String, + /// TMDB's synopsis, empty string normalised away. + pub overview: Option, + /// Path fragment, not a URL. + pub poster_path: Option, +} + +impl Movie { + /// Release year, when TMDB has a release date at all. + #[must_use] + pub fn year(&self) -> Option { + self.release_date.map(|date| date.year()) + } + + /// Whether a digital release exists as of `on`. + /// + /// This is the §6.2 gate in one place: no digital date at all, or a date + /// still in the future, means the release does not exist yet and searching + /// for it is a wasted query. + #[must_use] + pub fn is_digitally_released(&self, on: NaiveDate) -> bool { + self.digital_release.is_some_and(|date| date <= on) + } +} + +// --- TMDB wire types ------------------------------------------------------- +// +// Private on purpose. TMDB's field names stop here. + +#[derive(Debug, Deserialize)] +pub(crate) struct RawSearchPage { + #[serde(default)] + pub(crate) results: Vec, +} + +#[derive(Debug, Deserialize)] +pub(crate) struct RawSearchResult { + id: u32, + #[serde(default)] + title: String, + #[serde(default)] + original_title: String, + #[serde(default)] + original_language: String, + #[serde(default)] + release_date: Option, + #[serde(default)] + overview: Option, + #[serde(default)] + poster_path: Option, +} + +impl From for MovieSearchResult { + fn from(raw: RawSearchResult) -> Self { + Self { + tmdb_id: raw.id, + title: raw.title, + original_title: raw.original_title, + original_language: raw.original_language, + release_date: raw.release_date.as_deref().and_then(parse_date), + overview: non_empty(raw.overview), + poster_path: non_empty(raw.poster_path), + } + } +} + +#[derive(Debug, Deserialize)] +pub(crate) struct RawMovie { + id: u32, + #[serde(default)] + imdb_id: Option, + #[serde(default)] + title: String, + #[serde(default)] + original_title: String, + #[serde(default)] + original_language: String, + #[serde(default)] + origin_country: Vec, + #[serde(default)] + production_countries: Vec, + #[serde(default)] + release_date: Option, + #[serde(default)] + runtime: Option, + #[serde(default)] + status: String, + #[serde(default)] + overview: Option, + #[serde(default)] + poster_path: Option, + #[serde(default)] + release_dates: Option, +} + +#[derive(Debug, Deserialize)] +struct RawProductionCountry { + iso_3166_1: String, +} + +#[derive(Debug, Deserialize)] +struct RawReleaseDates { + #[serde(default)] + results: Vec, +} + +#[derive(Debug, Deserialize)] +struct RawCountryReleaseDates { + #[serde(default)] + release_dates: Vec, +} + +#[derive(Debug, Deserialize)] +struct RawReleaseDate { + #[serde(rename = "type")] + kind: u8, + #[serde(default)] + release_date: Option, +} + +impl From for Movie { + fn from(raw: RawMovie) -> Self { + let digital_release = raw + .release_dates + .as_ref() + .and_then(|dates| earliest_digital(&dates.results)); + + // `origin_country` is the newer field and the more precise one; + // `production_countries` is the fallback for records that predate it. + let origin_countries = if raw.origin_country.is_empty() { + raw.production_countries + .into_iter() + .map(|country| country.iso_3166_1) + .collect() + } else { + raw.origin_country + }; + + Self { + tmdb_id: raw.id, + imdb_id: non_empty(raw.imdb_id), + title: raw.title, + original_title: raw.original_title, + original_language: raw.original_language, + origin_countries, + release_date: raw.release_date.as_deref().and_then(parse_date), + digital_release, + runtime: raw.runtime, + status: raw.status, + overview: non_empty(raw.overview), + poster_path: non_empty(raw.poster_path), + } + } +} + +fn earliest_digital(countries: &[RawCountryReleaseDates]) -> Option { + countries + .iter() + .flat_map(|country| country.release_dates.iter()) + .filter(|entry| entry.kind == RELEASE_TYPE_DIGITAL) + .filter_map(|entry| entry.release_date.as_deref().and_then(parse_datetime)) + .min() +} + +/// TMDB sends `""` rather than `null` for a date it does not have. +fn parse_date(raw: &str) -> Option { + NaiveDate::parse_from_str(raw, "%Y-%m-%d").ok() +} + +/// Release-date entries are timestamps: `2024-04-16T00:00:00.000Z`. The clock +/// part is meaningless — TMDB stamps a local date as UTC midnight — so only +/// the date survives. +fn parse_datetime(raw: &str) -> Option { + chrono::DateTime::parse_from_rfc3339(raw) + .ok() + .map(|stamp| stamp.date_naive()) + .or_else(|| parse_date(raw)) +} + +/// TMDB uses `""` where `null` is meant, in most string fields. +fn non_empty(value: Option) -> Option { + value.filter(|text| !text.is_empty()) +} diff --git a/crates/arr-meta/tests/fixtures/movie_cidade_de_deus.json b/crates/arr-meta/tests/fixtures/movie_cidade_de_deus.json new file mode 100644 index 0000000..f24f58d --- /dev/null +++ b/crates/arr-meta/tests/fixtures/movie_cidade_de_deus.json @@ -0,0 +1,51 @@ +{ + "adult": false, + "backdrop_path": "/pdtzEreKvKAlqa2YEBaGwiA45V8.jpg", + "budget": 3300000, + "genres": [{ "id": 18, "name": "Drama" }, { "id": 80, "name": "Crime" }], + "homepage": "", + "id": 598, + "imdb_id": "tt0317248", + "origin_country": ["BR"], + "original_language": "pt", + "original_title": "Cidade de Deus", + "overview": "In the slums of Rio, two kids' paths diverge as one struggles to become a photographer and the other a kingpin.", + "popularity": 38.9, + "poster_path": "/k7eYdWvhYQyRQoU2TB2A2Xu2TfD.jpg", + "production_countries": [{ "iso_3166_1": "BR", "name": "Brazil" }], + "release_date": "2002-02-05", + "revenue": 30641770, + "runtime": 130, + "spoken_languages": [{ "english_name": "Portuguese", "iso_639_1": "pt", "name": "Português" }], + "status": "Released", + "tagline": "If you run you're dead. If you stay, you're dead again. Period.", + "title": "City of God", + "video": false, + "vote_average": 8.4, + "vote_count": 8123, + "release_dates": { + "results": [ + { + "iso_3166_1": "BR", + "release_dates": [ + { + "certification": "18", + "descriptors": [], + "iso_639_1": "", + "note": "", + "release_date": "2002-08-30T00:00:00.000Z", + "type": 3 + }, + { + "certification": "", + "descriptors": [], + "iso_639_1": "", + "note": "", + "release_date": "2016-05-10T00:00:00.000Z", + "type": 4 + } + ] + } + ] + } +} diff --git a/crates/arr-meta/tests/fixtures/movie_dune.json b/crates/arr-meta/tests/fixtures/movie_dune.json new file mode 100644 index 0000000..2d98628 --- /dev/null +++ b/crates/arr-meta/tests/fixtures/movie_dune.json @@ -0,0 +1,83 @@ +{ + "adult": false, + "backdrop_path": "/xOMo8BRK7PfcJv9JCnx7s5hj0PX.jpg", + "budget": 190000000, + "genres": [{ "id": 878, "name": "Science Fiction" }, { "id": 12, "name": "Adventure" }], + "homepage": "https://www.dunemovie.com", + "id": 693134, + "imdb_id": "tt15239678", + "origin_country": ["US"], + "original_language": "en", + "original_title": "Dune: Part Two", + "overview": "Follow the mythic journey of Paul Atreides as he unites with Chani and the Fremen while on a path of revenge against the conspirators who destroyed his family.", + "popularity": 234.53, + "poster_path": "/1pdfLvkbY9ohJlCjQH2CZjjYVvJ.jpg", + "production_countries": [ + { "iso_3166_1": "US", "name": "United States of America" }, + { "iso_3166_1": "CA", "name": "Canada" } + ], + "release_date": "2024-02-27", + "revenue": 711844358, + "runtime": 167, + "spoken_languages": [{ "english_name": "English", "iso_639_1": "en", "name": "English" }], + "status": "Released", + "tagline": "Long live the fighters.", + "title": "Dune: Part Two", + "video": false, + "vote_average": 8.157, + "vote_count": 6104, + "release_dates": { + "results": [ + { + "iso_3166_1": "US", + "release_dates": [ + { + "certification": "PG-13", + "descriptors": [], + "iso_639_1": "", + "note": "", + "release_date": "2024-03-01T00:00:00.000Z", + "type": 3 + }, + { + "certification": "", + "descriptors": [], + "iso_639_1": "", + "note": "", + "release_date": "2024-04-16T00:00:00.000Z", + "type": 4 + }, + { + "certification": "PG-13", + "descriptors": [], + "iso_639_1": "", + "note": "", + "release_date": "2024-05-14T00:00:00.000Z", + "type": 5 + } + ] + }, + { + "iso_3166_1": "PT", + "release_dates": [ + { + "certification": "M/12", + "descriptors": [], + "iso_639_1": "", + "note": "", + "release_date": "2024-02-28T00:00:00.000Z", + "type": 3 + }, + { + "certification": "", + "descriptors": [], + "iso_639_1": "", + "note": "", + "release_date": "2024-04-10T00:00:00.000Z", + "type": 4 + } + ] + } + ] + } +} diff --git a/crates/arr-meta/tests/fixtures/movie_future_digital.json b/crates/arr-meta/tests/fixtures/movie_future_digital.json new file mode 100644 index 0000000..f7a4225 --- /dev/null +++ b/crates/arr-meta/tests/fixtures/movie_future_digital.json @@ -0,0 +1,51 @@ +{ + "adult": false, + "backdrop_path": null, + "budget": 0, + "genres": [{ "id": 28, "name": "Action" }], + "homepage": "", + "id": 1211073, + "imdb_id": "tt31852248", + "origin_country": ["GB"], + "original_language": "en", + "original_title": "Dated For Later", + "overview": "A film with an announced but not yet reached digital release date.", + "popularity": 88.0, + "poster_path": "/placeholder.jpg", + "production_countries": [{ "iso_3166_1": "GB", "name": "United Kingdom" }], + "release_date": "2026-07-10", + "revenue": 0, + "runtime": 110, + "spoken_languages": [{ "english_name": "English", "iso_639_1": "en", "name": "English" }], + "status": "Released", + "tagline": "", + "title": "Dated For Later", + "video": false, + "vote_average": 6.4, + "vote_count": 40, + "release_dates": { + "results": [ + { + "iso_3166_1": "GB", + "release_dates": [ + { + "certification": "15", + "descriptors": [], + "iso_639_1": "", + "note": "", + "release_date": "2026-07-10T00:00:00.000Z", + "type": 3 + }, + { + "certification": "", + "descriptors": [], + "iso_639_1": "", + "note": "", + "release_date": "2026-11-20T00:00:00.000Z", + "type": 4 + } + ] + } + ] + } +} diff --git a/crates/arr-meta/tests/fixtures/movie_theatrical_only.json b/crates/arr-meta/tests/fixtures/movie_theatrical_only.json new file mode 100644 index 0000000..583ae7a --- /dev/null +++ b/crates/arr-meta/tests/fixtures/movie_theatrical_only.json @@ -0,0 +1,43 @@ +{ + "adult": false, + "backdrop_path": null, + "budget": 0, + "genres": [{ "id": 18, "name": "Drama" }], + "homepage": "", + "id": 1022789, + "imdb_id": "tt27675327", + "origin_country": ["US"], + "original_language": "en", + "original_title": "Still In Cinemas", + "overview": "A film that has opened theatrically and has no digital release yet.", + "popularity": 120.4, + "poster_path": "/placeholder.jpg", + "production_countries": [{ "iso_3166_1": "US", "name": "United States of America" }], + "release_date": "2026-08-01", + "revenue": 0, + "runtime": 96, + "spoken_languages": [{ "english_name": "English", "iso_639_1": "en", "name": "English" }], + "status": "Released", + "tagline": "", + "title": "Still In Cinemas", + "video": false, + "vote_average": 7.1, + "vote_count": 210, + "release_dates": { + "results": [ + { + "iso_3166_1": "US", + "release_dates": [ + { + "certification": "PG", + "descriptors": [], + "iso_639_1": "", + "note": "", + "release_date": "2026-08-01T00:00:00.000Z", + "type": 3 + } + ] + } + ] + } +} diff --git a/crates/arr-meta/tests/fixtures/movie_unreleased.json b/crates/arr-meta/tests/fixtures/movie_unreleased.json new file mode 100644 index 0000000..c933a35 --- /dev/null +++ b/crates/arr-meta/tests/fixtures/movie_unreleased.json @@ -0,0 +1,27 @@ +{ + "adult": false, + "backdrop_path": null, + "budget": 0, + "genres": [{ "id": 878, "name": "Science Fiction" }], + "homepage": "", + "id": 1156593, + "imdb_id": "", + "origin_country": [], + "original_language": "en", + "original_title": "Dune: Part Three", + "overview": "", + "popularity": 41.2, + "poster_path": null, + "production_countries": [], + "release_date": "", + "revenue": 0, + "runtime": null, + "spoken_languages": [], + "status": "Post Production", + "tagline": "", + "title": "Dune: Part Three", + "video": false, + "vote_average": 0.0, + "vote_count": 0, + "release_dates": { "results": [] } +} diff --git a/crates/arr-meta/tests/fixtures/search_dune.json b/crates/arr-meta/tests/fixtures/search_dune.json new file mode 100644 index 0000000..51cf033 --- /dev/null +++ b/crates/arr-meta/tests/fixtures/search_dune.json @@ -0,0 +1,39 @@ +{ + "page": 1, + "results": [ + { + "adult": false, + "backdrop_path": "/xOMo8BRK7PfcJv9JCnx7s5hj0PX.jpg", + "genre_ids": [878, 12], + "id": 693134, + "original_language": "en", + "original_title": "Dune: Part Two", + "overview": "Follow the mythic journey of Paul Atreides as he unites with Chani and the Fremen while on a path of revenge against the conspirators who destroyed his family.", + "popularity": 234.53, + "poster_path": "/1pdfLvkbY9ohJlCjQH2CZjjYVvJ.jpg", + "release_date": "2024-02-27", + "title": "Dune: Part Two", + "video": false, + "vote_average": 8.157, + "vote_count": 6104 + }, + { + "adult": false, + "backdrop_path": null, + "genre_ids": [878], + "id": 1156593, + "original_language": "en", + "original_title": "Dune: Part Three", + "overview": "", + "popularity": 41.2, + "poster_path": null, + "release_date": "", + "title": "Dune: Part Three", + "video": false, + "vote_average": 0.0, + "vote_count": 0 + } + ], + "total_pages": 1, + "total_results": 2 +} diff --git a/crates/arr-meta/tests/tmdb.rs b/crates/arr-meta/tests/tmdb.rs new file mode 100644 index 0000000..0a4fb1c --- /dev/null +++ b/crates/arr-meta/tests/tmdb.rs @@ -0,0 +1,463 @@ +//! TMDB client tests. Everything runs against `wiremock` — DESIGN.md §12 rules +//! out live calls, which would rate-limit and leak a key into CI. + +// Same per-target quirk as in `lib.rs`: an integration test links the library's +// dependencies without using them directly. +use {reqwest as _, serde as _, serde_json as _, thiserror as _, tracing as _}; + +use std::time::Duration; + +use arr_meta::{Error, TmdbClient}; +use chrono::NaiveDate; +use wiremock::matchers::{header_exists, method, path, query_param}; +use wiremock::{Mock, MockServer, ResponseTemplate}; + +const SEARCH_DUNE: &str = include_str!("fixtures/search_dune.json"); +const MOVIE_DUNE: &str = include_str!("fixtures/movie_dune.json"); +const MOVIE_CIDADE_DE_DEUS: &str = include_str!("fixtures/movie_cidade_de_deus.json"); +const MOVIE_UNRELEASED: &str = include_str!("fixtures/movie_unreleased.json"); +const MOVIE_THEATRICAL_ONLY: &str = include_str!("fixtures/movie_theatrical_only.json"); +const MOVIE_FUTURE_DIGITAL: &str = include_str!("fixtures/movie_future_digital.json"); + +fn client(server: &MockServer) -> TmdbClient { + TmdbClient::builder("test-key") + .base_url(format!("{}/3", server.uri())) + .build() + .expect("client builds") +} + +fn date(year: i32, month: u32, day: u32) -> NaiveDate { + NaiveDate::from_ymd_opt(year, month, day).expect("valid date") +} + +async fn mount_movie(server: &MockServer, tmdb_id: u32, body: &str) { + Mock::given(method("GET")) + .and(path(format!("/3/movie/{tmdb_id}"))) + .respond_with(ResponseTemplate::new(200).set_body_string(body)) + .mount(server) + .await; +} + +#[tokio::test] +async fn search_parses_results_and_normalises_empty_strings() { + let server = MockServer::start().await; + Mock::given(method("GET")) + .and(path("/3/search/movie")) + .respond_with(ResponseTemplate::new(200).set_body_string(SEARCH_DUNE)) + .mount(&server) + .await; + + let results = client(&server) + .search_movies("dune", None) + .await + .expect("search succeeds"); + + assert_eq!(results.len(), 2); + + let released = &results[0]; + assert_eq!(released.tmdb_id, 693_134); + assert_eq!(released.title, "Dune: Part Two"); + assert_eq!(released.original_language, "en"); + assert_eq!(released.release_date, Some(date(2024, 2, 27))); + assert_eq!(released.year(), Some(2024)); + assert!(released.poster_path.is_some()); + + // TMDB sends "" rather than null for a date it does not have, and for an + // overview it does not have either. + let announced = &results[1]; + assert_eq!(announced.release_date, None); + assert_eq!(announced.year(), None); + assert_eq!(announced.overview, None); + assert_eq!(announced.poster_path, None); +} + +#[tokio::test] +async fn search_sends_the_query_year_and_api_key() { + let server = MockServer::start().await; + Mock::given(method("GET")) + .and(path("/3/search/movie")) + .and(query_param("query", "dune")) + .and(query_param("year", "2024")) + .and(query_param("api_key", "test-key")) + .and(query_param("include_adult", "false")) + .respond_with(ResponseTemplate::new(200).set_body_string(SEARCH_DUNE)) + .expect(1) + .mount(&server) + .await; + + client(&server) + .search_movies(" dune ", Some(2024)) + .await + .expect("search succeeds"); +} + +#[tokio::test] +async fn movie_detail_asks_for_release_dates_in_one_call() { + let server = MockServer::start().await; + Mock::given(method("GET")) + .and(path("/3/movie/693134")) + .and(query_param("append_to_response", "release_dates")) + .and(header_exists("user-agent")) + .respond_with(ResponseTemplate::new(200).set_body_string(MOVIE_DUNE)) + .expect(1) + .mount(&server) + .await; + + client(&server) + .movie(693_134) + .await + .expect("lookup succeeds"); +} + +#[tokio::test] +async fn movie_detail_carries_the_policy_relevant_fields() { + let server = MockServer::start().await; + mount_movie(&server, 693_134, MOVIE_DUNE).await; + + let movie = client(&server) + .movie(693_134) + .await + .expect("lookup succeeds"); + + assert_eq!(movie.tmdb_id, 693_134); + assert_eq!(movie.imdb_id.as_deref(), Some("tt15239678")); + assert_eq!(movie.title, "Dune: Part Two"); + assert_eq!(movie.original_title, "Dune: Part Two"); + assert_eq!(movie.original_language, "en"); + assert_eq!(movie.origin_countries, vec!["US".to_owned()]); + assert_eq!(movie.release_date, Some(date(2024, 2, 27))); + assert_eq!(movie.runtime, Some(167)); + assert_eq!(movie.status, "Released"); + assert_eq!(movie.year(), Some(2024)); +} + +/// §5.2: a Brazilian film's own soundtrack must pass the pt-BR dub rule, which +/// only works if the origin country survives alongside the bare `pt` code. +#[tokio::test] +async fn brazilian_film_keeps_its_language_and_origin_country() { + let server = MockServer::start().await; + mount_movie(&server, 598, MOVIE_CIDADE_DE_DEUS).await; + + let movie = client(&server).movie(598).await.expect("lookup succeeds"); + + assert_eq!(movie.original_language, "pt"); + assert_eq!(movie.origin_countries, vec!["BR".to_owned()]); +} + +/// §6.2. Earliest digital date anywhere: the release existing in one region is +/// a release that exists on the indexers. +#[tokio::test] +async fn digital_release_is_the_earliest_across_every_country() { + let server = MockServer::start().await; + mount_movie(&server, 693_134, MOVIE_DUNE).await; + + let movie = client(&server) + .movie(693_134) + .await + .expect("lookup succeeds"); + + // US digital is 2024-04-16, PT digital is 2024-04-10. Theatrical (type 3) + // and physical (type 5) entries must not be mistaken for it. + assert_eq!(movie.digital_release, Some(date(2024, 4, 10))); + assert!(movie.is_digitally_released(date(2024, 4, 10))); + assert!(movie.is_digitally_released(date(2026, 1, 1))); + assert!(!movie.is_digitally_released(date(2024, 4, 9))); +} + +/// §6.2, the case that costs Radarr the most queries: no digital date means no +/// targeted search at all. +#[tokio::test] +async fn theatrical_only_movie_has_no_digital_release() { + let server = MockServer::start().await; + mount_movie(&server, 1_022_789, MOVIE_THEATRICAL_ONLY).await; + + let movie = client(&server) + .movie(1_022_789) + .await + .expect("lookup succeeds"); + + assert_eq!(movie.release_date, Some(date(2026, 8, 1))); + assert_eq!(movie.digital_release, None); + assert!(!movie.is_digitally_released(date(2026, 8, 22))); +} + +#[tokio::test] +async fn announced_digital_date_does_not_count_until_it_arrives() { + let server = MockServer::start().await; + mount_movie(&server, 1_211_073, MOVIE_FUTURE_DIGITAL).await; + + let movie = client(&server) + .movie(1_211_073) + .await + .expect("lookup succeeds"); + + assert_eq!(movie.digital_release, Some(date(2026, 11, 20))); + assert!(!movie.is_digitally_released(date(2026, 8, 22))); + assert!(movie.is_digitally_released(date(2026, 11, 20))); +} + +#[tokio::test] +async fn unreleased_movie_has_no_dates_and_no_imdb_id() { + let server = MockServer::start().await; + mount_movie(&server, 1_156_593, MOVIE_UNRELEASED).await; + + let movie = client(&server) + .movie(1_156_593) + .await + .expect("lookup succeeds"); + + assert_eq!(movie.release_date, None); + assert_eq!(movie.digital_release, None); + assert_eq!(movie.imdb_id, None); + assert_eq!(movie.runtime, None); + assert!(movie.origin_countries.is_empty()); + assert!(!movie.is_digitally_released(date(2026, 8, 22))); +} + +/// §8: metadata refresh is a daily tick, so repeated lookups within a day must +/// not become repeated requests. +#[tokio::test] +async fn responses_are_served_from_the_cache() { + let server = MockServer::start().await; + Mock::given(method("GET")) + .and(path("/3/movie/693134")) + .respond_with(ResponseTemplate::new(200).set_body_string(MOVIE_DUNE)) + .expect(1) + .mount(&server) + .await; + + let client = client(&server); + let first = client.movie(693_134).await.expect("lookup succeeds"); + let second = client.movie(693_134).await.expect("cached lookup succeeds"); + + assert_eq!(first, second); +} + +#[tokio::test] +async fn cache_entries_expire_and_can_be_cleared() { + let server = MockServer::start().await; + Mock::given(method("GET")) + .and(path("/3/movie/693134")) + .respond_with(ResponseTemplate::new(200).set_body_string(MOVIE_DUNE)) + .expect(3) + .mount(&server) + .await; + + let client = TmdbClient::builder("test-key") + .base_url(format!("{}/3", server.uri())) + .cache_ttl(Duration::from_millis(50)) + .build() + .expect("client builds"); + + client.movie(693_134).await.expect("lookup succeeds"); + tokio::time::sleep(Duration::from_millis(120)).await; + client.movie(693_134).await.expect("lookup succeeds"); + + client.clear_cache(); + client.movie(693_134).await.expect("lookup succeeds"); +} + +#[tokio::test] +async fn different_searches_do_not_share_a_cache_entry() { + let server = MockServer::start().await; + Mock::given(method("GET")) + .and(path("/3/search/movie")) + .respond_with(ResponseTemplate::new(200).set_body_string(SEARCH_DUNE)) + .expect(3) + .mount(&server) + .await; + + let client = client(&server); + client.search_movies("dune", None).await.expect("succeeds"); + client + .search_movies("dune", Some(2024)) + .await + .expect("succeeds"); + client.search_movies("bluey", None).await.expect("succeeds"); + // A repeat of the first is the cached one. + client.search_movies("dune", None).await.expect("succeeds"); +} + +#[tokio::test] +async fn unknown_id_is_not_found() { + let server = MockServer::start().await; + Mock::given(method("GET")) + .and(path("/3/movie/1")) + .respond_with(ResponseTemplate::new(404).set_body_string( + r#"{"success":false,"status_code":34,"status_message":"The resource you requested could not be found."}"#, + )) + .mount(&server) + .await; + + let error = client(&server).movie(1).await.expect_err("404 is an error"); + + match error { + Error::NotFound { resource } => assert_eq!(resource, "movie/1"), + other => panic!("expected NotFound, got {other:?}"), + } +} + +#[tokio::test] +async fn rejected_key_is_unauthorized() { + let server = MockServer::start().await; + Mock::given(method("GET")) + .and(path("/3/movie/693134")) + .respond_with(ResponseTemplate::new(401).set_body_string( + r#"{"success":false,"status_code":7,"status_message":"Invalid API key: You must be granted a valid key."}"#, + )) + .mount(&server) + .await; + + let error = client(&server) + .movie(693_134) + .await + .expect_err("401 is an error"); + + assert!(matches!(error, Error::Unauthorized), "got {error:?}"); +} + +#[tokio::test] +async fn rate_limit_surfaces_retry_after() { + let server = MockServer::start().await; + Mock::given(method("GET")) + .and(path("/3/movie/693134")) + .respond_with( + ResponseTemplate::new(429) + .insert_header("retry-after", "13") + .set_body_string(r#"{"status_code":25,"status_message":"Your request count is over the allowed limit."}"#), + ) + .mount(&server) + .await; + + let error = client(&server) + .movie(693_134) + .await + .expect_err("429 is an error"); + + match error { + Error::RateLimited { retry_after } => { + assert_eq!(retry_after, Some(Duration::from_secs(13))); + } + other => panic!("expected RateLimited, got {other:?}"), + } +} + +/// A TMDB outage must not pin a title into a bad state for a whole day. +#[tokio::test] +async fn failures_are_not_cached() { + let server = MockServer::start().await; + let client = client(&server); + + { + let _failing = Mock::given(method("GET")) + .and(path("/3/movie/693134")) + .respond_with(ResponseTemplate::new(500).set_body_string("upstream is down")) + .expect(1) + .mount_as_scoped(&server) + .await; + + let error = client.movie(693_134).await.expect_err("500 is an error"); + match error { + Error::Unexpected { status, body } => { + assert_eq!(status, 500); + assert_eq!(body, "upstream is down"); + } + other => panic!("expected Unexpected, got {other:?}"), + } + } + + Mock::given(method("GET")) + .and(path("/3/movie/693134")) + .respond_with(ResponseTemplate::new(200).set_body_string(MOVIE_DUNE)) + .expect(1) + .mount(&server) + .await; + + let movie = client.movie(693_134).await.expect("retry succeeds"); + assert_eq!(movie.tmdb_id, 693_134); +} + +/// A body that does not decode must not enter the cache, or one bad response +/// becomes a day-long outage for that title. +#[tokio::test] +async fn malformed_json_is_a_decode_error_and_is_not_cached() { + let server = MockServer::start().await; + let client = client(&server); + + { + let _garbage = Mock::given(method("GET")) + .and(path("/3/movie/693134")) + .respond_with(ResponseTemplate::new(200).set_body_string("{ not json")) + .expect(1) + .mount_as_scoped(&server) + .await; + + let error = client + .movie(693_134) + .await + .expect_err("garbage is an error"); + assert!(matches!(error, Error::Decode(_)), "got {error:?}"); + } + + Mock::given(method("GET")) + .and(path("/3/movie/693134")) + .respond_with(ResponseTemplate::new(200).set_body_string(MOVIE_DUNE)) + .expect(1) + .mount(&server) + .await; + + let movie = client.movie(693_134).await.expect("retry succeeds"); + assert_eq!(movie.tmdb_id, 693_134); +} + +/// The cache key is derived from the encoded URL, so a query that happens to +/// contain `&year=` cannot collide with the same query plus a real year. +#[tokio::test] +async fn a_query_containing_separators_does_not_collide_with_a_year() { + let server = MockServer::start().await; + Mock::given(method("GET")) + .and(path("/3/search/movie")) + .respond_with(ResponseTemplate::new(200).set_body_string(SEARCH_DUNE)) + .expect(2) + .mount(&server) + .await; + + let client = client(&server); + client + .search_movies("dune&year=2024", None) + .await + .expect("succeeds"); + client + .search_movies("dune", Some(2024)) + .await + .expect("succeeds"); +} + +/// The API key is appended at send time, so it can never become part of a +/// cache key. +#[tokio::test] +async fn a_query_that_spells_out_the_api_key_is_still_just_a_query() { + let server = MockServer::start().await; + Mock::given(method("GET")) + .and(path("/3/search/movie")) + .and(query_param("query", "dune&api_key=stolen")) + .and(query_param("api_key", "test-key")) + .respond_with(ResponseTemplate::new(200).set_body_string(SEARCH_DUNE)) + .expect(1) + .mount(&server) + .await; + + client(&server) + .search_movies("dune&api_key=stolen", None) + .await + .expect("succeeds"); +} + +#[tokio::test] +async fn debug_output_does_not_leak_the_api_key() { + let server = MockServer::start().await; + let rendered = format!("{:?}", client(&server)); + + assert!(!rendered.contains("test-key"), "{rendered}"); + assert!(rendered.contains("redacted"), "{rendered}"); +}