From 71bb9ef2c353b25fac566ffa601f44ec37edffb2 Mon Sep 17 00:00:00 2001 From: Miguel Palhas Date: Wed, 11 Nov 2026 19:13:19 +0000 Subject: [PATCH] refactor(web): settings forms and signal chain as utilities Refs #280 Co-Authored-By: Claude Opus 5.5 (1M context) --- web/src/components.css | 316 -------------------------------- web/src/look.ts | 29 +++ web/src/style.css | 4 + web/src/subs-panel.tsx | 11 +- web/src/views/Movie.tsx | 8 +- web/src/views/Search.tsx | 22 ++- web/src/views/Series.tsx | 8 +- web/src/views/Settings.tsx | 361 +++++++++++++++++++++---------------- 8 files changed, 264 insertions(+), 495 deletions(-) diff --git a/web/src/components.css b/web/src/components.css index 3547efc..8cca59f 100644 --- a/web/src/components.css +++ b/web/src/components.css @@ -376,322 +376,6 @@ body { } } -/* ---- settings (issue #116) -------------------------------------------- */ - -.form-grid { - display: grid; - grid-template-columns: repeat(auto-fit, minmax(13rem, 1fr)); - gap: var(--space-3); - align-items: end; -} - -.field { - display: grid; - gap: var(--space-1); -} - -.field-label { - font-size: var(--text-2xs); - font-weight: 600; - text-transform: uppercase; - letter-spacing: 0.12em; - color: var(--ink-muted); -} - -.form-input { - width: 100%; - min-height: var(--control-h); - padding: 0 var(--space-3); - font-family: var(--font-readout); - font-size: var(--text-base); - color: var(--ink); - background: var(--ground); - border: 1px solid var(--line); - border-radius: var(--radius); - box-shadow: inset 0 1px var(--lowlight); - caret-color: var(--accent); - transition: border-color 150ms var(--ease-out); -} - -.form-input:hover { - border-color: var(--line-strong); -} - -.form-input:focus { - border-color: var(--accent); - outline: none; -} - -.form-input:disabled { - color: var(--ink-faint); - border-color: var(--line); -} - -/* a select draws its own chevron: appearance is gone, so the shape returns */ -select.form-input { - appearance: none; - padding-right: var(--space-8); - background-image: - linear-gradient(45deg, transparent 50%, var(--ink-muted) 50%), - linear-gradient(135deg, var(--ink-muted) 50%, transparent 50%); - background-position: - calc(100% - 1.1rem) 50%, - calc(100% - 0.8rem) 50%; - background-size: 0.3rem 0.3rem; - background-repeat: no-repeat; -} - -.form-input[data-invalid] { - border-color: var(--signal-fault); -} - -.band-line { - display: flex; - align-items: center; - gap: var(--space-2); -} - -.band-line .field-label { - width: 3.5rem; -} - -/* four numbers and a label must share a phone's width, so the inputs shrink - rather than push the line past the gutter */ -.band-num { - flex: 1 1 0; - min-width: 0; - max-width: 4.5rem; -} - -.subtitle-panel .field-label { - display: block; - margin: var(--space-4) 0 var(--space-2); -} - -.provider-list { - margin: 0 0 var(--space-3); - padding: 0; - list-style: none; -} - -.provider-toggle { - width: 1.25rem; - height: 1.25rem; - margin: 0; - accent-color: var(--accent); -} - -.provider-budget { - width: 5.5rem; -} - -@media (min-width: 40rem) { - .form-input { - font-size: var(--text-sm); - } -} - -/* ---- signal chain (§9.7: a settings section) ------------------------------- */ - -.chain-wrap { - container-type: inline-size; - padding-top: var(--space-4); -} - -/* the phone stacks the chain into one junctioned trace */ -.chain { - width: 100%; - display: grid; - grid-template-columns: 1fr; - grid-template-areas: - "tmdb" - "prow" - "t1" - "master" - "out" - "sink"; - align-items: center; - row-gap: var(--space-3); -} - -.area-tmdb { - grid-area: tmdb; -} - -.area-prowlarr { - grid-area: prow; -} - -.area-t1 { - grid-area: t1; -} - -.area-t2 { - display: none; -} - -.area-master { - grid-area: master; -} - -.area-out { - grid-area: out; -} - -.area-qbittorrent { - grid-area: sink; -} - -.chain-lane { - margin-top: var(--space-4); - display: grid; - grid-template-columns: repeat(auto-fit, minmax(12rem, 1fr)); - gap: var(--space-3); - align-items: stretch; -} - -.module { - min-width: 0; - background: var(--panel); - border: 1px solid var(--line); - border-radius: var(--radius); - box-shadow: inset 0 1px var(--highlight); - padding: var(--space-4) var(--space-4) var(--space-3); -} - -.module-master { - background: var(--panel-raised); - border-color: var(--line-strong); -} - -.module-head { - display: flex; - align-items: center; - flex-wrap: wrap; - gap: var(--space-1) var(--space-2); -} - -.module-name { - margin: 0; - font-family: var(--font-display); - font-size: var(--text-md); - font-weight: 700; - text-transform: uppercase; - letter-spacing: 0.12em; - line-height: 1; -} - -.module-master .module-name { - font-size: var(--text-lg); -} - -.module-status { - margin-left: auto; - padding-left: var(--space-3); - color: var(--ink-muted); -} - -.module-status[data-tone="ok"] { - color: var(--signal-ok); -} - -.module-status[data-tone="warn"] { - color: var(--signal-warn); -} - -.module-status[data-tone="fault"] { - color: var(--signal-fault); -} - -.module-role { - margin: var(--space-2) 0 0; - font-size: var(--text-2xs); - font-weight: 600; - text-transform: uppercase; - letter-spacing: 0.12em; - color: var(--ink-muted); -} - -.module-detail { - margin: var(--space-1) 0 0; - min-height: 1.2em; - font-size: var(--text-xs); - color: var(--ink-muted); -} - -.intake .module-detail { - overflow-wrap: anywhere; -} - -.bus { - display: grid; - align-content: center; - justify-items: center; - height: 2rem; -} - -.bus svg { - transform: rotate(90deg); - width: 2rem; -} - -.bus-trace { - --trace: var(--line-strong); - width: 100%; - height: 0.5rem; - display: block; - transition: filter 300ms var(--ease-out); -} - -.bus-trace line { - stroke: var(--trace); - stroke-width: 1; -} - -.bus-arrow { - fill: var(--trace); -} - -.bus-trace[data-tone="ok"] { - --trace: var(--signal-ok); -} - -.bus-trace[data-tone="warn"] { - --trace: var(--signal-warn); -} - -.bus-trace[data-tone="fault"] { - --trace: var(--signal-fault); -} - -@container (min-width: 46rem) { - .chain { - grid-template-columns: 1fr 2.5rem 1.2fr 2.5rem 1fr; - grid-template-areas: - "tmdb t1 master out sink" - "prow t2 master out sink"; - row-gap: var(--space-6); - } - - .area-t2 { - display: grid; - grid-area: t2; - } - - .bus { - height: auto; - } - - .bus svg { - transform: none; - width: 100%; - } - - .module-master { - padding: var(--space-6) var(--space-4) var(--space-4); - } -} - @media (prefers-reduced-motion: reduce) { *, *::before { diff --git a/web/src/look.ts b/web/src/look.ts index 76e208d..a604826 100644 --- a/web/src/look.ts +++ b/web/src/look.ts @@ -339,3 +339,32 @@ export const detail = { moreToggles: "grid gap-2 @row:grid-cols-2 @row:col-span-full", controlNote: "readout m-0 text-xs text-ink-muted @row:col-span-full", } as const; + +/* ---- forms --------------------------------------------------------------- */ + +const INPUT = + "min-h-control-h py-0 px-3 font-readout text-base sm:text-sm text-ink bg-ground border border-line rounded-panel [box-shadow:inset_0_1px_var(--lowlight)] caret-accent [transition:border-color_150ms_var(--ease-out)] hover:border-line-strong focus:border-accent focus:outline-none disabled:text-ink-faint disabled:border-line data-invalid:border-signal-fault"; + +export const form = { + grid: "grid [grid-template-columns:repeat(auto-fit,minmax(13rem,1fr))] gap-3 [align-items:end]", + field: "grid gap-1", + label: "text-2xs font-semibold uppercase tracking-engraved text-ink-muted", + input: `w-full ${INPUT}`, + /** An input that brings its own width and flex, such as a band's number. */ + inputBare: INPUT, + /** A select draws its own chevron: appearance is gone, so the shape returns. */ + select: + "appearance-none pr-8 bg-no-repeat [background-size:0.3rem_0.3rem] [background-position:calc(100%_-_1.1rem)_50%,calc(100%_-_0.8rem)_50%] [background-image:linear-gradient(45deg,transparent_50%,var(--ink-muted)_50%),linear-gradient(135deg,var(--ink-muted)_50%,transparent_50%)]", +} as const; + +/* ---- the signal chain ---------------------------------------------------- */ + +export const chain = { + module: "min-w-0 border rounded-panel [box-shadow:inset_0_1px_var(--highlight)] pt-4 px-4 pb-3", + head: "flex items-center flex-wrap gap-y-1 gap-x-2", + name: "m-0 font-display font-bold uppercase tracking-engraved leading-none", + status: + "readout ml-auto pl-3 text-ink-muted data-[tone=ok]:text-signal-ok data-[tone=warn]:text-signal-warn data-[tone=fault]:text-signal-fault", + role: "mt-2 mx-0 mb-0 text-2xs font-semibold uppercase tracking-engraved text-ink-muted", + detail: "readout mt-1 mx-0 mb-0 min-h-detail text-xs text-ink-muted", +} as const; diff --git a/web/src/style.css b/web/src/style.css index 8b99f9a..b814eeb 100644 --- a/web/src/style.css +++ b/web/src/style.css @@ -94,6 +94,9 @@ /* a subtitle select: its least width, and where it starts from */ --spacing-field: 9rem; --spacing-field-basis: 12rem; + --spacing-band-label: 3.5rem; + --spacing-budget: 5.5rem; + --spacing-detail: 1.2em; --container-deck: var(--deck-max); --container-measure: var(--measure); @@ -101,6 +104,7 @@ --container-notice: 68ch; --container-select: 18rem; --container-select-narrow: 11rem; + --container-band: 4.5rem; /* container query widths for @row, @cells and @wide: the row grows its action column, the release cells line up, the detail hero widens */ --container-row: 40rem; diff --git a/web/src/subs-panel.tsx b/web/src/subs-panel.tsx index 8e025fd..7f019a0 100644 --- a/web/src/subs-panel.tsx +++ b/web/src/subs-panel.tsx @@ -4,7 +4,7 @@ import { type ReactNode, useEffect, useRef, useState } from "react"; import { ArmedDeleteIcon, Icon } from "./icons"; -import { CHIP_ICON, chip as chipLook, control, cx, seg, segmented } from "./look"; +import { CHIP_ICON, chip as chipLook, control, cx, form, seg, segmented } from "./look"; import { fileName } from "./movie"; import { cachedSubtitleOptions, @@ -200,11 +200,12 @@ function SubtitleField({ // biome-ignore lint/a11y/noLabelWithoutControl: the select is the child ); @@ -829,7 +830,7 @@ export function useSubtitleSection(
setEngine(event.target.value)} diff --git a/web/src/views/Movie.tsx b/web/src/views/Movie.tsx index daa19e1..46282b8 100644 --- a/web/src/views/Movie.tsx +++ b/web/src/views/Movie.tsx @@ -5,7 +5,7 @@ import { useCallback, useEffect, useRef, useState } from "react"; import { Buckets, type DeckState, type ReleaseActions } from "../buckets"; import { LAYER, useEscape, useNav } from "../context"; import { Hero, ProviderLink, RemovePanel, type RemoveSubject, TrailerLink } from "../detail"; -import { control, detail, SUB } from "../look"; +import { control, cx, detail, form, SUB } from "../look"; import { fileName, imdbLink, @@ -501,12 +501,12 @@ export function MovieView({ movieId, toReleases }: { movieId: number; toReleases -