yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Manual search on an available movie is a silent no-op #115

New Issue
Closed
opened 2026-08-23 12:16:48 +01:00 by naps62-yolo · 1 comment
naps62-yolo commented 2026-08-23 12:16:48 +01:00
Owner
Copy Link
Copy Source

MovieCommand::Search goes through search_now, which loads the movie via pending_movie — filtered to wanted, unblocked movies with no media files and no active grab (arr-daemon/src/grab.rs). A movie that is already available falls out of the filter, so the API accepts the search (202), the daemon does nothing, and the release deck is never refreshed. Observed live on The Batman.

For the §9.3 upgrade flow, a manual Search on an available movie should still sweep the searchable indexers and upsert the results into the deck (same upsert as the grab lane, refreshing scores) — but must NOT auto-grab a winner. Auto-grab remains correct only for wanted movies with nothing on disk.

So: split deck refresh from winner selection in the manual path. Search on a pending movie keeps today's behavior (search + grab). Search on an available movie refreshes the deck and stops. Blocked movies keep refusing.

Depends on: nothing. Related: the read-time rescoring issue filed alongside this one.

`MovieCommand::Search` goes through `search_now`, which loads the movie via `pending_movie` — filtered to wanted, unblocked movies with no media files and no active grab (`arr-daemon/src/grab.rs`). A movie that is already `available` falls out of the filter, so the API accepts the search (202), the daemon does nothing, and the release deck is never refreshed. Observed live on The Batman. For the §9.3 upgrade flow, a manual Search on an available movie should still sweep the searchable indexers and upsert the results into the deck (same upsert as the grab lane, refreshing scores) — but must NOT auto-grab a winner. Auto-grab remains correct only for wanted movies with nothing on disk. So: split deck refresh from winner selection in the manual path. Search on a pending movie keeps today's behavior (search + grab). Search on an available movie refreshes the deck and stops. Blocked movies keep refusing. Depends on: nothing. Related: the read-time rescoring issue filed alongside this one.
naps62-yolo added the area/daemondifficulty/moderatephase/5-uitype/bug labels 2026-08-23 12:16:59 +01:00
naps62-yolo commented 2026-08-23 12:23:19 +01:00
Author
Owner
Copy Link
Copy Source

Fixed in aa6961f (merged to main as 401afe5).

search_now no longer loads the movie through the gap filter. It loads any unblocked movie and picks a lane: a gap — wanted, nothing on disk, no grab in flight — searches and grabs as before; anything already satisfied sweeps the searchable indexers, upserts every candidate into the release deck with a fresh verdict and score, and stops without grabbing. Blocked movies are still refused.

The digital-release gate now applies only to the grab lane: a movie with a file on disk is released whatever TMDB knows, so it no longer silences the deck refresh.

Five tests in crates/arr-daemon/src/grab.rs cover the split: available movie refreshes the deck and grabs nothing, refreshes before the digital release date, does not re-grab with a grab in flight, wanted movie still grabs, blocked movie calls no indexer. just ci green.

Fixed in aa6961f (merged to main as 401afe5). `search_now` no longer loads the movie through the gap filter. It loads any unblocked movie and picks a lane: a gap — wanted, nothing on disk, no grab in flight — searches and grabs as before; anything already satisfied sweeps the searchable indexers, upserts every candidate into the release deck with a fresh verdict and score, and stops without grabbing. Blocked movies are still refused. The digital-release gate now applies only to the grab lane: a movie with a file on disk is released whatever TMDB knows, so it no longer silences the deck refresh. Five tests in `crates/arr-daemon/src/grab.rs` cover the split: available movie refreshes the deck and grabs nothing, refreshes before the digital release date, does not re-grab with a grab in flight, wanted movie still grabs, blocked movie calls no indexer. `just ci` green.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/daemon difficulty/moderate phase/5-ui type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#115