yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Manual episode and season commands are never drained #132

New Issue
Closed
opened 2026-08-23 16:53:07 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-23 16:53:07 +01:00
Owner
Copy Link
Copy Source

AppState exposes next_episode_command, and POST /api/episodes/{id}/search
and POST /api/episodes/{id}/releases/{rid}/grab both enqueue onto that
channel. Nothing drains it: crates/arr-daemon/src/manual.rs imports only
MovieCommand and its loop calls next_movie_command alone.

Both endpoints therefore return 202 and drop the work on the floor. Manual
episode search has never functioned; the movie equivalent does, which is why it
was not noticed. #125 added SeasonCommand with the same shape, so the new
season deck endpoints have the same gap from the moment they merged.

Drain all three in the daemon's manual lane:

  • EpisodeCommand::Search / Grab — the episode targeted search and grab paths
    already exist in tv_grab.rs; this is wiring, not new selection logic.
  • SeasonCommand::Search / Grab — same, against the season-pack path and the
    season_releases table from #125.

The movie lane is the template, including how it reports failures. Cover each
command variant with a test that asserts the work actually happened, not just
that the command was accepted — the missing assertion is what let this survive.

`AppState` exposes `next_episode_command`, and `POST /api/episodes/{id}/search` and `POST /api/episodes/{id}/releases/{rid}/grab` both enqueue onto that channel. Nothing drains it: `crates/arr-daemon/src/manual.rs` imports only `MovieCommand` and its loop calls `next_movie_command` alone. Both endpoints therefore return 202 and drop the work on the floor. Manual episode search has never functioned; the movie equivalent does, which is why it was not noticed. #125 added `SeasonCommand` with the same shape, so the new season deck endpoints have the same gap from the moment they merged. Drain all three in the daemon's manual lane: - `EpisodeCommand::Search` / `Grab` — the episode targeted search and grab paths already exist in `tv_grab.rs`; this is wiring, not new selection logic. - `SeasonCommand::Search` / `Grab` — same, against the season-pack path and the `season_releases` table from #125. The movie lane is the template, including how it reports failures. Cover each command variant with a test that asserts the work actually happened, not just that the command was accepted — the missing assertion is what let this survive.
naps62-yolo added this to the TV tracking milestone 2026-08-23 16:53:07 +01:00
naps62-yolo added the phase/6-tvdifficulty/moderatearea/daemontype/bug labels 2026-08-23 16:53:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/daemon difficulty/moderate phase/6-tv type/bug
Milestone
No items
No Milestone TV tracking
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#132