yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Season-pack names parse wrong in two ways #135

New Issue
Closed
opened 2026-08-23 17:11:54 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-23 17:11:54 +01:00
Owner
Copy Link
Copy Source

arr-core::matching::match_episode (#123) identifies a series by exact
normalised title when the tracker supplies no id. Two arr-parse gaps make
common season-pack names fail that comparison, so the pack matches nothing and
the failure is silent — there is no rejected-with-a-reason row, the release
simply never reaches the wanted episode.

Complete before the season token stays in the title. markers.rs:139
classifies complete as Junk with Weak strength, and only strong markers
close the title boundary. Bluey.COMPLETE.S01.1080p.WEB-DL therefore parses
with title: "Bluey Complete". The trailing form, Bluey.S01.COMPLETE.1080p,
is fine because the season token closes the boundary first — so this depends
on where the word lands, which is exactly the kind of difference a release
group varies freely.

The degenerate season range S01-S01 yields no season claim. The dash-range
branch only produces a Seasons claim when first and last differ, so
Fallout.S01-S01.1080p.BluRay parses with episode: None. match_episode
lifted is_this_seasons_pack's rule that a degenerate range is one season's
pack, and carries a predicate-level test for it, but the parse never gets far
enough to exercise it.

Both are arr-parse, both are pure, and both want table-driven cases over real
release names. #124 depends on this: RSS pack matching is only as good as the
parse under it.

`arr-core::matching::match_episode` (#123) identifies a series by exact normalised title when the tracker supplies no id. Two `arr-parse` gaps make common season-pack names fail that comparison, so the pack matches nothing and the failure is silent — there is no rejected-with-a-reason row, the release simply never reaches the wanted episode. **`Complete` before the season token stays in the title.** `markers.rs:139` classifies `complete` as `Junk` with `Weak` strength, and only strong markers close the title boundary. `Bluey.COMPLETE.S01.1080p.WEB-DL` therefore parses with `title: "Bluey Complete"`. The trailing form, `Bluey.S01.COMPLETE.1080p`, is fine because the season token closes the boundary first — so this depends on where the word lands, which is exactly the kind of difference a release group varies freely. **The degenerate season range `S01-S01` yields no season claim.** The dash-range branch only produces a `Seasons` claim when first and last differ, so `Fallout.S01-S01.1080p.BluRay` parses with `episode: None`. `match_episode` lifted `is_this_seasons_pack`'s rule that a degenerate range is one season's pack, and carries a predicate-level test for it, but the parse never gets far enough to exercise it. Both are `arr-parse`, both are pure, and both want table-driven cases over real release names. #124 depends on this: RSS pack matching is only as good as the parse under it.
naps62-yolo added this to the TV tracking milestone 2026-08-23 17:11:54 +01:00
naps62-yolo added the difficulty/easyphase/6-tvarea/parsetype/bug labels 2026-08-23 17:11:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/parse difficulty/easy phase/6-tv type/bug
Milestone
No items
No Milestone TV tracking
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#135