yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Unrated titles store a 0.0 rating instead of NULL #156

New Issue
Closed
opened 2026-08-23 22:15:30 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-23 22:15:30 +01:00
Owner
Copy Link
Copy Source

Found by the integration review of blitz/rich-metadata, spanning #143 and #145.

arr-meta's Movie and Series carry vote_average: f64, and #145's write
paths store it straight onto the row. TMDB reports vote_average: 0 for a title
nobody has rated — it is the absence of a rating, not a rating of zero.

So an unrated title is stored as 0.0 rather than NULL. The columns were made
nullable in #145 exactly so that "no rating yet" is representable, and this
defeats that. Nothing renders a rating yet, which is the only reason it is not
already visible: #147's search chips, #151's grid cards and the #149/#150 detail
headers would each show a confident 0.0 on any title TMDB has no votes for.

  • Make vote_average an Option<f64> in arr-meta, normalising 0.0 away at
    the edge — the same treatment non_empty already gives TMDB's "", and for
    the same reason: TMDB uses a zero value where null is meant.
  • Let that Option flow through the daemon refresh and the add paths, so an
    unrated title writes NULL.
  • A title that later gains votes must overwrite the NULL, and one whose votes
    are withdrawn must go back to NULL — the refresh already compares before
    writing, so this is about what it compares, not a new pass.

vote_count stays unstored, per #145. It is context for a detail page, which is
served live, and storing it would only be a second way to ask the same question.

Non-goal: no change to how a rating is displayed. That is each consuming issue's
own call; this one only makes "absent" expressible.

Found by the integration review of `blitz/rich-metadata`, spanning #143 and #145. `arr-meta`'s `Movie` and `Series` carry `vote_average: f64`, and #145's write paths store it straight onto the row. TMDB reports `vote_average: 0` for a title nobody has rated — it is the absence of a rating, not a rating of zero. So an unrated title is stored as `0.0` rather than `NULL`. The columns were made nullable in #145 exactly so that "no rating yet" is representable, and this defeats that. Nothing renders a rating yet, which is the only reason it is not already visible: #147's search chips, #151's grid cards and the #149/#150 detail headers would each show a confident `0.0` on any title TMDB has no votes for. - Make `vote_average` an `Option<f64>` in `arr-meta`, normalising `0.0` away at the edge — the same treatment `non_empty` already gives TMDB's `""`, and for the same reason: TMDB uses a zero value where `null` is meant. - Let that `Option` flow through the daemon refresh and the add paths, so an unrated title writes `NULL`. - A title that later gains votes must overwrite the `NULL`, and one whose votes are withdrawn must go back to `NULL` — the refresh already compares before writing, so this is about what it compares, not a new pass. `vote_count` stays unstored, per #145. It is context for a detail page, which is served live, and storing it would only be a second way to ask the same question. Non-goal: no change to how a rating is displayed. That is each consuming issue's own call; this one only makes "absent" expressible.
naps62-yolo added this to the Rich metadata milestone 2026-08-23 22:15:30 +01:00
naps62-yolo added the area/metadifficulty/easyphase/5-uitype/bug labels 2026-08-23 22:15:30 +01:00
naps62-yolo added a new dependency 2026-08-23 22:15:35 +01:00
#147 Posters and ratings on both sides of search results
naps62-yolo added a new dependency 2026-08-23 22:15:35 +01:00
#151 Library poster grid with a list toggle
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/meta difficulty/easy phase/5-ui type/bug
Milestone
No items
No Milestone Rich metadata
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#147 Posters and ratings on both sides of search results
yolo/arr
#151 Library poster grid with a list toggle
yolo/arr
Reference: yolo/arr#156