yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Series detail page never loads: open() wipes its own state #157

New Issue
Closed
opened 2026-08-24 03:18:47 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-24 03:18:47 +01:00
Owner
Copy Link
Copy Source

Found by the Rich metadata smoke test. Pre-existing on main — this is not a
regression from that milestone, but it hides everything #150 added.

/series/{id} renders an empty shell: an em-dash where the title goes, no
seasons, no cast, no metadata. The daemon sees GET /api/series/{id} and then
nothing — no /seasons, no /files, no /metadata.

The series view's open() takes its state before hiding its siblings:

seriesId = id;
...
for (const sibling of views) {
    sibling.hide();
}
...
await load();

The series view is itself in views, so that loop calls its own hide(), which
sets seriesId = null and bumps sequence. load() then returns at its
if (id === null) guard and the page paints nothing.

The movie view had the same hazard and already carries the fix, with a comment
naming it:

// this page is one of `views`, so the loop below calls its own hide()
// and would wipe the state assigned after it — hide first, then take state

Do the same here: hide the siblings first, then assign seriesId, origin,
returnTo, parentRoute, expanded and focusKey.

A regression test belongs with it — deep-linking to /series/{id} must issue the
seasons request, since the symptom is silent and the next reordering brings it
straight back.

Found by the Rich metadata smoke test. Pre-existing on `main` — this is not a regression from that milestone, but it hides everything #150 added. `/series/{id}` renders an empty shell: an em-dash where the title goes, no seasons, no cast, no metadata. The daemon sees `GET /api/series/{id}` and then nothing — no `/seasons`, no `/files`, no `/metadata`. The series view's `open()` takes its state before hiding its siblings: ``` seriesId = id; ... for (const sibling of views) { sibling.hide(); } ... await load(); ``` The series view is itself in `views`, so that loop calls its own `hide()`, which sets `seriesId = null` and bumps `sequence`. `load()` then returns at its `if (id === null)` guard and the page paints nothing. The movie view had the same hazard and already carries the fix, with a comment naming it: ``` // this page is one of `views`, so the loop below calls its own hide() // and would wipe the state assigned after it — hide first, then take state ``` Do the same here: hide the siblings first, then assign `seriesId`, `origin`, `returnTo`, `parentRoute`, `expanded` and `focusKey`. A regression test belongs with it — deep-linking to `/series/{id}` must issue the seasons request, since the symptom is silent and the next reordering brings it straight back.
naps62-yolo added this to the Rich metadata milestone 2026-08-24 03:18:47 +01:00
naps62-yolo added the phase/5-uidifficulty/easyarea/webtype/bug labels 2026-08-24 03:18:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/web difficulty/easy phase/5-ui type/bug
Milestone
No items
No Milestone Rich metadata
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#157