yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Add the episode title CHECK as a new migration #178

New Issue
Open
opened 2026-08-24 19:20:31 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-24 19:20:31 +01:00
Owner
Copy Link
Copy Source

CHECK (title <> '') on episodes.title is not in place. It was originally
abandoned in #153 because sqlx 0.8 made the table rebuild cascade-delete
children, then re-added by #155 as an in-place edit to migration
0021_episode_title_required.sql.

That edit had to be reverted. Changing an already-applied migration changes its
checksum, and migrate() refuses to start when one no longer matches what
_sqlx_migrations recorded — the daemon exited on boot against production and
the site was down for about ten minutes. See commit a3897df.

The constraint is still worth having, and now it can actually be added: the
sqlx 0.9 bump from #155 stands, so a migration marked -- no-transaction
holds PRAGMA foreign_keys = OFF across the rebuild and children survive.

Add it as a new migration on top rather than by editing 0021:

  • backfill any empty episodes.title to the TBA placeholder 0021 already uses
  • rebuild episodes with the CHECK, under -- no-transaction
  • assert in a test that episode_releases rows survive the rebuild, the way
    table_rebuild_preserves_child_rows does

The test empty_episode_titles_are_backfilled_and_then_rejected was removed
along with the reverted edit; restore it against the new migration.

Never edit a migration that has already run. Every schema change is a new
file. This is the second time the rule has cost something — #153 lost the
constraint, #155 lost production availability.

`CHECK (title <> '')` on `episodes.title` is not in place. It was originally abandoned in #153 because sqlx 0.8 made the table rebuild cascade-delete children, then re-added by #155 as an in-place edit to migration `0021_episode_title_required.sql`. That edit had to be reverted. Changing an already-applied migration changes its checksum, and `migrate()` refuses to start when one no longer matches what `_sqlx_migrations` recorded — the daemon exited on boot against production and the site was down for about ten minutes. See commit `a3897df`. The constraint is still worth having, and now it can actually be added: the sqlx 0.9 bump from #155 stands, so a migration marked `-- no-transaction` holds `PRAGMA foreign_keys = OFF` across the rebuild and children survive. Add it as a **new** migration on top rather than by editing `0021`: - backfill any empty `episodes.title` to the TBA placeholder `0021` already uses - rebuild `episodes` with the CHECK, under `-- no-transaction` - assert in a test that `episode_releases` rows survive the rebuild, the way `table_rebuild_preserves_child_rows` does The test `empty_episode_titles_are_backfilled_and_then_rejected` was removed along with the reverted edit; restore it against the new migration. **Never edit a migration that has already run.** Every schema change is a new file. This is the second time the rule has cost something — #153 lost the constraint, #155 lost production availability.
naps62-yolo added the area/dbdifficulty/moderatetype/bug labels 2026-08-24 19:20:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No Label area/db difficulty/moderate type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#178
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?