yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Record which rule a waiver relaxed #211

New Issue
Closed
opened 2026-08-24 22:15:27 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-24 22:15:27 +01:00
Owner
Copy Link
Copy Source

A waived release cannot record which rule it waived, so the §9.3 deck shows
waived with no rule beside it while every rejected row names its own.

releases carries:

CHECK ((verdict = 'rejected') = (rejected_rule IS NOT NULL))

so a waived row must store rejected_rule = NULL. The daemon already writes
it that way (verdict_columns in arr-daemon/src/grab.rs maps
Verdict::Waived(_) to ("waived", None)), and #210's size waiver does the
same because the constraint leaves no choice.

That loses information §5.7 says is worth keeping: a waiver is "watchable but
not what was asked", and which rule was relaxed is the whole content of that
sentence. Before #210 the case was rare enough not to show; now the ordinary
outcome of waiving a size rejection is three rows that say only waived.

The fix is a migration relaxing the constraint to require a rule on a rejection
without forbidding one elsewhere:

CHECK (verdict != 'rejected' OR rejected_rule IS NOT NULL)

then having both the daemon and arr-api's reclassification store the waived
rule. SQLite needs a table rebuild for this, in the shape migration 0014
already uses.

Existing rows keep NULL and read as they do today, so the deck has to go on
tolerating a waived row with no rule.

Found while implementing #210.

A waived release cannot record which rule it waived, so the §9.3 deck shows `waived` with no rule beside it while every rejected row names its own. `releases` carries: ```sql CHECK ((verdict = 'rejected') = (rejected_rule IS NOT NULL)) ``` so a `waived` row must store `rejected_rule = NULL`. The daemon already writes it that way (`verdict_columns` in `arr-daemon/src/grab.rs` maps `Verdict::Waived(_)` to `("waived", None)`), and #210's size waiver does the same because the constraint leaves no choice. That loses information §5.7 says is worth keeping: a waiver is "watchable but not what was asked", and which rule was relaxed is the whole content of that sentence. Before #210 the case was rare enough not to show; now the ordinary outcome of waiving a size rejection is three rows that say only `waived`. The fix is a migration relaxing the constraint to require a rule on a rejection without forbidding one elsewhere: ```sql CHECK (verdict != 'rejected' OR rejected_rule IS NOT NULL) ``` then having both the daemon and `arr-api`'s reclassification store the waived rule. SQLite needs a table rebuild for this, in the shape migration 0014 already uses. Existing rows keep `NULL` and read as they do today, so the deck has to go on tolerating a waived row with no rule. Found while implementing #210.
naps62-yolo added the area/dbphase/6-tvdifficulty/moderatetype/bug labels 2026-08-24 22:15:31 +01:00
naps62-yolo added this to the Feedback pass 2 milestone 2026-08-25 11:31:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/db difficulty/moderate phase/6-tv type/bug
Milestone
No items
No Milestone Feedback pass 2
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#211