yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Tidy the leftovers from the Jellyfin client move #242

New Issue
Open
opened 2026-08-25 10:30:19 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-25 10:30:19 +01:00
Owner
Copy Link
Copy Source

Three leftovers from moving JellyfinClient out of arr-daemon into arr-api,
found in the integration review. None is urgent; all are cheap.

  • crates/arr-api/src/jellyfin.rs:1-2 and crates/arr-api/src/state.rs:163-164
    both cite "DESIGN.md §15" and describe "a manual subtitle grab or
    translation". DESIGN.md ends at §14, and arr-api holds no subtitle code.
    The sole consumer of AppState::jellyfin() is relocate.rs. The stated
    motivation for the move is not the code that landed. (§15 belongs to the
    subtitles branch, which is where that text came from.)
  • crates/arr-daemon/src/import.rs:30 now does
    use arr_api::jellyfin::JellyfinClient, so the daemon's import lane depends
    on the axum/OpenAPI crate to get an HTTP client. Every other outbound client
    has its own crate — arr-meta, arr-indexer, arr-dl. This was the
    cheapest place to put it, not the right one; arr-jellyfin would match the
    layout CLAUDE.md describes.
  • crates/arr-daemon/src/main.rs:126 and :299 build two independent
    reqwest::Clients, so two connection pools for one Jellyfin instance. The
    doc comment acknowledges it. Sharing one Clone is free.

Coordinate the crate move with the subtitles branch before doing it — both
branches touch main.rs and state.rs and the merge is already hand-resolved
there. See #237.

Three leftovers from moving `JellyfinClient` out of `arr-daemon` into `arr-api`, found in the integration review. None is urgent; all are cheap. - `crates/arr-api/src/jellyfin.rs:1-2` and `crates/arr-api/src/state.rs:163-164` both cite **"DESIGN.md §15"** and describe "a manual subtitle grab or translation". `DESIGN.md` ends at §14, and `arr-api` holds no subtitle code. The sole consumer of `AppState::jellyfin()` is `relocate.rs`. The stated motivation for the move is not the code that landed. (§15 belongs to the subtitles branch, which is where that text came from.) - `crates/arr-daemon/src/import.rs:30` now does `use arr_api::jellyfin::JellyfinClient`, so the daemon's import lane depends on the axum/OpenAPI crate to get an HTTP client. Every other outbound client has its own crate — `arr-meta`, `arr-indexer`, `arr-dl`. This was the cheapest place to put it, not the right one; `arr-jellyfin` would match the layout CLAUDE.md describes. - `crates/arr-daemon/src/main.rs:126` and `:299` build two independent `reqwest::Client`s, so two connection pools for one Jellyfin instance. The doc comment acknowledges it. Sharing one `Clone` is free. Coordinate the crate move with the subtitles branch before doing it — both branches touch `main.rs` and `state.rs` and the merge is already hand-resolved there. See #237.
naps62-yolo added this to the Feedback pass 2 milestone 2026-08-25 10:30:19 +01:00
naps62-yolo added the difficulty/moderatetype/chore labels 2026-08-25 10:30:19 +01:00
naps62-yolo modified the milestone from Feedback pass 2 to Feedback pass 2 follow-ups 2026-08-25 12:16:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No Label difficulty/moderate type/chore
Milestone
No items
No Milestone Feedback pass 2 follow-ups
Projects
Clear projects
No project
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#242
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?