yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Root path edges: trailing slash self-conflict, stray directory #243

New Issue
Closed
opened 2026-08-25 10:30:19 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-25 10:30:19 +01:00
Owner
Copy Link
Copy Source

Two small filesystem-edge defects in the root relocation, from the integration
review.

A trailing slash makes a root conflict with itself. roots.rs:183 compares
path == current.path as exact strings and neither create nor update
normalises trailing separators. PUT with /mnt/media/ when /mnt/media is
stored takes the relocation branch, every planned destination resolves to its
own source, and the pre-check returns
409 the destination already has '/mnt/media/Dune Part Two (2024) [tmdbid-693134]'
for what the operator sees as a no-op edit.

A failed move leaves an empty directory behind. relocate.rs:166-172 calls
create_dir_all(new_root) and never cleans it up when the move then fails;
roots.rs's own test asserts the leftover exists. §7.4 says a failure "leaves
the root's path alone, so the stored path always describes the disk" — true of
the row, but an empty directory is left at a path no root points at.

Scope: normalise trailing separators before the comparison and before planning,
and remove a directory this request created when the move it was created for
does not complete.

Two small filesystem-edge defects in the root relocation, from the integration review. **A trailing slash makes a root conflict with itself.** `roots.rs:183` compares `path == current.path` as exact strings and neither `create` nor `update` normalises trailing separators. `PUT` with `/mnt/media/` when `/mnt/media` is stored takes the relocation branch, every planned destination resolves to its own source, and the pre-check returns `409 the destination already has '/mnt/media/Dune Part Two (2024) [tmdbid-693134]'` for what the operator sees as a no-op edit. **A failed move leaves an empty directory behind.** `relocate.rs:166-172` calls `create_dir_all(new_root)` and never cleans it up when the move then fails; `roots.rs`'s own test asserts the leftover exists. §7.4 says a failure "leaves the root's path alone, so the stored path always describes the disk" — true of the row, but an empty directory is left at a path no root points at. Scope: normalise trailing separators before the comparison and before planning, and remove a directory this request created when the move it was created for does not complete.
naps62-yolo added this to the Feedback pass 2 milestone 2026-08-25 10:30:19 +01:00
naps62-yolo added the difficulty/easyarea/apitype/bug labels 2026-08-25 10:30:19 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No Label area/api difficulty/easy type/bug
Milestone
No items
No Milestone Feedback pass 2
Projects
Clear projects
No project
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#243
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?