yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

The pack backoff ladder measures from the grab, not the failure #245

New Issue
Closed
opened 2026-08-25 11:14:56 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-25 11:14:56 +01:00
Owner
Copy Link
Copy Source

#239 moved the attention window's anchor to failed_at and explicitly, correctly,
left §6.2's pack backoff on grabbed_at — the decision is documented at
crates/arr-daemon/src/tv_grab.rs:1141-1143. This issue is the consequence, not
a complaint about that call.

In exactly the scenario §5.7's new paragraph describes — a torrent that stalls
for five weeks before ffprobe condemns it at import — backoff_elapsed(failures, grabbed_at) has already elapsed the moment the grab fails. The pack lane retries
immediately instead of backing off, which is the opposite of what §6.2's ladder
is for: the backoff exists to stop hammering a source that just failed, and it
measures from a moment five weeks before the failure.

Sites: crates/arr-daemon/src/tv_grab.rs:1149, crates/arr-daemon/src/rss.rs:632,
crates/arr-api/src/series.rs:1676.

A naming trap worth fixing whatever is decided. All three sites alias
max(grabbed_at) as last_failed_at, and series.rs:1683-1691 feeds that into
the season deck's reopens_at and pack_retry_at. So the UI shows a grab time
under a name that §5.7 has now redefined to mean something else. Either the alias
is wrong or the column is; they cannot both stay.

Scope: decide whether the backoff ladder measures from the grab or the failure,
state it in §6.2 the way §5.7 now states its own anchor, and make the aliases
say what they hold.

#239 moved the attention window's anchor to `failed_at` and explicitly, correctly, left §6.2's pack backoff on `grabbed_at` — the decision is documented at `crates/arr-daemon/src/tv_grab.rs:1141-1143`. This issue is the consequence, not a complaint about that call. In exactly the scenario §5.7's new paragraph describes — a torrent that stalls for five weeks before `ffprobe` condemns it at import — `backoff_elapsed(failures, grabbed_at)` has already elapsed the moment the grab fails. The pack lane retries immediately instead of backing off, which is the opposite of what §6.2's ladder is for: the backoff exists to stop hammering a source that just failed, and it measures from a moment five weeks before the failure. Sites: `crates/arr-daemon/src/tv_grab.rs:1149`, `crates/arr-daemon/src/rss.rs:632`, `crates/arr-api/src/series.rs:1676`. **A naming trap worth fixing whatever is decided.** All three sites alias `max(grabbed_at)` as `last_failed_at`, and `series.rs:1683-1691` feeds that into the season deck's `reopens_at` and `pack_retry_at`. So the UI shows a *grab* time under a name that §5.7 has now redefined to mean something else. Either the alias is wrong or the column is; they cannot both stay. Scope: decide whether the backoff ladder measures from the grab or the failure, state it in §6.2 the way §5.7 now states its own anchor, and make the aliases say what they hold.
naps62-yolo added this to the Feedback pass 2 milestone 2026-08-25 11:14:56 +01:00
naps62-yolo added the difficulty/moderatetype/bug labels 2026-08-25 11:14:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels difficulty/moderate type/bug
Milestone
No items
No Milestone Feedback pass 2
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#245