yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Editing a policy must re-derive the verdicts it invalidates #246

New Issue
Closed
opened 2026-08-25 11:19:12 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-25 11:19:12 +01:00
Owner
Copy Link
Copy Source

#241 made the three operator actions that change a title's effective policy
re-derive stored verdicts: editing overrides, moving a title to a root with a
different policy, and pointing a root at a different policy. DESIGN.md §5.1 now
states that contract.

PUT /api/policies/{id} has the same gap one level up, and #241 flagged it
rather than widening its own scope. Editing a policy's contents — its language
rule, its size bands, its HDR handling — changes the effective policy of every
title under every root that points at it, and re-derives nothing. The stored
verdicts §9.3's deck and the daemon's manual-grab gate read are then computed
under a rule that no longer exists.

This is the largest blast radius of the four: a root repoint moves one library,
a policy edit moves every library that shares the policy.

crates/arr-api/src/reclassify.rs already has the pieces — movie, series
and the root walker #241 added, with the skip rules in one place and rows
whose verdict does not move left unwritten. This needs the same walk driven from
a policy id rather than a root id.

Scope: editing a policy re-derives the verdicts of every title under every root
that points at it, and §5.1's new paragraph is extended to name this fourth
action alongside the three it already lists — it currently says "the three
operator actions", which will be wrong once this lands.

Worth confirming while implementing: whether inline is still the right shape at
this size. #241 argued inline is affordable because re-evaluation is pure and
in-memory and unchanged rows are not rewritten. That argument holds for one
library; check it still holds when a policy is shared by several.

#241 made the three operator actions that change a title's *effective* policy re-derive stored verdicts: editing overrides, moving a title to a root with a different policy, and pointing a root at a different policy. DESIGN.md §5.1 now states that contract. `PUT /api/policies/{id}` has the same gap one level up, and #241 flagged it rather than widening its own scope. Editing a policy's *contents* — its language rule, its size bands, its HDR handling — changes the effective policy of every title under every root that points at it, and re-derives nothing. The stored verdicts §9.3's deck and the daemon's manual-grab gate read are then computed under a rule that no longer exists. This is the largest blast radius of the four: a root repoint moves one library, a policy edit moves every library that shares the policy. `crates/arr-api/src/reclassify.rs` already has the pieces — `movie`, `series` and the `root` walker #241 added, with the skip rules in one place and rows whose verdict does not move left unwritten. This needs the same walk driven from a policy id rather than a root id. Scope: editing a policy re-derives the verdicts of every title under every root that points at it, and §5.1's new paragraph is extended to name this fourth action alongside the three it already lists — it currently says "the three operator actions", which will be wrong once this lands. Worth confirming while implementing: whether inline is still the right shape at this size. #241 argued inline is affordable because re-evaluation is pure and in-memory and unchanged rows are not rewritten. That argument holds for one library; check it still holds when a policy is shared by several.
naps62-yolo added this to the Feedback pass 2 milestone 2026-08-25 11:19:12 +01:00
naps62-yolo added the area/apidifficulty/moderatetype/bug labels 2026-08-25 11:19:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/api difficulty/moderate type/bug
Milestone
No items
No Milestone Feedback pass 2
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#246