yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Reclassify skips titles with no stored original language #248

New Issue
Open
opened 2026-08-25 12:04:37 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-25 12:04:37 +01:00
Owner
Copy Link
Copy Source

reclassify.rs:50-53 and :94-97 return early when a title has no stored
original_language:

let Some(language) = movie_language(state, movie_id).await? else {
    return Ok(());
};

The skip is right for the language rule — without the language the required-audio
rule has nothing to compare, and guessing would move verdicts on worse evidence
than the ones already there. But it drops the title from re-derivation of the
size bands, resolution and source rules too, none of which need a language.

movies.original_language is documented as "Nullable until the first metadata
refresh" (0001_movies.sql:47-48), so this is reachable — a title added and then
had its root's policy changed before the metadata tick ran.

Low impact: the metadata lane fills it within 24 hours and such titles usually
have no stored releases yet. But §5.1 now states the guarantee without exception,
so either narrow the skip to the language rule alone, or state the exception in
§5.1. Do not leave the document claiming something the code does not do.

`reclassify.rs:50-53` and `:94-97` return early when a title has no stored `original_language`: ```rust let Some(language) = movie_language(state, movie_id).await? else { return Ok(()); }; ``` The skip is right for the language rule — without the language the required-audio rule has nothing to compare, and guessing would move verdicts on worse evidence than the ones already there. But it drops the title from re-derivation of the size bands, resolution and source rules too, none of which need a language. `movies.original_language` is documented as "Nullable until the first metadata refresh" (`0001_movies.sql:47-48`), so this is reachable — a title added and then had its root's policy changed before the metadata tick ran. Low impact: the metadata lane fills it within 24 hours and such titles usually have no stored releases yet. But §5.1 now states the guarantee without exception, so either narrow the skip to the language rule alone, or state the exception in §5.1. Do not leave the document claiming something the code does not do.
naps62-yolo added this to the Feedback pass 2 milestone 2026-08-25 12:04:37 +01:00
naps62-yolo added the difficulty/easyarea/apitype/bug labels 2026-08-25 12:04:37 +01:00
naps62-yolo modified the milestone from Feedback pass 2 to Feedback pass 2 follow-ups 2026-08-25 12:16:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No Label area/api difficulty/easy type/bug
Milestone
No items
No Milestone Feedback pass 2 follow-ups
Projects
Clear projects
No project
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#248
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?