yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Extract an embedded text track on demand from the panel #260

New Issue
Closed
opened 2026-08-26 10:14:39 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-26 10:14:39 +01:00
Owner
Copy Link
Copy Source

§15 says a text-format embedded track is extracted to a sidecar "because an
extracted track is a legal translation source". Today the only caller of
arr_probe::Extractor is arr-daemon/src/subtitles.rs:913
translation_source(), which runs when the reconcile loop is already
translating a wanted gap. Nothing else can trigger an extraction.

The consequence is on a file where nothing is missing: the wanted set is
satisfied, so the loop never runs, so no sidecar exists, so the manual
translate lane in the subtitle panel (§9.3, #203) reports "nothing to
translate from" about a file that carries an English text track. Manual
translation is reachable only where the automatic path has already been,
which is backwards — §15 treats a manual action as bypassing the wanted set,
not as something that depends on it.

Extracting every text track at import is the wrong answer: a WEB-DL episode
here carries 25 of them, and §15's <video>.<lang>.srt naming would drop 25
sidecars into every title folder and make the row's subtitle chip claim all
25 are on disk.

Extract on demand instead. The panel's translate lane offers the file's
embedded text tracks as sources, and picking one extracts it then.

Three parts:

  1. subtitle_files rows for embedded tracks carry no codec, so nothing
    downstream can tell a subrip track from a PGS one. The fact lives in
    media_files.probed (arr-probe records codec, forced, sdh per
    track since #189). Decide whether the status endpoint joins it in or the
    API reads probed directly.
  2. An endpoint that extracts one track — arr_probe::Extractor is not on
    AppState today; Syncer is, and it is the same shape, so it is the
    precedent to follow. The row it writes is NewSubtitleFile::extracted,
    which already exists.
  3. The panel lists text-format embedded tracks in the source picker,
    extracting on pick. An image-format track is never listed — §15 does not
    OCR.

Not in scope: extraction at import (option 1 above, rejected for the sidecar
count), and re-probing files imported before #189, whose sub_tracks carry
only a language and are therefore invisible to any of this. Those are
re-downloaded rather than migrated.

§15 says a text-format embedded track is extracted to a sidecar "because an extracted track is a legal translation source". Today the only caller of `arr_probe::Extractor` is `arr-daemon/src/subtitles.rs:913` `translation_source()`, which runs when the reconcile loop is already translating a wanted gap. Nothing else can trigger an extraction. The consequence is on a file where nothing is missing: the wanted set is satisfied, so the loop never runs, so no sidecar exists, so the manual translate lane in the subtitle panel (§9.3, #203) reports "nothing to translate from" about a file that carries an English text track. Manual translation is reachable only where the automatic path has already been, which is backwards — §15 treats a manual action as bypassing the wanted set, not as something that depends on it. Extracting every text track at import is the wrong answer: a WEB-DL episode here carries 25 of them, and §15's `<video>.<lang>.srt` naming would drop 25 sidecars into every title folder and make the row's subtitle chip claim all 25 are on disk. **Extract on demand instead.** The panel's translate lane offers the file's embedded text tracks as sources, and picking one extracts it then. Three parts: 1. `subtitle_files` rows for embedded tracks carry no codec, so nothing downstream can tell a `subrip` track from a PGS one. The fact lives in `media_files.probed` (`arr-probe` records `codec`, `forced`, `sdh` per track since #189). Decide whether the status endpoint joins it in or the API reads `probed` directly. 2. An endpoint that extracts one track — `arr_probe::Extractor` is not on `AppState` today; `Syncer` is, and it is the same shape, so it is the precedent to follow. The row it writes is `NewSubtitleFile::extracted`, which already exists. 3. The panel lists text-format embedded tracks in the source picker, extracting on pick. An image-format track is never listed — §15 does not OCR. Not in scope: extraction at import (option 1 above, rejected for the sidecar count), and re-probing files imported before #189, whose `sub_tracks` carry only a language and are therefore invisible to any of this. Those are re-downloaded rather than migrated.
naps62-yolo added the area/apidifficulty/moderatephase/9-subtitlestype/feature labels 2026-08-26 10:14:48 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/api difficulty/moderate phase/9-subtitles type/feature
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#260