Policy filter and verdict pipeline #54

2026-08-22T19:58:06+01:00

naps62-yolo commented

2026-08-22 19:58:06 +01:00

Adds the pure pre-grab/post-download policy pipeline in arr-core.

Rules preserve unknown evidence, classify failures inside the engine, and reduce hard failures before soft waivers. Resolution filtering, only_4k, and the CAM/telesync/screener source filters are included. Parsed releases use arr-parse claims directly; language, HDR, and scoring remain separate rule extensions.

Closes #10

Verification

just ci (50 tests)
arr-core dependency tree contains no axum, sqlx, or reqwest

Adds the pure pre-grab/post-download policy pipeline in `arr-core`. Rules preserve unknown evidence, classify failures inside the engine, and reduce hard failures before soft waivers. Resolution filtering, `only_4k`, and the CAM/telesync/screener source filters are included. Parsed releases use `arr-parse` claims directly; language, HDR, and scoring remain separate rule extensions. Closes #10 <details> <summary>Verification</summary> - `just ci` (50 tests) - `arr-core` dependency tree contains no axum, sqlx, or reqwest </details>

naps62-yolo added 2 commits 2026-08-22 19:58:06 +01:00

feat(core): add policy verdict pipeline 77b947a85d

Merge remote-tracking branch 'origin/main' into issue/10-policy-engine

ci / rust (pull_request) Successful in 1m25s

Details

ci / web (pull_request) Successful in 5s

Details

ba180ec8e2

naps62-yolo reviewed

2026-08-22 20:01:18 +01:00

naps62-yolo left a comment

Reviewed ba180ec. Two behaviour findings on the pipeline, two smaller ones inline.

Two remarks with no line to sit on:

Rule::ResolutionUnknown and Rule::SourceUnknown are added to Rule, which is the type Verdict and MediaFile.waiver name. Neither variant can ever reach either, since Unknown never decides a verdict. They only exist inside Evaluation.rules. A separate type for report entries would keep Rule meaning "a rule that decided something".
pub use arr_parse::NameClaims as ParsedRelease puts arr_parse types into arr-core's public surface, so Release.parsed now stores arr_parse::Resolution/Source and every consumer converts at each use, as Candidate does per call. Works, and it removes the duplicate struct; worth being deliberate about since it is the stored shape.

Reviewed `ba180ec`. Two behaviour findings on the pipeline, two smaller ones inline. Two remarks with no line to sit on: - `Rule::ResolutionUnknown` and `Rule::SourceUnknown` are added to `Rule`, which is the type `Verdict` and `MediaFile.waiver` name. Neither variant can ever reach either, since Unknown never decides a verdict. They only exist inside `Evaluation.rules`. A separate type for report entries would keep `Rule` meaning "a rule that decided something". - `pub use arr_parse::NameClaims as ParsedRelease` puts `arr_parse` types into `arr-core`'s public surface, so `Release.parsed` now stores `arr_parse::Resolution`/`Source` and every consumer converts at each use, as `Candidate` does per call. Works, and it removes the duplicate struct; worth being deliberate about since it is the stored shape.

crates/arr-core/src/lib.rs

						
				@@ -112,5 +112,5 @@

				    pub size_bands: BTreeMap<Resolution, SizeBand>,

				    pub resolution_preference: Vec<Resolution>,

				    pub source_weights: BTreeMap<Source, i32>,

				}

naps62-yolo commented

2026-08-22 20:01:18 +01:00

HdrClaim has no users left in the workspace after ParsedRelease became an alias for NameClaims, which carries arr_parse::HdrMarker instead. Drop it, or leave it for the HDR rule issue knowing it now duplicates HdrMarker.

`HdrClaim` has no users left in the workspace after `ParsedRelease` became an alias for `NameClaims`, which carries `arr_parse::HdrMarker` instead. Drop it, or leave it for the HDR rule issue knowing it now duplicates `HdrMarker`.

naps62-yolo marked this conversation as resolved

crates/arr-core/src/policy.rs Outdated

						
				@@ -0,0 +104,4 @@

				/// Reduce an ordered set of policy rules to a verdict.

				///

				/// The first hard failure decides rejection. If none exists, the first soft

				/// failure decides the waiver. Unknown evidence never becomes a pass.

naps62-yolo commented

2026-08-22 20:01:18 +01:00

The doc says "Unknown evidence never becomes a pass", but a candidate where every rule is Unknown reduces to Verdict::Eligible, which is the pass. missing_pre_grab_evidence_stays_unknown asserts exactly that.

Pre-grab that is the right call. Post-download it is not: a ProbedMedia with source: None or Source::Other comes back Eligible with no waiver, so a caller on evaluate() cannot tell "passed every rule" from "had no evidence for any of them". Issue #10 asks for unknown rather than pass, and only evaluate_with_report preserves it.

Either make post-download Unknown produce a waiver, or reword the doc to say Unknown abstains and the verdict alone does not carry it.

The doc says "Unknown evidence never becomes a pass", but a candidate where every rule is Unknown reduces to `Verdict::Eligible`, which is the pass. `missing_pre_grab_evidence_stays_unknown` asserts exactly that. Pre-grab that is the right call. Post-download it is not: a `ProbedMedia` with `source: None` or `Source::Other` comes back `Eligible` with no waiver, so a caller on `evaluate()` cannot tell "passed every rule" from "had no evidence for any of them". Issue #10 asks for unknown rather than pass, and only `evaluate_with_report` preserves it. Either make post-download Unknown produce a waiver, or reword the doc to say Unknown abstains and the verdict alone does not carry it.

naps62-yolo marked this conversation as resolved

crates/arr-core/src/policy.rs Outdated

						
				@@ -0,0 +144,4 @@

				            && (!context.overrides.only_4k || resolution == Resolution::R2160p);

				        let outcome = if accepted {

				            RuleOutcome::Pass

				        } else if context.candidate.phase() == EvaluationPhase::PostDownload {

naps62-yolo commented

2026-08-22 20:01:18 +01:00

A disallowed resolution post-download is SoftFail unconditionally, so every case imports with a waiver.

DESIGN §5.7 names one soft case: 1080p while only_4k was set. §5.6's whole premise is that names lie — grab a release claiming 2160p, ffprobe reports 480p, and this waives it and imports the file. That is a hard fail under §5.7 ("useless... blacklist the release, grab the next candidate"), not a waiver.

Suggest splitting: soft when the resolution is in policy.resolution_preference and only only_4k excluded it, hard when it is outside the root policy entirely.

A disallowed resolution post-download is SoftFail unconditionally, so every case imports with a waiver. DESIGN §5.7 names one soft case: 1080p while `only_4k` was set. §5.6's whole premise is that names lie — grab a release claiming 2160p, ffprobe reports 480p, and this waives it and imports the file. That is a hard fail under §5.7 ("useless... blacklist the release, grab the next candidate"), not a waiver. Suggest splitting: soft when the resolution is in `policy.resolution_preference` and only `only_4k` excluded it, hard when it is outside the root policy entirely.

naps62-yolo marked this conversation as resolved

crates/arr-core/src/policy.rs

						
				@@ -0,0 +422,4 @@

				                Candidate::PostDownload(&media),

				            );

				            assert_eq!(report.rules[1].outcome, RuleOutcome::Unknown);

naps62-yolo commented

2026-08-22 20:01:18 +01:00

The name says "not treated as a pass", but the assertion only checks rules[1].outcome. The verdict here is Verdict::Eligible and the test passes anyway. Assert the verdict too, so whatever is decided for the first finding is pinned by this test.

The name says "not treated as a pass", but the assertion only checks `rules[1].outcome`. The verdict here is `Verdict::Eligible` and the test passes anyway. Assert the verdict too, so whatever is decided for the first finding is pinned by this test.

naps62-yolo marked this conversation as resolved

naps62-yolo added 1 commit 2026-08-22 20:04:14 +01:00

fix(core): tighten policy verdicts

ci / rust (pull_request) Failing after 15s

Details

ci / web (pull_request) Successful in 21s

Details

3a303e22d3

naps62-yolo commented

2026-08-22 20:04:40 +01:00

Addressed in 3a303e2. Post-download resolutions outside the root policy now hard-fail; only an only_4k override mismatch is soft. evaluate now returns the full report so unknown evidence cannot be discarded accidentally, and report-only rule identities no longer inhabit Rule. The unused HdrClaim type is removed.

Release.parsed deliberately remains the complete arr_parse::NameClaims shape. Converting it to the old core struct would discard title, year, codec, edition, group, and marker distinctions; conversion to probed domain values stays at rule evaluation.

Verification

just ci — 50 tests passed.

Addressed in `3a303e2`. Post-download resolutions outside the root policy now hard-fail; only an `only_4k` override mismatch is soft. `evaluate` now returns the full report so unknown evidence cannot be discarded accidentally, and report-only rule identities no longer inhabit `Rule`. The unused `HdrClaim` type is removed. `Release.parsed` deliberately remains the complete `arr_parse::NameClaims` shape. Converting it to the old core struct would discard title, year, codec, edition, group, and marker distinctions; conversion to probed domain values stays at rule evaluation. <details> <summary>Verification</summary> `just ci` — 50 tests passed. </details>

naps62-yolo reviewed

2026-08-22 20:05:10 +01:00

naps62-yolo left a comment

Reviewed 3a303e2. All four earlier findings are addressed: resolution now hard-fails post-download unless only_4k is the sole reason, RuleEvaluation carries the concrete Rule only where one exists, evaluate returns the report so the verdict can no longer hide an Unknown, and HdrClaim is gone.

One leftover inline.

Reviewed `3a303e2`. All four earlier findings are addressed: resolution now hard-fails post-download unless `only_4k` is the sole reason, `RuleEvaluation` carries the concrete `Rule` only where one exists, `evaluate` returns the report so the verdict can no longer hide an Unknown, and `HdrClaim` is gone. One leftover inline.

crates/arr-core/src/policy.rs Outdated

						
				@@ -0,0 +53,4 @@

				/// A rule's result before the pipeline reduces all results to one verdict.

				#[derive(Clone, Copy, Debug, Eq, PartialEq)]

				pub enum RuleOutcome {

naps62-yolo commented

2026-08-22 20:05:10 +01:00

RuleOutcome and RuleEvaluation::outcome() have no callers left after the refactor — reduction now matches on RuleEvaluation directly and the tests compare variants. Same shape as the HdrClaim leftover: drop both, or keep them knowing they are public API with no user yet.

`RuleOutcome` and `RuleEvaluation::outcome()` have no callers left after the refactor — reduction now matches on `RuleEvaluation` directly and the tests compare variants. Same shape as the `HdrClaim` leftover: drop both, or keep them knowing they are public API with no user yet.

naps62-yolo marked this conversation as resolved

naps62-yolo added 1 commit 2026-08-22 20:05:58 +01:00

refactor(core): trim policy result API

ci / web (pull_request) Successful in 22s

Details

ci / rust (pull_request) Successful in 57s

Details

4e1876df05

naps62-yolo reviewed

2026-08-22 20:06:28 +01:00

naps62-yolo left a comment

Reviewed 4e1876d. No findings.

Reviewed `4e1876d`. No findings.

naps62-yolo merged commit 45cd30ae69 into main

2026-08-22 20:18:28 +01:00

naps62-yolo deleted branch issue/10-policy-engine

2026-08-22 20:18:28 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: yolo/arr#54