Compare commits

...
6 changed files with 114 additions and 41 deletions
+3 -1
View File
@@ -3053,17 +3053,19 @@ mod tests {
let request = |view| CreateSessionRequest { let request = |view| CreateSessionRequest {
view, view,
cwd: std::path::PathBuf::from("/srv/work"), cwd: std::path::PathBuf::from("/srv/work"),
command: "claude".into(), command: "codex".into(),
env: Default::default(), env: Default::default(),
metadata: Default::default(), metadata: Default::default(),
worktree: None, worktree: None,
}; };
let structured_id = Uuid::from_u128(188); let structured_id = Uuid::from_u128(188);
app.state.mode = Mode::Insert;
app.submit_spawn(request(SessionView::Structured)).await; app.submit_spawn(request(SessionView::Structured)).await;
assert!(app.catalog.snapshot().sessions.is_empty()); assert!(app.catalog.snapshot().sessions.is_empty());
assert!(app.structured.contains_key(&structured_id)); assert!(app.structured.contains_key(&structured_id));
assert!(app.emulators.get(structured_id).is_none()); assert!(app.emulators.get(structured_id).is_none());
assert_eq!(app.state.mode, Mode::Normal);
let terminal_id = Uuid::from_u128(187); let terminal_id = Uuid::from_u128(187);
app.submit_spawn(request(SessionView::Terminal)).await; app.submit_spawn(request(SessionView::Terminal)).await;
+60 -16
View File
@@ -91,7 +91,7 @@ pub enum DraftField {
/// Disclosure collapsing the optional view and worktree controls below. /// Disclosure collapsing the optional view and worktree controls below.
/// Closed by default; Enter / Space toggles. /// Closed by default; Enter / Space toggles.
Advanced, Advanced,
/// ACP-backed transcript instead of a terminal. Claude Code only. /// ACP-backed transcript instead of a terminal. Claude Code or Codex.
StructuredToggle, StructuredToggle,
/// Worktree on/off for this session (#65). Enter / Space toggles. /// Worktree on/off for this session (#65). Enter / Space toggles.
WorktreeToggle, WorktreeToggle,
@@ -256,7 +256,7 @@ pub struct DraftPane {
/// take the default target. /// take the default target.
pub advanced_collapsed: bool, pub advanced_collapsed: bool,
/// ACP-backed structured transcript. Off by default and supported only /// ACP-backed structured transcript. Off by default and supported only
/// when the resolved command is Claude Code. /// when the resolved command is Claude Code or Codex.
pub structured_view: bool, pub structured_view: bool,
/// Enclosing repository of the chosen target — from the project scan for /// Enclosing repository of the chosen target — from the project scan for
/// picked rows, `/api/gitroot` for raw paths. `None` until known. /// picked rows, `/api/gitroot` for raw paths. `None` until known.
@@ -673,7 +673,7 @@ impl DraftPane {
} }
fn supports_structured_view(&self) -> bool { fn supports_structured_view(&self) -> bool {
command_tool(self.command()) == Some("claude") matches!(command_tool(self.command()), Some("claude" | "codex"))
} }
fn clear_unsupported_structured_view(&mut self) { fn clear_unsupported_structured_view(&mut self) {
@@ -1888,11 +1888,28 @@ mod tests {
} }
#[test] #[test]
fn structured_view_is_default_off_and_only_visible_for_claude_code() { fn structured_view_is_default_off_and_visible_for_supported_agents() {
let mut draft = DraftPane { let mut draft = DraftPane {
advanced_collapsed: false, advanced_collapsed: false,
..DraftPane::default() ..DraftPane::default()
}; };
draft.set_presets(vec![
SpawnPreset {
id: "claude".into(),
label: "Claude".into(),
command: "claude".into(),
},
SpawnPreset {
id: "codex".into(),
label: "Codex".into(),
command: "codex".into(),
},
SpawnPreset {
id: "opencode".into(),
label: "OpenCode".into(),
command: "opencode".into(),
},
]);
assert!(!draft.structured_view); assert!(!draft.structured_view);
assert!(draft.field_order().contains(&DraftField::StructuredToggle)); assert!(draft.field_order().contains(&DraftField::StructuredToggle));
let rendered = render_to_string(100, 24, |f| draft.render(f, f.area(), true)); let rendered = render_to_string(100, 24, |f| draft.render(f, f.area(), true));
@@ -1901,6 +1918,12 @@ mod tests {
draft.toggle_structured_view(); draft.toggle_structured_view();
assert!(draft.structured_view); assert!(draft.structured_view);
draft.cycle_preset(1); draft.cycle_preset(1);
assert_eq!(draft.command(), "codex");
assert!(
draft.structured_view,
"Codex keeps the structured selection"
);
draft.cycle_preset(1);
assert_eq!(draft.command(), "opencode"); assert_eq!(draft.command(), "opencode");
assert!( assert!(
!draft.structured_view, !draft.structured_view,
@@ -1928,9 +1951,9 @@ mod tests {
/// A custom command typed into the free-text field, run through the same /// A custom command typed into the free-text field, run through the same
/// resolver the daemon/web gate uses (`command_tool`, #199): a path, an /// resolver the daemon/web gate uses (`command_tool`, #199): a path, an
/// env prefix, or a wrapper still resolves to Claude, so the toggle stays /// env prefix, or a wrapper still resolves to Claude Code or Codex, so
/// offered and the request carries `Structured`; an unrelated program /// the toggle stays offered and the request carries `Structured`; an
/// does not. /// unrelated program does not.
#[test] #[test]
fn structured_view_follows_command_resolution_for_custom_commands() { fn structured_view_follows_command_resolution_for_custom_commands() {
let cases: &[(&str, bool)] = &[ let cases: &[(&str, bool)] = &[
@@ -1952,6 +1975,16 @@ mod tests {
("yarn --silent dlx claude-code", true), ("yarn --silent dlx claude-code", true),
("bun x claude-code", true), ("bun x claude-code", true),
("\"/opt/my agent/claude\" --resume", true), ("\"/opt/my agent/claude\" --resume", true),
("codex", true),
("codex --full-auto", true),
("CODEX=1 codex", true),
("/usr/local/bin/codex exec", true),
("npx codex", true),
("sudo -u root codex", true),
("env -i codex", true),
("command codex", true),
("pnpm --silent dlx codex", true),
("\"/opt/my agent/codex\" exec", true),
("bash", false), ("bash", false),
("opencode", false), ("opencode", false),
("/usr/local/bin/bash -l", false), ("/usr/local/bin/bash -l", false),
@@ -1999,7 +2032,7 @@ mod tests {
/// A configured preset (the spawn-form "alias" for a command) is gated /// A configured preset (the spawn-form "alias" for a command) is gated
/// the same way as free text: a preset whose command resolves to Claude /// the same way as free text: a preset whose command resolves to Claude
/// through a wrapper still offers structured view. /// Code or Codex through a wrapper still offers structured view.
#[test] #[test]
fn structured_view_follows_command_resolution_for_presets() { fn structured_view_follows_command_resolution_for_presets() {
let mut draft = DraftPane { let mut draft = DraftPane {
@@ -2014,6 +2047,11 @@ mod tests {
label: "Claude (npx)".into(), label: "Claude (npx)".into(),
command: "npx claude-code --resume".into(), command: "npx claude-code --resume".into(),
}, },
SpawnPreset {
id: "codex-wrapped".into(),
label: "Codex (npx)".into(),
command: "npx codex exec".into(),
},
SpawnPreset { SpawnPreset {
id: "aider".into(), id: "aider".into(),
label: "Aider".into(), label: "Aider".into(),
@@ -2027,7 +2065,13 @@ mod tests {
assert!(draft.structured_view); assert!(draft.structured_view);
assert_eq!(draft.build_request().unwrap().view, SessionView::Structured); assert_eq!(draft.build_request().unwrap().view, SessionView::Structured);
// Switching to a preset that does not resolve to Claude clears the // Switching between supported presets preserves the selection.
draft.cycle_preset(1);
assert_eq!(draft.command(), "npx codex exec");
assert!(draft.structured_view);
assert_eq!(draft.build_request().unwrap().view, SessionView::Structured);
// Switching to a preset that does not resolve to an ACP agent clears the
// stale selection instead of letting an invalid request through. // stale selection instead of letting an invalid request through.
draft.cycle_preset(1); draft.cycle_preset(1);
assert_eq!(draft.command(), "aider"); assert_eq!(draft.command(), "aider");
@@ -2036,11 +2080,11 @@ mod tests {
assert_eq!(draft.build_request().unwrap().view, SessionView::Terminal); assert_eq!(draft.build_request().unwrap().view, SessionView::Terminal);
} }
/// Editing the custom-command text away from Claude clears an armed /// Editing the custom-command text away from a supported agent clears an armed
/// selection immediately, matching the preset-switch case above — an /// selection immediately, matching the preset-switch case above — an
/// invalid `Structured` request can never reach `build_request`. /// invalid `Structured` request can never reach `build_request`.
#[test] #[test]
fn structured_view_clears_when_custom_command_edited_away_from_claude() { fn structured_view_clears_when_custom_command_edited_away_from_supported_agent() {
let mut draft = DraftPane { let mut draft = DraftPane {
picked_cwd: Some(PathBuf::from("/srv/work")), picked_cwd: Some(PathBuf::from("/srv/work")),
worktree_enabled: false, worktree_enabled: false,
@@ -2049,22 +2093,22 @@ mod tests {
..DraftPane::default() ..DraftPane::default()
}; };
draft.selected_preset = draft.presets.len() - 1; draft.selected_preset = draft.presets.len() - 1;
draft.custom_command = crate::text_input::TextInput::with_value("claude"); draft.custom_command = crate::text_input::TextInput::with_value("codex");
draft.toggle_structured_view(); draft.toggle_structured_view();
assert!(draft.structured_view); assert!(draft.structured_view);
typed(&mut draft, " -p"); typed(&mut draft, " -p");
assert_eq!(draft.command(), "claude -p"); assert_eq!(draft.command(), "codex -p");
assert!(draft.structured_view, "still Claude, selection survives"); assert!(draft.structured_view, "still Codex, selection survives");
for _ in 0.."claude -p".chars().count() { for _ in 0.."codex -p".chars().count() {
draft.on_input(&InputKey::Backspace); draft.on_input(&InputKey::Backspace);
} }
typed(&mut draft, "bash"); typed(&mut draft, "bash");
assert_eq!(draft.command(), "bash"); assert_eq!(draft.command(), "bash");
assert!( assert!(
!draft.structured_view, !draft.structured_view,
"editing the program away from claude clears the stale selection" "editing the program away from Codex clears the stale selection"
); );
assert_eq!(draft.build_request().unwrap().view, SessionView::Terminal); assert_eq!(draft.build_request().unwrap().view, SessionView::Terminal);
} }
+2 -2
View File
@@ -38,8 +38,8 @@ ACP handle instead of a tmux pane).
## The adapter ## The adapter
The resolved structured command selects a provider adapter. Its binary is The resolved structured command selects a provider adapter. Its binary is
resolved by walking the session's `PATH` (when set on the spawn request), then resolved by walking the session's `PATH` when the spawn request sets one, or
the daemon's `PATH`, and taking the first executable with that name. the daemon's `PATH` otherwise, and taking the first executable with that name.
| Command | Adapter binary | Install command | Provider detail | | Command | Adapter binary | Install command | Provider detail |
| --- | --- | --- | --- | | --- | --- | --- | --- |
+15 -9
View File
@@ -26,15 +26,21 @@ describe("buildSpawnRequest", () => {
expect(res).toEqual({ req: { cwd: base.cwd, command: base.command, metadata: {} } }); expect(res).toEqual({ req: { cwd: base.cwd, command: base.command, metadata: {} } });
}); });
it("requests structured view only for Claude Code", () => { it.each(["claude", "FOO=1 /usr/local/bin/codex", "env -i codex"])(
expect(buildSpawnRequest({ ...base, structuredView: true }, null)).toEqual({ "requests structured view for resolved %s commands",
req: { (command) => {
cwd: base.cwd, expect(buildSpawnRequest({ ...base, command, structuredView: true }, null)).toEqual({
command: "claude", req: {
metadata: { name: "amber-fox" }, cwd: base.cwd,
view: "Structured", command,
}, metadata: { name: "amber-fox" },
}); view: "Structured",
},
});
},
);
it("does not request structured view for unsupported commands", () => {
expect( expect(
buildSpawnRequest({ ...base, command: "opencode", structuredView: true }, null), buildSpawnRequest({ ...base, command: "opencode", structuredView: true }, null),
).toEqual({ ).toEqual({
+9 -2
View File
@@ -15,6 +15,13 @@ import { splitCommand } from "./toolIcon.js";
import { abbreviateCwd } from "./types.js"; import { abbreviateCwd } from "./types.js";
import type { BranchInfo, CreateSessionRequest, Project, Session, SpawnPreset } from "./types.js"; import type { BranchInfo, CreateSessionRequest, Project, Session, SpawnPreset } from "./types.js";
const STRUCTURED_VIEW_TOOLS = new Set(["claude", "codex"]);
function supportsStructuredView(command: string): boolean {
const tool = splitCommand(command).tool;
return tool !== null && STRUCTURED_VIEW_TOOLS.has(tool);
}
/** Where a worktree's branch comes from: freshly created (default) or picked /** Where a worktree's branch comes from: freshly created (default) or picked
* from the repository's existing branches (#61). */ * from the repository's existing branches (#61). */
export type WorktreeBranchMode = "new" | "existing"; export type WorktreeBranchMode = "new" | "existing";
@@ -68,7 +75,7 @@ export function buildSpawnRequest(
metadata, metadata,
}; };
if (values.structuredView && splitCommand(values.command).tool === "claude") { if (values.structuredView && supportsStructuredView(values.command)) {
req.view = "Structured"; req.view = "Structured";
} }
@@ -369,7 +376,7 @@ export function createSpawnForm(opts: SpawnFormOptions): SpawnFormHandle {
let commandTouched = false; let commandTouched = false;
function updateStructuredAvailability(): void { function updateStructuredAvailability(): void {
const supported = splitCommand(command).tool === "claude"; const supported = supportsStructuredView(command);
structuredWrap.hidden = !supported; structuredWrap.hidden = !supported;
if (!supported) structuredView.checked = false; if (!supported) structuredView.checked = false;
} }
+25 -11
View File
@@ -44,7 +44,7 @@ describe("spawn form structured view", () => {
vi.unstubAllGlobals(); vi.unstubAllGlobals();
}); });
it("is default-off and shown only for the resolved Claude Code command", async () => { it("is default-off and shown for resolved Claude Code and Codex commands", async () => {
stubApi(); stubApi();
handle = createSpawnForm({ onSuccess() {} }); handle = createSpawnForm({ onSuccess() {} });
document.body.appendChild(handle.el); document.body.appendChild(handle.el);
@@ -59,26 +59,33 @@ describe("spawn form structured view", () => {
expect(wrap.hidden).toBe(false); expect(wrap.hidden).toBe(false);
expect(checkbox.checked).toBe(false); expect(checkbox.checked).toBe(false);
handle.el.querySelector<HTMLButtonElement>('[data-id="opencode"]')!.click(); const custom = handle.el.querySelector<HTMLButtonElement>('[data-id="custom"]')!;
expect(wrap.hidden).toBe(true); custom.click();
const command = handle.el.querySelector<HTMLInputElement>(".cmd-raw")!;
handle.el.querySelector<HTMLButtonElement>('[data-id="claude"]')!.click(); command.value = "FOO=1 /usr/local/bin/codex";
command.dispatchEvent(new Event("input"));
expect(wrap.hidden).toBe(false); expect(wrap.hidden).toBe(false);
command.value = "opencode";
command.dispatchEvent(new Event("input"));
expect(wrap.hidden).toBe(true);
}); });
it("clears a checked value when the command changes away from Claude Code", async () => { it("clears a checked value when Codex changes to an unsupported command", async () => {
stubApi(); stubApi();
handle = createSpawnForm({ onSuccess() {} }); handle = createSpawnForm({ onSuccess() {} });
document.body.appendChild(handle.el); document.body.appendChild(handle.el);
await drain(); await drain();
handle.el.querySelector<HTMLButtonElement>('[data-id="custom"]')!.click();
const command = handle.el.querySelector<HTMLInputElement>(".cmd-raw")!;
command.value = "env -i codex";
command.dispatchEvent(new Event("input"));
const checkbox = handle.el.querySelector<HTMLInputElement>("input[name=structured_view]")!; const checkbox = handle.el.querySelector<HTMLInputElement>("input[name=structured_view]")!;
checkbox.click(); checkbox.click();
expect(checkbox.checked).toBe(true); expect(checkbox.checked).toBe(true);
const custom = handle.el.querySelector<HTMLButtonElement>('[data-id="custom"]')!;
custom.click();
const command = handle.el.querySelector<HTMLInputElement>(".cmd-raw")!;
command.value = "opencode"; command.value = "opencode";
command.dispatchEvent(new Event("input")); command.dispatchEvent(new Event("input"));
@@ -86,7 +93,7 @@ describe("spawn form structured view", () => {
expect(checkbox.checked).toBe(false); expect(checkbox.checked).toBe(false);
}); });
it("emits Structured in the submitted request when selected", async () => { it.each(["claude", "codex"])("emits Structured for a selected %s command", async (tool) => {
const requests = stubApi(); const requests = stubApi();
handle = createSpawnForm({ handle = createSpawnForm({
seed: { cwd: "/srv/work", cwdRawVisible: true, worktreeEnabled: false }, seed: { cwd: "/srv/work", cwdRawVisible: true, worktreeEnabled: false },
@@ -95,13 +102,20 @@ describe("spawn form structured view", () => {
document.body.appendChild(handle.el); document.body.appendChild(handle.el);
await drain(); await drain();
if (tool === "codex") {
handle.el.querySelector<HTMLButtonElement>('[data-id="custom"]')!.click();
const command = handle.el.querySelector<HTMLInputElement>(".cmd-raw")!;
command.value = "codex";
command.dispatchEvent(new Event("input"));
}
handle.el.querySelector<HTMLInputElement>("input[name=structured_view]")!.click(); handle.el.querySelector<HTMLInputElement>("input[name=structured_view]")!.click();
handle.el.requestSubmit(); handle.el.requestSubmit();
await drain(); await drain();
expect(requests).toHaveLength(1); expect(requests).toHaveLength(1);
expect(JSON.parse(String(requests[0].body))).toMatchObject({ expect(JSON.parse(String(requests[0].body))).toMatchObject({
command: "claude", command: tool,
view: "Structured", view: "Structured",
}); });
}); });