Compare commits

...
Author SHA1 Message Date
Miguel PalhasandClaude Sonnet 5 20d303278d feat(web): port CatalogStore and ConnectionPool to Zustand stores
Ports events.ts's CatalogStore and connections.ts's ConnectionPool to
Zustand stores (src/stores/catalogStore.ts, connectionStore.ts) built
via factory functions so tests can inject fake sockets/schedulers, same
as the originals. Reconnect/backoff schedule, the 6-max-parked LRU, and
the #140 view-reconciliation race handling all carry over unchanged.

The vanilla events.ts/connections.ts stay in place for the current app;
this is prep for the React port (#241).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-09 00:12:09 +01:00
Miguel Palhas 589e0144e2 Closes #239: scaffold React + Tailwind + Zustand 2026-09-09 00:03:04 +01:00
Miguel Palhas 0061378193 feat(maestro): scaffold React + Tailwind + Zustand
Adds react, react-dom, zustand, tailwindcss, @tailwindcss/vite as a new
skeleton alongside the existing vanilla SPA. New src/index.tsx entry
point (unused until wired into index.html in a later issue); main.ts
stays the active entry.
2026-09-09 00:01:33 +01:00
Miguel Palhas 1cf4825b1d fix(web): collapse agent commentary
ci / web (push) Failing after 6s
ci / flake (push) Successful in 3m31s
ci / rust (push) Successful in 6m18s
2026-09-08 17:21:08 +01:00
Miguel PalhasandClaude Opus 4.6 f799aaf564 fix(maestro): restore focus after surgical tool-row patch
ci / web (push) Successful in 41s
ci / flake (push) Successful in 4m36s
ci / rust (push) Successful in 8m42s
The patch path did a DOM replaceWith and returned early, skipping the
focus-restoration logic in rebuildTranscript. Now saves and restores
tool-head focus within the surgical swap.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-09-08 15:37:58 +01:00
naps62-yolo 5af5ceb9a8 feat(maestro): trigger haiku naming for ACP sessions (#206)
ci / web (push) Has been cancelled
ci / rust (push) Has been cancelled
ci / flake (push) Has been cancelled
2026-09-08 15:35:27 +01:00
Miguel PalhasandClaude Opus 4.6 fbdcec6f69 chore(maestro): allow cargo test in local settings
ci / flake (push) Successful in 3m39s
ci / rust (push) Successful in 6m32s
ci / web (push) Failing after 27s
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-09-08 15:05:41 +01:00
Miguel PalhasandClaude Opus 4.6 6af4cda650 fix(maestro): gitroot tests tolerate /tmp inside a repo
The sandbox has /tmp/.git, so the ancestor walk finds a git root
above the tempdir. Weakened the assertion: the result must not point
inside the .git-free tempdir, but may point above it.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-09-08 14:50:50 +01:00
Miguel Palhas ab4beea2d9 Merge branch 'trombone-2'
ci / web (push) Failing after 27s
ci / rust (push) Failing after 1m1s
ci / flake (push) Successful in 3m18s
2026-09-08 14:36:21 +01:00
Miguel Palhas 44ef5619bf Merge branch 'staccato-2'
ci / rust (push) Has been cancelled
ci / web (push) Has been cancelled
ci / flake (push) Has been cancelled
2026-09-08 14:36:20 +01:00
Miguel Palhas 6adb5dabf0 Merge branch 'harpsichord-2'
ci / web (push) Failing after 31s
ci / rust (push) Failing after 56s
ci / flake (push) Successful in 4m3s
2026-09-08 14:33:49 +01:00
Miguel Palhas e9c9e1c647 Merge remote-tracking branch 'origin/main' into staccato-2 2026-09-08 14:33:26 +01:00
Miguel PalhasandClaude Opus 4.6 4167b21fe9 feat(maestro): render queued messages as blurred chat bubbles
Queued prompts now appear inline in the transcript as faded user bubbles
instead of a pill badge above the composer.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-09-08 14:33:22 +01:00
Miguel PalhasandClaude Opus 4.6 b9f8f02e11 fix(maestro): fix diff double-spacing and add +/- markers
Block spans + literal \n text nodes inside <pre> caused empty lines
between every diff line. Drop the text nodes, add unified-diff prefixes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-09-08 14:32:51 +01:00
Miguel PalhasandClaude Opus 4.6 c2d427691d fix(web): stop tool-group flashing and config-menu closure on updates
Reuse existing tool-group DOM elements in rebuildTranscript instead of
tearing them down — preserves CSS transition state and focus. Defer
config-menu DOM rebuild while the menu is open so <select> dropdowns
survive background state updates.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-09-08 14:26:14 +01:00
22 changed files with 2351 additions and 91 deletions
+2 -1
View File
@@ -11,7 +11,8 @@
"Bash(./node_modules/.bin/tsc:*)",
"Bash(npm test:*)",
"Bash(cargo check:*)",
"Bash(cargo clippy:*)"
"Bash(cargo clippy:*)",
"Bash(cargo test:*)"
]
}
}
+13 -4
View File
@@ -80,13 +80,22 @@ mod tests {
}
#[test]
fn non_repo_dir_is_none() {
// A temp dir with no `.git` anywhere up the chain. Use the temp root so
// the walk can't accidentally hit a real repo above the test's cwd.
fn non_repo_dir_does_not_find_root_inside_fixture() {
// The fixture has no `.git`, so `find_root` must not return a path
// inside it. On hosts where an ancestor of the temp dir *is* a repo
// (e.g. `/tmp` lives inside a checkout), the function legitimately
// returns that ancestor — the test only asserts the fixture itself
// was not mistaken for a repo.
let tmp = tempfile::tempdir().unwrap();
let sub = tmp.path().join("plain/dir");
fs::create_dir_all(&sub).unwrap();
assert_eq!(find_root(&sub), None);
match find_root(&sub) {
None => {} // expected on most hosts
Some(root) => assert!(
!root.starts_with(tmp.path()),
"found .git inside the fixture at {root:?}, but none was created"
),
}
}
#[test]
+4
View File
@@ -805,6 +805,10 @@ impl SessionManager {
});
drop(stream);
sync_structured_activity(&self.inner, id).await;
#[cfg(feature = "haiku-autoname")]
if let Ok(true) = self.claim_autoname(id).await {
crate::autoname::spawn_naming(self.clone(), id, text);
}
return Ok(QueueAcpPrompt::Queued);
}
Err(message) => {
+13 -2
View File
@@ -1003,7 +1003,9 @@ async fn names_honors_count_and_caps_it() {
#[tokio::test]
async fn gitroot_probes_path() {
// #26: resolves the query against the daemon home dir and walks up for a
// `.git`. A `/tmp`-rooted temp dir is not in a repo, so the root is null.
// `.git`. The tempdir itself has no `.git`, so the result must either be
// null (no repo anywhere above) or — in sandboxed environments where /tmp
// itself sits inside a repo — a path strictly above the tempdir.
let h = spawn("naps-laptop").await;
let tmp = tempfile::tempdir().unwrap();
let resp: serde_json::Value = reqwest::get(url(
@@ -1018,7 +1020,16 @@ async fn gitroot_probes_path() {
.json()
.await
.unwrap();
assert!(resp.get("root").is_none() || resp["root"].is_null());
// On hosts where an ancestor of the temp dir is a repo (e.g. `/tmp`
// inside a checkout), the root legitimately points there. The test only
// asserts no root was found *inside* the temp dir.
match resp.get("root").and_then(|v| v.as_str()) {
None => {}
Some(root) => assert!(
!root.starts_with(tmp.path().to_string_lossy().as_ref()),
"found a repo root inside the fixture at {root:?}"
),
}
}
#[tokio::test]
+1 -4
View File
@@ -95,10 +95,7 @@ impl MockDaemon {
.route(routes::SESSIONS, get(list_sessions).post(create_session))
.route(routes::patterns::SESSION, delete(kill_session))
.route(routes::patterns::SESSION_INPUT, post(send_input))
.route(
routes::patterns::STRUCTURED_PROMPT,
post(structured_prompt),
)
.route(routes::patterns::STRUCTURED_PROMPT, post(structured_prompt))
.route(routes::INFO, get(daemon_info))
.route(routes::DIRS, get(list_dir))
.route(routes::RECENT_DIRS, get(recent_dirs))
+12 -2
View File
@@ -17,12 +17,22 @@
"@xterm/addon-fit": "^0.10.0",
"@xterm/addon-webgl": "^0.19.0",
"@xterm/xterm": "^5.5.0",
"marked": "^18.0.11"
"marked": "^18.0.11",
"react": "^19.2.8",
"react-dom": "^19.2.8"
},
"devDependencies": {
"@tailwindcss/vite": "^4.3.3",
"@testing-library/jest-dom": "^7.0.1",
"@testing-library/react": "^16.3.3",
"@types/react": "^19.2.18",
"@types/react-dom": "^19.2.7",
"@vitejs/plugin-react": "^4.7.0",
"happy-dom": "^20.11.6",
"tailwindcss": "^4.3.3",
"typescript": "^5.6.3",
"vite": "^5.4.10",
"vitest": "^2.1.9"
"vitest": "^2.1.9",
"zustand": "^5.0.15"
}
}
+984 -11
View File
File diff suppressed because it is too large Load Diff
+3
View File
@@ -0,0 +1,3 @@
export function App() {
return <div id="react-root" />;
}
+10
View File
@@ -0,0 +1,10 @@
import { createRoot } from "react-dom/client";
import { App } from "./App";
import "./main.css";
const container = document.getElementById("root");
if (!container) {
throw new Error("missing #root element");
}
createRoot(container).render(<App />);
+1
View File
@@ -0,0 +1 @@
@import "tailwindcss";
+206
View File
@@ -0,0 +1,206 @@
import { describe, expect, it, vi } from "vitest";
import {
createCatalogStore,
INITIAL_BACKOFF_MS,
MAX_BACKOFF_MS,
type CatalogStore,
type Scheduler,
} from "./catalogStore.js";
import type { CatalogEvent, Session } from "../types.js";
function session(id: string): Session {
return {
id,
cwd: "/home/n",
command: "bash",
env: {},
metadata: {},
status: "Running",
created_at: "2026-08-22T00:00:00Z",
} as Session;
}
/** Just enough of a WebSocket for the store to drive, plus a way to push frames. */
class FakeSocket {
onmessage: ((ev: { data: string }) => void) | null = null;
onopen: (() => void) | null = null;
onclose: (() => void) | null = null;
onerror: (() => void) | null = null;
closed = false;
close(): void {
this.closed = true;
}
open(): void {
this.onopen?.();
}
emit(event: CatalogEvent): void {
this.onmessage?.({ data: JSON.stringify(event) });
}
drop(): void {
this.onclose?.();
}
}
/** Scheduler that records delays instead of waiting them out. */
function fakeScheduler(): Scheduler & { delays: number[]; runNext(): void } {
const queued: Array<() => void> = [];
return {
delays: [] as number[],
setTimer(fn, ms) {
this.delays.push(ms);
queued.push(fn);
return queued.length;
},
clearTimer() {},
runNext() {
queued.shift()?.();
},
};
}
function storeWith(sockets: FakeSocket[], refetch?: () => Promise<Session[]>) {
let i = 0;
const scheduler = fakeScheduler();
const store = createCatalogStore({
socket: () => sockets[i++] as unknown as WebSocket,
scheduler,
refetch,
});
return { store, scheduler };
}
describe("catalogStore reducer", () => {
it("replaces state on Snapshot and applies deltas", () => {
const ws = new FakeSocket();
const { store } = storeWith([ws]);
store.getState().start();
ws.emit({ type: "Snapshot", sessions: [session("a")] } as CatalogEvent);
expect([...store.getState().sessions.keys()]).toEqual(["a"]);
ws.emit({ type: "SessionAdded", session: session("b") } as CatalogEvent);
expect([...store.getState().sessions.keys()].sort()).toEqual(["a", "b"]);
ws.emit({ type: "SessionRemoved", id: "a" } as CatalogEvent);
expect([...store.getState().sessions.keys()]).toEqual(["b"]);
});
it("ignores a frame that is not JSON", () => {
const ws = new FakeSocket();
const { store } = storeWith([ws]);
store.getState().start();
ws.emit({ type: "Snapshot", sessions: [session("a")] } as CatalogEvent);
ws.onmessage?.({ data: "not json" });
expect([...store.getState().sessions.keys()]).toEqual(["a"]);
});
it("refetches over REST when the server reports dropped frames", async () => {
const ws = new FakeSocket();
const refetch = vi.fn(async () => [session("fresh")]);
const { store } = storeWith([ws], refetch);
store.getState().start();
ws.emit({ type: "Snapshot", sessions: [session("stale")] } as CatalogEvent);
ws.emit({ type: "Lagged", skipped: 4 } as CatalogEvent);
await vi.waitFor(() => expect(refetch).toHaveBeenCalledOnce());
expect([...store.getState().sessions.keys()]).toEqual(["fresh"]);
});
it("hands each subscriber a fresh sessions map it can diff against the previous one", () => {
const ws = new FakeSocket();
const { store } = storeWith([ws]);
const seen: CatalogStore[] = [];
store.subscribe((s) => seen.push(s));
store.getState().start();
ws.emit({ type: "Snapshot", sessions: [session("a")] } as CatalogEvent);
ws.emit({ type: "SessionAdded", session: session("b") } as CatalogEvent);
const [afterSnapshot, afterAdd] = seen;
expect(afterSnapshot.sessions).not.toBe(afterAdd.sessions);
expect(afterSnapshot.sessions.size).toBe(1);
expect(afterAdd.sessions.size).toBe(2);
});
});
describe("catalogStore reconnect", () => {
it("replaces a suspended socket immediately", () => {
const first = new FakeSocket();
const second = new FakeSocket();
const { store } = storeWith([first, second]);
store.getState().start();
store.getState().reconnect();
expect(first.closed).toBe(true);
second.open();
// A late close from the old socket is deliberately ignored.
first.drop();
expect(store.getState().backoff()).toBe(INITIAL_BACKOFF_MS);
});
it("doubles the delay per attempt and caps it", () => {
const sockets = Array.from({ length: 8 }, () => new FakeSocket());
const { store, scheduler } = storeWith(sockets);
store.getState().start();
for (let i = 0; i < 7; i++) {
sockets[i].drop();
scheduler.runNext();
}
expect(scheduler.delays[0]).toBe(INITIAL_BACKOFF_MS);
expect(scheduler.delays[1]).toBe(INITIAL_BACKOFF_MS * 2);
expect(scheduler.delays.at(-1)).toBe(MAX_BACKOFF_MS);
});
it("resets the delay once a connection opens", () => {
const sockets = [new FakeSocket(), new FakeSocket(), new FakeSocket()];
const { store, scheduler } = storeWith(sockets);
store.getState().start();
sockets[0].drop();
scheduler.runNext();
expect(store.getState().backoff()).toBe(INITIAL_BACKOFF_MS * 2);
sockets[1].open();
expect(store.getState().backoff()).toBe(INITIAL_BACKOFF_MS);
});
it("stop() tears the socket down without scheduling a reconnect", () => {
const ws = new FakeSocket();
const { store, scheduler } = storeWith([ws]);
store.getState().start();
store.getState().stop();
ws.drop();
expect(ws.closed).toBe(true);
expect(scheduler.delays).toEqual([]);
});
});
describe("catalogStore connected state", () => {
it("reports the socket opening and dropping", () => {
const sock = new FakeSocket();
const store = createCatalogStore({
socket: () => sock as unknown as WebSocket,
scheduler: fakeScheduler(),
});
const seen: boolean[] = [];
store.subscribe((s) => seen.push(s.connected));
store.getState().start();
sock.open();
sock.drop();
expect(seen).toEqual([true, false]);
});
});
+188
View File
@@ -0,0 +1,188 @@
import { create } from "zustand";
import { eventsWsUrl, listSessions } from "../api.js";
import type { CatalogEvent, Session, Uuid } from "../types.js";
export interface CatalogState {
sessions: Map<Uuid, Session>;
/** The events socket's up/down state. Drives the daemon link (daemonLink.ts)
* — the socket dying is the first sign the daemon went down or was
* upgraded under the page. */
connected: boolean;
}
/** Opens the events socket. Injectable so the reducer and the backoff schedule
* can be driven without a server. */
export type SocketFactory = () => WebSocket;
/** Schedules a reconnect attempt; returns a handle `clearTimer` understands. */
export interface Scheduler {
setTimer(fn: () => void, ms: number): number;
clearTimer(handle: number): void;
}
const browserScheduler: Scheduler = {
setTimer: (fn, ms) => window.setTimeout(fn, ms),
clearTimer: (h) => window.clearTimeout(h),
};
/** Initial reconnect delay, doubling to `MAX_BACKOFF_MS`. */
export const INITIAL_BACKOFF_MS = 500;
export const MAX_BACKOFF_MS = 10_000;
export interface CatalogStoreOptions {
socket?: SocketFactory;
scheduler?: Scheduler;
/** Full-state refetch used when the server reports it dropped frames. */
refetch?: () => Promise<Session[]>;
}
export interface CatalogActions {
start(): void;
/** Replace a socket that may have gone stale while the browser was suspended. */
reconnect(): void;
stop(): void;
/** Current reconnect delay, for tests asserting the backoff schedule. */
backoff(): number;
}
export type CatalogStore = CatalogState & CatalogActions;
/** Builds an isolated catalog store — a socket/scheduler/refetch can be
* injected (tests), or defaulted to the real browser/daemon ones. The
* returned value is both a React hook (`useCatalog(selector)`) and a plain
* object (`useCatalog.getState()`, `useCatalog.subscribe(fn)`), so the
* reconnect/backoff machinery works the same whether or not React is
* driving it. */
export function createCatalogStore(opts: CatalogStoreOptions = {}) {
const socketFactory = opts.socket ?? (() => new WebSocket(eventsWsUrl()));
const scheduler = opts.scheduler ?? browserScheduler;
const refetch = opts.refetch ?? listSessions;
let ws: WebSocket | null = null;
let reconnectTimer: number | null = null;
let backoffMs = INITIAL_BACKOFF_MS;
return create<CatalogStore>((set, get) => {
function apply(event: CatalogEvent): void {
switch (event.type) {
case "Snapshot":
set({ sessions: new Map(event.sessions.map((s) => [s.id, s])) });
return;
case "SessionAdded":
case "SessionUpdated": {
const next = new Map(get().sessions);
next.set(event.session.id, event.session);
set({ sessions: next });
return;
}
case "SessionRemoved": {
const next = new Map(get().sessions);
next.delete(event.id);
set({ sessions: next });
return;
}
case "Lagged":
// Re-derive from REST to avoid showing stale state.
void resync();
return;
}
}
async function resync(): Promise<void> {
try {
const sessions = await refetch();
set({ sessions: new Map(sessions.map((s) => [s.id, s])) });
} catch {
// surface in UI on next reconnect cycle; nothing else useful to do
}
}
function connect(): void {
const socket = socketFactory();
ws = socket;
socket.onmessage = (ev) => {
let event: CatalogEvent;
try {
event = JSON.parse(ev.data) as CatalogEvent;
} catch {
return;
}
apply(event);
};
socket.onopen = () => {
backoffMs = INITIAL_BACKOFF_MS;
set({ connected: true });
};
socket.onclose = () => {
ws = null;
set({ connected: false });
scheduleReconnect();
};
socket.onerror = () => {
try {
socket.close();
} catch {
// ignore
}
};
}
function scheduleReconnect(): void {
if (reconnectTimer !== null) return;
const delay = Math.min(backoffMs, MAX_BACKOFF_MS);
reconnectTimer = scheduler.setTimer(() => {
reconnectTimer = null;
backoffMs = Math.min(backoffMs * 2, MAX_BACKOFF_MS);
connect();
}, delay);
}
return {
sessions: new Map(),
connected: false,
start() {
connect();
},
reconnect() {
if (reconnectTimer !== null) {
scheduler.clearTimer(reconnectTimer);
reconnectTimer = null;
}
if (ws) {
// A close event from the superseded socket must not schedule a
// second connection alongside the new one.
ws.onclose = null;
ws.onerror = null;
ws.close();
ws = null;
}
connect();
},
stop() {
if (reconnectTimer !== null) {
scheduler.clearTimer(reconnectTimer);
reconnectTimer = null;
}
if (ws) {
ws.onclose = null;
ws.close();
ws = null;
}
},
backoff() {
return backoffMs;
},
};
});
}
export type CatalogStoreApi = ReturnType<typeof createCatalogStore>;
+414
View File
@@ -0,0 +1,414 @@
// @vitest-environment happy-dom
import { afterEach, describe, expect, it, vi } from "vitest";
import { createConnectionStore } from "./connectionStore.js";
import { createCatalogStore } from "./catalogStore.js";
import type { Session } from "../types.js";
// The pane's own bytes-out path, stubbed: the escape hatch only needs to know
// the pool reaches the focused connection with them.
const sent: { id: string; data: string }[] = [];
const disposed: string[] = [];
const mounts: { id: string; focus: boolean | undefined }[] = [];
function fakeConn(kind: string, id: string) {
const el = document.createElement("div");
el.tabIndex = -1; // focusable via .focus(), like a real input/terminal
el.dataset.kind = kind;
el.dataset.session = id;
return {
sessionId: id,
kind,
el,
onMount(opts?: { focus?: boolean }) {
mounts.push({ id, focus: opts?.focus });
},
onUnmount() {},
focusTerminal() {},
sendInput(data: string) {
sent.push({ id, data });
},
updateInfo() {},
dispose() {
disposed.push(`${kind}:${id}`);
},
};
}
vi.mock("../attach.js", () => ({
createAttachConnection: (id: string) => fakeConn("attach", id),
}));
vi.mock("../structured.js", () => ({
createStructuredConnection: (id: string) => fakeConn("structured", id),
}));
afterEach(() => {
vi.unstubAllGlobals();
sent.length = 0;
disposed.length = 0;
mounts.length = 0;
});
/** Minimal fixture for the sessions map a catalog store broadcasts. */
function session(id: string, view?: "Terminal" | "Structured"): Session {
return {
id,
cwd: "/repo",
command: "claude",
env: {},
metadata: {},
status: "Running",
created_at: "2026-01-01T00:00:00Z",
view,
};
}
/** A catalog store an id can be pushed into on demand, mirroring
* catalogStore.test.ts's own injectable-socket pattern. */
class FakeCatalogSocket {
onmessage: ((ev: { data: string }) => void) | null = null;
onopen: (() => void) | null = null;
onclose: (() => void) | null = null;
onerror: (() => void) | null = null;
close(): void {}
push(sessions: Session[]): void {
this.onmessage?.({ data: JSON.stringify({ type: "Snapshot", sessions }) });
}
}
function fakeCatalog() {
const socket = new FakeCatalogSocket();
const store = createCatalogStore({ socket: () => socket as unknown as WebSocket });
store.getState().start();
return { store, socket };
}
const A = "aaaaaaaa-0000-0000-0000-0000000000ff";
const B = "bbbbbbbb-0000-0000-0000-0000000000ff";
function mockFetch() {
const fetchMock = vi.fn(() => Promise.resolve(new Response(null, { status: 204 })));
vi.stubGlobal("fetch", fetchMock);
return fetchMock;
}
describe("connectionStore setFocus", () => {
it("reports the new session focused, none unfocused, the first time", () => {
const fetchMock = mockFetch();
const pool = createConnectionStore();
pool.getState().setFocus(A);
expect(fetchMock).toHaveBeenCalledOnce();
const [url, init] = fetchMock.mock.calls[0] as unknown as [string, RequestInit];
expect(url).toBe(`/api/sessions/${A}/focus`);
expect(init.method).toBe("POST");
expect(JSON.parse(init.body as string)).toEqual({ focused: true });
expect(pool.getState().focusedId).toBe(A);
});
it("unfocuses the previous session and focuses the new one on a switch", () => {
const fetchMock = mockFetch();
const pool = createConnectionStore();
pool.getState().setFocus(A);
fetchMock.mockClear();
pool.getState().setFocus(B);
expect(fetchMock).toHaveBeenCalledTimes(2);
const bodies = fetchMock.mock.calls.map(([url, init]: unknown[]) => [
url,
JSON.parse((init as RequestInit).body as string),
]);
expect(bodies).toContainEqual([`/api/sessions/${A}/focus`, { focused: false }]);
expect(bodies).toContainEqual([`/api/sessions/${B}/focus`, { focused: true }]);
});
it("reports unfocused when focus clears to null", () => {
const fetchMock = mockFetch();
const pool = createConnectionStore();
pool.getState().setFocus(A);
fetchMock.mockClear();
pool.getState().setFocus(null);
expect(fetchMock).toHaveBeenCalledOnce();
const [url, init] = fetchMock.mock.calls[0] as unknown as [string, RequestInit];
expect(url).toBe(`/api/sessions/${A}/focus`);
expect(JSON.parse(init.body as string)).toEqual({ focused: false });
});
it("is a no-op when the focused session doesn't change", () => {
const fetchMock = mockFetch();
const pool = createConnectionStore();
pool.getState().setFocus(A);
fetchMock.mockClear();
pool.getState().setFocus(A);
expect(fetchMock).not.toHaveBeenCalled();
});
it("does not let a fetch rejection break the pool", async () => {
vi.stubGlobal(
"fetch",
vi.fn(() => Promise.reject(new Error("offline"))),
);
const pool = createConnectionStore();
expect(() => pool.getState().setFocus(A)).not.toThrow();
// Let the rejected promise's `.catch` settle before the test ends.
await Promise.resolve();
await Promise.resolve();
});
});
describe("connectionStore sendToFocused", () => {
it("types the bytes into the focused session's PTY", () => {
mockFetch();
sent.length = 0;
const pool = createConnectionStore();
const pane = document.createElement("div");
pool.getState().mount(A, pane);
pool.getState().setFocus(A);
expect(pool.getState().sendToFocused("\x0b")).toBe(true);
expect(sent).toEqual([{ id: A, data: "\x0b" }]);
});
it("is a no-op with nothing focused", () => {
mockFetch();
sent.length = 0;
const pool = createConnectionStore();
expect(pool.getState().sendToFocused("\x0b")).toBe(false);
expect(sent).toEqual([]);
});
});
describe("connectionStore mount/unmount", () => {
it("tracks mounted and LRU order reactively", () => {
mockFetch();
const pool = createConnectionStore();
const paneA = document.createElement("div");
const paneB = document.createElement("div");
pool.getState().mount(A, paneA);
pool.getState().mount(B, paneB);
expect(pool.getState().cacheOrder).toEqual([A, B]);
expect([...pool.getState().mounted]).toEqual([A, B]);
pool.getState().unmount(A);
expect([...pool.getState().mounted]).toEqual([B]);
// Parked, not evicted — still in LRU order.
expect(pool.getState().cacheOrder).toEqual([A, B]);
pool.getState().close(A);
expect(pool.getState().cacheOrder).toEqual([B]);
expect(disposed).toEqual(["attach:" + A]);
});
it("evicts the least-recently-viewed parked connection beyond MAX_PARKED", () => {
mockFetch();
const pool = createConnectionStore();
const ids = Array.from({ length: 8 }, (_, i) => `id-${i}`);
for (const id of ids) {
pool.getState().mount(id, document.createElement("div"));
pool.getState().unmount(id); // park immediately
}
// Each mount only has itself visible (the rest already parked), so the
// cap-crossing eviction fires once, on the mount that pushes the parked
// count from 6 to 7: the single oldest (id-0) is dropped.
expect(disposed).toEqual(["attach:id-0"]);
expect(pool.getState().cacheOrder).toEqual(ids.slice(1));
});
});
// A deep link or restored layout can `mount()` a session before the catalog
// snapshot names its view — the daemon defaults an absent `view` to
// `"Terminal"`, but so does an *unknown* session, and only one of those is
// actually resolved (#140 review).
describe("connectionStore: view resolution races", () => {
it("replaces a wrongly-typed connection once the catalog resolves it, without waiting for another mount()", () => {
mockFetch();
const { store, socket } = fakeCatalog();
const pool = createConnectionStore({ store });
const pane = document.createElement("div");
pool.getState().mount(A, pane); // no info: deep-link-before-snapshot race
expect(disposed).toEqual([]);
socket.push([session(A, "Structured")]);
expect(disposed).toEqual(["attach:" + A]);
// The fresh connection landed in the same pane nothing re-mounted it into.
expect(pane.children).toHaveLength(1);
});
it("also repairs a wrongly-typed connection that is parked, not mounted, without evicting its other parked siblings", () => {
mockFetch();
const { store, socket } = fakeCatalog();
const pool = createConnectionStore({ store });
const hidden = document.body.lastElementChild as HTMLElement; // this pool's own cache
pool.getState().mount(A, document.createElement("div"));
pool.getState().mount(B, document.createElement("div"));
pool.getState().unmount(A);
pool.getState().unmount(B);
disposed.length = 0;
socket.push([session(A, "Structured")]);
expect(disposed).toEqual(["attach:" + A]);
// B's own element is still parked — A's repair didn't wipe its siblings
// out of the shared hidden cache.
expect(hidden.querySelector(`[data-session="${B}"]`)).not.toBeNull();
expect((hidden.querySelector(`[data-session="${A}"]`) as HTMLElement | null)?.dataset.kind).toBe("structured");
});
it("does not replace a connection whose resolved view already matches", () => {
mockFetch();
const { store, socket } = fakeCatalog();
const pool = createConnectionStore({ store });
const pane = document.createElement("div");
pool.getState().mount(A, pane, { name: "a", command: "claude", view: "Structured" });
disposed.length = 0;
socket.push([session(A, "Structured")]);
expect(disposed).toEqual([]);
});
it("does not downgrade an already-resolved connection when a later mount() call has no info", () => {
mockFetch();
const pool = createConnectionStore();
const pane = document.createElement("div");
pool.getState().mount(A, pane, { name: "a", command: "claude", view: "Structured" });
disposed.length = 0;
pool.getState().mount(A, pane); // e.g. a re-render before the catalog answers again
expect(disposed).toEqual([]);
});
it("does not treat a session missing from the catalog as Terminal and churn a live connection", () => {
mockFetch();
const { store, socket } = fakeCatalog();
const pool = createConnectionStore({ store });
const pane = document.createElement("div");
pool.getState().mount(A, pane, { name: "a", command: "claude", view: "Structured" });
disposed.length = 0;
// `A` is absent from this snapshot — the embedder's own subscription
// handles closing the pane; the pool must not race it by "fixing" the
// view first.
socket.push([session(B, "Terminal")]);
expect(disposed).toEqual([]);
});
it("re-focuses the fresh connection when the keyboard was actually inside the replaced pane", () => {
mockFetch();
const { store, socket } = fakeCatalog();
const pool = createConnectionStore({ store });
const pane = document.createElement("div");
document.body.appendChild(pane);
pool.getState().mount(A, pane);
pool.getState().setFocus(A);
(pane.firstElementChild as HTMLElement).focus();
expect(document.activeElement).toBe(pane.firstElementChild);
mounts.length = 0;
socket.push([session(A, "Structured")]);
expect(disposed).toEqual(["attach:" + A]);
expect(mounts).toEqual([{ id: A, focus: true }]);
pane.remove();
});
it("does not steal focus from a same-tab sidebar preview even though focusedId still names the previous pane", () => {
mockFetch();
const { store, socket } = fakeCatalog();
const pool = createConnectionStore({ store });
const pane = document.createElement("div");
document.body.appendChild(pane);
pool.getState().mount(A, pane);
pool.getState().setFocus(A);
(pane.firstElementChild as HTMLElement).focus();
const sidebarInput = document.createElement("input");
document.body.appendChild(sidebarInput);
sidebarInput.focus();
expect(document.activeElement).toBe(sidebarInput);
mounts.length = 0;
socket.push([session(A, "Structured")]);
expect(disposed).toEqual(["attach:" + A]);
expect(mounts).toEqual([{ id: A, focus: false }]);
pane.remove();
sidebarInput.remove();
});
it("does not focus a parked (unmounted) connection it repairs", () => {
mockFetch();
const { store, socket } = fakeCatalog();
const pool = createConnectionStore({ store });
const pane = document.createElement("div");
pool.getState().mount(A, pane);
pool.getState().setFocus(A);
pool.getState().unmount(A); // parked — no longer visible, `focusedId` still names it
mounts.length = 0;
socket.push([session(A, "Structured")]);
expect(disposed).toEqual(["attach:" + A]);
expect(mounts).toEqual([]); // parked repair calls onUnmount, never onMount
});
});
describe("connectionStore setVisible/activate/parkActive", () => {
it("parks sessions not in the next visible set and mounts the rest", () => {
mockFetch();
const pool = createConnectionStore();
const paneA = document.createElement("div");
const paneB = document.createElement("div");
pool.getState().setVisible([
{ id: A, pane: paneA },
{ id: B, pane: paneB },
]);
expect([...pool.getState().mounted].sort()).toEqual([A, B]);
pool.getState().setVisible([{ id: B, pane: paneB }]);
expect([...pool.getState().mounted]).toEqual([B]);
});
it("activate mounts+focuses alone, parkActive parks all and clears focus", () => {
mockFetch();
const pool = createConnectionStore();
const pane = document.createElement("div");
pool.getState().activate(A, pane);
expect(pool.getState().focusedId).toBe(A);
expect(pool.getState().isMounted(A)).toBe(true);
pool.getState().parkActive();
expect(pool.getState().focusedId).toBeNull();
expect(pool.getState().isMounted(A)).toBe(false);
});
});
describe("connectionStore dispose", () => {
it("disposes every cached connection and resets state", () => {
mockFetch();
const pool = createConnectionStore();
pool.getState().mount(A, document.createElement("div"));
pool.getState().mount(B, document.createElement("div"));
disposed.length = 0;
pool.getState().dispose();
expect(disposed.sort()).toEqual(["attach:" + A, "attach:" + B]);
expect(pool.getState().mounted.size).toBe(0);
expect(pool.getState().cacheOrder).toEqual([]);
expect(pool.getState().focusedId).toBeNull();
});
});
+360
View File
@@ -0,0 +1,360 @@
import { create } from "zustand";
import { createAttachConnection } from "../attach.js";
import type { AttachInfo } from "../paneTitle.js";
import type { PaneConnection } from "../pane.js";
import { createStructuredConnection } from "../structured.js";
import { setSessionFocus } from "../api.js";
import { sessionName, type Session, type SessionView, type Uuid } from "../types.js";
import type { CatalogStoreApi } from "./catalogStore.js";
/**
* How many *parked* (off-screen but still-connected) sessions to keep warm
* beyond whatever is currently visible. Visible panes are never counted or
* evicted — only this background buffer is bounded, so the browser doesn't hold
* an unbounded fan of open sockets. Switching back to a recently-viewed session
* is instant while it's still parked; older ones are evicted (WS closed) once
* the buffer overflows.
*/
const MAX_PARKED = 6;
/** A session's view defaults to `"Terminal"` wherever it isn't carried —
* matching the wire default (`SessionView`'s `#[default]`, types.ts). Only
* meaningful once the session itself is known; an altogether-unknown
* session (no `AttachInfo`/`Session` at all) is a distinct, un-resolved
* state callers must check for separately, not "Terminal". */
function resolveView(view: SessionView | undefined): SessionView {
return view ?? "Terminal";
}
export interface PoolOptions {
/** Fired when the focused session changes (drives sidebar highlight + HUD). */
onFocusChange?: (id: Uuid | null) => void;
/** Fired when a view's explicit disconnect control is used; the embedder
* decides how to update the layout/route (then typically calls `close`). */
onRequestClose?: (id: Uuid) => void;
/** Fired when a connection's socket closes on its own (session ended/dropped),
* not via an intentional close/eviction. The embedder closes the pane. */
onClosed?: (id: Uuid) => void;
/** Forwarded to each connection: should a dropped socket be retried? */
shouldReconnect?: (id: Uuid, code: number) => boolean;
/** Threaded through to a structured connection so its rail can read live
* worktree/git-status data (#140). Terminal connections don't need it. */
store?: CatalogStoreApi;
}
export interface ConnectionState {
/** Sessions currently mounted into a visible pane. */
mounted: Set<Uuid>;
/** Every live (mounted or parked) connection, oldest first — LRU order. */
cacheOrder: Uuid[];
/** The focused session, or null when nothing is focused (welcome pane). */
focusedId: Uuid | null;
}
export interface ConnectionActions {
isMounted(id: Uuid): boolean;
/**
* Ensure `id` is live and shown inside `pane`, reusing its connection if one
* exists (refreshing LRU recency). Does not touch other mounted panes.
*/
mount(id: Uuid, pane: HTMLElement, info?: AttachInfo, opts?: { focus?: boolean }): void;
/** Park `id` back into the hidden cache (still connected) and stop showing it. */
unmount(id: Uuid): void;
/**
* Reconcile the visible set to exactly `entries` (in render order): park any
* mounted session not listed, mount/refresh each listed one in its pane.
* `focus: false` shows the panes without taking the keyboard (preview).
*/
setVisible(entries: { id: Uuid; pane: HTMLElement; info?: AttachInfo }[], opts?: { focus?: boolean }): void;
/** Also tells the daemon which pane is focused (docs/SIDEBAR.md's
* `AwaitingInput` auto-clear) — the sidebar highlight never calls this,
* only a pane actually becoming the visible view. Best-effort: a failed
* report only delays the glow clearing. */
setFocus(id: Uuid | null): void;
/** Compat shim: show `id` alone in `pane` and focus it; park everything else. */
activate(id: Uuid, pane: HTMLElement, info?: AttachInfo): void;
/** Compat shim: park all visible panes and clear focus (e.g. welcome pane). */
parkActive(): void;
/** Put the keyboard back into the focused session's terminal. No-op when
* nothing is focused (welcome pane) or its connection is gone. */
focusTerminal(): void;
/** Type raw bytes into the focused session's PTY. Returns false when there is
* nothing focused, or its connection is gone — the leader's literal Ctrl-K
* is a no-op over the welcome pane rather than an error
* (docs/COMMAND-BAR.md). */
sendToFocused(data: string): boolean;
/** Fully disconnect + forget a session. */
close(id: Uuid): void;
dispose(): void;
}
export type ConnectionStore = ConnectionState & ConnectionActions;
/**
* Builds an isolated connection store — owns the set of live attach
* connections, decoupled from the router/UI. The returned value is both a
* React hook and a plain object (`getState`/`subscribe`), same shape as
* {@link createCatalogStore}.
*
* Unlike a single-active pool, several connections can be **mounted**
* (visible) at once — one per leaf of the active tab's layout tree. The
* caller reconciles the visible set with {@link ConnectionActions.setVisible}.
* Sessions no longer shown are **parked** in a hidden cache (still streaming)
* and bounded by an LRU. A connection only dies on eviction, an explicit
* {@link ConnectionActions.close}, or {@link ConnectionActions.dispose}.
*/
export function createConnectionStore(opts: PoolOptions = {}) {
/** All live connections. Insertion order doubles as LRU: oldest first. */
const cache = new Map<Uuid, PaneConnection>();
/** The view each cached connection was actually created for — a deep link
* or a restored layout can `mount()` a session before the catalog
* snapshot names its view, defaulting it to `"Terminal"`; this is what
* lets a later reconciliation notice the resolved view disagrees (#140
* review). */
const connViews = new Map<Uuid, SessionView>();
// Off-screen home for parked, still-connected terminals.
const hidden = document.createElement("div");
hidden.className = "conn-cache";
hidden.setAttribute("aria-hidden", "true");
document.body.appendChild(hidden);
let unsubscribeStore: (() => void) | undefined;
const store = create<ConnectionStore>((set, get) => {
function createConn(id: Uuid, info?: AttachInfo): PaneConnection {
const view = resolveView(info?.view);
connViews.set(id, view);
const connOpts = {
onRequestClose: (sid: Uuid) => opts.onRequestClose?.(sid),
onClosed: (sid: Uuid) => opts.onClosed?.(sid),
shouldReconnect: (sid: Uuid, code: number) => opts.shouldReconnect?.(sid, code) ?? false,
};
// structured.ts's own `store` param still expects the pre-Zustand
// `CatalogStore` class (events.ts) and doesn't use it yet (#140) — left
// unpassed here until that rail wiring is ported too.
return view === "Structured"
? createStructuredConnection(id, connOpts, info)
: createAttachConnection(id, connOpts, info);
}
/** Dispose whatever is cached for `id` and cache a freshly created
* connection in its place. Does not touch the DOM, `mounted`, or LRU
* order — callers place the new element themselves. */
function replace(id: Uuid, info?: AttachInfo): PaneConnection {
cache.get(id)?.dispose();
const fresh = createConn(id, info);
cache.set(id, fresh);
return fresh;
}
function insertOrder(id: Uuid): void {
set((s) => ({ cacheOrder: [...s.cacheOrder, id] }));
}
function touchOrder(id: Uuid): void {
set((s) => ({ cacheOrder: [...s.cacheOrder.filter((x) => x !== id), id] }));
}
function removeOrder(id: Uuid): void {
set((s) => ({ cacheOrder: s.cacheOrder.filter((x) => x !== id) }));
}
function setMounted(id: Uuid, isMounted: boolean): void {
set((s) => {
if (s.mounted.has(id) === isMounted) return {};
const next = new Set(s.mounted);
if (isMounted) next.add(id);
else next.delete(id);
return { mounted: next };
});
}
function setFocus(id: Uuid | null): void {
const previous = get().focusedId;
if (id === previous) return;
set({ focusedId: id });
if (previous !== null) void setSessionFocus(previous, false).catch(() => {});
if (id !== null) void setSessionFocus(id, true).catch(() => {});
opts.onFocusChange?.(id);
}
function close(id: Uuid): void {
const conn = cache.get(id);
if (!conn) return;
conn.dispose();
cache.delete(id);
connViews.delete(id);
removeOrder(id);
setMounted(id, false);
if (get().focusedId === id) setFocus(null);
}
/** Drop least-recently-viewed *parked* connections beyond the buffer cap. */
function evict(): void {
while (cache.size - get().mounted.size > MAX_PARKED) {
const mounted = get().mounted;
let victim: Uuid | null = null;
for (const id of cache.keys()) {
if (!mounted.has(id)) {
victim = id;
break;
}
}
if (victim === null) break;
close(victim);
}
}
function mount(id: Uuid, pane: HTMLElement, info?: AttachInfo, mountOpts?: { focus?: boolean }): void {
let conn = cache.get(id);
if (conn) {
// `info === undefined` means "session not known yet", not "Terminal" —
// never downgrade a resolved connection just because a later caller
// couldn't resolve the session. Only a *resolved* view that disagrees
// with what this connection was built for forces a replace.
if (info !== undefined && resolveView(info.view) !== connViews.get(id)) {
conn = replace(id, info);
} else {
touchOrder(id);
if (info) conn.updateInfo(info);
}
} else {
conn = createConn(id, info);
cache.set(id, conn);
insertOrder(id);
}
if (conn.el.parentElement !== pane) {
pane.replaceChildren(conn.el);
conn.onMount(mountOpts);
} else if (!get().mounted.has(id)) {
conn.onMount(mountOpts);
}
setMounted(id, true);
evict();
}
function unmount(id: Uuid): void {
if (!get().mounted.has(id)) return;
setMounted(id, false);
const conn = cache.get(id);
if (conn) {
hidden.appendChild(conn.el); // stays alive, just off-screen
conn.onUnmount();
}
}
function setVisible(
entries: { id: Uuid; pane: HTMLElement; info?: AttachInfo }[],
visOpts?: { focus?: boolean },
): void {
const next = new Set(entries.map((e) => e.id));
for (const id of [...get().mounted]) {
if (!next.has(id)) unmount(id);
}
for (const e of entries) mount(e.id, e.pane, e.info, visOpts);
}
/** Proactively fix any cached connection whose view no longer matches the
* catalog — the only path that repairs a pane nothing will `mount()`
* again on its own (parked, or mounted but not currently being
* re-rendered by anything else). A session absent from `sessions` (not
* yet known, or removed) is left alone — that's the embedder's own
* close/eviction concern, not a view mismatch. */
function reconcileViews(sessions: Map<Uuid, Session>): void {
for (const id of [...cache.keys()]) {
const session = sessions.get(id);
if (session === undefined || resolveView(session.view) === connViews.get(id)) continue;
const existing = cache.get(id)!;
const parent = existing.el.parentElement;
const wasMounted = get().mounted.has(id);
// Capture before anything below touches the DOM: dispose()/el.remove()
// detach `existing.el`, and once a focused descendant is detached the
// browser moves `document.activeElement` to `<body>` — too late to
// tell whether the keyboard was actually in this pane.
const hadDomFocus = existing.el.contains(document.activeElement);
const info: AttachInfo = { name: sessionName(session), command: session.command, view: session.view };
const fresh = replace(id, info);
existing.el.remove(); // don't rely on dispose() to clear the DOM
if (parent && parent !== hidden) {
parent.replaceChildren(fresh.el);
} else {
// Parked: `hidden` holds every parked connection's element as
// siblings — append, never replaceChildren, or they'd all vanish.
hidden.appendChild(fresh.el);
}
if (wasMounted) {
// `focusedId` names the session the pool was last told to focus —
// but a same-tab sidebar preview moves the keyboard into the
// sidebar without clearing it, so `focusedId` alone can point at a
// pane the keyboard already left. Only re-focus when the DOM
// agrees it never did.
fresh.onMount({ focus: get().focusedId === id && hadDomFocus });
} else {
fresh.onUnmount();
}
}
}
// A session `mount()`ed before its catalog entry exists gets a
// `"Terminal"` connection by default; once the snapshot actually names
// the view, fix any connection that guessed wrong — nothing else
// re-`mount()`s an already-open pane just because the catalog updated.
unsubscribeStore = opts.store?.subscribe((state) => reconcileViews(state.sessions));
return {
mounted: new Set<Uuid>(),
cacheOrder: [],
focusedId: null,
isMounted(id) {
return get().mounted.has(id);
},
mount,
unmount,
setVisible,
setFocus,
activate(id, pane, info) {
setVisible([{ id, pane, info }]);
setFocus(id);
},
parkActive() {
for (const id of [...get().mounted]) unmount(id);
setFocus(null);
},
focusTerminal() {
const id = get().focusedId;
if (id === null) return;
cache.get(id)?.focusTerminal();
},
sendToFocused(data) {
const id = get().focusedId;
if (id === null) return false;
const conn = cache.get(id);
if (!conn) return false;
conn.sendInput(data);
return true;
},
close,
dispose() {
unsubscribeStore?.();
for (const conn of cache.values()) conn.dispose();
cache.clear();
connViews.clear();
set({ mounted: new Set(), cacheOrder: [], focusedId: null });
hidden.remove();
},
};
});
return store;
}
export type ConnectionStoreApi = ReturnType<typeof createConnectionStore>;
+32 -8
View File
@@ -468,18 +468,40 @@ describe("structured connection: data flow", () => {
},
});
ws.emit({ type: "reduced_state", state: respondingState });
// While the turn is active, the last intermediate text (agent:2) stays
// outside the collapsed group so it's visible as current narration.
expect(conn.el.querySelector('[data-row-id="agent:2"]')?.closest(".st-tool-group")).toBeNull();
// Earlier intermediate text (agent:1) is still inside the group.
// Intermediate updates stay inside the collapsed activity disclosure,
// rather than becoming a second visible transcript alongside its summary.
expect(conn.el.querySelector('[data-row-id="agent:2"]')?.closest(".st-tool-group")).not.toBeNull();
expect(conn.el.querySelector('[data-row-id="agent:1"]')?.closest(".st-tool-group")).not.toBeNull();
// When the turn ends, all intermediate text is absorbed.
// It remains collapsed when the turn ends.
ws.emit({ type: "reduced_state", state: idleState });
expect(conn.el.querySelector('[data-row-id="agent:2"]')?.closest(".st-tool-group")).not.toBeNull();
expect(conn.el.querySelector('[data-row-id="agent:1"]')?.closest(".st-tool-group")).not.toBeNull();
conn.dispose();
});
it("collapses trailing thought commentary with a turn's tool activity", () => {
const ws = new FakeSocket();
const conn = mount({ sockets: [ws] });
ws.open();
ws.emit({
type: "transcript_snapshot",
snapshot: {
cursor: 5,
rows: [
row("user:1", "user", { content: { type: "text", text: "do it" } }),
toolRow("tool:1", "one"),
toolRow("tool:2", "two"),
row("thought:1", "agent_thought", { content: { type: "text", text: "Checking the next step" } }),
row("thought:2", "agent_thought", { content: { type: "text", text: "Preparing the change" } }),
],
},
});
for (const id of ["thought:1", "thought:2"]) {
expect(conn.el.querySelector(`[data-row-id="${id}"]`)?.closest(".st-tool-group")).not.toBeNull();
}
conn.dispose();
});
it("keeps an expanded running tool open without emitting a click when patched", () => {
const ws = new FakeSocket();
const conn = mount({ sockets: [ws] });
@@ -824,7 +846,9 @@ describe("structured connection: turn/composer gating", () => {
expect(send.disabled).toBe(false);
expect(sendStructuredPrompt).toHaveBeenCalledTimes(1);
expect(sendStructuredPrompt).toHaveBeenCalledWith("s1", "only once");
expect(conn.el.querySelector(".structured-queue")?.textContent).toBe("1 message queued");
const queued = conn.el.querySelectorAll(".st-row-queued");
expect(queued).toHaveLength(1);
expect(queued[0].textContent).toBe("queued next");
conn.dispose();
});
@@ -844,7 +868,7 @@ describe("structured connection: turn/composer gating", () => {
submit("second");
submit("third");
expect(sendStructuredPrompt).toHaveBeenCalledTimes(1);
expect(conn.el.querySelector(".structured-queue")?.textContent).toBe("2 messages queued");
expect(conn.el.querySelectorAll(".st-row-queued")).toHaveLength(2);
await Promise.resolve().then(() => Promise.resolve());
ws.emit({ type: "reduced_state", state: idleState });
@@ -853,7 +877,7 @@ describe("structured connection: turn/composer gating", () => {
await Promise.resolve().then(() => Promise.resolve());
ws.emit({ type: "reduced_state", state: idleState });
expect(sendStructuredPrompt).toHaveBeenNthCalledWith(3, "s1", "third");
expect((conn.el.querySelector(".structured-queue") as HTMLElement).hidden).toBe(true);
expect(conn.el.querySelectorAll(".st-row-queued")).toHaveLength(0);
conn.dispose();
});
+73 -40
View File
@@ -117,7 +117,6 @@ export function createStructuredConnection(
<svg class="structured-cancel-spinner" viewBox="0 0 24 24" aria-hidden="true"><circle cx="12" cy="12" r="10" fill="none" stroke="currentColor" stroke-width="2" stroke-dasharray="50 14" stroke-linecap="round"/></svg>
<svg class="structured-cancel-stop" viewBox="0 0 24 24" aria-hidden="true"><rect x="6" y="6" width="12" height="12" rx="2" fill="currentColor"/></svg>
</button>
<span class="structured-queue" role="status" aria-live="polite" hidden></span>
</form>
</div>
</div>
@@ -139,7 +138,6 @@ export function createStructuredConnection(
const sendBtn = el.querySelector(".structured-send") as HTMLButtonElement;
const sendLabel = sendBtn.querySelector("span") as HTMLSpanElement;
const cancelBtn = el.querySelector(".structured-cancel") as HTMLButtonElement;
const queueEl = el.querySelector(".structured-queue") as HTMLSpanElement;
const attachBtn = el.querySelector(".structured-attach") as HTMLButtonElement;
const fileInput = el.querySelector(".structured-file-input") as HTMLInputElement;
const attachmentEl = el.querySelector(".structured-attachments") as HTMLDivElement;
@@ -490,24 +488,14 @@ export function createStructuredConnection(
groups.set(currentGid, group);
}
}
// pending at end of a turn = final text/approvals, stays outside (not flushed).
// While the turn is still active, keep the last intermediate text/thought
// row outside the collapsed group so it's visible as the agent's current
// narration. It gets absorbed on the next rebuild once newer content
// arrives or the turn ends.
const turnActive = state.turn.responding || state.turn.thinking;
if (turnActive) {
const lastGroup = groups.get(currentGid);
if (lastGroup) {
for (let i = lastGroup.rows.length - 1; i >= 0; i--) {
const kind = lastGroup.rows[i].kind;
if (kind === "agent_text" || kind === "agent_thought") {
lastGroup.rows.splice(i, 1);
break;
}
}
}
// A final agent text is the answer, so it stays outside. Thought rows are
// working commentary, though: when a turn already has a disclosure they
// belong with its activity even if the next tool call has not arrived yet.
// Leaving that tail loose made a busy agent look like it was publishing a
// long italic answer above a collapsed "N tool calls" summary.
const lastGroup = groups.get(currentGid);
if (lastGroup && pending.length > 0 && pending.every((row) => row.kind === "agent_thought")) {
lastGroup.rows.push(...pending);
}
return groups;
@@ -524,6 +512,7 @@ export function createStructuredConnection(
const liveGroupIds = new Set([...groups.keys()]);
for (const id of expandedGroupIds) if (!liveGroupIds.has(id)) expandedGroupIds.delete(id);
const prevGroupEls = new Map(groupEls);
rowEls.clear();
groupEls.clear();
const children: HTMLElement[] = [];
@@ -542,23 +531,37 @@ export function createStructuredConnection(
rowEls.set(memberRow.id, memberEl);
return [memberEl];
});
const groupEl = buildToolGroup(
groupId,
group.rows,
memberEls,
expandedGroupIds.has(groupId),
(expanded) => {
if (expanded) expandedGroupIds.add(groupId);
else expandedGroupIds.delete(groupId);
settleDisclosureLayout();
},
group.toolCount,
);
if (group.rows.some((r) => enteringRowIds.has(r.id))) {
groupEl.classList.add("st-row-enter");
// Reuse existing group element when possible — avoids tearing down
// and recreating the wrapper, which restarts CSS transitions (visible
// flash) and destroys keyboard/focus state.
const existing = prevGroupEls.get(groupId);
if (existing) {
const titleEl = existing.querySelector<HTMLElement>(".st-tool-group-title");
if (titleEl) titleEl.textContent = `${group.toolCount} tool calls`;
const inner = existing.querySelector<HTMLElement>(".st-disclosure-inner");
if (inner) inner.replaceChildren(...memberEls);
groupEls.set(groupId, existing);
children.push(existing);
} else {
const groupEl = buildToolGroup(
groupId,
group.rows,
memberEls,
expandedGroupIds.has(groupId),
(expanded) => {
if (expanded) expandedGroupIds.add(groupId);
else expandedGroupIds.delete(groupId);
settleDisclosureLayout();
},
group.toolCount,
);
if (group.rows.some((r) => enteringRowIds.has(r.id))) {
groupEl.classList.add("st-row-enter");
}
groupEls.set(groupId, groupEl);
children.push(groupEl);
}
groupEls.set(groupId, groupEl);
children.push(groupEl);
continue;
}
// Resolved approvals not absorbed into a tool group are hidden — the
@@ -621,10 +624,15 @@ export function createStructuredConnection(
// visible flashing and breaks text selection.
const oldEl = rowEls.get(delta.row.id);
if (oldEl) {
const active = document.activeElement as HTMLElement | null;
const hadToolFocus = active?.classList.contains("st-tool-head") && oldEl.contains(active);
const newEl = buildRowElement(delta.row);
if (newEl) {
oldEl.replaceWith(newEl);
rowEls.set(delta.row.id, newEl);
if (hadToolFocus) {
newEl.querySelector<HTMLButtonElement>(".st-tool-head")?.focus();
}
}
syncAvailableCommands();
return;
@@ -673,12 +681,14 @@ export function createStructuredConnection(
}
}
let configDirty = false;
function renderConfig(): void {
const options = sessionConfigOptions();
configEl.hidden = options.length === 0;
if (options.length === 0) {
configMenu.hidden = true;
configTrigger.setAttribute("aria-expanded", "false");
configDirty = false;
return;
}
const ordered = [...options].sort((a, b) => {
@@ -692,6 +702,15 @@ export function createStructuredConnection(
configTrigger.title = summary;
configTrigger.setAttribute("aria-label", `Session settings. ${summary.replaceAll("\n", ". ")}`);
configTrigger.disabled = configBusy;
// When the menu is open and the user is interacting (not mid-change),
// skip the DOM rebuild so open <select> dropdowns aren't destroyed.
// Mark dirty so the next open rebuilds with fresh data.
if (!configMenu.hidden && !configBusy) {
configDirty = true;
return;
}
configDirty = false;
configMenu.replaceChildren();
for (const option of ordered) {
const row = document.createElement("label");
@@ -730,6 +749,22 @@ export function createStructuredConnection(
}
}
function renderQueuedPrompts(): void {
for (const old of rowsEl.querySelectorAll(".st-row-queued")) old.remove();
for (const queued of promptQueue) {
const wrap = document.createElement("div");
wrap.className = "st-row st-row-queued";
const body = document.createElement("div");
body.className = "st-body";
const line = document.createElement("div");
line.className = "st-user-text";
line.textContent = queued.text;
body.appendChild(line);
wrap.appendChild(body);
rowsEl.appendChild(wrap);
}
}
function renderComposerState(): void {
const projectedActive = state.turn.responding || state.turn.thinking;
input.disabled = false;
@@ -740,10 +775,7 @@ export function createStructuredConnection(
sendBtn.hidden = false;
sendLabel.textContent = "Send";
cancelBtn.hidden = !projectedActive;
queueEl.hidden = promptQueue.length === 0;
queueEl.textContent = promptQueue.length === 1
? "1 message queued"
: `${promptQueue.length} messages queued`;
renderQueuedPrompts();
renderActivity();
}
@@ -823,6 +855,7 @@ export function createStructuredConnection(
configTrigger.addEventListener("click", () => {
const opening = configMenu.hidden;
if (opening && configDirty) renderConfig();
configMenu.hidden = !opening;
configTrigger.setAttribute("aria-expanded", String(opening));
});
+2 -2
View File
@@ -315,8 +315,8 @@ describe("buildTranscriptRow: tool diffs", () => {
(el.querySelector(".st-tool-head") as HTMLButtonElement).click();
const diff = el.querySelector(".st-diff") as HTMLElement;
expect(diff).not.toBeNull();
expect(diff.querySelector(".st-ln-add")!.textContent).toBe("c");
expect(diff.querySelector(".st-ln-del")!.textContent).toBe("b");
expect(diff.querySelector(".st-ln-add")!.textContent).toBe("+ c");
expect(diff.querySelector(".st-ln-del")!.textContent).toBe("- b");
});
it("gives the diff its own horizontally-scrolling container", () => {
+5 -4
View File
@@ -223,15 +223,16 @@ function buildDiffBlock(diff: { path: string; oldText?: string | null; newText:
wrap.appendChild(label);
const scroller = el("div", "st-diff");
const pre = document.createElement("pre");
for (const line of computeDiffLines(diff.oldText, diff.newText)) {
const lines = computeDiffLines(diff.oldText, diff.newText);
const prefixes: Record<string, string> = { add: "+ ", del: "- ", ctx: " ", hunk: "", eof: "" };
for (const line of lines) {
const span = document.createElement("span");
span.className = `st-ln st-ln-${line.kind}`;
span.textContent = line.text;
span.textContent = (prefixes[line.kind] ?? "") + line.text;
pre.appendChild(span);
pre.appendChild(document.createTextNode("\n"));
}
scroller.appendChild(pre);
makeCopyable(scroller, pre.textContent ?? "", "diff");
makeCopyable(scroller, lines.map((l) => (prefixes[l.kind] ?? "") + l.text).join("\n"), "diff");
wrap.appendChild(scroller);
return wrap;
}
+19 -13
View File
@@ -2375,6 +2375,22 @@ input.leaf-rename:focus {
background: var(--surface-2);
}
/* Queued messages: optimistic user bubbles, not yet sent. */
.st-row-queued {
justify-content: flex-end;
pointer-events: none;
}
.st-row-queued .st-body {
flex: 0 1 auto;
max-width: min(86%, 72ch);
padding: var(--sp-2) var(--sp-3);
border-radius: var(--r-2);
background: var(--surface-3);
opacity: 0.45;
filter: blur(0.5px);
}
.st-user-text {
white-space: pre-wrap;
overflow-wrap: anywhere;
@@ -2491,7 +2507,8 @@ input.leaf-rename:focus {
.st-row-thought {
color: var(--faint);
font-style: italic;
font-size: var(--fs-12);
line-height: 1.4;
white-space: pre-wrap;
overflow-wrap: anywhere;
}
@@ -2974,6 +2991,7 @@ input.leaf-rename:focus {
display: block;
white-space: pre;
padding: 0 var(--sp-3);
line-height: 1.4;
}
.st-ln-add {
@@ -3121,18 +3139,6 @@ input.leaf-rename:focus {
transition: border-color var(--dur-fast) var(--ease-out);
}
.structured-queue {
position: absolute;
right: var(--sp-2);
bottom: calc(100% + var(--sp-1));
padding: 3px var(--sp-2);
border: 1px solid var(--border);
border-radius: var(--r-pill);
background: var(--surface);
color: var(--muted);
font-size: var(--fs-11);
box-shadow: var(--shadow-1);
}
.structured-composer:focus-within {
border-top-color: var(--border);
+5
View File
@@ -0,0 +1,5 @@
import type { Config } from "tailwindcss";
export default {
content: ["src/**/*.{ts,tsx}"],
} satisfies Config;
+1
View File
@@ -4,6 +4,7 @@
"lib": ["ES2022", "DOM", "DOM.Iterable"],
"module": "ESNext",
"moduleResolution": "Bundler",
"jsx": "react-jsx",
"strict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
+3
View File
@@ -1,4 +1,6 @@
import { defineConfig, loadEnv } from "vite";
import react from "@vitejs/plugin-react";
import tailwindcss from "@tailwindcss/vite";
// Where the dev proxy forwards `/api/*` (and the events WS) to. Default to a
// local daemon on 127.0.0.1:7070. Override with:
@@ -18,6 +20,7 @@ export default defineConfig(({ mode }) => {
const target = resolveProxyTarget(env.MAESTRO_DAEMON_URL);
const secure = target.startsWith("https://");
return {
plugins: [react(), tailwindcss()],
build: {
target: "es2022",
outDir: "dist",