naps62/maestro
Archived
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

daemon: apply the same worktree rule when a session exits on its own #82

New Issue
Closed
opened 2026-08-24 09:38:48 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-24 09:38:48 +01:00
Collaborator
Copy Link
Copy Source

A session that ends on its own — the command finishes, or the operator types exit — never goes through the kill path, so #79's guard does not apply. This is the main way a worktree becomes orphaned once kills are guarded, and it is the case the daemon currently handles worst.

When the watcher notices the tmux session is gone, apply the same rule the kill uses: a pristine worktree is removed, anything else is retained with reason exited-with-unsaved-work and enters the store (#78).

The distinction from a kill is that nobody is waiting for an answer, so there is nothing to refuse — the choice is only between removing and retaining, and it is made with the same predicate so the two paths cannot drift apart. Factor that predicate out of #79 rather than writing it twice.

Depends on: #78, #79

A session that ends on its own — the command finishes, or the operator types `exit` — never goes through the kill path, so #79's guard does not apply. This is the main way a worktree becomes orphaned once kills are guarded, and it is the case the daemon currently handles worst. When the watcher notices the tmux session is gone, apply the same rule the kill uses: a pristine worktree is removed, anything else is retained with reason `exited-with-unsaved-work` and enters the store (#78). The distinction from a kill is that nobody is waiting for an answer, so there is nothing to refuse — the choice is only between removing and retaining, and it is made with the same predicate so the two paths cannot drift apart. Factor that predicate out of #79 rather than writing it twice. Depends on: #78, #79
naps62-yolo added this to the Worktree lifecycle milestone 2026-08-24 09:38:48 +01:00
naps62-yolo added the area/daemondifficulty/mediumtype/feat labels 2026-08-24 09:38:48 +01:00
naps62-yolo added a new dependency 2026-08-24 09:39:01 +01:00
#78 daemon: persist a retained-worktree store in state_dir
naps62-yolo added a new dependency 2026-08-24 09:39:01 +01:00
#88 e2e: the whole worktree lifecycle, retention cases included
naps62-yolo added a new dependency 2026-08-24 09:39:01 +01:00
#89 write the worktree lifecycle contract into the design doc
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/android
area/cli
area/config
area/daemon
area/protocol
area/tui
area/web
code-review
difficulty/easy
difficulty/hard
difficulty/medium
epic
Tracks a multi-issue epic / parent work item
 tui
type/docs
type/feat
type/fix
type/refactor
type/test
No labels area/daemon difficulty/medium type/feat
Milestone
No items
No Milestone Worktree lifecycle
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62-yolo (naps62-yolo (agent)) resende (Resende) naps62 (Miguel Palhas)
No Assignees
1 Participants
Due Date
No due date set.
Blocks
#88 e2e: the whole worktree lifecycle, retention cases included
naps62/maestro
Depends on
#78 daemon: persist a retained-worktree store in state_dir
naps62/maestro
#79 daemon: refuse a kill when the session's worktree holds unsaved work
naps62/maestro
Reference: naps62/maestro#82