naps62/maestro
Archived
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

e2e: the whole worktree lifecycle, retention cases included #88

New Issue
Closed
opened 2026-08-24 09:38:54 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-24 09:38:54 +01:00
Collaborator
Copy Link
Copy Source

Cover the lifecycle end to end in crates/maestro-e2e, against real git and tmux with a temp $HOME and TMUX_TMPDIR, following the harness already there.

  • A second spawn onto an occupied path gets the suffixed directory, and both worktrees work.
  • A spawn whose target path is occupied by a directory the daemon never made sidesteps it rather than adopting or failing.
  • Killing a session with uncommitted changes is refused, the session keeps running, and the worktree is untouched.
  • Committing and pushing that work, then killing again, succeeds and removes the tree.
  • Killing with unpushed commits is refused; --force ends the session and the worktree is retained.
  • A session that exits on its own with a dirty worktree leaves it retained; one that exits pristine leaves nothing behind.
  • GET /api/worktrees lists the retained trees with their reasons, and reclaim removes the directory while the branch survives.
  • The retained store survives a daemon restart.

The retention cases are the ones that must not be skipped: they are what the whole redesign rests on, and every earlier version of this behaviour passed its unit tests while being wrong in practice.

Depends on: #81, #82, #80

Cover the lifecycle end to end in `crates/maestro-e2e`, against real `git` and `tmux` with a temp `$HOME` and `TMUX_TMPDIR`, following the harness already there. - A second spawn onto an occupied path gets the suffixed directory, and both worktrees work. - A spawn whose target path is occupied by a directory the daemon never made sidesteps it rather than adopting or failing. - Killing a session with uncommitted changes is refused, the session keeps running, and the worktree is untouched. - Committing and pushing that work, then killing again, succeeds and removes the tree. - Killing with unpushed commits is refused; `--force` ends the session and the worktree is retained. - A session that exits on its own with a dirty worktree leaves it retained; one that exits pristine leaves nothing behind. - `GET /api/worktrees` lists the retained trees with their reasons, and reclaim removes the directory while the branch survives. - The retained store survives a daemon restart. The retention cases are the ones that must not be skipped: they are what the whole redesign rests on, and every earlier version of this behaviour passed its unit tests while being wrong in practice. Depends on: #81, #82, #80
naps62-yolo added this to the Worktree lifecycle milestone 2026-08-24 09:38:54 +01:00
naps62-yolo added the area/daemontype/testdifficulty/medium labels 2026-08-24 09:38:54 +01:00
naps62-yolo added a new dependency 2026-08-24 09:39:01 +01:00
#81 kill --force ends the session and retains the worktree
naps62-yolo added a new dependency 2026-08-24 09:39:01 +01:00
#80 daemon: GET /api/worktrees plus a reclaim endpoint
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/android
area/cli
area/config
area/daemon
area/protocol
area/tui
area/web
code-review
difficulty/easy
difficulty/hard
difficulty/medium
epic
Tracks a multi-issue epic / parent work item
 tui
type/docs
type/feat
type/fix
type/refactor
type/test
No labels area/daemon difficulty/medium type/test
Milestone
No items
No Milestone Worktree lifecycle
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62-yolo (naps62-yolo (agent)) resende (Resende) naps62 (Miguel Palhas)
No Assignees
1 Participants
Due Date
No due date set.
Depends on
#80 daemon: GET /api/worktrees plus a reclaim endpoint
naps62/maestro
#81 kill --force ends the session and retains the worktree
naps62/maestro
#82 daemon: apply the same worktree rule when a session exits on its own
naps62/maestro
Reference: naps62/maestro#88