Miguel PalhasandClaude Opus 5
f01771568b
dispatch was `async fn -> ()` with reqwest calls and task spawns inlined, so it could not report intent and the spawn, kill and attach arms had no test. It now returns Vec<Effect> and App::run performs them. Two bugs the old shape produced, both fixed and covered: - The toast overlay could not be dismissed. handle_overlay_input returned Pass for Toast(_) and nothing cleared it, so "spawn failed: ..." stayed until another overlay replaced it. It now clears and still returns Pass, so the keystroke does its normal job instead of being eaten. - Closing a tab leaked its emulator. Only submit_kill released one, so a closed tab's WebSocket task and vt100 parser outlived it forever. close_tab now reports the session it dropped — and holds onto it when another tab still shows the same one. AppState::overlay is private behind show_overlay/dismiss_overlay/toast. Four sites poked the field directly; that is why the toast bug existed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>