Compare commits
4 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
 naps62
|
c12f621176 | ||
|
naps62
|
19bd110188 | ||
|
naps62
|
1efa691b04 | ||
|
naps62
|
cb525048a4 |
@@ -36,6 +36,13 @@ point.
|
||||
This does not restrict acting without asking in the first place. It governs
|
||||
only what happens after a question has been put to me and left unanswered.
|
||||
|
||||
### Commit attribution
|
||||
|
||||
Never add a `Co-Authored-By:` trailer, a "generated with" line, or any other
|
||||
attribution to a commit message or a PR body. Every commit is authored solely
|
||||
by me. This overrides the harness default that appends a Co-Authored-By
|
||||
trailer, and it applies on every repo and every forge.
|
||||
|
||||
### Long unattended runs
|
||||
|
||||
Before reporting progress, check each claim against a tool result from this
|
||||
|
||||
+20
-1
@@ -10,11 +10,30 @@
|
||||
- Environment file: `~/.env.claude` (auto-loaded in shell sessions)
|
||||
- For Claude sessions, source it manually if needed: `source ~/.env.claude`
|
||||
|
||||
## Browser automation
|
||||
- Use the `agent-browser` CLI (headless, via Bash) for anything browser-shaped: checking pages, dev servers, screenshots, form flows, console/eval. `agent-browser --help` lists commands; `snapshot` gives an accessibility tree with refs for AI use.
|
||||
- The claude-in-chrome extension is disabled by default. Only reach for it if the task genuinely needs my real logged-in browser session or open tabs — and if its tools aren't available, ask me to enable it rather than working around it.
|
||||
|
||||
@~/.claude/writing.md
|
||||
|
||||
@~/.claude/operating.md
|
||||
|
||||
## Crit reviews
|
||||
## Rev code reviews
|
||||
|
||||
- Code-change reviews use the always-on rev server on `:7373`. A review is
|
||||
just a URL — never start crit or any per-review server for code diffs.
|
||||
- Global hooks do the plumbing: SessionStart injects the review URL and full
|
||||
instructions in any rev-known repo, and a Stop hook prompts to (re)arm the
|
||||
comment watcher (`~/tea/yolo/rev/scripts/rev-watch.sh <dir>`, background).
|
||||
Follow the injected instructions; there is nothing to set up.
|
||||
- Fallback if no instructions were injected: the URL to hand me is
|
||||
`https://rev.n62.casa/review?dir=<url-encoded worktree>&base=<base>`, while
|
||||
the API to call is `http://localhost:7373`;
|
||||
long-poll `GET /api/comments?dir=&since=&wait=1`, reply in-thread via
|
||||
`POST /api/comments` with author `"agent"` + `parentId`, never mark
|
||||
threads resolved.
|
||||
|
||||
## Crit reviews (plans, live pages, HTML files — code diffs go to rev)
|
||||
- **`crit live` / `crit preview` write comments to a local review FILE, not an API** — there is NO notification and `crit fetch` does NOT apply (it needs a prior `crit share`). `/api/comments` on the daemon is the WRONG place (stays `[]`). If I launched the crit server myself, I must poll the review file myself.
|
||||
- **Whenever I start a `crit live`/`crit preview` review for the user, immediately arm the watcher so they don't have to babysit it:**
|
||||
`~/.claude/scripts/crit-watch.sh` — run it via the Bash tool with `run_in_background: true`. It auto-finds the active live/preview review file (`~/.crit/reviews/<id>/review.json`), baselines existing comment IDs, and re-invokes me with any NEW comments once they settle. When it fires: read the comments, address them, **reply to each via `crit comment --reply-to <id> <body>`**, then re-arm the watcher. Keep doing this until the user says they're done.
|
||||
|
||||
@@ -20,7 +20,12 @@
|
||||
|
||||
@/home/naps62/tea/yolo/agent-skills/claude-md/code-comments.md
|
||||
|
||||
## Crit
|
||||
## Rev code reviews
|
||||
|
||||
- For code-change reviews, hand the user a URL on the always-on rev server: `http://localhost:7373/review?dir=<url-encoded abs worktree path>&base=<base>`. Do not start crit for code diffs.
|
||||
- Poll `GET http://localhost:7373/api/comments?dir=<dir>&since=<cursor>&wait=1` (seed the cursor from an initial call); reply in-thread via `POST /api/comments` with author `"agent"` and `parentId` = root comment id. Never mark threads resolved.
|
||||
|
||||
## Crit (plans, live pages, HTML files — code diffs go to rev)
|
||||
|
||||
- `crit live` and `crit preview` write to a local review file; poll that file, not an API. `crit fetch` needs a prior `crit share` and does not apply here.
|
||||
- When starting a live review, run `~/.claude/scripts/crit-watch.sh` in the background. Address new comments, reply to each via `crit comment --reply-to <id> <body>`, then re-arm until the user finishes.
|
||||
|
||||
@@ -7,7 +7,14 @@ argument-hint: "[file|url]"
|
||||
|
||||
# Review with Crit
|
||||
|
||||
Review and revise code changes, plans, live pages (running dev servers, staging URLs), or local HTML files using `crit` for inline comment review.
|
||||
Review and revise plans, live pages (running dev servers, staging URLs), or local HTML files using `crit` for inline comment review.
|
||||
|
||||
> **Code changes go to rev, not crit.** The always-on rev server reviews any
|
||||
> worktree at `http://<host>:7373/review?dir=<url-encoded dir>&base=<base>`,
|
||||
> and global hooks inject the full flow automatically. If this skill was
|
||||
> invoked for a code diff / branch review, hand out the rev URL instead and
|
||||
> follow the hook-injected instructions. Use crit only for the modes rev
|
||||
> doesn't cover: plan files, live pages, local HTML.
|
||||
|
||||
## Step 1: Pass arguments to `crit`
|
||||
|
||||
|
||||
Reference in New Issue
Block a user