yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

derive_series_status trusts callers to pass every season #131

New Issue
Closed
opened 2026-08-23 16:41:23 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-23 16:41:23 +01:00
Owner
Copy Link
Copy Source

derive_series_status(series, seasons, episodes, now) decides which episodes
are specials by looking them up in the seasons slice it is handed. A caller
that passes an incomplete or empty slice silently gets the old behaviour —
specials count again, and the series pins at incomplete. #118's own test
asserts this: "without knowing the seasons, the special pins the series".

#118 asked for the opposite — "extend the input so the function decides rather
than trusting every caller to filter first. A caller that forgets is the failure
this is meant to prevent." Passing two parallel slices still lets a caller get
it wrong; the only current caller (arr-api's tv_by_series) happens to be
correct, and #121 and #129 both add new callers.

Make it unrepresentable rather than documented. Options, cheapest first:

  • Give Episode the season number alongside season_id, so the function needs
    no second slice at all.
  • Take a single grouped input — seasons each owning their episodes — so a
    caller cannot supply episodes whose season is absent.

arr-api's with_status carries the same shape for its episode counters and
should follow whichever is chosen.

`derive_series_status(series, seasons, episodes, now)` decides which episodes are specials by looking them up in the `seasons` slice it is handed. A caller that passes an incomplete or empty slice silently gets the old behaviour — specials count again, and the series pins at `incomplete`. #118's own test asserts this: `"without knowing the seasons, the special pins the series"`. #118 asked for the opposite — "extend the input so the function decides rather than trusting every caller to filter first. A caller that forgets is the failure this is meant to prevent." Passing two parallel slices still lets a caller get it wrong; the only current caller (`arr-api`'s `tv_by_series`) happens to be correct, and #121 and #129 both add new callers. Make it unrepresentable rather than documented. Options, cheapest first: - Give `Episode` the season number alongside `season_id`, so the function needs no second slice at all. - Take a single grouped input — seasons each owning their episodes — so a caller cannot supply episodes whose season is absent. `arr-api`'s `with_status` carries the same shape for its episode counters and should follow whichever is chosen.
naps62-yolo added this to the TV tracking milestone 2026-08-23 16:41:23 +01:00
naps62-yolo added the area/corephase/6-tvdifficulty/moderatetype/bug labels 2026-08-23 16:41:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/core difficulty/moderate phase/6-tv type/bug
Milestone
No items
No Milestone TV tracking
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#131