Add the DeepL and Google Translate backends #192
No Assignees
Notifications
Due Date
No due date set.
Depends on
Reference: yolo/arr#192
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Implement the DeepL and Google Translate backends, each behind its own cargo
feature, against the trait from #190.
They share a shape — a dedicated translation API, per-character billing, no
context carried between requests — which is why they are one issue rather than
two. What differs is auth and response format.
PT-PTtarget distinct fromPT-BR; use it, and do notaccept a request for pt-PT that would silently return Brazilian text.
pttarget is Brazilian in practice. The backend must saythat it cannot express pt-PT rather than pretending, per #190's contract.
real number rather than an estimate.
Keys come from config or environment per §10. Fixture responses in tests.
Depends on: #190
Implemented the DeepL and Google Translate translation backends in
arr-subs, each behind its existing cargo feature (translate-deepl,translate-google), implementing #190'sBackendtrait. DeepL keepsPT-PTandPT-BRapart as first-class targets, auto-selects the free-tier host from a:fxkey, and maps DeepL's 403/429/456 toUnauthorized/RateLimited; bareptis accepted as a source but refused as a target. Google Translate refuses pt-PT insupports()(itspttarget is Brazilian) rather than pretending, and decodes the HTML entities its v2 API emits even in text mode (",', numeric forms). Both preserve cue numbering by array position (one output per input text), surface per-character usage via a new providedBackend::characters_billed()method (default zero, so additive for #191/#193), and map connection failures toTransport. All HTTP paths are tested against wiremock fixtures — no live service. Keys stay in bootstrap config/env per §10;arr-daemonalready plumbsARR_TRANSLATE_DEEPL_API_KEY/ARR_TRANSLATE_GOOGLE_API_KEY.Branch:
subtitles/192-deepl-google(3 commits, pushed)just ci: passed through the gate (exit 0), 556 tests green. Note the gate runs default features, so it does not compile the backends; I rancargo test/clippy -p arr-subs --features translate-deepl,translate-googlelocally with all green, both with and without features.Findings
--all-features, or enable the shipped backends in the release build's features.Backend::characters_billed()is cumulative since construction; #197 may prefer a returned-per-call number instead of polling a counter on adyn Backend. The trait change is small if that turns out better.#[cfg(test)] use wiremock as _;blocks (lines ~24 and ~46); harmless duplicate, left alone.