yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Sync translated subtitles with alass too #217

New Issue
Closed
opened 2026-08-25 01:50:43 +01:00 by naps62-yolo · 1 comment
naps62-yolo commented 2026-08-25 01:50:43 +01:00
Owner
Copy Link
Copy Source

DESIGN.md §15 says alass runs on "every fetched and every translated
subtitle". #214 wired it into the manual grab endpoint, which was all its
issue body asked for. The translate endpoint still records every machine
translation with sync: "not_run".

Syncer::settle — the seam #214 added in arr-subs precisely so more than
one caller could use it — applies here unchanged. This is a call, not a
design.

Found while implementing #214.

Depends on: #214

DESIGN.md §15 says `alass` runs on "every fetched and every translated subtitle". #214 wired it into the manual grab endpoint, which was all its issue body asked for. The translate endpoint still records every machine translation with `sync: "not_run"`. `Syncer::settle` — the seam #214 added in `arr-subs` precisely so more than one caller could use it — applies here unchanged. This is a call, not a design. Found while implementing #214. Depends on: #214
naps62-yolo added this to the Subtitles milestone 2026-08-25 01:50:43 +01:00
naps62-yolo added the area/apidifficulty/easytype/bugphase/9-subtitles labels 2026-08-25 01:50:43 +01:00
naps62-yolo added a new dependency 2026-08-25 01:50:50 +01:00
#214 Sync manually grabbed subtitles with alass
naps62-yolo commented 2026-08-25 04:59:57 +01:00
Author
Owner
Copy Link
Copy Source

Implemented: the translate handler now calls Syncer::settle after writing the .mt sidecar, same as #214 wired into grab. An accepted alass shift replaces the sidecar content before the row is recorded; an implausible result keeps the unsynced translation and records sync: "rejected". NewSubtitleFile::translated now goes through .sync(db_sync_state(...)) like the fetched path already did.

Branch: subtitles/217-sync-translated

just ci passed (678 tests).

Findings

None outside this issue's scope.

Implemented: the `translate` handler now calls `Syncer::settle` after writing the `.mt` sidecar, same as #214 wired into `grab`. An accepted `alass` shift replaces the sidecar content before the row is recorded; an implausible result keeps the unsynced translation and records `sync: "rejected"`. `NewSubtitleFile::translated` now goes through `.sync(db_sync_state(...))` like the fetched path already did. Branch: `subtitles/217-sync-translated` `just ci` passed (678 tests). ## Findings None outside this issue's scope.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/api difficulty/easy phase/9-subtitles type/bug
Milestone
No items
No Milestone Subtitles
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Depends on
#214 Sync manually grabbed subtitles with alass
yolo/arr
Reference: yolo/arr#217