yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

OpenSubtitles login sends HTTP basic auth; the API wants a JSON body #271

New Issue
Closed
opened 2026-08-31 09:57:39 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-31 09:57:39 +01:00
Owner
Copy Link
Copy Source

Every subtitle download fails with "opensubtitles rejected the configured credentials", regardless of whether the username and password are correct.

OpenSubtitles::login posts to /api/v1/login with .basic_auth(username, Some(password)) and no request body. The API takes the credentials as JSON:

{"username": "...", "password": "..."}

Basic auth is answered 401, which check_status maps to Error::Unauthorized, which the subtitle lane reports as refused credentials. The search lane is unaffected because it authenticates with the Api-Key header alone, so searches return candidates and only the download fails.

The integration tests did not catch this: mount_login matched on method and path only, so the mock answered a token to any request shape.

Related: repeated failed logins are rate-limited harshly by OpenSubtitles, and the token is only cached in memory, so every daemon restart re-attempts.

Found while fixing #270.

Every subtitle download fails with "opensubtitles rejected the configured credentials", regardless of whether the username and password are correct. `OpenSubtitles::login` posts to `/api/v1/login` with `.basic_auth(username, Some(password))` and no request body. The API takes the credentials as JSON: ```json {"username": "...", "password": "..."} ``` Basic auth is answered 401, which `check_status` maps to `Error::Unauthorized`, which the subtitle lane reports as refused credentials. The search lane is unaffected because it authenticates with the `Api-Key` header alone, so searches return candidates and only the download fails. The integration tests did not catch this: `mount_login` matched on method and path only, so the mock answered a token to any request shape. Related: repeated failed logins are rate-limited harshly by OpenSubtitles, and the token is only cached in memory, so every daemon restart re-attempts. Found while fixing #270.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#271
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?