yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

OpenSubtitles downloads arrive with no format and fail conversion #272

New Issue
Closed
opened 2026-08-31 10:09:20 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-31 10:09:20 +01:00
Owner
Copy Link
Copy Source

A download fails with:

4073669 could not be converted from  to SRT: no parser for ""

Search entries frequently carry no format attribute. format_of(None) returns SubtitleFormat::Other(""), that value is stashed in CandidateMeta at search time and handed back as the Fetched format, and convert then has no parser to pick.

The API converts on its side when the download request asks it to. POST /download takes sub_format, so sending {"file_id": ..., "sub_format": "srt"} makes the answer SRT unconditionally and the guessed-from-search format becomes dead weight.

The download mock matched only file_id, so it never exercised the format the real API returns.

Found while fixing #271.

A download fails with: ``` 4073669 could not be converted from to SRT: no parser for "" ``` Search entries frequently carry no `format` attribute. `format_of(None)` returns `SubtitleFormat::Other("")`, that value is stashed in `CandidateMeta` at search time and handed back as the `Fetched` format, and `convert` then has no parser to pick. The API converts on its side when the download request asks it to. `POST /download` takes `sub_format`, so sending `{"file_id": ..., "sub_format": "srt"}` makes the answer SRT unconditionally and the guessed-from-search format becomes dead weight. The download mock matched only `file_id`, so it never exercised the format the real API returns. Found while fixing #271.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#272
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?