yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Bootstrap configuration loading #46

Merged
naps62-yolo merged 2 commits from issue/3-config into main 2026-08-22 19:44:50 +01:00
Conversation 2 Commits 2 Files Changed 4
+396 -2
naps62-yolo commented 2026-08-22 19:31:08 +01:00
Owner
Copy Link
Copy Source

Closes #3.

arr-daemon loads bootstrap settings (bind address, database path, media
root, Prowlarr/Transmission/Jellyfin/ntfy URLs) with precedence env > file >
default. Every non-secret field has a default, so the daemon starts with
only environment variables set — no config file required.

API keys (Prowlarr, TMDB, Jellyfin) come from the environment only. The
optional TOML file's schema has no fields for them, so a key placed there
is a hard parse error rather than a silent leak.

Closes #3. `arr-daemon` loads bootstrap settings (bind address, database path, media root, Prowlarr/Transmission/Jellyfin/ntfy URLs) with precedence env > file > default. Every non-secret field has a default, so the daemon starts with only environment variables set — no config file required. API keys (Prowlarr, TMDB, Jellyfin) come from the environment only. The optional TOML file's schema has no fields for them, so a key placed there is a hard parse error rather than a silent leak.
naps62-yolo added 1 commit 2026-08-22 19:31:09 +01:00
feat: bootstrap config loading from env and file
ci / rust (pull_request) Successful in 59s
Details
ci / web (pull_request) Successful in 10s
Details
e2e / e2e (pull_request) Successful in 46s
Details
57170b01b4 
Env overrides an optional TOML file, which overrides sensible
defaults. Secrets (API keys) are read from the environment only —
the file schema has no fields for them.

Closes #3
naps62-yolo commented 2026-08-22 19:35:40 +01:00
Author
Owner
Copy Link
Copy Source

No findings. The bootstrap configuration implementation matches #3, and just ci passes (format, clippy, dependency check, and 8 tests).

No findings. The bootstrap configuration implementation matches #3, and `just ci` passes (format, clippy, dependency check, and 8 tests).
naps62-yolo added 1 commit 2026-08-22 19:40:57 +01:00
Merge remote-tracking branch 'origin/main' into issue/3-config
ci / web (pull_request) Successful in 8s
Details
ci / rust (pull_request) Successful in 1m3s
Details
e2e / e2e (pull_request) Successful in 1m18s
Details
8e8d90de65 
# Conflicts:
#	Cargo.lock
naps62-yolo commented 2026-08-22 19:41:41 +01:00
Author
Owner
Copy Link
Copy Source

No findings on the current head. The only update since the previous review is the merge of main; all three PR CI checks are successful.

No findings on the current head. The only update since the previous review is the merge of `main`; all three PR CI checks are successful.
naps62-yolo merged commit 1529e9fdca into main 2026-08-22 19:44:50 +01:00
naps62-yolo deleted branch issue/3-config 2026-08-22 19:44:50 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#46
Delete Branch "issue/3-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?