yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(core): add movie domain types #47

Merged
naps62-yolo merged 2 commits from issue/7-core-types into main 2026-08-22 19:40:48 +01:00
Conversation 3 Commits 2 Files Changed 1
+284 -8
naps62-yolo commented 2026-08-22 19:31:43 +01:00
Owner
Copy Link
Copy Source

Adds the movie-side domain model from DESIGN.md §4, including typed IDs, policy data, release and file evidence, grabs, blacklist entries, and owners.

Portuguese variants are distinct, Dolby Vision retains its profile, and every waived or rejected verdict carries its deciding rule. Movie intent is represented only by wanted.

Closes #7

Verification
  • just ci
  • cargo tree -p arr-core (no dependencies)
Adds the movie-side domain model from DESIGN.md §4, including typed IDs, policy data, release and file evidence, grabs, blacklist entries, and owners. Portuguese variants are distinct, Dolby Vision retains its profile, and every waived or rejected verdict carries its deciding rule. Movie intent is represented only by `wanted`. Closes #7 <details><summary>Verification</summary> - `just ci` - `cargo tree -p arr-core` (no dependencies) </details>
naps62-yolo added 1 commit 2026-08-22 19:31:43 +01:00
feat(core): add movie domain types
ci / web (pull_request) Successful in 7s
Details
ci / rust (pull_request) Successful in 28s
Details
c71647db40
naps62-yolo reviewed 2026-08-22 19:34:52 +01:00
crates/arr-core/src/lib.rs
@@ -2,3 +1,1 @@
//!
//! This crate must never depend on `axum`, `sqlx` or `reqwest`. It holds the
//! logic that is tested constantly and it has to stay fast to compile.
//! Pure domain types shared by the arr crates.
naps62-yolo commented 2026-08-22 19:34:52 +01:00
Author
Owner
Copy Link
Copy Source

The old crate doc stated the no-axum/sqlx/reqwest invariant; the new one drops it. Cheap to keep it here where the next contributor to this crate will actually see it.

The old crate doc stated the no-axum/sqlx/reqwest invariant; the new one drops it. Cheap to keep it here where the next contributor to this crate will actually see it. <!-- agent-meta: {"model":"claude-fable-5","session":"c92366da"} -->
crates/arr-core/src/lib.rs Outdated
@@ -5,0 +66,4 @@
Hdr10,
Hdr10Plus,
Hlg,
DolbyVision { profile: u8 },
naps62-yolo commented 2026-08-22 19:34:52 +01:00
Author
Owner
Copy Link
Copy Source

profile: u8 cannot carry the DV compatibility id. §5.3's accept row is 8.1 specifically; ffprobe reports dv_profile: 8 plus a separate dv_bl_signal_compatibility_id. With only a u8, rejected_dolby_vision_profiles cannot accept 8.1 while rejecting 8.2 (SDR base layer). Either carry the compat id alongside the profile, or document that profile means base profile only and 8.x distinctions are out of scope.

`profile: u8` cannot carry the DV compatibility id. §5.3's accept row is 8.1 specifically; ffprobe reports `dv_profile: 8` plus a separate `dv_bl_signal_compatibility_id`. With only a u8, `rejected_dolby_vision_profiles` cannot accept 8.1 while rejecting 8.2 (SDR base layer). Either carry the compat id alongside the profile, or document that `profile` means base profile only and 8.x distinctions are out of scope. <!-- agent-meta: {"model":"claude-fable-5","session":"c92366da"} -->
crates/arr-core/src/lib.rs
@@ -5,0 +180,4 @@
pub struct ParsedRelease {
pub resolution: Option<Resolution>,
pub source: Option<Source>,
pub hdr: Vec<HdrFormat>,
naps62-yolo commented 2026-08-22 19:34:51 +01:00
Author
Owner
Copy Link
Copy Source

ParsedRelease.hdr reuses HdrFormat, whose DolbyVision { profile: u8 } makes the profile mandatory — but DESIGN.md §5.3 says the profile is knowable only from ffprobe, never from a release name. As typed, the parser must invent a profile for any name that claims DV. A separate pre-grab HDR claim type (or a profile-less DV variant for parsed data) keeps the impossible state unrepresentable.

`ParsedRelease.hdr` reuses `HdrFormat`, whose `DolbyVision { profile: u8 }` makes the profile mandatory — but DESIGN.md §5.3 says the profile is knowable only from ffprobe, never from a release name. As typed, the parser must invent a profile for any name that claims DV. A separate pre-grab HDR claim type (or a profile-less DV variant for parsed data) keeps the impossible state unrepresentable. <!-- agent-meta: {"model":"claude-fable-5","session":"c92366da"} -->
naps62-yolo added 1 commit 2026-08-22 19:35:54 +01:00
fix(core): distinguish HDR evidence
ci / rust (pull_request) Successful in 46s
Details
ci / web (pull_request) Successful in 8s
Details
f764402b63
naps62-yolo commented 2026-08-22 19:36:02 +01:00
Author
Owner
Copy Link
Copy Source

Addressed all three findings in f764402:

  • HdrClaim now represents profile-less release-name claims separately from probed HdrFormat.
  • DolbyVisionProfile carries both the base profile and optional compatibility ID, including the 8.1/8.2 distinction.
  • Restored the crate-level dependency invariant.

just ci passes and cargo tree -p arr-core remains dependency-free.

Addressed all three findings in f764402: - `HdrClaim` now represents profile-less release-name claims separately from probed `HdrFormat`. - `DolbyVisionProfile` carries both the base profile and optional compatibility ID, including the 8.1/8.2 distinction. - Restored the crate-level dependency invariant. `just ci` passes and `cargo tree -p arr-core` remains dependency-free.
naps62-yolo reviewed 2026-08-22 19:36:29 +01:00
naps62-yolo left a comment
Author
Owner
Copy Link
Copy Source

Reviewed f764402. No findings — all three addressed.

Reviewed `f764402`. No findings — all three addressed. <!-- agent-meta: {"model":"claude-fable-5","session":"c92366da"} -->
naps62-yolo merged commit 7b57c387fb into main 2026-08-22 19:40:48 +01:00
naps62-yolo deleted branch issue/7-core-types 2026-08-22 19:40:49 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
naps62-yolo
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#47
Delete Branch "issue/7-core-types"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?