yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Enforce Dolby Vision profile policy #61

Merged
naps62-yolo merged 3 commits from issue/12-hdr-rule into main 2026-08-22 20:52:06 +01:00
Conversation 2 Commits 3 Files Changed 1
+126 -6
naps62-yolo commented 2026-08-22 20:38:15 +01:00
Owner
Copy Link
Copy Source

Summary

  • Add the Dolby Vision profile rule to the core policy pipeline.
  • Reject configured Profile 5 and 7 variants after probing; accept Profile 8.1.
  • Keep all pre-grab HDR profile evaluations unknown, including names claiming DV.

Issue

Closes #12

Test plan

  • just ci
## Summary - Add the Dolby Vision profile rule to the core policy pipeline. - Reject configured Profile 5 and 7 variants after probing; accept Profile 8.1. - Keep all pre-grab HDR profile evaluations unknown, including names claiming DV. ## Issue Closes #12 ## Test plan - `just ci` <!-- agent-meta: {"model":"gpt-5.6-sol","session":"01a02af6"} -->
naps62-yolo added 1 commit 2026-08-22 20:38:15 +01:00
feat(core): enforce Dolby Vision profiles
ci / rust (pull_request) Successful in 1m11s
Details
ci / web (pull_request) Successful in 7s
Details
be231352ca
naps62-yolo reviewed 2026-08-22 20:40:53 +01:00
crates/arr-core/src/policy.rs
@@ -203,0 +221,4 @@
.iter()
.any(|blocked| {
blocked.profile == profile.profile
&& blocked.compatibility_id.is_none_or(|compatibility_id| {
naps62-yolo commented 2026-08-22 20:40:53 +01:00
Author
Owner
Copy Link
Copy Source

The Some(compatibility_id) arm of the blocked-entry match is untested: all three tests use wildcard entries (compatibility_id: None) — 5 and 7 reject via the wildcard, and 8.1 passes only because profile 8 is absent from the list. Add a test with a blocked entry carrying Some(cid) that rejects the matching compat id and passes a different one.

The `Some(compatibility_id)` arm of the blocked-entry match is untested: all three tests use wildcard entries (`compatibility_id: None`) — 5 and 7 reject via the wildcard, and 8.1 passes only because profile 8 is absent from the list. Add a test with a blocked entry carrying `Some(cid)` that rejects the matching compat id and passes a different one. <!-- agent-meta: {"model":"claude-fable-5","session":"71932a7a"} -->
naps62-yolo marked this conversation as resolved
naps62-yolo added 2 commits 2026-08-22 20:41:56 +01:00
test(core): cover profile compatibility dcd7328c8c
Merge remote-tracking branch 'origin/main' into issue/12-hdr-rule
ci / web (pull_request) Successful in 8s
Details
ci / rust (pull_request) Successful in 3m29s
Details
68e276eee2
naps62-yolo reviewed 2026-08-22 20:42:28 +01:00
naps62-yolo left a comment
Author
Owner
Copy Link
Copy Source

Reviewed 68e276e. Previous finding addressed — compatibility_specific_rule_matches_only_that_id covers the Some(cid) arm. No new findings.

Reviewed `68e276e`. Previous finding addressed — `compatibility_specific_rule_matches_only_that_id` covers the `Some(cid)` arm. No new findings. <!-- agent-meta: {"model":"claude-fable-5","session":"71932a7a"} -->
naps62-yolo merged commit c7cb3652e5 into main 2026-08-22 20:52:06 +01:00
naps62-yolo deleted branch issue/12-hdr-rule 2026-08-22 20:52:06 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
naps62-yolo
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#61
Delete Branch "issue/12-hdr-rule"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?