fix(maestro): follow initial attach replay

Cargo.lock

@@ -1051,7 +1051,6 @@ dependencies = [
  "maestro-cli",
  "maestro-daemon",
  "maestro-tui",
- "tempfile",
  "tokio",
  "tracing-subscriber",
 ]

crates/maestro/Cargo.toml

@@ -29,6 +29,3 @@ tracing-subscriber.workspace = true
 maestro-cli = { path = "../maestro-cli", optional = true, default-features = false }
 maestro-daemon = { path = "../maestro-daemon", optional = true, default-features = false }
 maestro-tui = { path = "../maestro-tui", optional = true }
-
-[dev-dependencies]
-tempfile.workspace = true

crates/maestro/tests/subcommand_routing.rs

@@ -1,102 +0,0 @@
-//! Process-level routing for the umbrella `maestro` binary (#10): each
-//! enabled top-level subcommand must reach its own crate's runtime dispatch,
-//! not just parse successfully.
-//!
-//! A malformed `--config` file makes every crate's dispatch fail identically
-//! at config load, before any subcommand touches tmux, the network, or a
-//! terminal. That lets the assertions tell "clap parsed it but the handler
-//! never ran" (a usage error, exit 2) apart from "it dispatched into the real
-//! crate" (a `toml decode` runtime error via `main`'s `maestro: {e}` printer,
-//! exit 1).
-//!
-//! The absence tests below only compile when the matching feature is off, so
-//! they run under CI's per-feature-subset matrix (`--no-default-features
-//! --features cli|daemon|tui`) rather than the default all-features build.
-
-use std::io::Write;
-use std::path::PathBuf;
-use std::process::{Command, Output};
-
-fn bin() -> PathBuf {
-    PathBuf::from(env!("CARGO_BIN_EXE_maestro"))
-}
-
-fn bad_config() -> tempfile::NamedTempFile {
-    let mut f = tempfile::NamedTempFile::new().expect("create temp config file");
-    write!(f, "this is not valid toml {{{{{{").expect("write temp config");
-    f
-}
-
-fn run(args: &[&str]) -> Output {
-    Command::new(bin())
-        .args(args)
-        .output()
-        .unwrap_or_else(|e| panic!("spawn `maestro {args:?}`: {e}"))
-}
-
-/// Real dispatch happened: exit 1, `main`'s `"maestro: {e}"` prefix, and the
-/// config crate's error surfacing through — never clap's own usage-error
-/// page, which would mean the subcommand never reached its handler.
-fn assert_dispatched(out: &Output) {
-    let stderr = String::from_utf8_lossy(&out.stderr);
-    assert_eq!(out.status.code(), Some(1), "stderr:\n{stderr}");
-    assert!(stderr.starts_with("maestro: "), "stderr:\n{stderr}");
-    assert!(stderr.contains("toml decode"), "stderr:\n{stderr}");
-    assert!(!stderr.contains("Usage:"), "stderr:\n{stderr}");
-}
-
-/// Never reached a handler: clap rejected the subcommand outright because the
-/// feature that defines it is off. Only used by the `not(feature = "...")`
-/// tests below, which themselves only exist in a single-feature build.
-#[cfg(not(all(feature = "cli", feature = "daemon", feature = "tui")))]
-fn assert_unrecognized(out: &Output, name: &str) {
-    let stderr = String::from_utf8_lossy(&out.stderr);
-    assert_eq!(out.status.code(), Some(2), "stderr:\n{stderr}");
-    assert!(
-        stderr.contains("unrecognized subcommand"),
-        "stderr:\n{stderr}"
-    );
-    assert!(stderr.contains(name), "stderr:\n{stderr}");
-}
-
-#[cfg(feature = "cli")]
-#[test]
-fn list_dispatches_into_maestro_cli() {
-    let cfg = bad_config();
-    let out = run(&["list", "--config", cfg.path().to_str().unwrap()]);
-    assert_dispatched(&out);
-}
-
-#[cfg(not(feature = "cli"))]
-#[test]
-fn list_is_unrecognized_without_cli_feature() {
-    assert_unrecognized(&run(&["list"]), "list");
-}
-
-#[cfg(feature = "daemon")]
-#[test]
-fn daemon_dispatches_into_maestro_daemon() {
-    let cfg = bad_config();
-    let out = run(&["daemon", "--config", cfg.path().to_str().unwrap()]);
-    assert_dispatched(&out);
-}
-
-#[cfg(not(feature = "daemon"))]
-#[test]
-fn daemon_is_unrecognized_without_daemon_feature() {
-    assert_unrecognized(&run(&["daemon"]), "daemon");
-}
-
-#[cfg(feature = "tui")]
-#[test]
-fn tui_dispatches_into_maestro_tui() {
-    let cfg = bad_config();
-    let out = run(&["tui", "--config", cfg.path().to_str().unwrap()]);
-    assert_dispatched(&out);
-}
-
-#[cfg(not(feature = "tui"))]
-#[test]
-fn tui_is_unrecognized_without_tui_feature() {
-    assert_unrecognized(&run(&["tui"]), "tui");
-}

web/src/attach.ts

@@ -43,10 +43,6 @@ export interface AttachConnection {
    *  handling — the leader's literal Ctrl-K escape hatch
    *  (docs/COMMAND-BAR.md). */
   sendInput(data: string): void;
-  /** Refresh the header's name/command (e.g. after autoname renames the
-   *  session) — the connection outlives mount/unmount, so this is the only
-   *  way an already-open header picks up a new name. */
-  updateInfo(info: AttachInfo): void;
   /** Fully disconnect: close the WS, dispose the terminal, remove the element. */
   dispose(): void;
 }
@@ -89,25 +85,21 @@ export function createAttachConnection(
   el.className = "attach";
   // Useful identity over a bare UUID: name · command. The full id stays in the
   // tooltip for when you really need it.
-  const titleMarkup = (i?: AttachInfo): { html: string; attr: string } => ({
-    html: i
-      ? `<span class="at-name">${escapeHtml(i.name)}</span>` +
-        (i.command && i.command !== i.name ? commandFragment(i.command) : "")
-      : `session <span class="sid">${escapeHtml(sessionId.slice(0, 8))}</span>`,
-    attr: i ? `${i.name} · ${i.command}  (${sessionId})` : sessionId,
-  });
-  const initialTitle = titleMarkup(info);
+  const titleHtml = info
+    ? `<span class="at-name">${escapeHtml(info.name)}</span>` +
+      (info.command && info.command !== info.name ? commandFragment(info.command) : "")
+    : `session <span class="sid">${escapeHtml(sessionId.slice(0, 8))}</span>`;
+  const titleAttr = info ? `${info.name} · ${info.command}  (${sessionId})` : sessionId;
   el.innerHTML = `
     <header class="attach-header">
       <button type="button" class="btn btn-ghost btn-icon sessions-btn" aria-label="Show sessions" title="Show sessions">☰</button>
-      <span class="attach-title" title="${escapeHtml(initialTitle.attr)}">${initialTitle.html}</span>
+      <span class="attach-title" title="${escapeHtml(titleAttr)}">${titleHtml}</span>
       <span class="attach-state" data-state="connecting">connecting…</span>
       <button class="btn btn-ghost btn-icon disconnect" type="button" aria-label="Disconnect" title="Disconnect this session">⏻</button>
     </header>
     <div class="attach-body"></div>
   `;
 
-  const titleEl = el.querySelector(".attach-title") as HTMLSpanElement;
   const body = el.querySelector(".attach-body") as HTMLDivElement;
   const stateEl = el.querySelector(".attach-state") as HTMLSpanElement;
   const disconnectBtn = el.querySelector(".disconnect") as HTMLButtonElement;
@@ -367,6 +359,9 @@ export function createAttachConnection(
   let ws: WebSocket;
   let reconnectMs = INITIAL_RECONNECT_MS;
   let reconnectTimer: number | null = null;
+  // Snapshot replay starts at row zero, which can leave Codex at its oldest line.
+  // Follow it once per socket; later scrolling remains under the operator's control.
+  let awaitingReplay = true;
 
   const sendControl = (msg: ClientControl) => {
     if (ws.readyState !== WebSocket.OPEN) return;
@@ -386,6 +381,7 @@ export function createAttachConnection(
   };
 
   function connect(): void {
+    awaitingReplay = true;
     ws = new WebSocket(attachWsUrl(sessionId));
     ws.binaryType = "arraybuffer";
 
@@ -406,10 +402,20 @@ export function createAttachConnection(
         return;
       }
       if (ev.data instanceof ArrayBuffer) {
-        term.write(new Uint8Array(ev.data));
+        const replay = awaitingReplay;
+        awaitingReplay = false;
+        term.write(new Uint8Array(ev.data), () => {
+          if (replay) term.scrollToBottom();
+        });
       } else if (ev.data instanceof Blob) {
         // Some browsers may default to Blob despite binaryType="arraybuffer".
-        ev.data.arrayBuffer().then((b) => term.write(new Uint8Array(b)));
+        void ev.data.arrayBuffer().then((b) => {
+          const replay = awaitingReplay;
+          awaitingReplay = false;
+          term.write(new Uint8Array(b), () => {
+            if (replay) term.scrollToBottom();
+          });
+        });
       }
     };
 
@@ -507,11 +513,6 @@ export function createAttachConnection(
     // The closure above: the same bytes-out path keystrokes and the mobile key
     // bar already take.
     sendInput,
-    updateInfo(next: AttachInfo) {
-      const { html, attr } = titleMarkup(next);
-      titleEl.innerHTML = html;
-      titleEl.title = attr;
-    },
     dispose() {
       if (disposed) return;
       disposed = true;

web/src/connections.test.ts

@@ -16,7 +16,6 @@ vi.mock("./attach.js", () => ({
     sendInput(data: string) {
       sent.push({ id, data });
     },
-    updateInfo() {},
     dispose() {},
   }),
 }));

web/src/connections.ts

@@ -79,7 +79,6 @@ export class ConnectionPool {
     if (conn) {
       this.cache.delete(id);
       this.cache.set(id, conn);
-      if (info) conn.updateInfo(info);
     } else {
       conn = createAttachConnection(
         id,