Compare commits
41
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
9a48bf51f1 | ||
|
|
fa7d5fb505 | ||
|
|
66f386b87b | ||
|
|
e18ad716a0 | ||
|
|
f7e7a77912 | ||
|
|
d4c72577b9 | ||
|
|
aed9a5eec0 | ||
|
|
f84199d292 | ||
|
|
64d5829037 | ||
|
|
2ad2858fd5 | ||
|
|
fa2a26faa9 | ||
|
|
b5feb3c39a | ||
|
|
e12baa23c6 | ||
|
|
63191c7be1 | ||
|
|
acb84b91ef | ||
|
|
c8ab4a531e | ||
|
|
21fc20b30a | ||
|
|
abbd15a8b2 | ||
|
|
1d18e21420 | ||
|
|
38a65e585f | ||
|
|
adbf57fc49 | ||
|
|
7935663ed7 | ||
|
|
bff0eddc12 | ||
|
|
3ce1a6f331 | ||
|
|
8cb6aeb61e | ||
|
|
247060de68 | ||
|
|
29545d15fe | ||
|
|
4d7e368d31 | ||
|
|
eaf60d9dac | ||
|
|
f89be4a716 | ||
|
|
6be0dba74e | ||
|
|
28778b2224 | ||
|
|
766eabbcb6 | ||
|
|
c67fa2bd4e | ||
|
|
88b6bba9f2 | ||
|
|
1c349e5858 | ||
|
|
9fc21b4306 | ||
|
|
19162f9952 | ||
|
|
2fcfc06c3c | ||
|
|
f82ab45766 | ||
|
|
d304171d7c |
@@ -0,0 +1,20 @@
|
||||
# The integration suites drive real tmux servers and real git repos, and most
|
||||
# of their wall time is spent waiting on those subprocesses rather than on the
|
||||
# CPU. nextest runs test binaries in parallel — which plain `cargo test` does
|
||||
# not — but at its `num-cpus` default the tmux-backed tests starve each other
|
||||
# and the tighter `wait_for_async` deadlines (5s) start timing out. Capping the
|
||||
# concurrency keeps the cross-binary win without the contention.
|
||||
|
||||
[profile.ci]
|
||||
test-threads = 4
|
||||
|
||||
# Anything past this is reported as slow while it keeps running, so a genuine
|
||||
# hang is visible in the log instead of only showing up as a job timeout.
|
||||
slow-timeout = { period = "30s", terminate-after = 8 }
|
||||
|
||||
failure-output = "immediate-final"
|
||||
final-status-level = "slow"
|
||||
|
||||
# nextest does not run doctests. There are none today (every ``` fence in the
|
||||
# crates is `toml` or `text`), so nothing is lost; adding a real doctest means
|
||||
# adding `cargo test --doc` to CI alongside this.
|
||||
+106
-21
@@ -7,6 +7,14 @@ on:
|
||||
- 'linear/**'
|
||||
pull_request:
|
||||
|
||||
concurrency:
|
||||
group: ci-${{ github.workflow }}-${{ github.ref }}
|
||||
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
|
||||
|
||||
env:
|
||||
CARGO_TERM_COLOR: always
|
||||
CARGO_INCREMENTAL: 0
|
||||
|
||||
jobs:
|
||||
rust:
|
||||
runs-on: ubuntu-latest
|
||||
@@ -26,23 +34,36 @@ jobs:
|
||||
--component rustfmt --component clippy
|
||||
echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
|
||||
|
||||
- name: Install Node.js + pnpm
|
||||
# `crates/maestro-web/build.rs` shells out to pnpm whenever
|
||||
# MAESTRO_WEB_DIST is unset, so the Rust build needs node here too.
|
||||
- uses: actions/setup-node@v4
|
||||
with:
|
||||
node-version: '20'
|
||||
|
||||
- name: Enable pnpm
|
||||
run: |
|
||||
curl -fsSL https://deb.nodesource.com/setup_20.x | bash -
|
||||
apt-get install -y --no-install-recommends nodejs
|
||||
corepack enable
|
||||
corepack prepare pnpm@9.15.4 --activate
|
||||
|
||||
# Caching all of `target/` under a prefix restore-key let every stale
|
||||
# artifact a previous run dragged in survive forever, so the entry grew
|
||||
# without bound and cost ~60s to move. rust-cache keys on the rustc
|
||||
# version plus the lockfile and prunes target/ to what that lockfile
|
||||
# actually needs. Only main writes the cache; PRs restore from it and
|
||||
# skip the save, which also keeps concurrent PRs from thrashing it.
|
||||
- name: Cache cargo
|
||||
uses: actions/cache@v4
|
||||
uses: Swatinem/rust-cache@v2
|
||||
with:
|
||||
path: |
|
||||
~/.cargo/registry
|
||||
~/.cargo/git
|
||||
target
|
||||
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock', '**/Cargo.toml') }}
|
||||
restore-keys: |
|
||||
${{ runner.os }}-cargo-
|
||||
save-if: ${{ github.ref == 'refs/heads/main' }}
|
||||
|
||||
# nextest runs test *binaries* in parallel, which plain `cargo test`
|
||||
# does not — this suite is 20 integration binaries that mostly sit
|
||||
# waiting on tmux and git. Thread count is capped in
|
||||
# `.config/nextest.toml`; see the comment there.
|
||||
- name: Install cargo-nextest
|
||||
run: |
|
||||
curl -sSfL https://get.nexte.st/latest/linux \
|
||||
| tar zxf - -C "$HOME/.cargo/bin"
|
||||
|
||||
- name: fmt
|
||||
run: cargo fmt --all -- --check
|
||||
@@ -51,7 +72,7 @@ jobs:
|
||||
run: cargo clippy --all-targets -- -D warnings
|
||||
|
||||
- name: test
|
||||
run: cargo test --all
|
||||
run: cargo nextest run --all --profile ci
|
||||
|
||||
# NAP-271: the umbrella `maestro` binary is feature-gated (cli / daemon /
|
||||
# tui). Verify each subset compiles and its tests pass on its own, and
|
||||
@@ -62,7 +83,8 @@ jobs:
|
||||
for f in cli daemon tui; do
|
||||
echo "::group::maestro --no-default-features --features $f"
|
||||
cargo build -p maestro --no-default-features --features "$f"
|
||||
cargo test -p maestro --no-default-features --features "$f"
|
||||
cargo nextest run -p maestro --no-default-features --features "$f" \
|
||||
--profile ci
|
||||
echo "::endgroup::"
|
||||
done
|
||||
echo "::group::maestro with no features must fail to compile"
|
||||
@@ -77,12 +99,12 @@ jobs:
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
|
||||
- name: Install Node.js + pnpm
|
||||
- uses: actions/setup-node@v4
|
||||
with:
|
||||
node-version: '20'
|
||||
|
||||
- name: Enable pnpm
|
||||
run: |
|
||||
apt-get update
|
||||
apt-get install -y --no-install-recommends curl ca-certificates
|
||||
curl -fsSL https://deb.nodesource.com/setup_20.x | bash -
|
||||
apt-get install -y --no-install-recommends nodejs
|
||||
corepack enable
|
||||
corepack prepare pnpm@9.15.4 --activate
|
||||
|
||||
@@ -106,25 +128,88 @@ jobs:
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
|
||||
# A cold /nix means every run recompiles the entire release closure —
|
||||
# every third-party crate under `lto = "thin"` + `codegen-units = 1`,
|
||||
# which was ~8.5 minutes and the whole pipeline's critical path. With the
|
||||
# store restored, crane's deps-only derivation is already built and only
|
||||
# maestro's own crates recompile.
|
||||
#
|
||||
# The key is the lockfiles that closure derives from, not the sources: a
|
||||
# source-only push is an exact hit, which makes actions/cache skip the
|
||||
# (multi-GB) save. Only the cheap final crates rebuild in that case.
|
||||
- name: Restore nix store
|
||||
id: nix-cache
|
||||
uses: actions/cache/restore@v4
|
||||
with:
|
||||
path: /nix
|
||||
key: nix-${{ runner.os }}-${{ hashFiles('flake.lock', 'Cargo.lock', 'web/pnpm-lock.yaml', '**/*.nix') }}
|
||||
restore-keys: |
|
||||
nix-${{ runner.os }}-
|
||||
|
||||
# The runner container is root with no `nixbld` group, but the installer
|
||||
# writes `build-users-group = nixbld` anyway and then fails on it, so the
|
||||
# config goes in first. Flakes are off by default and `nix build .#…`
|
||||
# needs them. Written again afterwards in case the installer replaced it.
|
||||
#
|
||||
# A restored /nix already holds nix itself — the single-user installer
|
||||
# puts its profile under /nix/var/nix/profiles/per-user/root, which is
|
||||
# inside the cached path. Only $HOME (the ~/.nix-profile symlink, the
|
||||
# PATH entry, NIX_SSL_CERT_FILE) lives outside it and has to be redone.
|
||||
- name: Install nix
|
||||
run: |
|
||||
set -euo pipefail
|
||||
mkdir -p /etc/nix
|
||||
printf 'build-users-group =\nexperimental-features = nix-command flakes\n' > /etc/nix/nix.conf
|
||||
curl -fsSL https://nixos.org/nix/install | sh -s -- --no-daemon --yes
|
||||
printf 'build-users-group =\nexperimental-features = nix-command flakes\n' > /etc/nix/nix.conf
|
||||
profile=/nix/var/nix/profiles/per-user/root/profile
|
||||
if [ -x "$profile/bin/nix" ]; then
|
||||
ln -sfn "$profile" "$HOME/.nix-profile"
|
||||
else
|
||||
curl -fsSL https://nixos.org/nix/install | sh -s -- --no-daemon --yes
|
||||
printf 'build-users-group =\nexperimental-features = nix-command flakes\n' > /etc/nix/nix.conf
|
||||
fi
|
||||
echo "$HOME/.nix-profile/bin" >> "$GITHUB_PATH"
|
||||
# Sourcing the installer's profile script is what normally sets this;
|
||||
# without it a restored store cannot talk to cache.nixos.org.
|
||||
if [ -z "${NIX_SSL_CERT_FILE:-}" ] && [ -r /etc/ssl/certs/ca-certificates.crt ]; then
|
||||
echo "NIX_SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt" >> "$GITHUB_ENV"
|
||||
fi
|
||||
|
||||
# Fail here rather than 8 minutes into a build if a restored store is
|
||||
# unusable.
|
||||
- name: Check nix works
|
||||
run: nix --extra-experimental-features "nix-command flakes" --version
|
||||
|
||||
# The installer does not enable flakes, so `nix build .#…` needs the
|
||||
# features passed explicitly — a local machine that has them in
|
||||
# nix.conf will build fine while CI fails without this.
|
||||
- name: build flake packages
|
||||
#
|
||||
# This is the step that guards pnpmDeps.hash, and it is cheap, so it runs
|
||||
# on every event.
|
||||
- name: build SPA package
|
||||
run: |
|
||||
nix --extra-experimental-features "nix-command flakes" build \
|
||||
.#webFrontend \
|
||||
--no-link
|
||||
|
||||
# The release binaries are a full LTO compile of the workspace. The rust
|
||||
# job already builds, lints and tests the same sources, so the only extra
|
||||
# signal here is that the *packaging* works — worth a few minutes on main,
|
||||
# not on every PR push. Trade-off: a break that is specific to the Nix
|
||||
# packaging surfaces on main instead of on the PR.
|
||||
- name: build release packages
|
||||
if: github.event_name == 'push'
|
||||
run: |
|
||||
nix --extra-experimental-features "nix-command flakes" build \
|
||||
.#maestro \
|
||||
.#maestro-web \
|
||||
--no-link
|
||||
|
||||
# Saved only from a push, so a PR that built webFrontend alone can never
|
||||
# write a store missing the Rust closure and have a later run restore it
|
||||
# through the prefix key.
|
||||
- name: Save nix store
|
||||
if: github.event_name == 'push' && steps.nix-cache.outputs.cache-hit != 'true'
|
||||
uses: actions/cache/save@v4
|
||||
with:
|
||||
path: /nix
|
||||
key: nix-${{ runner.os }}-${{ hashFiles('flake.lock', 'Cargo.lock', 'web/pnpm-lock.yaml', '**/*.nix') }}
|
||||
|
||||
@@ -11,6 +11,7 @@ persistence, WebSocket for transport.
|
||||
maestro daemon tmux wrapper + session API on 127.0.0.1:7070
|
||||
├── GET/POST /api/sessions list / spawn
|
||||
├── DELETE /api/sessions/:id kill
|
||||
├── POST /api/sessions/:id/input type text into a session
|
||||
├── GET /api/info hostname, version, home dir, spawn presets
|
||||
├── GET /api/dirs directory listing (spawn autocomplete)
|
||||
├── GET /api/recent-dirs spawn history
|
||||
@@ -18,7 +19,7 @@ maestro daemon tmux wrapper + session API on 127.0.0.1:7070
|
||||
├── WS /api/events Snapshot + session deltas
|
||||
└── WS /api/attach/:id raw PTY bytes
|
||||
|
||||
maestro list/spawn/attach/kill CLI client
|
||||
maestro list/spawn/attach/kill/send CLI client
|
||||
maestro tui ratatui client
|
||||
maestro-web serves the SPA, reverse-proxies /api/* to the daemon
|
||||
```
|
||||
@@ -70,6 +71,11 @@ before changing anything that creates or removes one.
|
||||
sidebars — line layout, activity colours, duration format, state precedence.
|
||||
Read it before changing sidebar rendering.
|
||||
|
||||
`docs/RESTART.md` is the contract for what clients do when the daemon restarts
|
||||
or is upgraded under them — the build stamp on `/api/info`, the status
|
||||
indicator's states, the blocking overlay, grace and poll timings. Read it
|
||||
before changing reconnect behaviour on either client.
|
||||
|
||||
`nix run .#dev` (or `just dev`) brings up the whole local stack under
|
||||
process-compose: a debug daemon on 127.0.0.1:7071, then Vite on :5173 once the
|
||||
daemon answers `/api/info`. The SPA proxies `/api/*` back to the daemon, so only
|
||||
|
||||
@@ -100,10 +100,11 @@ Three surfaces, all DOM built in TS, styled by class:
|
||||
no-sessions, no-search-match.
|
||||
- **Attach** — header (back, `session <id>`, live/closed/error state pill) over
|
||||
a framed dark xterm with a green cursor.
|
||||
- **Draft pane** — the spawn form mounted inline in an empty split pane,
|
||||
focusable like any session pane; mono inputs with green focus ring; grouped
|
||||
worktree fieldset. Spawn opens one (reusing an empty focused pane, else
|
||||
splitting), and "Spawn similar" seeds one from a session's dir + command.
|
||||
- **Spawn modal** — the spawn form in a centered dialog (a bottom sheet below
|
||||
600px) over a blurred backdrop; mono inputs with green focus ring; grouped
|
||||
worktree fieldset. Escape, Cancel, ✕ and a backdrop click all dismiss it.
|
||||
Submitting gives the new session its own tab; "Spawn similar" seeds the form
|
||||
from a session's dir + command and puts the result beside it.
|
||||
|
||||
Interactive elements ship default / hover / focus-visible / active / disabled
|
||||
states; the accent green is used only for action, selection, focus, and live
|
||||
@@ -112,5 +113,5 @@ status — never decoration.
|
||||
## Dev review aids (DEV-only, stripped from production)
|
||||
|
||||
`web/src/mock.ts` + query params seed a representative catalog without a running
|
||||
daemon: `?mock` (seed sessions), `?mock&spawn` (open a draft pane),
|
||||
daemon: `?mock` (seed sessions), `?mock&spawn` (open the spawn modal),
|
||||
`?theme=light|dark` (pin a theme). Guarded by `import.meta.env.DEV`.
|
||||
|
||||
@@ -41,6 +41,9 @@ pub enum Command {
|
||||
Attach(AttachArgs),
|
||||
/// Kill a session by ID.
|
||||
Kill(KillArgs),
|
||||
/// Type text into a running session, as if it had been typed on an
|
||||
/// attached terminal.
|
||||
Send(SendArgs),
|
||||
/// Install or update the agent activity hook (#106).
|
||||
Hooks(HooksArgs),
|
||||
}
|
||||
@@ -103,6 +106,20 @@ pub struct AttachArgs {
|
||||
pub detach_key: String,
|
||||
}
|
||||
|
||||
/// `maestro send <session> <text...>`
|
||||
#[derive(Debug, clap::Args)]
|
||||
pub struct SendArgs {
|
||||
/// Session to type into: its ID, a unique ID prefix, or its name.
|
||||
pub session: String,
|
||||
/// Text to send. Omit it to read the text from stdin.
|
||||
#[arg(trailing_var_arg = true, allow_hyphen_values = true)]
|
||||
pub text: Vec<String>,
|
||||
/// Leave the text sitting in the session's prompt instead of pressing
|
||||
/// Enter after it.
|
||||
#[arg(long)]
|
||||
pub no_enter: bool,
|
||||
}
|
||||
|
||||
#[derive(Debug, clap::Args)]
|
||||
pub struct KillArgs {
|
||||
/// Session ID to kill.
|
||||
@@ -245,6 +262,40 @@ mod tests {
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn parses_send_joining_the_message_words() {
|
||||
let cli =
|
||||
Cli::try_parse_from(["maestro", "send", "planner", "run", "the", "tests"]).unwrap();
|
||||
let Command::Send(a) = cli.command else {
|
||||
panic!("expected send")
|
||||
};
|
||||
assert_eq!(a.session, "planner");
|
||||
assert_eq!(a.text, vec!["run", "the", "tests"]);
|
||||
assert!(!a.no_enter);
|
||||
}
|
||||
|
||||
/// The message is trailing_var_arg, so a word starting with `-` inside it
|
||||
/// is text, not a flag clap should reject.
|
||||
#[test]
|
||||
fn send_message_may_start_with_a_dash() {
|
||||
let cli =
|
||||
Cli::try_parse_from(["maestro", "send", "--no-enter", "planner", "--force"]).unwrap();
|
||||
let Command::Send(a) = cli.command else {
|
||||
panic!("expected send")
|
||||
};
|
||||
assert!(a.no_enter);
|
||||
assert_eq!(a.text, vec!["--force"]);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn send_text_may_be_omitted_for_stdin() {
|
||||
let cli = Cli::try_parse_from(["maestro", "send", "planner"]).unwrap();
|
||||
let Command::Send(a) = cli.command else {
|
||||
panic!("expected send")
|
||||
};
|
||||
assert!(a.text.is_empty());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn rejects_env_without_equals() {
|
||||
let err = Cli::try_parse_from([
|
||||
|
||||
@@ -10,7 +10,7 @@ use maestro_protocol::DaemonClient;
|
||||
|
||||
use crate::attach::{parse_detach_key, run_attach_url};
|
||||
use crate::cli::Command;
|
||||
use crate::sessions::{run_kill, run_list, run_spawn};
|
||||
use crate::sessions::{run_kill, run_list, run_send, run_spawn};
|
||||
use maestro_config::{default_config_path, MaestroConfigFile};
|
||||
|
||||
#[derive(Debug, thiserror::Error)]
|
||||
@@ -24,6 +24,10 @@ pub enum CliError {
|
||||
Attach(#[from] crate::attach::AttachError),
|
||||
#[error("{0}")]
|
||||
Hooks(#[from] maestro_hooks::HooksError),
|
||||
#[error("{0}")]
|
||||
Resolve(#[from] crate::sessions::ResolveError),
|
||||
#[error("nothing to send: pass the text as arguments or pipe it on stdin")]
|
||||
NothingToSend,
|
||||
#[error("could not determine the home directory ($HOME unset?)")]
|
||||
NoHome,
|
||||
#[error("{0}")]
|
||||
@@ -82,6 +86,10 @@ pub async fn dispatch(
|
||||
run_kill(&daemon, &args).await?;
|
||||
println!("killed {}", args.session_id);
|
||||
}
|
||||
Command::Send(args) => {
|
||||
let id = run_send(&daemon, &args, &mut std::io::stdin()).await?;
|
||||
println!("sent to {id}");
|
||||
}
|
||||
Command::Hooks(_) => unreachable!("hooks handled before the daemon client exists"),
|
||||
}
|
||||
Ok(())
|
||||
|
||||
@@ -5,12 +5,13 @@ use std::io::Write;
|
||||
|
||||
use maestro_protocol::display::abbreviate_dir;
|
||||
use maestro_protocol::{
|
||||
ActivityState, ClientError, CreateSessionRequest, DaemonClient, DaemonInfo, Session,
|
||||
SessionStatus, WorktreeSpec,
|
||||
ActivityState, ClientError, CreateSessionRequest, DaemonClient, DaemonInfo, SendInputRequest,
|
||||
Session, SessionStatus, WorktreeSpec,
|
||||
};
|
||||
use serde_json::Value;
|
||||
|
||||
use crate::cli::{KillArgs, ListArgs, SpawnArgs};
|
||||
use crate::cli::{KillArgs, ListArgs, SendArgs, SpawnArgs};
|
||||
use crate::dispatch::CliError;
|
||||
|
||||
/// `maestro list`
|
||||
pub async fn run_list(
|
||||
@@ -66,6 +67,92 @@ pub async fn run_kill(client: &DaemonClient, args: &KillArgs) -> Result<(), Clie
|
||||
client.kill_session(args.session_id, args.force).await
|
||||
}
|
||||
|
||||
/// Nothing on the daemon answers to what the operator named.
|
||||
#[derive(Debug, thiserror::Error)]
|
||||
pub enum ResolveError {
|
||||
#[error("no session matches {0:?} — run `maestro list` to see what is running")]
|
||||
NoMatch(String),
|
||||
#[error("{0:?} matches {1} sessions; use a session id instead")]
|
||||
Ambiguous(String, usize),
|
||||
}
|
||||
|
||||
/// Turn what the operator typed into a session id: a full ID, a unique ID
|
||||
/// prefix, or a session's name (#125), matched case-insensitively. Names come
|
||||
/// first — an operator who named a session after a hex string meant the name.
|
||||
pub fn resolve_session(sessions: &[Session], needle: &str) -> Result<uuid::Uuid, ResolveError> {
|
||||
let needle = needle.trim();
|
||||
let by_name: Vec<&Session> = sessions
|
||||
.iter()
|
||||
.filter(|s| {
|
||||
maestro_protocol::display::custom_name(s)
|
||||
.is_some_and(|n| n.eq_ignore_ascii_case(needle))
|
||||
})
|
||||
.collect();
|
||||
match by_name.len() {
|
||||
1 => return Ok(by_name[0].id),
|
||||
0 => {}
|
||||
n => return Err(ResolveError::Ambiguous(needle.to_string(), n)),
|
||||
}
|
||||
|
||||
let by_id: Vec<&Session> = sessions
|
||||
.iter()
|
||||
.filter(|s| {
|
||||
s.id.to_string()
|
||||
.to_ascii_lowercase()
|
||||
.starts_with(&needle.to_ascii_lowercase())
|
||||
})
|
||||
.collect();
|
||||
match by_id.len() {
|
||||
1 => Ok(by_id[0].id),
|
||||
0 => Err(ResolveError::NoMatch(needle.to_string())),
|
||||
n => Err(ResolveError::Ambiguous(needle.to_string(), n)),
|
||||
}
|
||||
}
|
||||
|
||||
/// `maestro send`. Answers with the session that was typed into, so the
|
||||
/// caller can name it once the daemon has accepted the text.
|
||||
///
|
||||
/// A bare ID skips the catalog fetch; anything else needs the list to match
|
||||
/// against. Text comes from the arguments, or from stdin when there is none —
|
||||
/// the shape a heredoc or a pipe wants.
|
||||
#[allow(clippy::result_large_err)]
|
||||
pub async fn run_send(
|
||||
client: &DaemonClient,
|
||||
args: &SendArgs,
|
||||
stdin: &mut impl std::io::Read,
|
||||
) -> Result<uuid::Uuid, CliError> {
|
||||
let text = if args.text.is_empty() {
|
||||
let mut buf = String::new();
|
||||
stdin.read_to_string(&mut buf)?;
|
||||
// One trailing newline is how a pipe ends, not part of the message —
|
||||
// keeping it would submit the text twice.
|
||||
buf.strip_suffix('\n')
|
||||
.map(|t| t.strip_suffix('\r').unwrap_or(t))
|
||||
.unwrap_or(&buf)
|
||||
.to_string()
|
||||
} else {
|
||||
args.text.join(" ")
|
||||
};
|
||||
if text.is_empty() {
|
||||
return Err(CliError::NothingToSend);
|
||||
}
|
||||
|
||||
let id = match uuid::Uuid::parse_str(args.session.trim()) {
|
||||
Ok(id) => id,
|
||||
Err(_) => {
|
||||
let sessions = client.list_sessions().await?;
|
||||
resolve_session(&sessions, &args.session)?
|
||||
}
|
||||
};
|
||||
|
||||
let req = SendInputRequest {
|
||||
text,
|
||||
submit: !args.no_enter,
|
||||
};
|
||||
client.send_input(id, &req).await?;
|
||||
Ok(id)
|
||||
}
|
||||
|
||||
#[allow(clippy::write_literal)]
|
||||
fn print_session_table(out: &mut impl Write, sessions: &[Session], info: &DaemonInfo) {
|
||||
if sessions.is_empty() {
|
||||
@@ -218,6 +305,63 @@ mod tests {
|
||||
assert!(out.contains("bash [claude]"), "{out}");
|
||||
}
|
||||
|
||||
fn named(id: u128, name: &str) -> Session {
|
||||
let mut s = session("/tmp", "claude", id);
|
||||
s.metadata
|
||||
.insert("name".into(), serde_json::Value::String(name.into()));
|
||||
s
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn resolves_by_name_id_prefix_and_reports_what_it_cannot() {
|
||||
use super::{resolve_session, ResolveError};
|
||||
|
||||
// Ids that differ in their first characters, so a short prefix is
|
||||
// enough to pick one — the ergonomics the prefix match exists for.
|
||||
let (a, b) = (1u128 << 124, 2u128 << 124);
|
||||
let sessions = vec![named(a, "planner"), named(b, "builder")];
|
||||
let one = Uuid::from_u128(a);
|
||||
|
||||
assert_eq!(resolve_session(&sessions, "planner").unwrap(), one);
|
||||
// Names match case-insensitively and ignore surrounding space.
|
||||
assert_eq!(resolve_session(&sessions, " Planner ").unwrap(), one);
|
||||
// An id prefix works when it picks exactly one session.
|
||||
let prefix = &one.to_string()[..8];
|
||||
assert_eq!(resolve_session(&sessions, prefix).unwrap(), one);
|
||||
assert!(matches!(
|
||||
resolve_session(&sessions, "nope"),
|
||||
Err(ResolveError::NoMatch(_))
|
||||
));
|
||||
}
|
||||
|
||||
/// Two sessions sharing a name is legal — the daemon never enforced
|
||||
/// uniqueness — so `send` must refuse rather than pick one.
|
||||
#[test]
|
||||
fn an_ambiguous_name_is_refused() {
|
||||
use super::{resolve_session, ResolveError};
|
||||
|
||||
let sessions = vec![named(1 << 124, "worker"), named(2 << 124, "worker")];
|
||||
assert!(matches!(
|
||||
resolve_session(&sessions, "worker"),
|
||||
Err(ResolveError::Ambiguous(_, 2))
|
||||
));
|
||||
}
|
||||
|
||||
/// A session named after its own id prefix means the name: an operator
|
||||
/// who typed a name they chose should not be routed by hex coincidence.
|
||||
#[test]
|
||||
fn names_win_over_id_prefixes() {
|
||||
use super::resolve_session;
|
||||
|
||||
let two = Uuid::from_u128(2 << 124);
|
||||
let prefix = two.to_string()[..8].to_string();
|
||||
let sessions = vec![named(1 << 124, &prefix), session("/tmp", "bash", 2 << 124)];
|
||||
assert_eq!(
|
||||
resolve_session(&sessions, &prefix).unwrap(),
|
||||
Uuid::from_u128(1 << 124)
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn empty_sessions() {
|
||||
let mut buf = Vec::new();
|
||||
|
||||
@@ -29,6 +29,7 @@ async fn info_carries_version_and_presets() {
|
||||
label: "Claude".into(),
|
||||
command: "claude".into(),
|
||||
}],
|
||||
..Default::default()
|
||||
});
|
||||
|
||||
let info = mock.client().daemon_info().await.expect("info");
|
||||
@@ -108,3 +109,110 @@ async fn spawn_round_trips_through_the_daemon() {
|
||||
.expect("kill");
|
||||
assert_eq!(mock.session_count(), 0);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn send_types_text_and_submits_by_default() {
|
||||
let mock = MockDaemon::start().await;
|
||||
let id = Uuid::from_u128(7);
|
||||
mock.add_session(session(id, "/home/mock/work", "claude"));
|
||||
|
||||
let args = maestro_cli::cli::SendArgs {
|
||||
session: id.to_string(),
|
||||
text: vec!["run".into(), "the".into(), "tests".into()],
|
||||
no_enter: false,
|
||||
};
|
||||
let sent = maestro_cli::sessions::run_send(&mock.client(), &args, &mut std::io::empty())
|
||||
.await
|
||||
.expect("send");
|
||||
|
||||
assert_eq!(sent, id);
|
||||
let inputs = mock.inputs();
|
||||
assert_eq!(inputs.len(), 1);
|
||||
assert_eq!(inputs[0].0, id);
|
||||
assert_eq!(inputs[0].1.text, "run the tests");
|
||||
assert!(inputs[0].1.submit, "Enter is the default");
|
||||
}
|
||||
|
||||
/// `--no-enter` leaves the text in the prompt; the flag has to survive the
|
||||
/// whole way to the daemon or the message is sent anyway.
|
||||
#[tokio::test]
|
||||
async fn send_without_enter_leaves_the_text_unsubmitted() {
|
||||
let mock = MockDaemon::start().await;
|
||||
let id = Uuid::from_u128(8);
|
||||
mock.add_session(session(id, "/tmp", "bash"));
|
||||
|
||||
let args = maestro_cli::cli::SendArgs {
|
||||
session: id.to_string(),
|
||||
text: vec!["ls".into()],
|
||||
no_enter: true,
|
||||
};
|
||||
maestro_cli::sessions::run_send(&mock.client(), &args, &mut std::io::empty())
|
||||
.await
|
||||
.expect("send");
|
||||
|
||||
assert!(!mock.inputs()[0].1.submit);
|
||||
}
|
||||
|
||||
/// No text arguments → the message comes from stdin, minus the trailing
|
||||
/// newline a pipe or heredoc adds.
|
||||
#[tokio::test]
|
||||
async fn send_reads_stdin_and_drops_its_trailing_newline() {
|
||||
let mock = MockDaemon::start().await;
|
||||
let id = Uuid::from_u128(9);
|
||||
mock.add_session(session(id, "/tmp", "bash"));
|
||||
|
||||
let args = maestro_cli::cli::SendArgs {
|
||||
session: id.to_string(),
|
||||
text: Vec::new(),
|
||||
no_enter: false,
|
||||
};
|
||||
let mut stdin = std::io::Cursor::new(b"multi\nline\n".to_vec());
|
||||
maestro_cli::sessions::run_send(&mock.client(), &args, &mut stdin)
|
||||
.await
|
||||
.expect("send");
|
||||
|
||||
assert_eq!(mock.inputs()[0].1.text, "multi\nline");
|
||||
}
|
||||
|
||||
/// A session named through `PATCH /api/sessions/:id` is addressable by that
|
||||
/// name, so scripts don't have to carry a UUID around.
|
||||
#[tokio::test]
|
||||
async fn send_resolves_a_session_by_name() {
|
||||
let mock = MockDaemon::start().await;
|
||||
let id = Uuid::from_u128(10);
|
||||
let mut named = session(id, "/tmp", "claude");
|
||||
named
|
||||
.metadata
|
||||
.insert("name".into(), serde_json::Value::String("planner".into()));
|
||||
mock.add_session(named);
|
||||
mock.add_session(session(Uuid::from_u128(11), "/tmp", "bash"));
|
||||
|
||||
let args = maestro_cli::cli::SendArgs {
|
||||
session: "Planner".into(),
|
||||
text: vec!["go".into()],
|
||||
no_enter: false,
|
||||
};
|
||||
let sent = maestro_cli::sessions::run_send(&mock.client(), &args, &mut std::io::empty())
|
||||
.await
|
||||
.expect("send");
|
||||
|
||||
assert_eq!(sent, id);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn send_to_an_unknown_session_fails_without_typing_anything() {
|
||||
let mock = MockDaemon::start().await;
|
||||
mock.add_session(session(Uuid::from_u128(12), "/tmp", "bash"));
|
||||
|
||||
let args = maestro_cli::cli::SendArgs {
|
||||
session: "nope".into(),
|
||||
text: vec!["hi".into()],
|
||||
no_enter: false,
|
||||
};
|
||||
let err = maestro_cli::sessions::run_send(&mock.client(), &args, &mut std::io::empty())
|
||||
.await
|
||||
.expect_err("should not resolve");
|
||||
|
||||
assert!(err.to_string().contains("no session matches"), "{err}");
|
||||
assert!(mock.inputs().is_empty());
|
||||
}
|
||||
|
||||
@@ -174,10 +174,20 @@ pub struct TuiSection {
|
||||
/// Palette presets supported by the TUI's `[tui].theme` setting.
|
||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||
pub enum TuiTheme {
|
||||
/// The terminal-native dark palette and the default.
|
||||
/// The graphite dark palette and the default.
|
||||
Dark,
|
||||
/// A high-contrast light palette.
|
||||
Light,
|
||||
/// Ice Cyan — cyan accent on the graphite base.
|
||||
IceCyan,
|
||||
/// Periwinkle — indigo base, blue-violet accent.
|
||||
Periwinkle,
|
||||
/// Amber Phosphor — CRT amber on warm graphite.
|
||||
AmberPhosphor,
|
||||
/// Ember — warm orange-red accent.
|
||||
Ember,
|
||||
/// Orchid — muted violet accent.
|
||||
Orchid,
|
||||
/// Named ANSI colours, allowing the terminal to provide the colour set.
|
||||
Ansi,
|
||||
/// Solarized Dark.
|
||||
@@ -204,6 +214,11 @@ pub enum TuiTheme {
|
||||
pub const TUI_THEMES: &[(&str, TuiTheme)] = &[
|
||||
("dark", TuiTheme::Dark),
|
||||
("light", TuiTheme::Light),
|
||||
("ice-cyan", TuiTheme::IceCyan),
|
||||
("periwinkle", TuiTheme::Periwinkle),
|
||||
("amber-phosphor", TuiTheme::AmberPhosphor),
|
||||
("ember", TuiTheme::Ember),
|
||||
("orchid", TuiTheme::Orchid),
|
||||
("ansi", TuiTheme::Ansi),
|
||||
("solarized-dark", TuiTheme::SolarizedDark),
|
||||
("solarized-light", TuiTheme::SolarizedLight),
|
||||
|
||||
@@ -0,0 +1,77 @@
|
||||
//! Stamps the daemon binary with the commit it was built from, so
|
||||
//! `GET /api/info` can tell clients which release they are talking to.
|
||||
//!
|
||||
//! Two sources, in order:
|
||||
//!
|
||||
//! 1. `MAESTRO_BUILD_COMMIT` / `MAESTRO_BUILD_DATE` / `MAESTRO_BUILD_DIRTY` in
|
||||
//! the environment. The Nix build has no `.git` in its source tree (crane
|
||||
//! filters it out), so `flake.nix` passes the flake's own revision this way.
|
||||
//! 2. The git checkout the crate is being compiled in.
|
||||
//!
|
||||
//! Neither available leaves the values empty; clients treat that as "unknown
|
||||
//! release" rather than an error.
|
||||
|
||||
use std::path::PathBuf;
|
||||
use std::process::Command;
|
||||
|
||||
fn main() {
|
||||
println!("cargo:rerun-if-env-changed=MAESTRO_BUILD_COMMIT");
|
||||
println!("cargo:rerun-if-env-changed=MAESTRO_BUILD_DATE");
|
||||
println!("cargo:rerun-if-env-changed=MAESTRO_BUILD_DIRTY");
|
||||
// Rebuild when HEAD moves, so a plain `cargo build` after a commit or a
|
||||
// branch switch restamps instead of serving the previous hash.
|
||||
for f in ["HEAD", "ORIG_HEAD"] {
|
||||
if let Some(p) = git_dir().map(|d| d.join(f)) {
|
||||
if p.exists() {
|
||||
println!("cargo:rerun-if-changed={}", p.display());
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
let commit = env_or_git("MAESTRO_BUILD_COMMIT", &["rev-parse", "--short=12", "HEAD"]);
|
||||
let date = env_or_git("MAESTRO_BUILD_DATE", &["log", "-1", "--format=%cI"]);
|
||||
let dirty = match std::env::var("MAESTRO_BUILD_DIRTY") {
|
||||
Ok(v) => v == "1" || v.eq_ignore_ascii_case("true"),
|
||||
Err(_) => !git(&["status", "--porcelain"])
|
||||
.unwrap_or_default()
|
||||
.is_empty(),
|
||||
};
|
||||
|
||||
println!("cargo:rustc-env=MAESTRO_BUILD_COMMIT={commit}");
|
||||
println!("cargo:rustc-env=MAESTRO_BUILD_DATE={date}");
|
||||
println!("cargo:rustc-env=MAESTRO_BUILD_DIRTY={dirty}");
|
||||
}
|
||||
|
||||
/// The environment variable if set and non-empty, else what git reports, else
|
||||
/// an empty string.
|
||||
fn env_or_git(var: &str, args: &[&str]) -> String {
|
||||
match std::env::var(var) {
|
||||
Ok(v) if !v.trim().is_empty() => v.trim().to_string(),
|
||||
_ => git(args).unwrap_or_default(),
|
||||
}
|
||||
}
|
||||
|
||||
/// Run `git` inside the crate's source tree. `None` when git is missing, the
|
||||
/// tree is not a checkout, or the command fails — every one of which is a
|
||||
/// legitimate way to build Maestro.
|
||||
fn git(args: &[&str]) -> Option<String> {
|
||||
let out = Command::new("git")
|
||||
.args(args)
|
||||
.current_dir(env!("CARGO_MANIFEST_DIR"))
|
||||
.output()
|
||||
.ok()?;
|
||||
if !out.status.success() {
|
||||
return None;
|
||||
}
|
||||
Some(String::from_utf8_lossy(&out.stdout).trim().to_string())
|
||||
}
|
||||
|
||||
/// Absolute path of the `.git` directory (a worktree's `.git` is a file
|
||||
/// pointing elsewhere, and `--git-common-dir` resolves both).
|
||||
fn git_dir() -> Option<PathBuf> {
|
||||
let dir = git(&["rev-parse", "--path-format=absolute", "--git-common-dir"])?;
|
||||
if dir.is_empty() {
|
||||
return None;
|
||||
}
|
||||
Some(PathBuf::from(dir))
|
||||
}
|
||||
@@ -66,6 +66,44 @@ pub fn decide(idle_for: Duration, awaiting_input: bool) -> ActivityState {
|
||||
}
|
||||
}
|
||||
|
||||
/// How long a session's pane must be continuously focused (a client's pane,
|
||||
/// not a sidebar highlight) before an `AwaitingInput` glow clears: the
|
||||
/// operator has looked, so the rail stops asking for attention.
|
||||
pub const FOCUS_CLEAR_HOLD: Duration = Duration::from_secs(5);
|
||||
|
||||
/// Downgrade `raw` from `AwaitingInput` to `Idle` once the pane has been
|
||||
/// focused for at least [`FOCUS_CLEAR_HOLD`].
|
||||
///
|
||||
/// `suppressed` is the session's sticky acknowledgement, threaded in and
|
||||
/// mutated in place: once set, it holds even after the pane loses focus, so
|
||||
/// the state stays `Idle` until the session does new work. Only a fresh
|
||||
/// `Active` — the session actually running something again — resets it, so
|
||||
/// the *next* time inference lands on `AwaitingInput` it glows again. Losing
|
||||
/// and regaining focus alone never re-arms it.
|
||||
pub fn apply_focus_suppression(
|
||||
raw: ActivityState,
|
||||
focused_since: Option<std::time::Instant>,
|
||||
now: std::time::Instant,
|
||||
suppressed: &mut bool,
|
||||
) -> ActivityState {
|
||||
if raw == ActivityState::Active {
|
||||
*suppressed = false;
|
||||
}
|
||||
if raw != ActivityState::AwaitingInput {
|
||||
return raw;
|
||||
}
|
||||
if let Some(since) = focused_since {
|
||||
if now.saturating_duration_since(since) >= FOCUS_CLEAR_HOLD {
|
||||
*suppressed = true;
|
||||
}
|
||||
}
|
||||
if *suppressed {
|
||||
ActivityState::Idle
|
||||
} else {
|
||||
raw
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
@@ -118,4 +156,99 @@ mod tests {
|
||||
Some("short")
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn awaiting_input_glows_until_focus_hold_is_reached() {
|
||||
let now = std::time::Instant::now();
|
||||
let mut suppressed = false;
|
||||
let since = now - (FOCUS_CLEAR_HOLD - Duration::from_secs(1));
|
||||
assert_eq!(
|
||||
apply_focus_suppression(
|
||||
ActivityState::AwaitingInput,
|
||||
Some(since),
|
||||
now,
|
||||
&mut suppressed
|
||||
),
|
||||
ActivityState::AwaitingInput
|
||||
);
|
||||
assert!(!suppressed);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn awaiting_input_clears_once_focus_hold_is_reached() {
|
||||
let now = std::time::Instant::now();
|
||||
let mut suppressed = false;
|
||||
let since = now - FOCUS_CLEAR_HOLD;
|
||||
assert_eq!(
|
||||
apply_focus_suppression(
|
||||
ActivityState::AwaitingInput,
|
||||
Some(since),
|
||||
now,
|
||||
&mut suppressed
|
||||
),
|
||||
ActivityState::Idle
|
||||
);
|
||||
assert!(suppressed);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn unfocused_awaiting_input_never_clears() {
|
||||
let now = std::time::Instant::now();
|
||||
let mut suppressed = false;
|
||||
assert_eq!(
|
||||
apply_focus_suppression(ActivityState::AwaitingInput, None, now, &mut suppressed),
|
||||
ActivityState::AwaitingInput
|
||||
);
|
||||
assert!(!suppressed);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn suppression_survives_losing_focus() {
|
||||
let now = std::time::Instant::now();
|
||||
let mut suppressed = true;
|
||||
// Focus dropped (`None`) but the session hasn't done new work.
|
||||
assert_eq!(
|
||||
apply_focus_suppression(ActivityState::AwaitingInput, None, now, &mut suppressed),
|
||||
ActivityState::Idle
|
||||
);
|
||||
assert!(suppressed);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn a_fresh_active_cycle_clears_the_suppression() {
|
||||
let now = std::time::Instant::now();
|
||||
let mut suppressed = true;
|
||||
assert_eq!(
|
||||
apply_focus_suppression(ActivityState::Active, None, now, &mut suppressed),
|
||||
ActivityState::Active
|
||||
);
|
||||
assert!(!suppressed);
|
||||
|
||||
// Blocked again, freshly focused: glows until the hold is reached again.
|
||||
assert_eq!(
|
||||
apply_focus_suppression(
|
||||
ActivityState::AwaitingInput,
|
||||
Some(now),
|
||||
now,
|
||||
&mut suppressed
|
||||
),
|
||||
ActivityState::AwaitingInput
|
||||
);
|
||||
assert!(!suppressed);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn idle_and_error_pass_through_untouched() {
|
||||
let now = std::time::Instant::now();
|
||||
let mut suppressed = false;
|
||||
assert_eq!(
|
||||
apply_focus_suppression(ActivityState::Idle, Some(now), now, &mut suppressed),
|
||||
ActivityState::Idle
|
||||
);
|
||||
assert_eq!(
|
||||
apply_focus_suppression(ActivityState::Error, Some(now), now, &mut suppressed),
|
||||
ActivityState::Error
|
||||
);
|
||||
assert!(!suppressed);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -20,6 +20,7 @@ pub mod panes;
|
||||
pub mod proc;
|
||||
pub mod projects;
|
||||
pub mod pty;
|
||||
pub mod release;
|
||||
pub mod session;
|
||||
pub mod sidecar;
|
||||
pub mod spawn_history;
|
||||
|
||||
@@ -20,7 +20,8 @@ use axum::{Json, Router};
|
||||
use maestro_config::SpawnPreset;
|
||||
use maestro_protocol::{
|
||||
routes, ApiError, CatalogEvent, CreateSessionRequest, DaemonInfo, GitRoot, NameBatch,
|
||||
RenameSessionRequest, ReportActivityRequest, Session, PROTOCOL_VERSION,
|
||||
RenameSessionRequest, ReportActivityRequest, SendInputRequest, Session, SetFocusRequest,
|
||||
PROTOCOL_VERSION,
|
||||
};
|
||||
use serde::Deserialize;
|
||||
use uuid::Uuid;
|
||||
@@ -44,6 +45,8 @@ pub fn router(state: LocalApiState) -> Router {
|
||||
Router::new()
|
||||
.route(routes::SESSIONS, get(list_sessions).post(create_session))
|
||||
.route(routes::patterns::SESSION_ACTIVITY, post(report_activity))
|
||||
.route(routes::patterns::SESSION_INPUT, post(send_input))
|
||||
.route(routes::patterns::SESSION_FOCUS, post(set_focus))
|
||||
.route(
|
||||
routes::patterns::SESSION,
|
||||
delete(kill_session).patch(rename_session),
|
||||
@@ -100,6 +103,9 @@ fn session_error_status(code: &str) -> StatusCode {
|
||||
"invalid_env" => StatusCode::BAD_REQUEST,
|
||||
// A guard refusal is the daemon doing its job, not a failure (#79).
|
||||
"kill_guarded" => StatusCode::CONFLICT,
|
||||
// The session outlived its pane: nothing to type into, and nothing
|
||||
// the daemon can do about it.
|
||||
"not_running" => StatusCode::CONFLICT,
|
||||
_ => StatusCode::BAD_GATEWAY,
|
||||
}
|
||||
}
|
||||
@@ -137,7 +143,7 @@ struct NamesQuery {
|
||||
}
|
||||
|
||||
/// Fresh session handles for the spawn form's instant reroll (#53). The web
|
||||
/// client fetches one batch per draft pane and rerolls locally from it.
|
||||
/// client fetches one batch per spawn form and rerolls locally from it.
|
||||
async fn names(Query(q): Query<NamesQuery>) -> Json<NameBatch> {
|
||||
let count = q.count.unwrap_or(1).clamp(1, maestro_names::MAX_BATCH);
|
||||
Json(NameBatch {
|
||||
@@ -151,6 +157,8 @@ async fn daemon_info(State(s): State<LocalApiState>) -> Json<DaemonInfo> {
|
||||
version: PROTOCOL_VERSION.into(),
|
||||
home_dir: (*s.home_dir).clone(),
|
||||
presets: (*s.presets).clone(),
|
||||
build: crate::release::build_info(),
|
||||
instance: crate::release::instance_id().to_string(),
|
||||
})
|
||||
}
|
||||
|
||||
@@ -247,6 +255,50 @@ async fn report_activity(
|
||||
}
|
||||
}
|
||||
|
||||
/// `POST /api/sessions/:id/input`: type text into a session's pane, then
|
||||
/// press Enter unless the request turns `submit` off. Answers `204 No
|
||||
/// Content`. A session that has exited is refused (409) rather than accepted
|
||||
/// into nowhere.
|
||||
async fn send_input(
|
||||
State(s): State<LocalApiState>,
|
||||
Path(id): Path<Uuid>,
|
||||
Json(body): Json<SendInputRequest>,
|
||||
) -> Response {
|
||||
match s.manager.send_input(id, &body.text, body.submit).await {
|
||||
Ok(()) => StatusCode::NO_CONTENT.into_response(),
|
||||
Err(e) => {
|
||||
let info = e.to_error_info();
|
||||
error_response(
|
||||
session_error_status(&info.code),
|
||||
info.code.as_str(),
|
||||
info.message.as_str(),
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// `POST /api/sessions/:id/focus`: a client reports whether its pane is the
|
||||
/// one currently showing this session — read on the next activity tick to
|
||||
/// decide whether an `AwaitingInput` glow has been looked at long enough to
|
||||
/// clear (docs/SIDEBAR.md). Unknown session is 404. Answers `204 No Content`.
|
||||
async fn set_focus(
|
||||
State(s): State<LocalApiState>,
|
||||
Path(id): Path<Uuid>,
|
||||
Json(body): Json<SetFocusRequest>,
|
||||
) -> Response {
|
||||
match s.manager.set_focused(id, body.focused).await {
|
||||
Ok(()) => StatusCode::NO_CONTENT.into_response(),
|
||||
Err(e) => {
|
||||
let info = e.to_error_info();
|
||||
error_response(
|
||||
session_error_status(&info.code),
|
||||
info.code.as_str(),
|
||||
info.message.as_str(),
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn error_response(status: StatusCode, code: &str, message: &str) -> Response {
|
||||
(status, Json(ApiError::new(code, message))).into_response()
|
||||
}
|
||||
|
||||
@@ -32,7 +32,7 @@ pub const DEFAULT_HOME_IGNORE: &[&str] =
|
||||
/// triggers a rescan.
|
||||
///
|
||||
/// A scan walks the roots and runs one `git worktree list` per hit, holding
|
||||
/// the scanner lock throughout, and clients re-request whenever a draft pane
|
||||
/// the scanner lock throughout, and clients re-request whenever a spawn form
|
||||
/// re-mounts — which `multiview.render()` does on unrelated events. Keep this
|
||||
/// comfortably longer than [`REFRESH_INTERVAL`] so the background timer is
|
||||
/// what refreshes, and a request only rescans when that timer has failed to.
|
||||
|
||||
@@ -0,0 +1,31 @@
|
||||
//! What release this daemon is, and which run of it.
|
||||
//!
|
||||
//! Two facts ride `GET /api/info` so clients can render a status indicator and
|
||||
//! survive an upgrade:
|
||||
//!
|
||||
//! * [`build_info`] — the commit the binary was compiled from, stamped by
|
||||
//! `build.rs`. Shown in the indicator's tooltip; a change across a reconnect
|
||||
//! means the operator upgraded, so a browser reloads its assets.
|
||||
//! * [`instance_id`] — a fresh id per daemon process. A change with the same
|
||||
//! commit means a plain restart, which clients ride out silently.
|
||||
|
||||
use std::sync::OnceLock;
|
||||
|
||||
use maestro_protocol::BuildInfo;
|
||||
|
||||
/// The commit this binary was built from. Every field is empty when the build
|
||||
/// happened outside a git checkout and no `MAESTRO_BUILD_*` override was given.
|
||||
pub fn build_info() -> BuildInfo {
|
||||
BuildInfo {
|
||||
commit: env!("MAESTRO_BUILD_COMMIT").to_string(),
|
||||
commit_date: env!("MAESTRO_BUILD_DATE").to_string(),
|
||||
dirty: env!("MAESTRO_BUILD_DIRTY") == "true",
|
||||
}
|
||||
}
|
||||
|
||||
/// Identity of this daemon process, stable for its lifetime and different on
|
||||
/// every start. Clients diff it across a reconnect to detect a restart.
|
||||
pub fn instance_id() -> &'static str {
|
||||
static ID: OnceLock<String> = OnceLock::new();
|
||||
ID.get_or_init(|| uuid::Uuid::new_v4().to_string())
|
||||
}
|
||||
@@ -40,6 +40,15 @@ pub const DEFAULT_LIVENESS_INTERVAL: Duration = Duration::from_secs(2);
|
||||
/// attempt, which is all #83 needs.
|
||||
pub const DEFAULT_BLOCKED_WORK_INTERVAL: Duration = Duration::from_secs(15);
|
||||
|
||||
/// Gap between the text of a `send` and the Enter that submits it.
|
||||
///
|
||||
/// Agents that run a full-screen prompt (Claude Code, opencode) coalesce a
|
||||
/// burst of input into one paste; a newline inside that burst becomes a line
|
||||
/// break in the message instead of sending it. Landing the Enter as its own
|
||||
/// write, after the reader has drained the text, is what makes the message
|
||||
/// actually go.
|
||||
const SUBMIT_DELAY: Duration = Duration::from_millis(150);
|
||||
|
||||
/// Per-session daemon-local bookkeeping that complements the public `Session`.
|
||||
#[derive(Debug)]
|
||||
pub struct SessionRecord {
|
||||
@@ -62,6 +71,15 @@ pub struct SessionRecord {
|
||||
/// (#115), so this is the observable that says its outcomes are safe to
|
||||
/// assert on. Daemon-local bookkeeping; never rides the wire.
|
||||
pub settled: bool,
|
||||
/// When a client's pane last became the one showing this session
|
||||
/// (`POST /.../focus`), `None` while unfocused. Daemon-local; never rides
|
||||
/// the wire.
|
||||
pub focused_since: Option<std::time::Instant>,
|
||||
/// Sticky acknowledgement applied by [`crate::activity::apply_focus_suppression`]:
|
||||
/// once the pane has been focused long enough to clear an `AwaitingInput`
|
||||
/// glow, this holds through focus loss until the session does new work.
|
||||
/// Daemon-local; never rides the wire.
|
||||
pub awaiting_suppressed: bool,
|
||||
}
|
||||
|
||||
#[derive(Debug, thiserror::Error)]
|
||||
@@ -78,6 +96,11 @@ pub enum SessionError {
|
||||
NotFound(Uuid),
|
||||
#[error("invalid environment variable name: {0:?}")]
|
||||
InvalidEnv(String),
|
||||
/// The session exists but its pane is gone, so there is nothing to type
|
||||
/// into. Writing to a dead session is a client bug worth reporting, unlike
|
||||
/// a stray keystroke on an attach socket, which is dropped.
|
||||
#[error("session is no longer running: {0}")]
|
||||
NotRunning(Uuid),
|
||||
/// The kill was refused (#79): the session's worktree holds unsaved work.
|
||||
/// Nothing happened — the session keeps running and the tree is untouched,
|
||||
/// so it stays the operator's handle on their own unfinished work.
|
||||
@@ -94,6 +117,7 @@ impl SessionError {
|
||||
SessionError::Io(_) => "io_failed",
|
||||
SessionError::NotFound(_) => "not_found",
|
||||
SessionError::InvalidEnv(_) => "invalid_env",
|
||||
SessionError::NotRunning(_) => "not_running",
|
||||
SessionError::KillGuarded(_) => "kill_guarded",
|
||||
};
|
||||
let unsaved_work = match self {
|
||||
@@ -441,6 +465,8 @@ impl SessionManager {
|
||||
bridge,
|
||||
reported_activity: None,
|
||||
settled: false,
|
||||
focused_since: None,
|
||||
awaiting_suppressed: false,
|
||||
},
|
||||
);
|
||||
}
|
||||
@@ -644,6 +670,8 @@ impl SessionManager {
|
||||
bridge,
|
||||
reported_activity: None,
|
||||
settled: false,
|
||||
focused_since: None,
|
||||
awaiting_suppressed: false,
|
||||
},
|
||||
);
|
||||
let _ = self
|
||||
@@ -671,6 +699,33 @@ impl SessionManager {
|
||||
.map_err(SessionError::Tmux)
|
||||
}
|
||||
|
||||
/// Type `text` into a session's pane, with an Enter after it when
|
||||
/// `submit` is set.
|
||||
///
|
||||
/// Unlike [`Self::send_keys`], a dead session is an error: the caller
|
||||
/// asked for text to land somewhere, and a silent success would let a
|
||||
/// script believe an agent had been told something it never heard.
|
||||
pub async fn send_input(&self, id: Uuid, text: &str, submit: bool) -> Result<(), SessionError> {
|
||||
match self.status(id).await {
|
||||
None => return Err(SessionError::NotFound(id)),
|
||||
Some(SessionStatus::Dead) => return Err(SessionError::NotRunning(id)),
|
||||
Some(SessionStatus::Running) => {}
|
||||
}
|
||||
let tmux = self.inner.tmux.clone();
|
||||
let bytes = text.as_bytes().to_vec();
|
||||
tmux_blocking(move || tmux.send_keys(id, &bytes))
|
||||
.await
|
||||
.map_err(SessionError::Tmux)?;
|
||||
if submit {
|
||||
tokio::time::sleep(SUBMIT_DELAY).await;
|
||||
let tmux = self.inner.tmux.clone();
|
||||
tmux_blocking(move || tmux.send_keys(id, b"\r"))
|
||||
.await
|
||||
.map_err(SessionError::Tmux)?;
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
|
||||
/// Resize a session's window. No-op for a dead session, as with
|
||||
/// [`Self::send_keys`].
|
||||
pub async fn resize(&self, id: Uuid, cols: u16, rows: u16) -> Result<(), SessionError> {
|
||||
@@ -757,6 +812,17 @@ impl SessionManager {
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
|
||||
/// Record whether a client's pane is currently showing `id`. Read by the
|
||||
/// activity pass's next tick to decide whether an `AwaitingInput` glow
|
||||
/// has been looked at long enough to clear (`apply_focus_suppression`).
|
||||
/// An unknown session is [`SessionError::NotFound`].
|
||||
pub async fn set_focused(&self, id: Uuid, focused: bool) -> Result<(), SessionError> {
|
||||
let mut sessions = self.inner.sessions.lock().await;
|
||||
let rec = sessions.get_mut(&id).ok_or(SessionError::NotFound(id))?;
|
||||
rec.focused_since = focused.then(std::time::Instant::now);
|
||||
Ok(())
|
||||
}
|
||||
}
|
||||
|
||||
/// Run a blocking `tmux` subprocess call on the blocking thread pool so it
|
||||
@@ -913,10 +979,19 @@ async fn run_activity_pass(inner: &Arc<Inner>) {
|
||||
// #105: while a report is in force it supplies the state and
|
||||
// nothing here may overwrite it; only an unreported session is
|
||||
// decided by inference.
|
||||
let activity = match &rec.reported_activity {
|
||||
let raw_activity = match &rec.reported_activity {
|
||||
Some(report) => report.state,
|
||||
None => crate::activity::decide(idle, awaiting),
|
||||
};
|
||||
// A pane looked at long enough clears an `AwaitingInput` glow
|
||||
// (docs/SIDEBAR.md); the acknowledgement is sticky until the
|
||||
// session does new work again.
|
||||
let activity = crate::activity::apply_focus_suppression(
|
||||
raw_activity,
|
||||
rec.focused_since,
|
||||
std::time::Instant::now(),
|
||||
&mut rec.awaiting_suppressed,
|
||||
);
|
||||
let foreground = Some(pane.command.clone());
|
||||
// The pane's live cwd, drives the dir-based session tree; empty means
|
||||
// tmux reported none.
|
||||
|
||||
@@ -91,6 +91,35 @@ async fn info_returns_daemon_identity() {
|
||||
assert!(resp["version"].is_string());
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn info_reports_build_and_instance() {
|
||||
// The status indicator needs a release to name and a process to compare
|
||||
// against after a reconnect. `commit`/`commit_date` are empty when the
|
||||
// binary was built outside a checkout, so only their presence is asserted;
|
||||
// `instance` is a fresh uuid per daemon process.
|
||||
let h = spawn("naps-laptop").await;
|
||||
let resp: serde_json::Value = reqwest::get(url(h.addr, "/api/info"))
|
||||
.await
|
||||
.unwrap()
|
||||
.json()
|
||||
.await
|
||||
.unwrap();
|
||||
assert!(resp["build"]["commit"].is_string());
|
||||
assert!(resp["build"]["commit_date"].is_string());
|
||||
assert!(resp["build"]["dirty"].is_boolean());
|
||||
let instance = resp["instance"].as_str().unwrap();
|
||||
assert!(Uuid::parse_str(instance).is_ok(), "instance is a uuid");
|
||||
|
||||
// Same process, same id — a client only treats a *changed* id as a restart.
|
||||
let again: serde_json::Value = reqwest::get(url(h.addr, "/api/info"))
|
||||
.await
|
||||
.unwrap()
|
||||
.json()
|
||||
.await
|
||||
.unwrap();
|
||||
assert_eq!(again["instance"].as_str().unwrap(), instance);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn list_sessions_starts_empty_and_reflects_creates() {
|
||||
let h = spawn("naps-laptop").await;
|
||||
|
||||
@@ -1250,6 +1250,143 @@ async fn cli_list_reads_from_daemon() {
|
||||
);
|
||||
}
|
||||
|
||||
/// `maestro send` end to end: the shipped binary, a real daemon, a real tmux
|
||||
/// pane. The shell only runs the command if the Enter arrived as its own
|
||||
/// write after the text, so the file appearing is the whole path working.
|
||||
#[tokio::test(flavor = "multi_thread")]
|
||||
async fn cli_send_types_a_command_into_a_live_shell() {
|
||||
let (daemon, client) = bring_up().await;
|
||||
let cwd = TempDir::new().unwrap();
|
||||
let sess = client
|
||||
.spawn_session(&create_req(cwd.path(), "bash --norc --noprofile"))
|
||||
.await
|
||||
.expect("spawn bash");
|
||||
|
||||
let home = TempDir::new().unwrap();
|
||||
let cfg_path = home.path().join("config.toml");
|
||||
let out = run_cli(
|
||||
&["send", &sess.id.to_string(), "touch", "marker.txt"],
|
||||
&[
|
||||
("HOME", home.path().to_str().unwrap()),
|
||||
("MAESTRO_CONFIG", cfg_path.to_str().unwrap()),
|
||||
("MAESTRO_DAEMON_URL", &daemon.http_base()),
|
||||
],
|
||||
);
|
||||
assert!(
|
||||
out.status.success(),
|
||||
"send failed: {}",
|
||||
String::from_utf8_lossy(&out.stderr)
|
||||
);
|
||||
|
||||
let marker = cwd.path().join("marker.txt");
|
||||
wait_for_async(
|
||||
"the shell runs the sent command",
|
||||
Duration::from_secs(10),
|
||||
|| {
|
||||
let marker = marker.clone();
|
||||
async move { marker.exists() }
|
||||
},
|
||||
)
|
||||
.await;
|
||||
|
||||
client.kill_session(sess.id).await.expect("kill");
|
||||
}
|
||||
|
||||
/// `--no-enter` fills the prompt without submitting: the command must sit
|
||||
/// there unrun. Same setup as the test above, so the only difference is the
|
||||
/// flag.
|
||||
#[tokio::test(flavor = "multi_thread")]
|
||||
async fn send_without_enter_does_not_run_the_command() {
|
||||
let (daemon, client) = bring_up().await;
|
||||
let cwd = TempDir::new().unwrap();
|
||||
let sess = client
|
||||
.spawn_session(&create_req(cwd.path(), "bash --norc --noprofile"))
|
||||
.await
|
||||
.expect("spawn bash");
|
||||
|
||||
let home = TempDir::new().unwrap();
|
||||
let out = run_cli(
|
||||
&[
|
||||
"send",
|
||||
"--no-enter",
|
||||
&sess.id.to_string(),
|
||||
"touch",
|
||||
"unsubmitted.txt",
|
||||
],
|
||||
&[
|
||||
("HOME", home.path().to_str().unwrap()),
|
||||
(
|
||||
"MAESTRO_CONFIG",
|
||||
home.path().join("c.toml").to_str().unwrap(),
|
||||
),
|
||||
("MAESTRO_DAEMON_URL", &daemon.http_base()),
|
||||
],
|
||||
);
|
||||
assert!(
|
||||
out.status.success(),
|
||||
"send failed: {}",
|
||||
String::from_utf8_lossy(&out.stderr)
|
||||
);
|
||||
|
||||
tokio::time::sleep(Duration::from_secs(2)).await;
|
||||
assert!(
|
||||
!cwd.path().join("unsubmitted.txt").exists(),
|
||||
"the command ran despite --no-enter"
|
||||
);
|
||||
|
||||
client.kill_session(sess.id).await.expect("kill");
|
||||
}
|
||||
|
||||
/// A session whose command exited still exists in the catalog, but its pane
|
||||
/// is gone. Typing into it is refused instead of being swallowed — a script
|
||||
/// that sends an instruction to a dead agent has to hear about it.
|
||||
#[tokio::test(flavor = "multi_thread")]
|
||||
async fn send_to_a_dead_session_is_refused() {
|
||||
use maestro_protocol::{SendInputRequest, SessionStatus};
|
||||
let (_daemon, client) = bring_up().await;
|
||||
let cwd = TempDir::new().unwrap();
|
||||
let sess = client
|
||||
.spawn_session(&create_req(cwd.path(), "true"))
|
||||
.await
|
||||
.expect("spawn true");
|
||||
|
||||
wait_for_async(
|
||||
"the session to be seen dead",
|
||||
Duration::from_secs(15),
|
||||
|| {
|
||||
let client = client.clone();
|
||||
let id = sess.id;
|
||||
async move {
|
||||
client
|
||||
.list_sessions()
|
||||
.await
|
||||
.map(|ss| {
|
||||
ss.iter()
|
||||
.any(|s| s.id == id && s.status == SessionStatus::Dead)
|
||||
})
|
||||
.unwrap_or(false)
|
||||
}
|
||||
},
|
||||
)
|
||||
.await;
|
||||
|
||||
let err = client
|
||||
.daemon()
|
||||
.send_input(
|
||||
sess.id,
|
||||
&SendInputRequest {
|
||||
text: "hello".into(),
|
||||
submit: true,
|
||||
},
|
||||
)
|
||||
.await
|
||||
.expect_err("a dead session cannot be typed into");
|
||||
assert!(
|
||||
err.to_string().contains("no longer running"),
|
||||
"unexpected error: {err}"
|
||||
);
|
||||
}
|
||||
|
||||
#[tokio::test(flavor = "multi_thread")]
|
||||
async fn cli_list_fails_when_daemon_is_down() {
|
||||
let dead_daemon = format!("http://127.0.0.1:{}", maestro_e2e::util::free_port());
|
||||
|
||||
@@ -16,7 +16,8 @@ use uuid::Uuid;
|
||||
use crate::routes::{self, UrlError};
|
||||
use crate::{
|
||||
ApiError, BranchInfo, CreateSessionRequest, DaemonInfo, DirListing, ErrorInfo, GitRoot,
|
||||
Project, RecentDirs, RenameSessionRequest, ReportActivityRequest, Session,
|
||||
Project, RecentDirs, RenameSessionRequest, ReportActivityRequest, SendInputRequest, Session,
|
||||
SetFocusRequest,
|
||||
};
|
||||
|
||||
/// Time budget for establishing a TCP connection to the daemon.
|
||||
@@ -155,6 +156,29 @@ impl DaemonClient {
|
||||
Ok(())
|
||||
}
|
||||
|
||||
/// `POST /api/sessions/:id/input`: type text into a session's pane, with
|
||||
/// an Enter after it unless `submit` is off. Answers `204 No Content`; a
|
||||
/// session that has exited is refused rather than silently accepted.
|
||||
pub async fn send_input(&self, id: Uuid, req: &SendInputRequest) -> Result<(), ClientError> {
|
||||
let resp = self
|
||||
.send(Method::POST, &routes::session_input(id), &[], Some(req))
|
||||
.await?;
|
||||
check(resp).await?;
|
||||
Ok(())
|
||||
}
|
||||
|
||||
/// `POST /api/sessions/:id/focus`: report whether this client's pane is
|
||||
/// the one currently showing `id` — not merely highlighted in a sidebar.
|
||||
/// Answers `204 No Content`.
|
||||
pub async fn set_focus(&self, id: Uuid, focused: bool) -> Result<(), ClientError> {
|
||||
let req = SetFocusRequest { focused };
|
||||
let resp = self
|
||||
.send(Method::POST, &routes::session_focus(id), &[], Some(&req))
|
||||
.await?;
|
||||
check(resp).await?;
|
||||
Ok(())
|
||||
}
|
||||
|
||||
pub async fn daemon_info(&self) -> Result<DaemonInfo, ClientError> {
|
||||
self.get(routes::INFO, &[]).await
|
||||
}
|
||||
|
||||
@@ -7,6 +7,15 @@ use std::path::{Path, PathBuf};
|
||||
|
||||
use crate::Session;
|
||||
|
||||
/// The name a session was given (#125), if any. `None` for one that was never
|
||||
/// renamed — clients fall back to the command.
|
||||
pub fn custom_name(s: &Session) -> Option<&str> {
|
||||
match s.metadata.get("name") {
|
||||
Some(serde_json::Value::String(name)) => Some(name.as_str()),
|
||||
_ => None,
|
||||
}
|
||||
}
|
||||
|
||||
/// Collapse a daemon's home dir to `~`. `home` empty leaves the path
|
||||
/// untouched. Mirrors the web's `abbreviateCwd`.
|
||||
pub fn abbreviate_dir(path: &Path, home: &str) -> String {
|
||||
@@ -140,6 +149,63 @@ pub fn merge_linear<T>(folder: TreeFolder<T>) -> TreeFolder<T> {
|
||||
cur
|
||||
}
|
||||
|
||||
/// Command wrappers that run another program: the program is what follows.
|
||||
const WRAPPERS: [&str; 8] = [
|
||||
"sudo", "env", "npx", "bunx", "uvx", "pnpm", "yarn", "command",
|
||||
];
|
||||
|
||||
/// The program a command line runs, basenamed and stripped of its arguments —
|
||||
/// what a session card shows per `docs/SIDEBAR.md`, which names the program
|
||||
/// and never its flags. Leading `FOO=bar` assignments and wrappers (`sudo`,
|
||||
/// `npx`, `pnpm dlx`, …) are looked through. Mirrors the web's `splitCommand`.
|
||||
pub fn command_program(command: &str) -> String {
|
||||
let words: Vec<&str> = command.split_whitespace().collect();
|
||||
let mut i = 0;
|
||||
while i < words.len() {
|
||||
let word = words[i];
|
||||
if is_env_assignment(word) {
|
||||
i += 1;
|
||||
continue;
|
||||
}
|
||||
let wrapper = basename(word).to_lowercase();
|
||||
if WRAPPERS.contains(&wrapper.as_str()) {
|
||||
i += 1;
|
||||
if (wrapper == "pnpm" || wrapper == "yarn") && words.get(i) == Some(&"dlx") {
|
||||
i += 1;
|
||||
}
|
||||
continue;
|
||||
}
|
||||
break;
|
||||
}
|
||||
match words.get(i) {
|
||||
Some(word) => basename(word).to_string(),
|
||||
// Nothing but wrappers and assignments: say what was there rather than
|
||||
// rendering an empty fragment.
|
||||
None => command.trim().to_string(),
|
||||
}
|
||||
}
|
||||
|
||||
/// `FOO=bar`, the shell's own prefix for one command's environment.
|
||||
fn is_env_assignment(word: &str) -> bool {
|
||||
let mut chars = word.chars();
|
||||
match chars.next() {
|
||||
Some(c) if c.is_ascii_alphabetic() || c == '_' => {}
|
||||
_ => return false,
|
||||
}
|
||||
let rest: String = chars.collect();
|
||||
match rest.split_once('=') {
|
||||
Some((name, _)) => name.chars().all(|c| c.is_ascii_alphanumeric() || c == '_'),
|
||||
None => false,
|
||||
}
|
||||
}
|
||||
|
||||
fn basename(word: &str) -> &str {
|
||||
match word.rsplit_once('/') {
|
||||
Some((_, tail)) => tail,
|
||||
None => word,
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
@@ -318,4 +384,28 @@ mod tests {
|
||||
};
|
||||
assert_eq!(nested.name, "a/b");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn command_program_drops_arguments() {
|
||||
assert_eq!(
|
||||
command_program("claude --dangerously-skip-permissions"),
|
||||
"claude"
|
||||
);
|
||||
assert_eq!(command_program(" zsh -l "), "zsh");
|
||||
assert_eq!(command_program("hx src/main.rs"), "hx");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn command_program_looks_through_paths_env_and_wrappers() {
|
||||
assert_eq!(command_program("/usr/local/bin/claude -p hi"), "claude");
|
||||
assert_eq!(command_program("FOO=1 BAR=2 claude"), "claude");
|
||||
assert_eq!(command_program("npx opencode"), "opencode");
|
||||
assert_eq!(command_program("pnpm dlx opencode run"), "opencode");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn command_program_keeps_a_line_that_is_only_wrappers() {
|
||||
assert_eq!(command_program("sudo"), "sudo");
|
||||
assert_eq!(command_program(""), "");
|
||||
}
|
||||
}
|
||||
|
||||
@@ -485,6 +485,40 @@ pub struct SpawnPreset {
|
||||
pub command: String,
|
||||
}
|
||||
|
||||
/// Build provenance of the running daemon: the commit it was compiled
|
||||
/// from and when that commit was authored.
|
||||
///
|
||||
/// Clients show it in the status indicator's tooltip, and compare `commit`
|
||||
/// across a reconnect to tell an upgrade apart from a plain restart — an
|
||||
/// upgrade means the served assets changed, so a browser reloads rather than
|
||||
/// resuming against new code with an old bundle.
|
||||
///
|
||||
/// Stamped at compile time by `maestro-daemon/build.rs`, which reads the git
|
||||
/// checkout it is built in, or the `MAESTRO_BUILD_COMMIT` / `MAESTRO_BUILD_DATE`
|
||||
/// environment variables when there is no checkout (the Nix build). Every field
|
||||
/// is empty when neither is available; clients must render that gracefully.
|
||||
#[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
|
||||
pub struct BuildInfo {
|
||||
/// Abbreviated commit hash the binary was built from. Empty if unknown.
|
||||
#[serde(default)]
|
||||
pub commit: String,
|
||||
/// Commit date of `commit`, RFC 3339 (`2026-09-02T14:03:11+01:00`). Empty
|
||||
/// if unknown.
|
||||
#[serde(default)]
|
||||
pub commit_date: String,
|
||||
/// Whether the working tree carried uncommitted changes at build time.
|
||||
#[serde(default)]
|
||||
pub dirty: bool,
|
||||
}
|
||||
|
||||
impl BuildInfo {
|
||||
/// Whether anything is known about this build. A client with `false` here
|
||||
/// shows the indicator without a release line rather than an empty one.
|
||||
pub fn is_known(&self) -> bool {
|
||||
!self.commit.is_empty()
|
||||
}
|
||||
}
|
||||
|
||||
/// Payload of `GET /api/info` — daemon identity, protocol version, and the
|
||||
/// spawn presets clients render as one-click tiles.
|
||||
///
|
||||
@@ -503,6 +537,15 @@ pub struct DaemonInfo {
|
||||
pub home_dir: String,
|
||||
#[serde(default)]
|
||||
pub presets: Vec<SpawnPreset>,
|
||||
/// Which commit this daemon was built from.
|
||||
#[serde(default)]
|
||||
pub build: BuildInfo,
|
||||
/// Identity of this daemon *process*, regenerated on every start. Two
|
||||
/// replies carrying different ids mean the daemon restarted in between —
|
||||
/// which is how a client that lost its socket tells a restart from a
|
||||
/// network blip, even when the build did not change.
|
||||
#[serde(default)]
|
||||
pub instance: String,
|
||||
}
|
||||
|
||||
/// Payload of `GET /api/names?count=N` (#53) — a batch of fresh
|
||||
@@ -512,6 +555,35 @@ pub struct NameBatch {
|
||||
pub names: Vec<String>,
|
||||
}
|
||||
|
||||
/// HTTP `POST /api/sessions/:id/input` body: text typed into a session's
|
||||
/// pane, as if the operator had typed it on an attached terminal.
|
||||
///
|
||||
/// `submit` presses Enter after the text — what makes `maestro send` a way to
|
||||
/// give an agent an instruction rather than only to fill its prompt. It goes
|
||||
/// out as its own write a beat later, because a TUI agent that reads the text
|
||||
/// as one paste would otherwise swallow the newline into the message.
|
||||
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
|
||||
pub struct SendInputRequest {
|
||||
pub text: String,
|
||||
#[serde(default = "submit_default")]
|
||||
pub submit: bool,
|
||||
}
|
||||
|
||||
fn submit_default() -> bool {
|
||||
true
|
||||
}
|
||||
|
||||
/// HTTP `POST /api/sessions/:id/focus` body: a client reports whether its
|
||||
/// pane is the one currently showing this session — not merely highlighted
|
||||
/// in a sidebar. The daemon keeps one focus clock per session, last write
|
||||
/// wins; a second client attached to the same session can race the first
|
||||
/// one's unfocus, which is accepted as a rare, harmless case (worst outcome
|
||||
/// is one extra tick before the glow clears).
|
||||
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
|
||||
pub struct SetFocusRequest {
|
||||
pub focused: bool,
|
||||
}
|
||||
|
||||
/// Longest session name the daemon stores (#125), in characters. A name is a
|
||||
/// sidebar card's line 1; past this it only truncates on every client anyway.
|
||||
pub const MAX_SESSION_NAME_LEN: usize = 64;
|
||||
|
||||
@@ -49,6 +49,17 @@ pub fn session_activity(id: Uuid) -> String {
|
||||
format!("{SESSIONS}/{id}/activity")
|
||||
}
|
||||
|
||||
/// `POST /api/sessions/:id/input`: type text into a session's pane.
|
||||
pub fn session_input(id: Uuid) -> String {
|
||||
format!("{SESSIONS}/{id}/input")
|
||||
}
|
||||
|
||||
/// `POST /api/sessions/:id/focus`: a client reports whether its pane is the
|
||||
/// one currently showing this session.
|
||||
pub fn session_focus(id: Uuid) -> String {
|
||||
format!("{SESSIONS}/{id}/focus")
|
||||
}
|
||||
|
||||
/// `WS /api/attach/:id` — raw PTY bytes.
|
||||
pub fn attach(id: Uuid) -> String {
|
||||
format!("{API_PREFIX}/attach/{id}")
|
||||
@@ -59,6 +70,8 @@ pub fn attach(id: Uuid) -> String {
|
||||
pub mod patterns {
|
||||
pub const SESSION: &str = "/api/sessions/:id";
|
||||
pub const SESSION_ACTIVITY: &str = "/api/sessions/:id/activity";
|
||||
pub const SESSION_INPUT: &str = "/api/sessions/:id/input";
|
||||
pub const SESSION_FOCUS: &str = "/api/sessions/:id/focus";
|
||||
pub const ATTACH: &str = "/api/attach/:id";
|
||||
}
|
||||
|
||||
@@ -170,6 +183,14 @@ mod tests {
|
||||
session_activity(id()),
|
||||
"/api/sessions/6f1a7c0e-0f5e-4a2b-9a3d-6b1c2d3e4f50/activity"
|
||||
);
|
||||
assert_eq!(
|
||||
session_input(id()),
|
||||
"/api/sessions/6f1a7c0e-0f5e-4a2b-9a3d-6b1c2d3e4f50/input"
|
||||
);
|
||||
assert_eq!(
|
||||
session_focus(id()),
|
||||
"/api/sessions/6f1a7c0e-0f5e-4a2b-9a3d-6b1c2d3e4f50/focus"
|
||||
);
|
||||
assert_eq!(
|
||||
attach(id()),
|
||||
"/api/attach/6f1a7c0e-0f5e-4a2b-9a3d-6b1c2d3e4f50"
|
||||
@@ -192,6 +213,14 @@ mod tests {
|
||||
patterns::SESSION_ACTIVITY.trim_end_matches(":id/activity"),
|
||||
session(id()).trim_end_matches(&id().to_string())
|
||||
);
|
||||
assert_eq!(
|
||||
patterns::SESSION_INPUT.trim_end_matches(":id/input"),
|
||||
session(id()).trim_end_matches(&id().to_string())
|
||||
);
|
||||
assert_eq!(
|
||||
patterns::SESSION_FOCUS.trim_end_matches(":id/focus"),
|
||||
session(id()).trim_end_matches(&id().to_string())
|
||||
);
|
||||
assert_eq!(
|
||||
patterns::ATTACH.trim_end_matches(":id"),
|
||||
attach(id()).trim_end_matches(&id().to_string())
|
||||
|
||||
@@ -16,13 +16,13 @@ use axum::extract::ws::{Message, WebSocket, WebSocketUpgrade};
|
||||
use axum::extract::{Path, Query, State};
|
||||
use axum::http::StatusCode;
|
||||
use axum::response::{IntoResponse, Response};
|
||||
use axum::routing::{any, delete, get};
|
||||
use axum::routing::{any, delete, get, post};
|
||||
use axum::{Json, Router};
|
||||
use chrono::Utc;
|
||||
use futures_util::{SinkExt, StreamExt};
|
||||
use maestro_protocol::{
|
||||
routes, ApiError, CatalogEvent, CreateSessionRequest, DaemonClient, DaemonInfo, DirListing,
|
||||
GitRoot, RecentDirs, Session, SessionStatus, PROTOCOL_VERSION,
|
||||
GitRoot, RecentDirs, SendInputRequest, Session, SessionStatus, PROTOCOL_VERSION,
|
||||
};
|
||||
use tokio::net::TcpListener;
|
||||
use tokio::sync::{broadcast, oneshot};
|
||||
@@ -55,6 +55,8 @@ struct Inner {
|
||||
info: Option<DaemonInfo>,
|
||||
/// When set, every route answers with this instead of its normal response.
|
||||
forced_error: Option<(u16, ApiError)>,
|
||||
/// Everything `POST /api/sessions/:id/input` was asked to type, in order.
|
||||
inputs: Vec<(Uuid, SendInputRequest)>,
|
||||
}
|
||||
|
||||
#[derive(Clone)]
|
||||
@@ -86,6 +88,7 @@ impl MockDaemon {
|
||||
let app = Router::new()
|
||||
.route(routes::SESSIONS, get(list_sessions).post(create_session))
|
||||
.route(routes::patterns::SESSION, delete(kill_session))
|
||||
.route(routes::patterns::SESSION_INPUT, post(send_input))
|
||||
.route(routes::INFO, get(daemon_info))
|
||||
.route(routes::DIRS, get(list_dir))
|
||||
.route(routes::RECENT_DIRS, get(recent_dirs))
|
||||
@@ -167,6 +170,11 @@ impl MockDaemon {
|
||||
self.state.inner.lock().expect("poisoned").forced_error = None;
|
||||
}
|
||||
|
||||
/// Every `send` this daemon received, oldest first.
|
||||
pub fn inputs(&self) -> Vec<(Uuid, SendInputRequest)> {
|
||||
self.state.inner.lock().expect("poisoned").inputs.clone()
|
||||
}
|
||||
|
||||
pub fn session_count(&self) -> usize {
|
||||
self.state.inner.lock().expect("poisoned").sessions.len()
|
||||
}
|
||||
@@ -233,6 +241,28 @@ async fn kill_session(State(s): State<AppState>, Path(id): Path<Uuid>) -> Respon
|
||||
StatusCode::NO_CONTENT.into_response()
|
||||
}
|
||||
|
||||
/// Records the text instead of typing it — the subject under test is the
|
||||
/// client's request, not tmux.
|
||||
async fn send_input(
|
||||
State(s): State<AppState>,
|
||||
Path(id): Path<Uuid>,
|
||||
Json(req): Json<SendInputRequest>,
|
||||
) -> Response {
|
||||
if let Some(r) = forced(&s) {
|
||||
return r;
|
||||
}
|
||||
let mut guard = s.inner.lock().expect("poisoned");
|
||||
if !guard.sessions.iter().any(|x| x.id == id) {
|
||||
return (
|
||||
StatusCode::NOT_FOUND,
|
||||
Json(ApiError::new("not_found", "no such session on this daemon")),
|
||||
)
|
||||
.into_response();
|
||||
}
|
||||
guard.inputs.push((id, req));
|
||||
StatusCode::NO_CONTENT.into_response()
|
||||
}
|
||||
|
||||
async fn daemon_info(State(s): State<AppState>) -> Response {
|
||||
if let Some(r) = forced(&s) {
|
||||
return r;
|
||||
@@ -248,6 +278,7 @@ async fn daemon_info(State(s): State<AppState>) -> Response {
|
||||
version: PROTOCOL_VERSION.into(),
|
||||
home_dir: "/home/mock".into(),
|
||||
presets: Vec::new(),
|
||||
..Default::default()
|
||||
});
|
||||
Json(info).into_response()
|
||||
}
|
||||
|
||||
@@ -43,9 +43,9 @@ pub enum Action {
|
||||
// Catalog actions on the highlighted sidebar row
|
||||
AttachHighlighted,
|
||||
ToggleAttachHighlighted,
|
||||
NewDraftPane,
|
||||
OpenSpawnModal,
|
||||
/// Fast-forward spawn (#67): spawn immediately with every default
|
||||
/// resolved; unresolvable defaults open a pre-filled draft instead.
|
||||
/// resolved; unresolvable defaults open a pre-filled form instead.
|
||||
FastForwardSpawn,
|
||||
KillHighlighted,
|
||||
/// Rename the highlighted session (#125): opens a prompt pre-filled with
|
||||
@@ -90,7 +90,7 @@ impl Action {
|
||||
Action::ToggleSidebarGroup => "Expand or collapse directory".into(),
|
||||
Action::AttachHighlighted => "Open selected item".into(),
|
||||
Action::ToggleAttachHighlighted => "Open selected item".into(),
|
||||
Action::NewDraftPane => "Create a session".into(),
|
||||
Action::OpenSpawnModal => "Create a session".into(),
|
||||
Action::FastForwardSpawn => "Create session with defaults".into(),
|
||||
Action::KillHighlighted => "Kill selected session".into(),
|
||||
Action::RenameHighlighted => "Rename selected session".into(),
|
||||
@@ -116,7 +116,7 @@ impl Action {
|
||||
"ToggleSidebarGroup" => return Ok(Action::ToggleSidebarGroup),
|
||||
"AttachHighlighted" => return Ok(Action::AttachHighlighted),
|
||||
"ToggleAttachHighlighted" => return Ok(Action::ToggleAttachHighlighted),
|
||||
"NewDraftPane" => return Ok(Action::NewDraftPane),
|
||||
"OpenSpawnModal" => return Ok(Action::OpenSpawnModal),
|
||||
"FastForwardSpawn" => return Ok(Action::FastForwardSpawn),
|
||||
"KillHighlighted" => return Ok(Action::KillHighlighted),
|
||||
"RenameHighlighted" => return Ok(Action::RenameHighlighted),
|
||||
@@ -179,7 +179,9 @@ mod tests {
|
||||
fn help_labels_are_plain_language() {
|
||||
assert_eq!(Action::EnterInsert.help_label(), "Send keys to session");
|
||||
assert_eq!(Action::AttachHighlighted.help_label(), "Open selected item");
|
||||
assert!(!Action::NewDraftPane.help_label().contains("NewDraftPane"));
|
||||
assert!(!Action::OpenSpawnModal
|
||||
.help_label()
|
||||
.contains("OpenSpawnModal"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
@@ -214,7 +216,7 @@ mod tests {
|
||||
assert_eq!(err, ActionParseError::Malformed("FocusPane(Left".into()));
|
||||
}
|
||||
|
||||
/// The fast-forward pair sits next to the draft-pane key (#67).
|
||||
/// The fast-forward pair sits next to the spawn key (#67).
|
||||
#[test]
|
||||
fn fast_forward_spawn_round_trips() {
|
||||
assert_eq!(
|
||||
@@ -243,7 +245,7 @@ mod tests {
|
||||
Action::EnterInsert,
|
||||
Action::RenameHighlighted,
|
||||
Action::Quit,
|
||||
Action::NewDraftPane,
|
||||
Action::OpenSpawnModal,
|
||||
Action::ScrollPanePageDown,
|
||||
Action::FocusPane(Direction::Right),
|
||||
] {
|
||||
@@ -252,13 +254,12 @@ mod tests {
|
||||
}
|
||||
}
|
||||
|
||||
/// The spawn modal is gone (issue #63); its old action string must not
|
||||
/// resolve to anything.
|
||||
/// Draft panes are gone; their old action string must not resolve.
|
||||
#[test]
|
||||
fn the_removed_spawn_modal_action_no_longer_parses() {
|
||||
fn the_removed_draft_pane_action_no_longer_parses() {
|
||||
assert_eq!(
|
||||
Action::parse("OpenSpawnModal").unwrap_err(),
|
||||
ActionParseError::Unknown("OpenSpawnModal".into())
|
||||
Action::parse("NewDraftPane").unwrap_err(),
|
||||
ActionParseError::Unknown("NewDraftPane".into())
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
+376
-211
File diff suppressed because it is too large
Load Diff
@@ -127,11 +127,24 @@ impl CatalogStore {
|
||||
/// apply them. Reconnects with exponential backoff on disconnect. Never
|
||||
/// returns — spawn it on a Tokio task.
|
||||
pub async fn run_events_loop(self, ws_url: String) {
|
||||
self.run_events_loop_reporting(ws_url, crate::daemon_link::DaemonLink::default())
|
||||
.await
|
||||
}
|
||||
|
||||
/// [`Self::run_events_loop`], reporting every connect and disconnect to
|
||||
/// `link` — the socket dying is the first sign the daemon went down or was
|
||||
/// upgraded under the client (`docs/RESTART.md`).
|
||||
pub async fn run_events_loop_reporting(
|
||||
self,
|
||||
ws_url: String,
|
||||
link: crate::daemon_link::DaemonLink,
|
||||
) {
|
||||
let mut backoff = Duration::from_secs(1);
|
||||
loop {
|
||||
match tokio_tungstenite::connect_async(&ws_url).await {
|
||||
Ok((ws, _resp)) => {
|
||||
backoff = Duration::from_secs(1);
|
||||
link.note_connected();
|
||||
let (_sink, mut stream) = ws.split();
|
||||
while let Some(frame) = stream.next().await {
|
||||
match frame {
|
||||
@@ -152,6 +165,7 @@ impl CatalogStore {
|
||||
tracing::debug!(error = ?e, "catalog: connect failed");
|
||||
}
|
||||
}
|
||||
link.note_disconnected(std::time::Instant::now());
|
||||
tracing::debug!(?backoff, "catalog: sleeping before reconnect");
|
||||
tokio::time::sleep(jitter(backoff)).await;
|
||||
backoff = std::cmp::min(backoff.saturating_mul(2), Duration::from_secs(30));
|
||||
|
||||
@@ -2,7 +2,9 @@
|
||||
|
||||
#[derive(Debug, clap::Args)]
|
||||
pub struct TuiArgs {
|
||||
/// Override the local daemon's HTTP base URL (default `http://127.0.0.1:7070`).
|
||||
/// Override the local daemon's HTTP base URL. Defaults to
|
||||
/// `[cli].daemon_url`, then the local `[daemon].bind_addr`, then
|
||||
/// `http://127.0.0.1:7070`.
|
||||
#[arg(long, env = "MAESTRO_DAEMON_URL")]
|
||||
pub daemon_url: Option<String>,
|
||||
}
|
||||
|
||||
@@ -48,8 +48,12 @@ const DEFAULT_NORMAL: &[(&str, &str)] = &[
|
||||
("c", "ToggleSidebarGroup"),
|
||||
// Catalog actions
|
||||
("enter", "AttachHighlighted"),
|
||||
("s", "NewDraftPane"),
|
||||
// Fast-forward spawn (#67): the draft-pane key's neighbour does the same
|
||||
// Tab focuses the highlighted pane, mirroring the web keybind — bare
|
||||
// because Normal mode only exists while the sidebar is focused, so
|
||||
// nothing forwards it to a pty.
|
||||
("tab", "AttachHighlighted"),
|
||||
("s", "OpenSpawnModal"),
|
||||
// Fast-forward spawn (#67): the spawn key's neighbour does the same
|
||||
// thing with every default resolved and no form.
|
||||
("S", "FastForwardSpawn"),
|
||||
("x", "KillHighlighted"),
|
||||
@@ -63,14 +67,17 @@ const DEFAULT_NORMAL: &[(&str, &str)] = &[
|
||||
("ctrl-w b", "ToggleSidebar"),
|
||||
("?", "ShowHelp"),
|
||||
("ctrl-w q", "Quit"),
|
||||
// Bare quit, AoE-style: only reachable from the sidebar (Normal mode
|
||||
// never forwards keys to a pty), same reasoning as bare `tab` above.
|
||||
("q", "Quit"),
|
||||
// Mouse
|
||||
("mouse:dblclick(sidebar-row)", "AttachHighlighted"),
|
||||
];
|
||||
|
||||
/// Default Insert-mode bindings. Empty by default — the only Insert binding
|
||||
/// is the leader, which is inserted dynamically by [`TuiConfig::load`] so
|
||||
/// rebinding the leader rebinds its Insert escape automatically.
|
||||
const DEFAULT_INSERT: &[(&str, &str)] = &[];
|
||||
/// Default Insert-mode bindings. The leader (`LeaveInsert`) is inserted
|
||||
/// dynamically by [`TuiConfig::load`] so rebinding it rebinds its Insert
|
||||
/// escape automatically; `esc` is a second, fixed way back to the sidebar.
|
||||
const DEFAULT_INSERT: &[(&str, &str)] = &[("esc", "LeaveInsert")];
|
||||
|
||||
impl TuiConfig {
|
||||
/// Build a runtime config from a [`TuiSection`] (typically the `tui`
|
||||
@@ -80,6 +87,11 @@ impl TuiConfig {
|
||||
let palette = match section.theme.unwrap_or(TuiTheme::Dark) {
|
||||
TuiTheme::Dark => Palette::DARK,
|
||||
TuiTheme::Light => Palette::LIGHT,
|
||||
TuiTheme::IceCyan => Palette::ICE_CYAN,
|
||||
TuiTheme::Periwinkle => Palette::PERIWINKLE,
|
||||
TuiTheme::AmberPhosphor => Palette::AMBER_PHOSPHOR,
|
||||
TuiTheme::Ember => Palette::EMBER,
|
||||
TuiTheme::Orchid => Palette::ORCHID,
|
||||
TuiTheme::Ansi => Palette::ANSI,
|
||||
TuiTheme::SolarizedDark => Palette::SOLARIZED_DARK,
|
||||
TuiTheme::SolarizedLight => Palette::SOLARIZED_LIGHT,
|
||||
@@ -172,6 +184,11 @@ mod tests {
|
||||
for (theme, expected) in [
|
||||
(TuiTheme::Dark, Palette::DARK),
|
||||
(TuiTheme::Light, Palette::LIGHT),
|
||||
(TuiTheme::IceCyan, Palette::ICE_CYAN),
|
||||
(TuiTheme::Periwinkle, Palette::PERIWINKLE),
|
||||
(TuiTheme::AmberPhosphor, Palette::AMBER_PHOSPHOR),
|
||||
(TuiTheme::Ember, Palette::EMBER),
|
||||
(TuiTheme::Orchid, Palette::ORCHID),
|
||||
(TuiTheme::Ansi, Palette::ANSI),
|
||||
(TuiTheme::SolarizedDark, Palette::SOLARIZED_DARK),
|
||||
(TuiTheme::SolarizedLight, Palette::SOLARIZED_LIGHT),
|
||||
@@ -204,7 +221,7 @@ mod tests {
|
||||
);
|
||||
assert_eq!(
|
||||
cfg.keymap.resolve(Mode::Normal, "s"),
|
||||
Some(Action::NewDraftPane),
|
||||
Some(Action::OpenSpawnModal),
|
||||
);
|
||||
assert_eq!(
|
||||
cfg.keymap.resolve(Mode::Normal, "S"),
|
||||
@@ -212,6 +229,23 @@ mod tests {
|
||||
);
|
||||
}
|
||||
|
||||
/// AoE-style defaults (#shortcuts): `q` and `tab` are bare because Normal
|
||||
/// mode only exists while the sidebar is focused, so neither can leak
|
||||
/// into a pty; `esc` is a second way out of Insert alongside the leader.
|
||||
#[test]
|
||||
fn aoe_style_defaults_are_bound() {
|
||||
let cfg = TuiConfig::load(&TuiSection::default()).unwrap();
|
||||
assert_eq!(cfg.keymap.resolve(Mode::Normal, "q"), Some(Action::Quit));
|
||||
assert_eq!(
|
||||
cfg.keymap.resolve(Mode::Normal, "tab"),
|
||||
Some(Action::AttachHighlighted),
|
||||
);
|
||||
assert_eq!(
|
||||
cfg.keymap.resolve(Mode::Insert, "esc"),
|
||||
Some(Action::LeaveInsert),
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn default_leader_is_ctrl_a_and_escapes_insert() {
|
||||
let cfg = TuiConfig::load(&TuiSection::default()).unwrap();
|
||||
|
||||
@@ -0,0 +1,343 @@
|
||||
//! Liveness and identity of the daemon behind this TUI.
|
||||
//!
|
||||
//! The status bar renders [`LinkStatus`], and [`LinkState::Down`] puts the
|
||||
//! restart overlay up and locks the keyboard. `docs/RESTART.md` is the
|
||||
//! contract; this is the TUI half of what `web/src/daemonLink.ts` does.
|
||||
|
||||
use std::sync::{Arc, RwLock};
|
||||
use std::time::{Duration, Instant};
|
||||
|
||||
use maestro_protocol::{BuildInfo, DaemonClient, DaemonInfo};
|
||||
use tokio::sync::Notify;
|
||||
|
||||
/// How long a lost connection stays quiet before the overlay blocks the UI.
|
||||
pub const GRACE: Duration = Duration::from_millis(1200);
|
||||
/// Cadence of `GET /api/info` while the daemon is unreachable.
|
||||
pub const POLL: Duration = Duration::from_millis(700);
|
||||
|
||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||
pub enum LinkState {
|
||||
/// No probe has landed yet.
|
||||
Connecting,
|
||||
/// The daemon answered.
|
||||
Online,
|
||||
/// The events socket dropped, still inside the grace window.
|
||||
Reconnecting,
|
||||
/// Unreachable past the grace window: the overlay is up.
|
||||
Down,
|
||||
}
|
||||
|
||||
/// What happened between two `/api/info` replies.
|
||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||
pub enum RestartKind {
|
||||
Same,
|
||||
Restarted,
|
||||
Upgraded,
|
||||
}
|
||||
|
||||
/// Compare two daemon replies. The commit decides first — a different one is
|
||||
/// new code. `instance` catches a restart of the same build, and is the only
|
||||
/// signal for a daemon built outside a git checkout (empty commit), which must
|
||||
/// never be read as an upgrade.
|
||||
pub fn compare_identity(before: &DaemonInfo, after: &DaemonInfo) -> RestartKind {
|
||||
let a = before.build.commit.as_str();
|
||||
let b = after.build.commit.as_str();
|
||||
if !a.is_empty() && !b.is_empty() && a != b {
|
||||
return RestartKind::Upgraded;
|
||||
}
|
||||
if !before.instance.is_empty()
|
||||
&& !after.instance.is_empty()
|
||||
&& before.instance != after.instance
|
||||
{
|
||||
return RestartKind::Restarted;
|
||||
}
|
||||
RestartKind::Same
|
||||
}
|
||||
|
||||
/// One line naming a release: `f89be4a716c7 · 2026-09-02`, `(dirty)` when the
|
||||
/// build carried uncommitted changes.
|
||||
pub fn format_release(build: &BuildInfo) -> String {
|
||||
if build.commit.is_empty() {
|
||||
return "unknown release".to_string();
|
||||
}
|
||||
let mut out = build.commit.clone();
|
||||
if build.commit_date.len() >= 10 {
|
||||
out.push_str(" · ");
|
||||
out.push_str(&build.commit_date[..10]);
|
||||
}
|
||||
if build.dirty {
|
||||
out.push_str(" (dirty)");
|
||||
}
|
||||
out
|
||||
}
|
||||
|
||||
/// Snapshot of the link, taken once per frame by the renderer.
|
||||
#[derive(Debug, Clone)]
|
||||
pub struct LinkStatus {
|
||||
pub state: LinkState,
|
||||
/// The release the daemon last reported. `None` until the first probe.
|
||||
pub build: Option<BuildInfo>,
|
||||
/// Failed probes in the current outage — the overlay counts them so a long
|
||||
/// restart doesn't read as a hang.
|
||||
pub attempts: u32,
|
||||
/// Set once the daemon comes back on a different commit. The TUI is its own
|
||||
/// binary, so it keeps running against the new daemon and shows this until
|
||||
/// the user restarts it onto the new client.
|
||||
pub upgraded_to: Option<BuildInfo>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Default, Clone)]
|
||||
pub struct DaemonLink {
|
||||
inner: Arc<Inner>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Default)]
|
||||
struct Inner {
|
||||
state: RwLock<State>,
|
||||
notify: Notify,
|
||||
}
|
||||
|
||||
#[derive(Debug)]
|
||||
struct State {
|
||||
state: LinkState,
|
||||
identity: Option<DaemonInfo>,
|
||||
attempts: u32,
|
||||
/// When the events socket dropped, for the grace window.
|
||||
down_since: Option<Instant>,
|
||||
upgraded_to: Option<BuildInfo>,
|
||||
}
|
||||
|
||||
impl Default for State {
|
||||
fn default() -> Self {
|
||||
Self {
|
||||
state: LinkState::Connecting,
|
||||
identity: None,
|
||||
attempts: 0,
|
||||
down_since: None,
|
||||
upgraded_to: None,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
impl DaemonLink {
|
||||
pub fn status(&self) -> LinkStatus {
|
||||
let s = self.read();
|
||||
LinkStatus {
|
||||
state: s.state,
|
||||
build: s.identity.as_ref().map(|i| i.build.clone()),
|
||||
attempts: s.attempts,
|
||||
upgraded_to: s.upgraded_to.clone(),
|
||||
}
|
||||
}
|
||||
|
||||
/// Whether the UI is locked behind the restart overlay.
|
||||
pub fn is_blocking(&self) -> bool {
|
||||
self.read().state == LinkState::Down
|
||||
}
|
||||
|
||||
/// Wait until anything about the link changes, so the render loop redraws.
|
||||
pub async fn changed(&self) {
|
||||
self.inner.notify.notified().await;
|
||||
}
|
||||
|
||||
/// The events socket dropped. Starts the grace window.
|
||||
pub fn note_disconnected(&self, now: Instant) {
|
||||
{
|
||||
let mut s = self.write();
|
||||
if s.state == LinkState::Down {
|
||||
return;
|
||||
}
|
||||
s.state = LinkState::Reconnecting;
|
||||
s.attempts = 0;
|
||||
s.down_since = Some(now);
|
||||
}
|
||||
self.wake();
|
||||
}
|
||||
|
||||
/// The events socket came back. Does not clear the state on its own: the
|
||||
/// socket carries no identity, and only a probe can say which daemon
|
||||
/// answered.
|
||||
pub fn note_connected(&self) {
|
||||
self.wake();
|
||||
}
|
||||
|
||||
/// Fold in a successful `/api/info`. A reply on a new commit is recorded as
|
||||
/// an upgrade; either way the link is back online.
|
||||
pub fn apply_info(&self, info: DaemonInfo) {
|
||||
{
|
||||
let mut s = self.write();
|
||||
if let Some(before) = &s.identity {
|
||||
if compare_identity(before, &info) == RestartKind::Upgraded {
|
||||
s.upgraded_to = Some(info.build.clone());
|
||||
}
|
||||
}
|
||||
s.identity = Some(info);
|
||||
s.state = LinkState::Online;
|
||||
s.attempts = 0;
|
||||
s.down_since = None;
|
||||
}
|
||||
self.wake();
|
||||
}
|
||||
|
||||
/// Fold in a failed probe. The overlay goes up once the grace window since
|
||||
/// the disconnect has passed.
|
||||
pub fn probe_failed(&self, now: Instant) {
|
||||
{
|
||||
let mut s = self.write();
|
||||
s.attempts = s.attempts.saturating_add(1);
|
||||
let since = *s.down_since.get_or_insert(now);
|
||||
if now.duration_since(since) >= GRACE {
|
||||
s.state = LinkState::Down;
|
||||
} else if s.state == LinkState::Online {
|
||||
s.state = LinkState::Reconnecting;
|
||||
}
|
||||
}
|
||||
self.wake();
|
||||
}
|
||||
|
||||
/// Long-running task: keep [`LinkStatus`] true. Probes on a flat cadence
|
||||
/// while the daemon is unreachable and idles while it is up. Never returns.
|
||||
pub async fn run_probe_loop(self, daemon: DaemonClient) {
|
||||
loop {
|
||||
if self.read().state == LinkState::Online {
|
||||
// A tick bounds the wait so a disconnect racing the notify
|
||||
// costs a second, not the whole outage.
|
||||
let _ = tokio::time::timeout(Duration::from_secs(1), self.changed()).await;
|
||||
continue;
|
||||
}
|
||||
match daemon.daemon_info().await {
|
||||
Ok(info) => self.apply_info(info),
|
||||
Err(_) => {
|
||||
self.probe_failed(Instant::now());
|
||||
tokio::time::sleep(POLL).await;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn wake(&self) {
|
||||
self.inner.notify.notify_waiters();
|
||||
}
|
||||
|
||||
fn read(&self) -> std::sync::RwLockReadGuard<'_, State> {
|
||||
self.inner
|
||||
.state
|
||||
.read()
|
||||
.expect("daemon link rwlock poisoned")
|
||||
}
|
||||
|
||||
fn write(&self) -> std::sync::RwLockWriteGuard<'_, State> {
|
||||
self.inner
|
||||
.state
|
||||
.write()
|
||||
.expect("daemon link rwlock poisoned")
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
|
||||
fn info(commit: &str, instance: &str) -> DaemonInfo {
|
||||
DaemonInfo {
|
||||
hostname: "konishi".into(),
|
||||
version: "0.1.0".into(),
|
||||
home_dir: "/home/naps".into(),
|
||||
presets: Vec::new(),
|
||||
build: BuildInfo {
|
||||
commit: commit.into(),
|
||||
commit_date: "2026-09-02T14:03:11Z".into(),
|
||||
dirty: false,
|
||||
},
|
||||
instance: instance.into(),
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn identity_tells_upgrade_from_restart() {
|
||||
assert_eq!(
|
||||
compare_identity(&info("aaa", "i1"), &info("bbb", "i2")),
|
||||
RestartKind::Upgraded
|
||||
);
|
||||
assert_eq!(
|
||||
compare_identity(&info("aaa", "i1"), &info("aaa", "i2")),
|
||||
RestartKind::Restarted
|
||||
);
|
||||
assert_eq!(
|
||||
compare_identity(&info("aaa", "i1"), &info("aaa", "i1")),
|
||||
RestartKind::Same
|
||||
);
|
||||
// No build stamp: the instance still reports the restart, and nothing
|
||||
// ever claims a phantom upgrade.
|
||||
assert_eq!(
|
||||
compare_identity(&info("", "i1"), &info("", "i2")),
|
||||
RestartKind::Restarted
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn release_line_pairs_hash_with_date() {
|
||||
assert_eq!(
|
||||
format_release(&info("f89be4a716c7", "i1").build),
|
||||
"f89be4a716c7 · 2026-09-02"
|
||||
);
|
||||
assert_eq!(
|
||||
format_release(&BuildInfo {
|
||||
commit: "abc".into(),
|
||||
commit_date: String::new(),
|
||||
dirty: true,
|
||||
}),
|
||||
"abc (dirty)"
|
||||
);
|
||||
assert_eq!(format_release(&BuildInfo::default()), "unknown release");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn grace_window_holds_the_overlay_back() {
|
||||
let link = DaemonLink::default();
|
||||
link.apply_info(info("aaa", "i1"));
|
||||
assert_eq!(link.status().state, LinkState::Online);
|
||||
|
||||
let t0 = Instant::now();
|
||||
link.note_disconnected(t0);
|
||||
assert_eq!(link.status().state, LinkState::Reconnecting);
|
||||
assert!(!link.is_blocking());
|
||||
|
||||
link.probe_failed(t0 + Duration::from_millis(400));
|
||||
assert_eq!(link.status().state, LinkState::Reconnecting);
|
||||
|
||||
link.probe_failed(t0 + GRACE);
|
||||
assert_eq!(link.status().state, LinkState::Down);
|
||||
assert!(link.is_blocking());
|
||||
assert_eq!(link.status().attempts, 2);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn a_plain_restart_unlocks_without_an_upgrade_note() {
|
||||
let link = DaemonLink::default();
|
||||
link.apply_info(info("aaa", "i1"));
|
||||
let t0 = Instant::now();
|
||||
link.note_disconnected(t0);
|
||||
link.probe_failed(t0 + GRACE);
|
||||
assert!(link.is_blocking());
|
||||
|
||||
link.apply_info(info("aaa", "i2"));
|
||||
assert_eq!(link.status().state, LinkState::Online);
|
||||
assert!(link.status().upgraded_to.is_none());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn an_upgrade_unlocks_and_names_the_new_release() {
|
||||
let link = DaemonLink::default();
|
||||
link.apply_info(info("aaa", "i1"));
|
||||
let t0 = Instant::now();
|
||||
link.note_disconnected(t0);
|
||||
link.probe_failed(t0 + GRACE);
|
||||
|
||||
link.apply_info(info("bbb", "i2"));
|
||||
let status = link.status();
|
||||
assert_eq!(status.state, LinkState::Online);
|
||||
assert_eq!(status.upgraded_to.unwrap().commit, "bbb");
|
||||
assert!(!link.is_blocking());
|
||||
}
|
||||
}
|
||||
+136
-54
@@ -1,9 +1,9 @@
|
||||
//! Draft pane — the spawn form living in an ordinary pane (issues #63/#64).
|
||||
//! The spawn form (issues #63/#64), drawn inside the spawn modal.
|
||||
//!
|
||||
//! An empty pane renders a [`DraftPane`] instead of nothing; submitting hands
|
||||
//! the caller a built request and the pane is replaced with the new session,
|
||||
//! matching the web client's inline draft panes (#57). Field editing goes
|
||||
//! through [`crate::text_input::TextInput`]; Tab / BackTab walk the fields.
|
||||
//! Submitting hands the caller a built request; the modal closes and the new
|
||||
//! session takes the pane, matching the web client's spawn modal. Field
|
||||
//! editing goes through [`crate::text_input::TextInput`]; Tab / BackTab walk
|
||||
//! the fields.
|
||||
//!
|
||||
//! Field groups (#64), mirroring the web form (`web/src/spawnForm.ts`):
|
||||
//! command presets from `/api/info` (with an implicit `custom` free-text
|
||||
@@ -221,6 +221,11 @@ pub struct DraftPane {
|
||||
pub cwd_raw_visible: bool,
|
||||
pub cwd_raw: crate::text_input::TextInput,
|
||||
pub picked_cwd: Option<PathBuf>,
|
||||
/// Directory to preselect once the project scan lands — the project of
|
||||
/// the session the operator was last looking at, so `n` then Enter
|
||||
/// respawns there without touching the picker. Consumed by the first
|
||||
/// [`Self::set_projects`]; `None` once applied or when nothing seeded it.
|
||||
pub seed_cwd: Option<PathBuf>,
|
||||
/// The repository picked in step one ([`group_key`] of its main box),
|
||||
/// `None` until a box is picked. Looked up fresh in `groups` rather than
|
||||
/// cached, so a project-list refresh can't leave it stale.
|
||||
@@ -293,6 +298,7 @@ impl Default for DraftPane {
|
||||
cwd_raw_visible: false,
|
||||
cwd_raw: crate::text_input::TextInput::default(),
|
||||
picked_cwd: None,
|
||||
seed_cwd: None,
|
||||
selected_group_key: None,
|
||||
worktree_choice: WorktreeChoice::New,
|
||||
name: crate::text_input::TextInput::default(),
|
||||
@@ -315,7 +321,9 @@ impl Default for DraftPane {
|
||||
branches_for: None,
|
||||
needs_branches: false,
|
||||
error: None,
|
||||
focused_field: DraftField::Preset,
|
||||
// The picker owns the keyboard on open: typing filters projects
|
||||
// straight away, and Tab from here reaches the command tiles.
|
||||
focused_field: DraftField::DirPicker,
|
||||
home_dir: String::new(),
|
||||
}
|
||||
}
|
||||
@@ -358,6 +366,26 @@ impl DraftPane {
|
||||
})
|
||||
.collect();
|
||||
self.highlighted = self.highlighted.min(self.entry_count().saturating_sub(1));
|
||||
self.apply_seed_cwd();
|
||||
}
|
||||
|
||||
/// Preselect the seeded directory now that the scan has landed: highlight
|
||||
/// its repository box and pick it, so Enter from the untouched picker
|
||||
/// spawns there. A seed no box matches is dropped — the operator picks by
|
||||
/// hand, exactly as before.
|
||||
fn apply_seed_cwd(&mut self) {
|
||||
let Some(seed) = self.seed_cwd.take() else {
|
||||
return;
|
||||
};
|
||||
let hit = self.visible_groups().iter().enumerate().find_map(|(i, g)| {
|
||||
let matches = g.main.path == seed || g.worktrees.iter().any(|w| w.project.path == seed);
|
||||
matches.then(|| (i, (*g).clone()))
|
||||
});
|
||||
let Some((index, group)) = hit else {
|
||||
return;
|
||||
};
|
||||
self.highlighted = index;
|
||||
self.select_group(&group);
|
||||
}
|
||||
|
||||
/// Fill the local name batch from `GET /api/names`, seeding the field
|
||||
@@ -705,14 +733,14 @@ impl DraftPane {
|
||||
}
|
||||
|
||||
fn field_order(&self) -> Vec<DraftField> {
|
||||
let mut order = vec![DraftField::Preset];
|
||||
if self.is_custom() {
|
||||
order.push(DraftField::CustomCommand);
|
||||
}
|
||||
order.push(DraftField::DirPicker);
|
||||
let mut order = vec![DraftField::DirPicker];
|
||||
if self.cwd_raw_visible {
|
||||
order.push(DraftField::CwdRaw);
|
||||
}
|
||||
order.push(DraftField::Preset);
|
||||
if self.is_custom() {
|
||||
order.push(DraftField::CustomCommand);
|
||||
}
|
||||
order.push(DraftField::Name);
|
||||
order.push(DraftField::Advanced);
|
||||
if !self.advanced_collapsed {
|
||||
@@ -1116,15 +1144,17 @@ impl DraftPane {
|
||||
+ u16::from(self.error.is_some());
|
||||
let list_capacity = (inner.height.saturating_sub(fixed)).max(1) as usize;
|
||||
|
||||
let mut constraints = vec![Constraint::Length(1)];
|
||||
if show_custom {
|
||||
constraints.push(Constraint::Length(1));
|
||||
}
|
||||
constraints.push(Constraint::Length(1));
|
||||
// The picker leads the form: it is where focus lands on open, and Tab
|
||||
// walks down from it into the command tiles.
|
||||
let mut constraints = vec![Constraint::Length(1)]; // dir filter
|
||||
constraints.push(Constraint::Length(list_capacity as u16));
|
||||
if show_raw {
|
||||
constraints.push(Constraint::Length(1));
|
||||
}
|
||||
constraints.push(Constraint::Length(1)); // command tiles
|
||||
if show_custom {
|
||||
constraints.push(Constraint::Length(1));
|
||||
}
|
||||
constraints.push(Constraint::Length(1)); // name
|
||||
constraints.push(Constraint::Length(1)); // advanced header
|
||||
if show_wt_choice {
|
||||
@@ -1163,36 +1193,6 @@ impl DraftPane {
|
||||
// Tracks where the terminal cursor belongs for the focused text field.
|
||||
let mut cursor: Option<(u16, u16)> = None;
|
||||
|
||||
// -- command presets ---------------------------------------------------
|
||||
let tiles_row = next_row();
|
||||
let mut tiles = vec![Span::raw(format!("{:<GUTTER$}", "cmd:"))];
|
||||
for (i, preset) in self.presets.iter().enumerate() {
|
||||
if i > 0 {
|
||||
tiles.push(Span::raw(" "));
|
||||
}
|
||||
let mut style = Style::default();
|
||||
if i == self.selected_preset {
|
||||
style = style.add_modifier(Modifier::REVERSED);
|
||||
}
|
||||
tiles.push(Span::styled(format!("[{}]", preset.label), style));
|
||||
}
|
||||
f.render_widget(Paragraph::new(Line::from(tiles)), tiles_row);
|
||||
|
||||
// -- custom command (only while a custom tile is selected) -------------
|
||||
if show_custom {
|
||||
let row = next_row();
|
||||
draw_gutter(f, row, "");
|
||||
let col = draw_text_field(
|
||||
f,
|
||||
&self.custom_command,
|
||||
row,
|
||||
field_style(DraftField::CustomCommand),
|
||||
);
|
||||
if self.focused_field == DraftField::CustomCommand {
|
||||
cursor = Some((col, row.y));
|
||||
}
|
||||
}
|
||||
|
||||
// -- directory picker ----------------------------------------------------
|
||||
let filter_row = next_row();
|
||||
draw_gutter(f, filter_row, "dir:");
|
||||
@@ -1280,6 +1280,36 @@ impl DraftPane {
|
||||
}
|
||||
}
|
||||
|
||||
// -- command presets ---------------------------------------------------
|
||||
let tiles_row = next_row();
|
||||
let mut tiles = vec![Span::raw(format!("{:<GUTTER$}", "cmd:"))];
|
||||
for (i, preset) in self.presets.iter().enumerate() {
|
||||
if i > 0 {
|
||||
tiles.push(Span::raw(" "));
|
||||
}
|
||||
let mut style = Style::default();
|
||||
if i == self.selected_preset {
|
||||
style = style.add_modifier(Modifier::REVERSED);
|
||||
}
|
||||
tiles.push(Span::styled(format!("[{}]", preset.label), style));
|
||||
}
|
||||
f.render_widget(Paragraph::new(Line::from(tiles)), tiles_row);
|
||||
|
||||
// -- custom command (only while a custom tile is selected) -------------
|
||||
if show_custom {
|
||||
let row = next_row();
|
||||
draw_gutter(f, row, "");
|
||||
let col = draw_text_field(
|
||||
f,
|
||||
&self.custom_command,
|
||||
row,
|
||||
field_style(DraftField::CustomCommand),
|
||||
);
|
||||
if self.focused_field == DraftField::CustomCommand {
|
||||
cursor = Some((col, row.y));
|
||||
}
|
||||
}
|
||||
|
||||
// -- name + reroll ---------------------------------------------------------
|
||||
let name_row = next_row();
|
||||
draw_gutter(f, name_row, "name:");
|
||||
@@ -1681,7 +1711,10 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn left_right_cycles_presets_wrapping_into_custom() {
|
||||
let mut draft = DraftPane::default();
|
||||
let mut draft = DraftPane {
|
||||
focused_field: DraftField::Preset,
|
||||
..DraftPane::default()
|
||||
};
|
||||
draft.on_input(&InputKey::Right);
|
||||
assert_eq!(draft.command(), "opencode");
|
||||
draft.on_input(&InputKey::Left);
|
||||
@@ -1704,17 +1737,22 @@ mod tests {
|
||||
draft.selected_preset = draft.presets.len() - 1;
|
||||
assert!(draft.is_custom());
|
||||
assert_eq!(
|
||||
draft.field_order()[..2],
|
||||
[DraftField::Preset, DraftField::CustomCommand],
|
||||
"custom command sits between presets and the dir picker"
|
||||
draft.field_order()[..3],
|
||||
[
|
||||
DraftField::DirPicker,
|
||||
DraftField::Preset,
|
||||
DraftField::CustomCommand
|
||||
],
|
||||
"the picker leads; custom command sits right after the tiles"
|
||||
);
|
||||
draft.next_field(); // DirPicker → Preset
|
||||
draft.next_field();
|
||||
assert_eq!(draft.focused_field, DraftField::CustomCommand);
|
||||
typed(&mut draft, "bash -l");
|
||||
assert_eq!(draft.command(), "bash -l");
|
||||
// Tab walks past the hidden fields in order.
|
||||
draft.next_field();
|
||||
assert_eq!(draft.focused_field, DraftField::DirPicker);
|
||||
assert_eq!(draft.focused_field, DraftField::Name);
|
||||
}
|
||||
|
||||
#[test]
|
||||
@@ -1777,8 +1815,11 @@ mod tests {
|
||||
],
|
||||
Utc::now(),
|
||||
);
|
||||
draft.next_field(); // Preset → DirPicker
|
||||
assert_eq!(draft.focused_field, DraftField::DirPicker);
|
||||
assert_eq!(
|
||||
draft.focused_field,
|
||||
DraftField::DirPicker,
|
||||
"the form opens with the project filter focused"
|
||||
);
|
||||
typed(&mut draft, "maes");
|
||||
assert_eq!(
|
||||
draft.visible_groups().len(),
|
||||
@@ -1890,6 +1931,47 @@ mod tests {
|
||||
assert_eq!(draft.on_input(&InputKey::Enter), DraftInputResult::Submit);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn a_seeded_directory_is_preselected_so_one_enter_spawns_there() {
|
||||
let mut draft = DraftPane {
|
||||
seed_cwd: Some(PathBuf::from("/repos/other")),
|
||||
..DraftPane::default()
|
||||
};
|
||||
draft.set_projects(
|
||||
vec![
|
||||
project("maestro", "/repos/maestro", 1, Some("claude")),
|
||||
project("other", "/repos/other", 2, Some("zsh")),
|
||||
],
|
||||
Utc::now(),
|
||||
);
|
||||
assert_eq!(
|
||||
draft.picked_cwd.as_deref(),
|
||||
Some(Path::new("/repos/other")),
|
||||
"the seeded project is picked before a key is pressed"
|
||||
);
|
||||
assert_eq!(draft.selection(), 1, "and its row is the highlighted one");
|
||||
assert_eq!(
|
||||
draft.on_input(&InputKey::Enter),
|
||||
DraftInputResult::Submit,
|
||||
"one Enter spawns in the seeded project"
|
||||
);
|
||||
assert_eq!(draft.picked_cwd.as_deref(), Some(Path::new("/repos/other")));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn a_seed_no_project_matches_leaves_the_picker_untouched() {
|
||||
let mut draft = DraftPane {
|
||||
seed_cwd: Some(PathBuf::from("/gone")),
|
||||
..DraftPane::default()
|
||||
};
|
||||
draft.set_projects(
|
||||
vec![project("maestro", "/repos/maestro", 1, None)],
|
||||
Utc::now(),
|
||||
);
|
||||
assert_eq!(draft.picked_cwd, None);
|
||||
assert_eq!(draft.selection(), 0);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn dir_picker_enter_on_other_directory_never_submits_directly_97() {
|
||||
let mut draft = DraftPane::default();
|
||||
@@ -2140,7 +2222,7 @@ mod tests {
|
||||
let mut terminal = Terminal::new(backend).unwrap();
|
||||
terminal.draw(|f| draft.render(f, f.area(), true)).unwrap();
|
||||
let pos = terminal.get_cursor_position().unwrap();
|
||||
assert_eq!(pos, ratatui::layout::Position::new(GUTTER as u16 + 2, 1));
|
||||
assert_eq!(pos, ratatui::layout::Position::new(GUTTER as u16 + 2, 0));
|
||||
}
|
||||
|
||||
#[test]
|
||||
|
||||
@@ -1,11 +1,11 @@
|
||||
//! Fast-forward spawn (#67): one keystroke, every default resolved, no form.
|
||||
//!
|
||||
//! The defaults mirror what a draft pane would settle on after the operator
|
||||
//! The defaults mirror what the spawn form would settle on after the operator
|
||||
//! picked the most recent project and kept their hands off everything else:
|
||||
//! its last command (or the first non-custom preset), a freshly generated
|
||||
//! name, and a worktree with a branch named after that name. Any default
|
||||
//! that cannot be resolved — no projects yet, no command, no generated
|
||||
//! name — downgrades the keystroke to a draft pane pre-filled with whatever
|
||||
//! name — downgrades the keystroke to the spawn form pre-filled with whatever
|
||||
//! did resolve ([`FastForwardDefaults::apply_to_draft`]).
|
||||
|
||||
use std::path::PathBuf;
|
||||
@@ -26,16 +26,25 @@ pub struct FastForwardDefaults {
|
||||
|
||||
/// Resolve the fast-forward defaults from the daemon's answers. `name` is
|
||||
/// `None` when `/api/names` yielded nothing; `presets` may be empty (the
|
||||
/// caller falls back to the built-ins it already has).
|
||||
/// caller falls back to the built-ins it already has). `focused_cwd` is the
|
||||
/// project of the session the operator was last on ([`crate::app`]'s
|
||||
/// `focused_seed_cwd`) — when it matches a known project, that project wins
|
||||
/// over the global recency ranking, so `N` lands where the operator
|
||||
/// currently is rather than wherever was freshest.
|
||||
pub fn resolve(
|
||||
projects: &[Project],
|
||||
presets: &[SpawnPreset],
|
||||
name: Option<String>,
|
||||
now: DateTime<Utc>,
|
||||
focused_cwd: Option<&std::path::Path>,
|
||||
) -> FastForwardDefaults {
|
||||
let project = crate::projects::sort_projects(projects.to_vec(), now)
|
||||
.into_iter()
|
||||
.next();
|
||||
let project = focused_cwd
|
||||
.and_then(|cwd| projects.iter().find(|p| p.path == cwd).cloned())
|
||||
.or_else(|| {
|
||||
crate::projects::sort_projects(projects.to_vec(), now)
|
||||
.into_iter()
|
||||
.next()
|
||||
});
|
||||
let command = project
|
||||
.as_ref()
|
||||
.and_then(|p| p.last_command.clone())
|
||||
@@ -85,7 +94,7 @@ impl FastForwardDefaults {
|
||||
})
|
||||
}
|
||||
|
||||
/// Seed a fresh draft pane with whatever did resolve — the fallback when
|
||||
/// Seed a fresh spawn form with whatever did resolve — the fallback when
|
||||
/// [`Self::build_request`] is `None`. The operator fills in the rest.
|
||||
pub fn apply_to_draft(&self, draft: &mut DraftPane) {
|
||||
if let Some(project) = &self.project {
|
||||
@@ -155,7 +164,13 @@ mod tests {
|
||||
repo_project("/repos/fresh", "/repos/fresh", 0, Some("claude")),
|
||||
];
|
||||
let presets = vec![preset("aider", "aider"), preset("custom", "")];
|
||||
let r = resolve(&projects, &presets, Some("amber-falcon".into()), Utc::now());
|
||||
let r = resolve(
|
||||
&projects,
|
||||
&presets,
|
||||
Some("amber-falcon".into()),
|
||||
Utc::now(),
|
||||
None,
|
||||
);
|
||||
assert_eq!(
|
||||
r.project.as_ref().unwrap().path,
|
||||
PathBuf::from("/repos/fresh")
|
||||
@@ -176,6 +191,46 @@ mod tests {
|
||||
assert!(wt.create_branch, "fresh branch named after the session");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn the_focused_sessions_project_wins_over_the_freshest_one() {
|
||||
let projects = vec![
|
||||
repo_project("/repos/fresh", "/repos/fresh", 0, Some("claude")),
|
||||
project("/repos/current", 5, Some("zsh")),
|
||||
];
|
||||
let presets = vec![preset("claude", "claude")];
|
||||
let r = resolve(
|
||||
&projects,
|
||||
&presets,
|
||||
Some("n".into()),
|
||||
Utc::now(),
|
||||
Some(std::path::Path::new("/repos/current")),
|
||||
);
|
||||
assert_eq!(
|
||||
r.project.as_ref().unwrap().path,
|
||||
PathBuf::from("/repos/current")
|
||||
);
|
||||
assert_eq!(r.command.as_deref(), Some("zsh"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn an_unknown_focused_cwd_falls_back_to_the_freshest_project() {
|
||||
let projects = vec![
|
||||
project("/repos/old", 30, Some("zsh")),
|
||||
repo_project("/repos/fresh", "/repos/fresh", 0, Some("claude")),
|
||||
];
|
||||
let r = resolve(
|
||||
&projects,
|
||||
&[preset("claude", "claude")],
|
||||
Some("n".into()),
|
||||
Utc::now(),
|
||||
Some(std::path::Path::new("/repos/gone")),
|
||||
);
|
||||
assert_eq!(
|
||||
r.project.as_ref().unwrap().path,
|
||||
PathBuf::from("/repos/fresh")
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn worktree_of_the_most_recent_project_targets_its_base_repo() {
|
||||
let projects = vec![repo_project("/repos/main/wt-x", "/repos/main", 0, None)];
|
||||
@@ -184,6 +239,7 @@ mod tests {
|
||||
&[preset("zsh", "zsh")],
|
||||
Some("s".into()),
|
||||
Utc::now(),
|
||||
None,
|
||||
);
|
||||
let wt = r.build_request().unwrap().worktree.unwrap();
|
||||
assert_eq!(wt.base_repo, PathBuf::from("/repos/main"));
|
||||
@@ -193,7 +249,7 @@ mod tests {
|
||||
fn missing_last_command_falls_back_to_the_first_non_custom_preset() {
|
||||
let projects = vec![project("/repos/p", 0, None)];
|
||||
let presets = vec![preset("custom", ""), preset("claude", "claude")];
|
||||
let r = resolve(&projects, &presets, Some("n".into()), Utc::now());
|
||||
let r = resolve(&projects, &presets, Some("n".into()), Utc::now(), None);
|
||||
assert_eq!(r.command.as_deref(), Some("claude"));
|
||||
}
|
||||
|
||||
@@ -201,7 +257,7 @@ mod tests {
|
||||
fn an_empty_last_command_is_no_command_at_all() {
|
||||
let projects = vec![project("/repos/p", 0, Some(""))];
|
||||
let presets = vec![preset("custom", "")];
|
||||
let r = resolve(&projects, &presets, Some("n".into()), Utc::now());
|
||||
let r = resolve(&projects, &presets, Some("n".into()), Utc::now(), None);
|
||||
assert_eq!(r.command, None);
|
||||
assert!(r.build_request().is_none());
|
||||
}
|
||||
@@ -213,6 +269,7 @@ mod tests {
|
||||
&[preset("claude", "claude")],
|
||||
Some("n".into()),
|
||||
Utc::now(),
|
||||
None,
|
||||
);
|
||||
assert_eq!(r.project, None);
|
||||
// No project → no directory → no request, even with command + name.
|
||||
@@ -222,14 +279,26 @@ mod tests {
|
||||
#[test]
|
||||
fn a_missing_generated_name_downgrades_to_a_draft() {
|
||||
let projects = vec![project("/repos/p", 0, Some("claude"))];
|
||||
let r = resolve(&projects, &[preset("claude", "claude")], None, Utc::now());
|
||||
let r = resolve(
|
||||
&projects,
|
||||
&[preset("claude", "claude")],
|
||||
None,
|
||||
Utc::now(),
|
||||
None,
|
||||
);
|
||||
assert!(r.build_request().is_none(), "no name → no immediate spawn");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn unresolvable_defaults_still_seed_the_draft_with_what_resolved() {
|
||||
let projects = vec![repo_project("/repos/p", "/repos/p", 0, Some("aider"))];
|
||||
let r = resolve(&projects, &[preset("aider", "aider")], None, Utc::now());
|
||||
let r = resolve(
|
||||
&projects,
|
||||
&[preset("aider", "aider")],
|
||||
None,
|
||||
Utc::now(),
|
||||
None,
|
||||
);
|
||||
|
||||
let mut draft = DraftPane::default();
|
||||
r.apply_to_draft(&mut draft);
|
||||
@@ -251,6 +320,7 @@ mod tests {
|
||||
&[preset("claude", "claude")],
|
||||
Some("amber-falcon".into()),
|
||||
Utc::now(),
|
||||
None,
|
||||
);
|
||||
let mut draft = DraftPane::default();
|
||||
named.apply_to_draft(&mut draft);
|
||||
@@ -263,7 +333,13 @@ mod tests {
|
||||
#[test]
|
||||
fn an_unresolved_name_still_gets_generated_by_a_later_batch() {
|
||||
let projects = vec![project("/repos/p", 0, Some("claude"))];
|
||||
let r = resolve(&projects, &[preset("claude", "claude")], None, Utc::now());
|
||||
let r = resolve(
|
||||
&projects,
|
||||
&[preset("claude", "claude")],
|
||||
None,
|
||||
Utc::now(),
|
||||
None,
|
||||
);
|
||||
let mut draft = DraftPane::default();
|
||||
r.apply_to_draft(&mut draft);
|
||||
draft.seed_names(vec!["late-name".into()]);
|
||||
@@ -273,7 +349,13 @@ mod tests {
|
||||
#[test]
|
||||
fn a_last_command_no_preset_advertises_lands_in_custom_text() {
|
||||
let projects = vec![project("/repos/p", 0, Some("nvim -d"))];
|
||||
let r = resolve(&projects, &[preset("claude", "claude")], None, Utc::now());
|
||||
let r = resolve(
|
||||
&projects,
|
||||
&[preset("claude", "claude")],
|
||||
None,
|
||||
Utc::now(),
|
||||
None,
|
||||
);
|
||||
let mut draft = DraftPane::default();
|
||||
r.apply_to_draft(&mut draft);
|
||||
assert_eq!(draft.command(), "nvim -d");
|
||||
|
||||
@@ -7,6 +7,7 @@ pub mod app;
|
||||
pub mod catalog;
|
||||
pub mod cli;
|
||||
pub mod config;
|
||||
pub mod daemon_link;
|
||||
pub mod draft;
|
||||
pub mod emulators;
|
||||
pub mod fast_forward;
|
||||
@@ -33,14 +34,17 @@ use ratatui::Terminal;
|
||||
use crate::app::App;
|
||||
use crate::catalog::CatalogStore;
|
||||
use crate::config::TuiConfig;
|
||||
use crate::daemon_link::DaemonLink;
|
||||
|
||||
/// Inputs for [`run`]. Built by the umbrella binary from the parsed
|
||||
/// `TuiArgs` plus any global flags.
|
||||
#[derive(Debug, Clone)]
|
||||
pub struct RunConfig {
|
||||
/// HTTP base URL of the local daemon, e.g. `http://127.0.0.1:7070`.
|
||||
/// No trailing slash.
|
||||
pub daemon_url: String,
|
||||
/// Explicit `--daemon-url` / `$MAESTRO_DAEMON_URL` override. When `None`
|
||||
/// the URL is resolved from the config file the same way the CLI resolves
|
||||
/// it: `[cli].daemon_url`, then the local `[daemon].bind_addr`, then
|
||||
/// `maestro_config::DEFAULT_DAEMON_URL`.
|
||||
pub daemon_url: Option<String>,
|
||||
/// Explicit `--config <path>` override from the umbrella binary's global
|
||||
/// flag. When `None`, [`maestro_config::default_config_path`] picks the
|
||||
/// default (`$MAESTRO_CONFIG` or `~/.config/maestro/config.toml`).
|
||||
@@ -64,7 +68,25 @@ pub enum TuiError {
|
||||
pub async fn run(cfg: RunConfig) -> Result<(), TuiError> {
|
||||
terminal::install_panic_hook();
|
||||
|
||||
let base_url = cfg.daemon_url.trim_end_matches('/').to_string();
|
||||
// Load runtime config first: it carries the daemon URL as well as the UI
|
||||
// settings. Explicit `--config <path>` wins, then `$MAESTRO_CONFIG`, then
|
||||
// the platform default. Missing file is fine — we fall back to shipped
|
||||
// defaults.
|
||||
let cfg_path = cfg.config_path.clone().map(Ok).unwrap_or_else(|| {
|
||||
maestro_config::default_config_path().map_err(|e| TuiError::Config(e.to_string()))
|
||||
});
|
||||
let cfg_file = match cfg_path {
|
||||
Ok(path) => maestro_config::MaestroConfigFile::load(&path)
|
||||
.map_err(|e| TuiError::Config(e.to_string()))?,
|
||||
Err(_) => maestro_config::MaestroConfigFile::default(),
|
||||
};
|
||||
|
||||
// Same resolution order the CLI uses, so a host that moved `bind_addr` off
|
||||
// the default port stays reachable from the TUI without a second setting.
|
||||
let base_url = cfg_file
|
||||
.resolve_daemon_url(cfg.daemon_url.clone())
|
||||
.trim_end_matches('/')
|
||||
.to_string();
|
||||
|
||||
// Health check — fail fast if no daemon is reachable.
|
||||
health_check(&DaemonClient::with_timeouts(
|
||||
@@ -75,18 +97,6 @@ pub async fn run(cfg: RunConfig) -> Result<(), TuiError> {
|
||||
.await?;
|
||||
|
||||
let daemon = DaemonClient::with_timeouts(&base_url, REQUEST_TIMEOUT, REQUEST_TIMEOUT);
|
||||
|
||||
// Load runtime config: explicit `--config <path>` wins, then
|
||||
// `$MAESTRO_CONFIG`, then the platform default. Missing file is fine —
|
||||
// we fall back to shipped defaults.
|
||||
let cfg_path = cfg.config_path.clone().map(Ok).unwrap_or_else(|| {
|
||||
maestro_config::default_config_path().map_err(|e| TuiError::Config(e.to_string()))
|
||||
});
|
||||
let cfg_file = match cfg_path {
|
||||
Ok(path) => maestro_config::MaestroConfigFile::load(&path)
|
||||
.map_err(|e| TuiError::Config(e.to_string()))?,
|
||||
Err(_) => maestro_config::MaestroConfigFile::default(),
|
||||
};
|
||||
let tui_cfg = TuiConfig::load(&cfg_file.tui).map_err(|e| TuiError::Config(e.to_string()))?;
|
||||
palette::set_active(tui_cfg.palette);
|
||||
|
||||
@@ -94,8 +104,15 @@ pub async fn run(cfg: RunConfig) -> Result<(), TuiError> {
|
||||
let ws_url = daemon
|
||||
.events_url()
|
||||
.map_err(|e| TuiError::Config(e.to_string()))?;
|
||||
// The link watches the same daemon over `/api/info`; the events socket
|
||||
// reports its own connects and disconnects into it (`docs/RESTART.md`).
|
||||
let link = DaemonLink::default();
|
||||
let bg_catalog = catalog.clone();
|
||||
tokio::spawn(async move { bg_catalog.run_events_loop(ws_url).await });
|
||||
let ws_link = link.clone();
|
||||
tokio::spawn(async move { bg_catalog.run_events_loop_reporting(ws_url, ws_link).await });
|
||||
let probe_link = link.clone();
|
||||
let probe_daemon = daemon.clone();
|
||||
tokio::spawn(async move { probe_link.run_probe_loop(probe_daemon).await });
|
||||
|
||||
// Wait briefly for the bootstrap Snapshot to land. If it doesn't, we
|
||||
// still enter the UI — the sidebar will populate when events flow.
|
||||
@@ -107,7 +124,7 @@ pub async fn run(cfg: RunConfig) -> Result<(), TuiError> {
|
||||
let backend = CrosstermBackend::new(std::io::stdout());
|
||||
let mut terminal = Terminal::new(backend).map_err(|e| TuiError::Terminal(e.to_string()))?;
|
||||
|
||||
let app = App::new(tui_cfg, catalog, daemon);
|
||||
let app = App::new(tui_cfg, catalog, daemon, link);
|
||||
app.run(&mut terminal).await
|
||||
}
|
||||
|
||||
|
||||
@@ -1,8 +1,5 @@
|
||||
//! Overlay widgets: kill-confirm prompt, rename prompt, help overlay,
|
||||
//! transient toast.
|
||||
//!
|
||||
//! The spawn form is no longer an overlay (issue #63) — it lives in draft
|
||||
//! panes ([`crate::draft::DraftPane`]).
|
||||
//! Overlay widgets: spawn modal, kill-confirm prompt, rename prompt, help
|
||||
//! overlay, restart overlay, transient toast.
|
||||
//!
|
||||
//! All overlays are centered popups drawn over the rest of the UI; the
|
||||
//! `Clear` widget wipes the underlying buffer before drawing.
|
||||
@@ -15,6 +12,63 @@ use ratatui::Frame;
|
||||
|
||||
use crate::text_input::TextInput;
|
||||
|
||||
/// Chrome for the spawn form. The form itself ([`crate::draft::DraftPane`])
|
||||
/// draws into the rect this returns, so the two can be sized independently.
|
||||
#[derive(Debug, Clone, Copy)]
|
||||
pub struct SpawnModal;
|
||||
|
||||
impl SpawnModal {
|
||||
/// Draw the frame and return the area the form should render into.
|
||||
pub fn render(&self, f: &mut Frame, parent: Rect) -> (Rect, Rect) {
|
||||
// Tall enough for the whole form — presets, picker, name and the
|
||||
// advanced section — without pushing past small terminals.
|
||||
let area = centered(parent, 72, parent.height.saturating_sub(4).min(26));
|
||||
f.render_widget(Clear, area);
|
||||
let block = Block::default()
|
||||
.title(" new session ")
|
||||
.borders(Borders::ALL);
|
||||
let inner = block.inner(area);
|
||||
f.render_widget(block, area);
|
||||
(area, inner)
|
||||
}
|
||||
}
|
||||
|
||||
/// Shown while the daemon is unreachable past the grace window, over
|
||||
/// everything else, with the keyboard locked (`docs/RESTART.md`). Nothing to
|
||||
/// dismiss: it clears itself when a probe succeeds.
|
||||
#[derive(Debug, Clone)]
|
||||
pub struct RestartOverlay {
|
||||
/// Failed probes so far, so a long restart doesn't read as a hang.
|
||||
pub attempts: u32,
|
||||
/// The release the daemon was running before it went away.
|
||||
pub release: String,
|
||||
}
|
||||
|
||||
impl RestartOverlay {
|
||||
pub fn render(&self, f: &mut Frame, parent: Rect) {
|
||||
let area = centered(parent, 54, 7);
|
||||
f.render_widget(Clear, area);
|
||||
let block = Block::default()
|
||||
.title(" daemon restarting ")
|
||||
.borders(Borders::ALL);
|
||||
let inner = block.inner(area);
|
||||
f.render_widget(block, area);
|
||||
let attempts = if self.attempts <= 1 {
|
||||
String::new()
|
||||
} else {
|
||||
format!(" ({} attempts)", self.attempts)
|
||||
};
|
||||
let lines = vec![
|
||||
Line::from("Waiting for the daemon to come back…"),
|
||||
Line::from(format!("Polling /api/info{attempts}")),
|
||||
Line::from(""),
|
||||
Line::from(format!("was: {}", self.release)),
|
||||
Line::from("Sessions are held by tmux and survive the restart."),
|
||||
];
|
||||
f.render_widget(Paragraph::new(lines), inner);
|
||||
}
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone)]
|
||||
pub struct KillConfirm {
|
||||
pub label: String,
|
||||
@@ -168,6 +222,20 @@ mod tests {
|
||||
out
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn spawn_modal_frames_an_inner_area_inside_its_border() {
|
||||
let mut inner = None;
|
||||
let rendered = render_to_string(90, 30, |f| {
|
||||
let (area, i) = SpawnModal.render(f, f.area());
|
||||
inner = Some((area, i));
|
||||
f.render_widget(Paragraph::new("form goes here"), i);
|
||||
});
|
||||
let (area, i) = inner.unwrap();
|
||||
assert!(i.x > area.x && i.y > area.y, "{area:?} vs {i:?}");
|
||||
assert!(rendered.contains("new session"), "{rendered}");
|
||||
assert!(rendered.contains("form goes here"), "{rendered}");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn kill_confirm_renders_prompt() {
|
||||
let modal = KillConfirm {
|
||||
|
||||
@@ -13,15 +13,17 @@
|
||||
//!
|
||||
//! Each surface carries its own activity colours. A state colour picked for
|
||||
//! the dark card background is not legible on the selection background, so
|
||||
//! the selected card uses the selection surface's own state colours; the dot
|
||||
//! keeps carrying the state either way (docs/SIDEBAR.md).
|
||||
//! the selected card uses the selection surface's own state colours; the
|
||||
//! rail keeps carrying the state either way (docs/SIDEBAR.md).
|
||||
//!
|
||||
//! [`Palette::DARK`] is the default. [`Palette::LIGHT`] is its light peer and
|
||||
//! [`Palette::ANSI`] uses terminal-provided ANSI colours. The remaining
|
||||
//! presets ([`Palette::presets`]) adapt well-known editor themes — Solarized,
|
||||
//! Catppuccin, GitHub, Tokyo Night, Gruvbox, Nord, Dracula — with individual
|
||||
//! colours lifted or darkened where the originals fall short of the contrast
|
||||
//! floors asserted below.
|
||||
//! [`Palette::DARK`] — graphite, no accent hue — is the default.
|
||||
//! [`Palette::LIGHT`] is its light peer and [`Palette::ANSI`] uses
|
||||
//! terminal-provided ANSI colours. Five house presets recolour the graphite
|
||||
//! base with an accent (Ice Cyan, Periwinkle, Amber Phosphor, Ember, Orchid);
|
||||
//! the remaining presets ([`Palette::presets`]) adapt well-known editor
|
||||
//! themes — Solarized, Catppuccin, GitHub, Tokyo Night, Gruvbox, Nord,
|
||||
//! Dracula — with individual colours lifted or darkened where the originals
|
||||
//! fall short of the contrast floors asserted below.
|
||||
//!
|
||||
//! Out of scope: PTY cell colours. Those belong to the program running in the
|
||||
//! pane and pass through `pane::translate_color` verbatim.
|
||||
@@ -135,73 +137,75 @@ pub struct Palette {
|
||||
}
|
||||
|
||||
impl Palette {
|
||||
/// The dark terminal-native palette and the default preset.
|
||||
/// The graphite dark palette and the default preset: pure near-neutral
|
||||
/// chrome with an ink-coloured accent, so activity colours are the only
|
||||
/// hue on screen.
|
||||
pub const DARK: Palette = Palette {
|
||||
card: Surface {
|
||||
bg: Color::Rgb(0x1f, 0x23, 0x2b),
|
||||
fg: Color::Rgb(0xe5, 0xe7, 0xeb),
|
||||
muted: Color::Rgb(0xae, 0xb7, 0xc4),
|
||||
dim: Color::Rgb(0x85, 0x8f, 0x9e),
|
||||
bg: Color::Rgb(0x1d, 0x1f, 0x22),
|
||||
fg: Color::Rgb(0xe6, 0xe8, 0xeb),
|
||||
muted: Color::Rgb(0xb1, 0xb4, 0xb9),
|
||||
dim: Color::Rgb(0x86, 0x89, 0x8e),
|
||||
active: Color::Rgb(0x72, 0xd6, 0x87),
|
||||
idle: Color::Rgb(0xae, 0xb7, 0xc4),
|
||||
idle: Color::Rgb(0xb1, 0xb4, 0xb9),
|
||||
awaiting: Color::Rgb(0xf2, 0xc9, 0x5c),
|
||||
error: Color::Rgb(0xff, 0x82, 0x7a),
|
||||
},
|
||||
selection: Surface {
|
||||
bg: Color::Rgb(0x3d, 0x51, 0x44),
|
||||
fg: Color::Rgb(0xf3, 0xf7, 0xf4),
|
||||
muted: Color::Rgb(0xd0, 0xd9, 0xd3),
|
||||
dim: Color::Rgb(0xa1, 0xb0, 0xa6),
|
||||
bg: Color::Rgb(0x3f, 0x43, 0x48),
|
||||
fg: Color::Rgb(0xf0, 0xf2, 0xf5),
|
||||
muted: Color::Rgb(0xce, 0xd1, 0xd5),
|
||||
dim: Color::Rgb(0xa5, 0xa8, 0xab),
|
||||
active: Color::Rgb(0x9a, 0xf0, 0xa6),
|
||||
idle: Color::Rgb(0xc4, 0xcf, 0xc7),
|
||||
idle: Color::Rgb(0xd5, 0xd8, 0xdb),
|
||||
awaiting: Color::Rgb(0xf6, 0xd9, 0x78),
|
||||
error: Color::Rgb(0xff, 0xa8, 0xa3),
|
||||
},
|
||||
chrome_bg: Color::Rgb(0x1f, 0x23, 0x2b),
|
||||
sidebar_focus_bg: Color::Rgb(0x28, 0x30, 0x2a),
|
||||
border_focused: Color::Rgb(0x72, 0xd6, 0x87),
|
||||
border_unfocused: Color::Rgb(0x68, 0x73, 0x84),
|
||||
focus_accent: Color::Rgb(0x72, 0xd6, 0x87),
|
||||
group_row: Color::Rgb(0xb6, 0xc1, 0xd3),
|
||||
mode_normal_bg: Color::Rgb(0x72, 0xd6, 0x87),
|
||||
mode_normal_fg: Color::Rgb(0x1f, 0x23, 0x2b),
|
||||
chrome_bg: Color::Rgb(0x1d, 0x1f, 0x22),
|
||||
sidebar_focus_bg: Color::Rgb(0x28, 0x2a, 0x2d),
|
||||
border_focused: Color::Rgb(0xe2, 0xe5, 0xe8),
|
||||
border_unfocused: Color::Rgb(0x72, 0x75, 0x79),
|
||||
focus_accent: Color::Rgb(0xe2, 0xe5, 0xe8),
|
||||
group_row: Color::Rgb(0xba, 0xbe, 0xc3),
|
||||
mode_normal_bg: Color::Rgb(0xe2, 0xe5, 0xe8),
|
||||
mode_normal_fg: Color::Rgb(0x17, 0x1b, 0x20),
|
||||
mode_insert_bg: Color::Rgb(0xf2, 0xc9, 0x5c),
|
||||
mode_insert_fg: Color::Rgb(0x1f, 0x23, 0x2b),
|
||||
mode_insert_fg: Color::Rgb(0x1d, 0x1f, 0x22),
|
||||
error_text: Color::Rgb(0xff, 0x82, 0x7a),
|
||||
};
|
||||
|
||||
/// A high-contrast light peer to [`Self::DARK`].
|
||||
/// A high-contrast light peer to [`Self::DARK`]: ink-on-paper graphite.
|
||||
pub const LIGHT: Palette = Palette {
|
||||
card: Surface {
|
||||
bg: Color::Rgb(0xff, 0xff, 0xff),
|
||||
fg: Color::Rgb(0x27, 0x31, 0x3d),
|
||||
muted: Color::Rgb(0x4c, 0x5b, 0x6b),
|
||||
dim: Color::Rgb(0x68, 0x78, 0x8a),
|
||||
fg: Color::Rgb(0x20, 0x24, 0x2a),
|
||||
muted: Color::Rgb(0x56, 0x5b, 0x63),
|
||||
dim: Color::Rgb(0x7b, 0x81, 0x89),
|
||||
active: Color::Rgb(0x21, 0x7a, 0x3c),
|
||||
idle: Color::Rgb(0x4c, 0x5b, 0x6b),
|
||||
idle: Color::Rgb(0x56, 0x5b, 0x63),
|
||||
awaiting: Color::Rgb(0x8f, 0x63, 0x00),
|
||||
error: Color::Rgb(0xb4, 0x23, 0x18),
|
||||
},
|
||||
selection: Surface {
|
||||
bg: Color::Rgb(0xb5, 0xcf, 0xba),
|
||||
fg: Color::Rgb(0x1d, 0x2a, 0x24),
|
||||
muted: Color::Rgb(0x3f, 0x55, 0x45),
|
||||
dim: Color::Rgb(0x52, 0x68, 0x5a),
|
||||
bg: Color::Rgb(0xc5, 0xc7, 0xca),
|
||||
fg: Color::Rgb(0x15, 0x19, 0x1e),
|
||||
muted: Color::Rgb(0x43, 0x48, 0x4f),
|
||||
dim: Color::Rgb(0x5e, 0x64, 0x6b),
|
||||
active: Color::Rgb(0x15, 0x5b, 0x2e),
|
||||
idle: Color::Rgb(0x3f, 0x55, 0x45),
|
||||
idle: Color::Rgb(0x38, 0x3e, 0x45),
|
||||
awaiting: Color::Rgb(0x69, 0x46, 0x00),
|
||||
error: Color::Rgb(0xa5, 0x1d, 0x14),
|
||||
error: Color::Rgb(0x99, 0x1a, 0x12),
|
||||
},
|
||||
chrome_bg: Color::Rgb(0xff, 0xff, 0xff),
|
||||
sidebar_focus_bg: Color::Rgb(0xee, 0xf5, 0xef),
|
||||
border_focused: Color::Rgb(0x21, 0x7a, 0x3c),
|
||||
border_unfocused: Color::Rgb(0x65, 0x73, 0x6b),
|
||||
focus_accent: Color::Rgb(0x21, 0x7a, 0x3c),
|
||||
group_row: Color::Rgb(0x3f, 0x55, 0x45),
|
||||
mode_normal_bg: Color::Rgb(0x21, 0x7a, 0x3c),
|
||||
mode_normal_fg: Color::Rgb(0xff, 0xff, 0xff),
|
||||
mode_insert_bg: Color::Rgb(0xb6, 0x81, 0x08),
|
||||
mode_insert_fg: Color::Rgb(0x0b, 0x12, 0x0e),
|
||||
sidebar_focus_bg: Color::Rgb(0xef, 0xf0, 0xf2),
|
||||
border_focused: Color::Rgb(0x36, 0x3b, 0x41),
|
||||
border_unfocused: Color::Rgb(0x76, 0x7b, 0x82),
|
||||
focus_accent: Color::Rgb(0x36, 0x3b, 0x41),
|
||||
group_row: Color::Rgb(0x4e, 0x53, 0x5a),
|
||||
mode_normal_bg: Color::Rgb(0x23, 0x27, 0x2c),
|
||||
mode_normal_fg: Color::Rgb(0xf9, 0xfa, 0xfb),
|
||||
mode_insert_bg: Color::Rgb(0x8f, 0x63, 0x00),
|
||||
mode_insert_fg: Color::Rgb(0xff, 0xff, 0xff),
|
||||
error_text: Color::Rgb(0xb4, 0x23, 0x18),
|
||||
};
|
||||
|
||||
@@ -556,14 +560,195 @@ impl Palette {
|
||||
error_text: Color::Rgb(0xff, 0x59, 0x59),
|
||||
};
|
||||
|
||||
/// Ice Cyan — signal-cyan accent on the graphite slate base.
|
||||
pub const ICE_CYAN: Palette = Palette {
|
||||
card: Surface {
|
||||
bg: Color::Rgb(0x1c, 0x20, 0x25),
|
||||
fg: Color::Rgb(0xe4, 0xe8, 0xed),
|
||||
muted: Color::Rgb(0xaf, 0xb5, 0xbc),
|
||||
dim: Color::Rgb(0x84, 0x8a, 0x91),
|
||||
active: Color::Rgb(0x72, 0xd6, 0x87),
|
||||
idle: Color::Rgb(0xaf, 0xb5, 0xbc),
|
||||
awaiting: Color::Rgb(0xf2, 0xc9, 0x5c),
|
||||
error: Color::Rgb(0xff, 0x82, 0x7a),
|
||||
},
|
||||
selection: Surface {
|
||||
bg: Color::Rgb(0x24, 0x4d, 0x59),
|
||||
fg: Color::Rgb(0xee, 0xf2, 0xf7),
|
||||
muted: Color::Rgb(0xcd, 0xd1, 0xd7),
|
||||
dim: Color::Rgb(0xa4, 0xa8, 0xae),
|
||||
active: Color::Rgb(0x9a, 0xf0, 0xa6),
|
||||
idle: Color::Rgb(0xd3, 0xd8, 0xde),
|
||||
awaiting: Color::Rgb(0xf6, 0xd9, 0x78),
|
||||
error: Color::Rgb(0xff, 0xa8, 0xa3),
|
||||
},
|
||||
chrome_bg: Color::Rgb(0x1c, 0x20, 0x25),
|
||||
sidebar_focus_bg: Color::Rgb(0x26, 0x2a, 0x30),
|
||||
border_focused: Color::Rgb(0x61, 0xe3, 0xf1),
|
||||
border_unfocused: Color::Rgb(0x70, 0x75, 0x7b),
|
||||
focus_accent: Color::Rgb(0x61, 0xe3, 0xf1),
|
||||
group_row: Color::Rgb(0xb8, 0xbe, 0xc6),
|
||||
mode_normal_bg: Color::Rgb(0x61, 0xe3, 0xf1),
|
||||
mode_normal_fg: Color::Rgb(0x0f, 0x22, 0x2b),
|
||||
mode_insert_bg: Color::Rgb(0xf2, 0xc9, 0x5c),
|
||||
mode_insert_fg: Color::Rgb(0x1c, 0x20, 0x25),
|
||||
error_text: Color::Rgb(0xff, 0x82, 0x7a),
|
||||
};
|
||||
|
||||
/// Periwinkle — indigo-tinted base with a soft blue-violet accent.
|
||||
pub const PERIWINKLE: Palette = Palette {
|
||||
card: Surface {
|
||||
bg: Color::Rgb(0x1d, 0x1e, 0x29),
|
||||
fg: Color::Rgb(0xe5, 0xe7, 0xf1),
|
||||
muted: Color::Rgb(0xb1, 0xb3, 0xc2),
|
||||
dim: Color::Rgb(0x86, 0x88, 0x96),
|
||||
active: Color::Rgb(0x72, 0xd6, 0x87),
|
||||
idle: Color::Rgb(0xb1, 0xb3, 0xc2),
|
||||
awaiting: Color::Rgb(0xf2, 0xc9, 0x5c),
|
||||
error: Color::Rgb(0xff, 0x82, 0x7a),
|
||||
},
|
||||
selection: Surface {
|
||||
bg: Color::Rgb(0x3b, 0x43, 0x6c),
|
||||
fg: Color::Rgb(0xef, 0xf1, 0xfb),
|
||||
muted: Color::Rgb(0xce, 0xd0, 0xdc),
|
||||
dim: Color::Rgb(0xa5, 0xa7, 0xb2),
|
||||
active: Color::Rgb(0x9a, 0xf0, 0xa6),
|
||||
idle: Color::Rgb(0xd4, 0xd7, 0xe3),
|
||||
awaiting: Color::Rgb(0xf6, 0xd9, 0x78),
|
||||
error: Color::Rgb(0xff, 0xa8, 0xa3),
|
||||
},
|
||||
chrome_bg: Color::Rgb(0x1d, 0x1e, 0x29),
|
||||
sidebar_focus_bg: Color::Rgb(0x27, 0x29, 0x35),
|
||||
border_focused: Color::Rgb(0x97, 0xa7, 0xfd),
|
||||
border_unfocused: Color::Rgb(0x71, 0x74, 0x80),
|
||||
focus_accent: Color::Rgb(0x97, 0xa7, 0xfd),
|
||||
group_row: Color::Rgb(0xba, 0xbd, 0xcc),
|
||||
mode_normal_bg: Color::Rgb(0x97, 0xa7, 0xfd),
|
||||
mode_normal_fg: Color::Rgb(0x12, 0x14, 0x28),
|
||||
mode_insert_bg: Color::Rgb(0xf2, 0xc9, 0x5c),
|
||||
mode_insert_fg: Color::Rgb(0x1d, 0x1e, 0x29),
|
||||
error_text: Color::Rgb(0xff, 0x82, 0x7a),
|
||||
};
|
||||
|
||||
/// Amber Phosphor — CRT amber on warm graphite. The awaiting colour
|
||||
/// shifts orange so it stays distinct from the amber accent.
|
||||
pub const AMBER_PHOSPHOR: Palette = Palette {
|
||||
card: Surface {
|
||||
bg: Color::Rgb(0x22, 0x1f, 0x1a),
|
||||
fg: Color::Rgb(0xec, 0xe7, 0xe1),
|
||||
muted: Color::Rgb(0xba, 0xb3, 0xaa),
|
||||
dim: Color::Rgb(0x8f, 0x88, 0x7f),
|
||||
active: Color::Rgb(0x72, 0xd6, 0x87),
|
||||
idle: Color::Rgb(0xba, 0xb3, 0xaa),
|
||||
awaiting: Color::Rgb(0xff, 0x9b, 0x50),
|
||||
error: Color::Rgb(0xff, 0x82, 0x7a),
|
||||
},
|
||||
selection: Surface {
|
||||
bg: Color::Rgb(0x55, 0x43, 0x26),
|
||||
fg: Color::Rgb(0xf6, 0xf1, 0xeb),
|
||||
muted: Color::Rgb(0xd6, 0xd0, 0xc9),
|
||||
dim: Color::Rgb(0xad, 0xa7, 0xa0),
|
||||
active: Color::Rgb(0x9a, 0xf0, 0xa6),
|
||||
idle: Color::Rgb(0xdd, 0xd6, 0xcf),
|
||||
awaiting: Color::Rgb(0xff, 0xb9, 0x72),
|
||||
error: Color::Rgb(0xff, 0xa8, 0xa3),
|
||||
},
|
||||
chrome_bg: Color::Rgb(0x22, 0x1f, 0x1a),
|
||||
sidebar_focus_bg: Color::Rgb(0x2d, 0x29, 0x25),
|
||||
border_focused: Color::Rgb(0xf9, 0xbb, 0x51),
|
||||
border_unfocused: Color::Rgb(0x7a, 0x73, 0x6c),
|
||||
focus_accent: Color::Rgb(0xf9, 0xbb, 0x51),
|
||||
group_row: Color::Rgb(0xc4, 0xbc, 0xb3),
|
||||
mode_normal_bg: Color::Rgb(0xf9, 0xbb, 0x51),
|
||||
mode_normal_fg: Color::Rgb(0x2f, 0x1e, 0x01),
|
||||
mode_insert_bg: Color::Rgb(0xff, 0x9b, 0x50),
|
||||
mode_insert_fg: Color::Rgb(0x22, 0x1f, 0x1a),
|
||||
error_text: Color::Rgb(0xff, 0x82, 0x7a),
|
||||
};
|
||||
|
||||
/// Ember — warm orange-red accent on a cleaner warm neutral.
|
||||
pub const EMBER: Palette = Palette {
|
||||
card: Surface {
|
||||
bg: Color::Rgb(0x23, 0x1e, 0x1b),
|
||||
fg: Color::Rgb(0xed, 0xe6, 0xe3),
|
||||
muted: Color::Rgb(0xbc, 0xb2, 0xad),
|
||||
dim: Color::Rgb(0x90, 0x87, 0x82),
|
||||
active: Color::Rgb(0x72, 0xd6, 0x87),
|
||||
idle: Color::Rgb(0xbc, 0xb2, 0xad),
|
||||
awaiting: Color::Rgb(0xf2, 0xc9, 0x5c),
|
||||
error: Color::Rgb(0xff, 0x82, 0x7a),
|
||||
},
|
||||
selection: Surface {
|
||||
bg: Color::Rgb(0x5d, 0x3e, 0x30),
|
||||
fg: Color::Rgb(0xf7, 0xf0, 0xed),
|
||||
muted: Color::Rgb(0xd7, 0xcf, 0xcb),
|
||||
dim: Color::Rgb(0xae, 0xa6, 0xa2),
|
||||
active: Color::Rgb(0x9a, 0xf0, 0xa6),
|
||||
idle: Color::Rgb(0xde, 0xd5, 0xd1),
|
||||
awaiting: Color::Rgb(0xf6, 0xd9, 0x78),
|
||||
error: Color::Rgb(0xff, 0xa8, 0xa3),
|
||||
},
|
||||
chrome_bg: Color::Rgb(0x23, 0x1e, 0x1b),
|
||||
sidebar_focus_bg: Color::Rgb(0x2e, 0x29, 0x26),
|
||||
border_focused: Color::Rgb(0xf7, 0x89, 0x55),
|
||||
border_unfocused: Color::Rgb(0x7b, 0x72, 0x6e),
|
||||
focus_accent: Color::Rgb(0xf7, 0x89, 0x55),
|
||||
group_row: Color::Rgb(0xc6, 0xbb, 0xb6),
|
||||
mode_normal_bg: Color::Rgb(0xf7, 0x89, 0x55),
|
||||
mode_normal_fg: Color::Rgb(0x2a, 0x14, 0x0a),
|
||||
mode_insert_bg: Color::Rgb(0xf2, 0xc9, 0x5c),
|
||||
mode_insert_fg: Color::Rgb(0x23, 0x1e, 0x1b),
|
||||
error_text: Color::Rgb(0xff, 0x82, 0x7a),
|
||||
};
|
||||
|
||||
/// Orchid — muted violet accent on a faintly violet base.
|
||||
pub const ORCHID: Palette = Palette {
|
||||
card: Surface {
|
||||
bg: Color::Rgb(0x21, 0x1e, 0x25),
|
||||
fg: Color::Rgb(0xe9, 0xe6, 0xee),
|
||||
muted: Color::Rgb(0xb6, 0xb2, 0xbd),
|
||||
dim: Color::Rgb(0x8b, 0x87, 0x91),
|
||||
active: Color::Rgb(0x72, 0xd6, 0x87),
|
||||
idle: Color::Rgb(0xb6, 0xb2, 0xbd),
|
||||
awaiting: Color::Rgb(0xf2, 0xc9, 0x5c),
|
||||
error: Color::Rgb(0xff, 0x82, 0x7a),
|
||||
},
|
||||
selection: Surface {
|
||||
bg: Color::Rgb(0x51, 0x3c, 0x63),
|
||||
fg: Color::Rgb(0xf3, 0xf0, 0xf8),
|
||||
muted: Color::Rgb(0xd3, 0xcf, 0xd8),
|
||||
dim: Color::Rgb(0xa9, 0xa6, 0xaf),
|
||||
active: Color::Rgb(0x9a, 0xf0, 0xa6),
|
||||
idle: Color::Rgb(0xd9, 0xd5, 0xdf),
|
||||
awaiting: Color::Rgb(0xf6, 0xd9, 0x78),
|
||||
error: Color::Rgb(0xff, 0xa8, 0xa3),
|
||||
},
|
||||
chrome_bg: Color::Rgb(0x21, 0x1e, 0x25),
|
||||
sidebar_focus_bg: Color::Rgb(0x2c, 0x28, 0x30),
|
||||
border_focused: Color::Rgb(0xd1, 0x9f, 0xf5),
|
||||
border_unfocused: Color::Rgb(0x76, 0x72, 0x7c),
|
||||
focus_accent: Color::Rgb(0xd1, 0x9f, 0xf5),
|
||||
group_row: Color::Rgb(0xc0, 0xbb, 0xc7),
|
||||
mode_normal_bg: Color::Rgb(0xd1, 0x9f, 0xf5),
|
||||
mode_normal_fg: Color::Rgb(0x22, 0x13, 0x2c),
|
||||
mode_insert_bg: Color::Rgb(0xf2, 0xc9, 0x5c),
|
||||
mode_insert_fg: Color::Rgb(0x21, 0x1e, 0x25),
|
||||
error_text: Color::Rgb(0xff, 0x82, 0x7a),
|
||||
};
|
||||
|
||||
/// The default preset, retained as a named compatibility constant.
|
||||
pub const DEFAULT: Palette = Self::DARK;
|
||||
|
||||
/// All preset names and their complete palettes.
|
||||
pub fn presets() -> [(&'static str, Palette); 12] {
|
||||
pub fn presets() -> [(&'static str, Palette); 17] {
|
||||
[
|
||||
("dark", Self::DARK),
|
||||
("light", Self::LIGHT),
|
||||
("ice-cyan", Self::ICE_CYAN),
|
||||
("periwinkle", Self::PERIWINKLE),
|
||||
("amber-phosphor", Self::AMBER_PHOSPHOR),
|
||||
("ember", Self::EMBER),
|
||||
("orchid", Self::ORCHID),
|
||||
("ansi", Self::ANSI),
|
||||
("solarized-dark", Self::SOLARIZED_DARK),
|
||||
("solarized-light", Self::SOLARIZED_LIGHT),
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
//! Pure helpers behind the draft pane's project picker (#64): staleness,
|
||||
//! Pure helpers behind the spawn form's project picker (#64): staleness,
|
||||
//! recency ordering, worktree grouping, and free-text filtering. Mirrors
|
||||
//! `web/src/projectList.ts` so both clients order and dim identically — the
|
||||
//! daemon reports the timestamps; what "stale" means is a client decision
|
||||
|
||||
@@ -3,14 +3,17 @@
|
||||
//! hit-test mouse clicks.
|
||||
|
||||
use ratatui::layout::{Constraint, Direction, Layout, Rect};
|
||||
use ratatui::style::Modifier;
|
||||
use ratatui::style::{Modifier, Style};
|
||||
use ratatui::text::Span;
|
||||
use ratatui::widgets::Paragraph;
|
||||
use ratatui::Frame;
|
||||
|
||||
use maestro_protocol::ActivityState;
|
||||
|
||||
use crate::daemon_link::{format_release, LinkState, LinkStatus};
|
||||
use crate::input::Region;
|
||||
use crate::keymap::Mode;
|
||||
use crate::overlays::{HelpOverlay, KillConfirm, RenamePrompt, Toast};
|
||||
use crate::overlays::{HelpOverlay, KillConfirm, RenamePrompt, RestartOverlay, SpawnModal, Toast};
|
||||
use crate::palette;
|
||||
use crate::pane::Pane;
|
||||
use crate::sidebar::Sidebar;
|
||||
@@ -77,12 +80,15 @@ pub struct RenderInputs<'a> {
|
||||
pub home_dir: &'a str,
|
||||
pub pane_title: &'a str,
|
||||
pub pane: Option<&'a Pane>,
|
||||
/// Inline spawn form when the pane is a draft (issue #63).
|
||||
/// The spawn form behind [`OverlayKind::Spawn`], when one is up.
|
||||
pub draft: Option<&'a crate::draft::DraftPane>,
|
||||
pub state: &'a AppState,
|
||||
pub help: &'a HelpOverlay,
|
||||
/// Edit buffer behind the rename prompt (#125).
|
||||
pub rename_input: &'a crate::text_input::TextInput,
|
||||
/// Liveness + release of the daemon, for the status bar's indicator and the
|
||||
/// restart overlay (`docs/RESTART.md`).
|
||||
pub link: &'a crate::daemon_link::LinkStatus,
|
||||
}
|
||||
|
||||
/// Draw one frame. Returns the `RegionMap` the input router will consult for
|
||||
@@ -139,18 +145,24 @@ pub fn draw(f: &mut Frame, inputs: RenderInputs<'_>) -> RegionMap {
|
||||
if let Some(p) = inputs.pane {
|
||||
p.render(f, pane_area);
|
||||
}
|
||||
if let Some(d) = inputs.draft {
|
||||
d.render(f, pane_area, pane_focused);
|
||||
}
|
||||
// `RegionMap::pane` is also the PTY resize source. The title bar is
|
||||
// chrome; every remaining cell belongs to the emulator.
|
||||
map.pane = Some(pane_area);
|
||||
|
||||
// Status bar — always visible, never eclipsed by overlays so the user can
|
||||
// always see the current mode + key hints.
|
||||
render_status_bar(f, status_area, inputs.state);
|
||||
render_status_bar(f, status_area, inputs.state, inputs.link);
|
||||
|
||||
match inputs.state.overlay() {
|
||||
Some(OverlayKind::Spawn) => {
|
||||
if let Some(d) = inputs.draft {
|
||||
let (area, inner) = SpawnModal.render(f, area);
|
||||
// The modal owns the keyboard while it is up, so the form
|
||||
// always draws focused.
|
||||
d.render(f, inner, true);
|
||||
map.modal = Some(area);
|
||||
}
|
||||
}
|
||||
Some(OverlayKind::KillConfirm(id)) => {
|
||||
// #83: surface what the watcher last saw in the worktree, in
|
||||
// InTheWay's own words, before the operator commits to the kill.
|
||||
@@ -197,6 +209,22 @@ pub fn draw(f: &mut Frame, inputs: RenderInputs<'_>) -> RegionMap {
|
||||
None => {}
|
||||
}
|
||||
|
||||
// Last, so it covers whatever else is up: while the daemon is gone none of
|
||||
// it can act (`docs/RESTART.md`).
|
||||
if inputs.link.state == LinkState::Down {
|
||||
RestartOverlay {
|
||||
attempts: inputs.link.attempts,
|
||||
release: inputs
|
||||
.link
|
||||
.build
|
||||
.as_ref()
|
||||
.map(format_release)
|
||||
.unwrap_or_else(|| "unknown release".to_string()),
|
||||
}
|
||||
.render(f, area);
|
||||
map.modal = Some(area);
|
||||
}
|
||||
|
||||
map
|
||||
}
|
||||
|
||||
@@ -214,7 +242,16 @@ fn render_title_bar(f: &mut Frame, area: Rect, title: &str, focused: bool) {
|
||||
/// Render the always-visible status bar at the bottom of the frame. Surfaces
|
||||
/// mode + focused panel + the most useful key hints so the user is never
|
||||
/// guessing what state they're in.
|
||||
fn render_status_bar(f: &mut Frame, area: Rect, state: &AppState) {
|
||||
fn render_status_bar(f: &mut Frame, area: Rect, state: &AppState, link: &LinkStatus) {
|
||||
// The daemon indicator is pinned right and sized to its own text, so a
|
||||
// narrow terminal truncates the key hints rather than the release.
|
||||
let label = link_label(link);
|
||||
let indicator_w = (label.chars().count() as u16).saturating_add(3);
|
||||
let cols = Layout::default()
|
||||
.direction(Direction::Horizontal)
|
||||
.constraints([Constraint::Min(0), Constraint::Length(indicator_w)])
|
||||
.split(area);
|
||||
|
||||
let mode_label = match state.mode {
|
||||
Mode::Normal => "[NORMAL]",
|
||||
Mode::Insert => "[INSERT]",
|
||||
@@ -224,7 +261,7 @@ fn render_status_bar(f: &mut Frame, area: Rect, state: &AppState) {
|
||||
Focus::Pane => "pane",
|
||||
};
|
||||
let hint = match state.mode {
|
||||
Mode::Normal => "j/k: nav • enter: attach • s: new draft • ?: help • ^Wq: quit",
|
||||
Mode::Normal => "j/k: nav • enter: attach • s: spawn • ?: help • ^Wq: quit",
|
||||
Mode::Insert => "^a: return to sidebar",
|
||||
};
|
||||
let mode_style = palette::active().mode_style(state.mode == Mode::Insert);
|
||||
@@ -232,7 +269,42 @@ fn render_status_bar(f: &mut Frame, area: Rect, state: &AppState) {
|
||||
Span::styled(format!(" {mode_label} "), mode_style),
|
||||
Span::raw(format!(" {focus_label} • {hint}")),
|
||||
]);
|
||||
f.render_widget(Paragraph::new(line), area);
|
||||
f.render_widget(Paragraph::new(line), cols[0]);
|
||||
|
||||
let indicator = ratatui::text::Line::from(vec![
|
||||
Span::styled(" ●", Style::default().fg(link_colour(link.state))),
|
||||
Span::raw(format!(" {label} ")),
|
||||
]);
|
||||
f.render_widget(Paragraph::new(indicator), cols[1]);
|
||||
}
|
||||
|
||||
/// The status dot's colour: the same three the sidebar cards use for session
|
||||
/// activity, so "green is fine, red is broken" reads the same everywhere.
|
||||
fn link_colour(state: LinkState) -> ratatui::style::Color {
|
||||
let card = palette::active().card;
|
||||
match state {
|
||||
LinkState::Online => card.activity(ActivityState::Active),
|
||||
LinkState::Connecting | LinkState::Reconnecting => {
|
||||
card.activity(ActivityState::AwaitingInput)
|
||||
}
|
||||
LinkState::Down => card.activity(ActivityState::Error),
|
||||
}
|
||||
}
|
||||
|
||||
/// What sits next to the dot. The browser shows the release on hover; a
|
||||
/// terminal has no hover, so it is always on the line — replaced by the state
|
||||
/// while the daemon is not answering, which is the more urgent fact.
|
||||
fn link_label(link: &LinkStatus) -> String {
|
||||
match link.state {
|
||||
LinkState::Connecting => "connecting…".to_string(),
|
||||
LinkState::Reconnecting => "reconnecting…".to_string(),
|
||||
LinkState::Down => "daemon unreachable".to_string(),
|
||||
LinkState::Online => match (&link.upgraded_to, &link.build) {
|
||||
(Some(build), _) => format!("updated: {} (restart tui)", format_release(build)),
|
||||
(None, Some(build)) => format_release(build),
|
||||
(None, None) => "unknown release".to_string(),
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
@@ -240,6 +312,16 @@ mod tests {
|
||||
use super::*;
|
||||
use crate::input::Region;
|
||||
|
||||
/// A link that answered — the normal case every other render test assumes.
|
||||
fn online_link() -> LinkStatus {
|
||||
LinkStatus {
|
||||
state: LinkState::Online,
|
||||
build: None,
|
||||
attempts: 0,
|
||||
upgraded_to: None,
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn region_map_resolves_known_areas() {
|
||||
let map = RegionMap {
|
||||
@@ -325,20 +407,106 @@ mod tests {
|
||||
);
|
||||
}
|
||||
|
||||
/// Issue #63: an empty pane is a draft — the frame must show the spawn
|
||||
/// form where the terminal would otherwise be.
|
||||
#[test]
|
||||
fn a_draft_pane_renders_the_spawn_form_in_its_pane_area() {
|
||||
fn frame_text(link: &LinkStatus) -> String {
|
||||
use crate::overlays::HelpOverlay;
|
||||
use std::collections::HashSet;
|
||||
|
||||
let sidebar = Sidebar {
|
||||
sessions: Vec::new(),
|
||||
highlight: None,
|
||||
attached: HashSet::new(),
|
||||
};
|
||||
let help = HelpOverlay { lines: Vec::new() };
|
||||
let state = AppState::new();
|
||||
let inputs = RenderInputs {
|
||||
sidebar: &sidebar,
|
||||
home_dir: "",
|
||||
pane_title: "session",
|
||||
pane: None,
|
||||
draft: None,
|
||||
state: &state,
|
||||
help: &help,
|
||||
rename_input: &crate::text_input::TextInput::default(),
|
||||
link,
|
||||
};
|
||||
let backend = ratatui::backend::TestBackend::new(120, 24);
|
||||
let mut terminal = ratatui::Terminal::new(backend).unwrap();
|
||||
terminal
|
||||
.draw(|f| {
|
||||
draw(f, inputs);
|
||||
})
|
||||
.unwrap();
|
||||
let buf = terminal.backend().buffer().clone();
|
||||
buf.content()
|
||||
.iter()
|
||||
.map(|c| c.symbol())
|
||||
.collect::<Vec<_>>()
|
||||
.join("")
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn the_status_bar_names_the_release_the_daemon_is_running() {
|
||||
let text = frame_text(&LinkStatus {
|
||||
state: LinkState::Online,
|
||||
build: Some(maestro_protocol::BuildInfo {
|
||||
commit: "f89be4a716c7".into(),
|
||||
commit_date: "2026-09-02T14:03:11Z".into(),
|
||||
dirty: false,
|
||||
}),
|
||||
attempts: 0,
|
||||
upgraded_to: None,
|
||||
});
|
||||
assert!(text.contains("f89be4a716c7"), "{text}");
|
||||
assert!(text.contains("2026-09-02"), "{text}");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn an_unreachable_daemon_covers_the_frame_with_the_restart_overlay() {
|
||||
let up = frame_text(&LinkStatus {
|
||||
state: LinkState::Online,
|
||||
build: None,
|
||||
attempts: 0,
|
||||
upgraded_to: None,
|
||||
});
|
||||
assert!(!up.contains("daemon restarting"));
|
||||
|
||||
let down = frame_text(&LinkStatus {
|
||||
state: LinkState::Down,
|
||||
build: None,
|
||||
attempts: 4,
|
||||
upgraded_to: None,
|
||||
});
|
||||
assert!(down.contains("daemon restarting"), "{down}");
|
||||
assert!(down.contains("(4 attempts)"), "{down}");
|
||||
assert!(down.contains("daemon unreachable"), "{down}");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn an_upgraded_daemon_tells_the_user_to_restart_the_tui() {
|
||||
let text = frame_text(&LinkStatus {
|
||||
state: LinkState::Online,
|
||||
build: Some(maestro_protocol::BuildInfo::default()),
|
||||
attempts: 0,
|
||||
upgraded_to: Some(maestro_protocol::BuildInfo {
|
||||
commit: "bbb111222333".into(),
|
||||
commit_date: "2026-09-03T09:00:00Z".into(),
|
||||
dirty: false,
|
||||
}),
|
||||
});
|
||||
assert!(text.contains("updated: bbb111222333"), "{text}");
|
||||
assert!(text.contains("restart tui"), "{text}");
|
||||
}
|
||||
|
||||
/// The spawn form is a modal: the frame shows it over whatever the pane
|
||||
/// was displaying, framed by its own border.
|
||||
#[test]
|
||||
fn the_spawn_overlay_renders_the_form_in_a_modal() {
|
||||
use crate::overlays::HelpOverlay;
|
||||
use crate::state::PaneRef;
|
||||
use std::collections::HashSet;
|
||||
|
||||
let mut state = AppState::new();
|
||||
state.open_draft_pane();
|
||||
let draft = match &state.tabs[0].pane {
|
||||
Some(PaneRef::Draft(d)) => d,
|
||||
other => panic!("expected a draft pane, got {other:?}"),
|
||||
};
|
||||
state.open_spawn_modal();
|
||||
let draft = crate::draft::DraftPane::default();
|
||||
let sidebar = Sidebar {
|
||||
sessions: Vec::new(),
|
||||
highlight: None,
|
||||
@@ -348,21 +516,21 @@ mod tests {
|
||||
let inputs = RenderInputs {
|
||||
sidebar: &sidebar,
|
||||
home_dir: "",
|
||||
pane_title: "new session",
|
||||
pane_title: "session",
|
||||
pane: None,
|
||||
draft: Some(draft),
|
||||
draft: Some(&draft),
|
||||
state: &state,
|
||||
help: &help,
|
||||
rename_input: &crate::text_input::TextInput::default(),
|
||||
link: &online_link(),
|
||||
};
|
||||
|
||||
let backend = ratatui::backend::TestBackend::new(80, 24);
|
||||
let mut terminal = ratatui::Terminal::new(backend).unwrap();
|
||||
terminal
|
||||
.draw(|f| {
|
||||
draw(f, inputs);
|
||||
})
|
||||
.unwrap();
|
||||
let mut map = None;
|
||||
terminal.draw(|f| map = Some(draw(f, inputs))).unwrap();
|
||||
// Mouse clicks inside the form must not fall through to the pane.
|
||||
assert!(map.unwrap().modal.is_some());
|
||||
let buf = terminal.backend().buffer().clone();
|
||||
let mut out = String::new();
|
||||
for y in 0..buf.area.height {
|
||||
@@ -407,6 +575,7 @@ mod tests {
|
||||
state: &state,
|
||||
help: &help,
|
||||
rename_input: &crate::text_input::TextInput::default(),
|
||||
link: &online_link(),
|
||||
};
|
||||
let backend = ratatui::backend::TestBackend::new(80, 24);
|
||||
let mut terminal = ratatui::Terminal::new(backend).unwrap();
|
||||
@@ -446,6 +615,7 @@ mod tests {
|
||||
state: &state,
|
||||
help: &help,
|
||||
rename_input: &crate::text_input::TextInput::default(),
|
||||
link: &online_link(),
|
||||
};
|
||||
let backend = ratatui::backend::TestBackend::new(80, 24);
|
||||
let mut terminal = ratatui::Terminal::new(backend).unwrap();
|
||||
|
||||
@@ -1,14 +1,16 @@
|
||||
//! Sidebar widget — session cards per `docs/SIDEBAR.md`.
|
||||
//!
|
||||
//! Line 1: status glyph (● attached / ○ live / ✗ dead) + name.
|
||||
//! Line 2: activity dot + duration in the state's colour, plus the
|
||||
//! Line 1: activity rail + status glyph (● attached / ○ live / ✗ dead) + name.
|
||||
//! Line 2: activity rail + duration in the state's colour, plus the
|
||||
//! adaptive detail, blocked-work, exited, and command fragments.
|
||||
|
||||
use std::collections::{BTreeMap, HashSet};
|
||||
use std::path::PathBuf;
|
||||
|
||||
use chrono::Utc;
|
||||
use maestro_protocol::display::{abbreviate_dir, abbreviate_folder_name, session_tree_path};
|
||||
use maestro_protocol::display::{
|
||||
abbreviate_dir, abbreviate_folder_name, command_program, session_tree_path,
|
||||
};
|
||||
use maestro_protocol::{ActivityState, Session, SessionStatus, StatKind};
|
||||
use ratatui::layout::Rect;
|
||||
use ratatui::style::{Color, Modifier, Style};
|
||||
@@ -31,6 +33,9 @@ const META_LINE_AFTER_SECS: i64 = 30;
|
||||
const PLAUSIBLE_SINCE_YEAR: i32 = 2010;
|
||||
const INDENT: &str = " ";
|
||||
const META_INDENT: &str = " ";
|
||||
/// docs/SIDEBAR.md: a one-column activity rail leads the indent gutter on
|
||||
/// both card rows, replacing the old inline dot glyph on the meta line.
|
||||
const RAIL: &str = "▌";
|
||||
|
||||
/// Cards use the selection surface only while the sidebar owns focus. An
|
||||
/// unfocused highlight remains an edge-marked cursor without claiming the
|
||||
@@ -201,7 +206,9 @@ impl Sidebar {
|
||||
);
|
||||
let chevron = Span::styled(chevron, base);
|
||||
let count = Span::styled(count, surface.muted_style().bg(row_bg));
|
||||
let label_budget = width.saturating_sub(prefix.width() + chevron.width() + count.width());
|
||||
// "1 +" is the blank leading column matching the session rows' rail.
|
||||
let label_budget =
|
||||
width.saturating_sub(1 + prefix.width() + chevron.width() + count.width());
|
||||
let mut label = Vec::new();
|
||||
if let Some(stem) = name.stem {
|
||||
label.push(Span::styled(
|
||||
@@ -211,7 +218,9 @@ impl Sidebar {
|
||||
}
|
||||
label.push(Span::styled(name.last, base));
|
||||
|
||||
let mut spans = vec![prefix, chevron];
|
||||
// A blank leading column, matching the width the activity rail adds
|
||||
// to session rows, so folder labels keep aligning under names.
|
||||
let mut spans = vec![Span::styled(" ", base), prefix, chevron];
|
||||
spans.extend(fit_to_width(label, label_budget));
|
||||
spans.push(count);
|
||||
pad_to_width(spans, width, base)
|
||||
@@ -225,11 +234,13 @@ impl Sidebar {
|
||||
};
|
||||
let highlighted = self.highlight == Some(SidebarItem::Session(s.id));
|
||||
let base = card_base(highlighted, focused);
|
||||
let prefix = INDENT.chars().count() + 2;
|
||||
let prefix = 1 + INDENT.chars().count() + 2;
|
||||
let name_budget = width.saturating_sub(prefix);
|
||||
|
||||
let edge = highlighted && !focused;
|
||||
let rail_style = base.fg(activity_color(s.activity, highlighted, focused));
|
||||
let mut spans: Vec<Span<'static>> = vec![
|
||||
Span::styled(RAIL, rail_style),
|
||||
Span::styled(
|
||||
if edge { "▏ " } else { INDENT },
|
||||
if edge {
|
||||
@@ -248,7 +259,8 @@ impl Sidebar {
|
||||
pad_to_width(spans, width, base)
|
||||
}
|
||||
|
||||
/// The adaptive second line: `<dot> [<duration>] [<detail>] [<blocked work> | exited] <command>`.
|
||||
/// The adaptive second line: `[<duration>] [<detail>] <command> [<blocked work> | exited]`,
|
||||
/// led by the activity rail (docs/SIDEBAR.md).
|
||||
fn meta_row(&self, s: &Session, width: usize, focused: bool) -> Vec<Span<'static>> {
|
||||
let now = Utc::now();
|
||||
let held = held_for(s, now);
|
||||
@@ -259,7 +271,7 @@ impl Sidebar {
|
||||
let dead = s.status == SessionStatus::Dead;
|
||||
let highlighted = self.highlight == Some(SidebarItem::Session(s.id));
|
||||
let base = card_base(highlighted, focused);
|
||||
let dot_style =
|
||||
let rail_style =
|
||||
base.patch(Style::default().fg(activity_color(s.activity, highlighted, focused)));
|
||||
let muted = palette::active()
|
||||
.surface(highlighted && focused)
|
||||
@@ -267,6 +279,7 @@ impl Sidebar {
|
||||
.bg(base.bg.unwrap_or(palette::active().chrome_bg));
|
||||
let edge = highlighted && !focused;
|
||||
let mut spans = vec![
|
||||
Span::styled(RAIL, rail_style),
|
||||
Span::styled(
|
||||
if edge { " ▏ " } else { META_INDENT },
|
||||
if edge {
|
||||
@@ -275,11 +288,9 @@ impl Sidebar {
|
||||
base
|
||||
},
|
||||
),
|
||||
Span::styled("●", dot_style),
|
||||
];
|
||||
if let Some(d) = held.filter(|_| held_secs >= META_LINE_AFTER_SECS) {
|
||||
spans.push(Span::styled(" ", base));
|
||||
spans.push(Span::styled(format_state_duration(d), dot_style));
|
||||
spans.push(Span::styled(format_state_duration(d), rail_style));
|
||||
}
|
||||
let mut tail: Vec<Span<'static>> = Vec::new();
|
||||
if let Some(b) = blocked {
|
||||
@@ -297,7 +308,8 @@ impl Sidebar {
|
||||
if dead {
|
||||
tail.push(Span::styled(" exited", muted));
|
||||
}
|
||||
let command = Span::styled(format!(" {}", s.command), muted);
|
||||
// docs/SIDEBAR.md: the card names the program, never its arguments.
|
||||
let command = Span::styled(format!(" {}", command_program(&s.command)), muted);
|
||||
|
||||
// Reserve the triggered status fragments before detail and command.
|
||||
// If the row is exceptionally narrow, keep one column for the
|
||||
@@ -317,8 +329,8 @@ impl Sidebar {
|
||||
budget,
|
||||
));
|
||||
}
|
||||
spans.extend(tail);
|
||||
spans.extend(fit_to_width(vec![command], command_w));
|
||||
spans.extend(tail);
|
||||
spans
|
||||
}
|
||||
}
|
||||
@@ -686,7 +698,7 @@ mod tests {
|
||||
|
||||
/// The additions and deletions are the only coloured fragments: they are
|
||||
/// what a reader scans for, and colouring the rest would make the line
|
||||
/// compete with the activity dot.
|
||||
/// compete with the activity rail.
|
||||
#[test]
|
||||
fn the_diff_colours_only_its_additions_and_deletions() {
|
||||
let mut s = session_named(1, "claude");
|
||||
@@ -732,8 +744,8 @@ mod tests {
|
||||
assert_eq!(content(&all[0]), "sessions");
|
||||
assert!(row_containing(&all, "claude").contains('○'));
|
||||
assert!(
|
||||
all[3].contains('●'),
|
||||
"line 2 must carry the dot: {:?}",
|
||||
all[3].contains(RAIL),
|
||||
"line 2 must carry the rail: {:?}",
|
||||
all[3]
|
||||
);
|
||||
assert!(
|
||||
@@ -749,7 +761,7 @@ mod tests {
|
||||
}
|
||||
|
||||
/// Rule 1 of docs/SIDEBAR.md: held in state longer than 30s earns the
|
||||
/// meta line, with the floored duration next to the dot.
|
||||
/// meta line, with the floored duration next to the rail.
|
||||
#[test]
|
||||
fn long_held_session_gets_a_meta_line_with_duration() {
|
||||
let mut s = session_named(1, "claude");
|
||||
@@ -762,7 +774,7 @@ mod tests {
|
||||
let all = rows(&draw(&sb, 28, 8));
|
||||
let idx = all.iter().position(|l| l.contains("claude")).unwrap();
|
||||
let meta = &all[idx + 1];
|
||||
assert!(meta.contains('●'), "meta line carries the dot: {meta:?}");
|
||||
assert!(meta.contains(RAIL), "meta line carries the rail: {meta:?}");
|
||||
assert!(meta.contains("1m"), "expected 1m in: {meta:?}");
|
||||
}
|
||||
|
||||
@@ -779,10 +791,10 @@ mod tests {
|
||||
assert_eq!(fmt(7200), "2h");
|
||||
}
|
||||
|
||||
/// The dot and duration carry the activity state's colour; the state word
|
||||
/// is never spelled out (docs/SIDEBAR.md colour table).
|
||||
/// The rail and duration carry the activity state's colour; the state
|
||||
/// word is never spelled out (docs/SIDEBAR.md colour table).
|
||||
#[test]
|
||||
fn meta_line_dot_uses_the_contract_colour_per_state() {
|
||||
fn meta_line_rail_uses_the_contract_colour_per_state() {
|
||||
for state in [
|
||||
ActivityState::Active,
|
||||
ActivityState::Idle,
|
||||
@@ -805,7 +817,7 @@ mod tests {
|
||||
}
|
||||
}
|
||||
|
||||
/// The selected card keeps carrying its state on the dot, but in the
|
||||
/// The selected card keeps carrying its state on the rail, but in the
|
||||
/// selection surface's own colours. A state colour picked for the dark
|
||||
/// card background painted onto the selection background is the contrast
|
||||
/// bug this palette fixes — this test fails if it comes back.
|
||||
@@ -842,7 +854,7 @@ mod tests {
|
||||
);
|
||||
assert!(
|
||||
on_selection(p.selection.activity(state)),
|
||||
"{state:?}: the dot must still carry the state on the selected card"
|
||||
"{state:?}: the rail must still carry the state on the selected card"
|
||||
);
|
||||
let ratio = palette::contrast_ratio(p.selection.bg, p.selection.activity(state))
|
||||
.expect("palette roles are RGB");
|
||||
@@ -874,12 +886,34 @@ mod tests {
|
||||
);
|
||||
}
|
||||
|
||||
/// docs/SIDEBAR.md: line 2 names the program, never its arguments.
|
||||
#[test]
|
||||
fn meta_line_drops_the_commands_arguments() {
|
||||
let mut s = session_named(1, "handle");
|
||||
s.command = "claude --dangerously-skip-permissions".into();
|
||||
let sb = Sidebar {
|
||||
sessions: vec![s],
|
||||
highlight: None,
|
||||
attached: Default::default(),
|
||||
};
|
||||
let all = rows(&draw(&sb, 60, 6));
|
||||
let meta = content(&all[3]);
|
||||
assert!(
|
||||
meta.contains("claude"),
|
||||
"line 2 must name the program: {meta:?}"
|
||||
);
|
||||
assert!(
|
||||
!meta.contains("dangerously"),
|
||||
"line 2 must not carry arguments: {meta:?}"
|
||||
);
|
||||
}
|
||||
|
||||
/// The sidebar is narrow: the command truncates with `…` and never wraps
|
||||
/// onto a third row (docs/SIDEBAR.md).
|
||||
#[test]
|
||||
fn meta_line_command_truncates_instead_of_wrapping() {
|
||||
let mut s = session_named(1, "claude");
|
||||
s.command = "a command that cannot fit".into();
|
||||
s.command = "a-program-name-that-cannot-fit".into();
|
||||
s.activity_since = Utc::now() - Duration::seconds(5);
|
||||
s.blocked_work = Some(InTheWay {
|
||||
uncommitted_files: 120,
|
||||
@@ -893,9 +927,11 @@ mod tests {
|
||||
let all = rows(&draw(&sb, 28, 8));
|
||||
let idx = all.iter().position(|l| l.contains("claude")).unwrap();
|
||||
let meta = content(&all[idx + 1]);
|
||||
let ellipsis = meta.find('…').expect("truncated command must contain …");
|
||||
let tail = meta.find("~120").expect("diff stat must survive: {meta:?}");
|
||||
assert!(
|
||||
meta.trim_end().ends_with('…'),
|
||||
"truncated command must end with …: {meta:?}"
|
||||
ellipsis < tail,
|
||||
"command must truncate before the diff stat: {meta:?}"
|
||||
);
|
||||
assert!(
|
||||
content(&all[idx + 2]).trim().is_empty(),
|
||||
@@ -920,7 +956,7 @@ mod tests {
|
||||
let all = rows(&draw(&sb, 40, 8));
|
||||
let idx = all.iter().position(|l| l.contains("claude")).unwrap();
|
||||
let meta = &all[idx + 1];
|
||||
assert!(meta.contains('●'), "meta line carries the dot: {meta:?}");
|
||||
assert!(meta.contains(RAIL), "meta line carries the rail: {meta:?}");
|
||||
assert!(
|
||||
meta.contains("1m"),
|
||||
"duration precedes the detail: {meta:?}"
|
||||
@@ -993,7 +1029,7 @@ mod tests {
|
||||
|
||||
/// docs/SIDEBAR.md: a payload predating #102 carries an epoch
|
||||
/// `activity_since` and so contributes no duration — a card must not claim
|
||||
/// the session has been idle since 1970. The dot still renders when some
|
||||
/// the session has been idle since 1970. The rail still renders when some
|
||||
/// other trigger puts line 2 on screen.
|
||||
#[test]
|
||||
fn epoch_activity_since_renders_no_duration() {
|
||||
@@ -1010,10 +1046,10 @@ mod tests {
|
||||
rendered.contains("exited"),
|
||||
"dead session must still show line 2:\n{rendered}"
|
||||
);
|
||||
for line in rendered.lines().filter(|l| l.contains('●')) {
|
||||
for line in rendered.lines().filter(|l| l.contains(RAIL)) {
|
||||
assert!(
|
||||
!line
|
||||
.split('●')
|
||||
.split(RAIL)
|
||||
.nth(1)
|
||||
.unwrap_or("")
|
||||
.trim_start()
|
||||
@@ -1076,7 +1112,7 @@ mod tests {
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn narrow_meta_line_keeps_dot_and_truncates_command() {
|
||||
fn narrow_meta_line_keeps_rail_and_truncates_command() {
|
||||
let s = session_named(1, "name");
|
||||
let sb = Sidebar {
|
||||
sessions: vec![s],
|
||||
@@ -1085,8 +1121,8 @@ mod tests {
|
||||
};
|
||||
let all = rows(&draw(&sb, 9, 6));
|
||||
assert!(
|
||||
all[3].contains('●'),
|
||||
"dot must survive narrow cards: {:?}",
|
||||
all[3].contains(RAIL),
|
||||
"rail must survive narrow cards: {:?}",
|
||||
all[3]
|
||||
);
|
||||
assert!(
|
||||
@@ -1097,9 +1133,9 @@ mod tests {
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn blocked_warning_survives_before_a_truncated_command() {
|
||||
fn blocked_warning_survives_after_a_truncated_command() {
|
||||
let mut s = session_named(1, "name");
|
||||
s.command = "a command that cannot fit".into();
|
||||
s.command = "a-program-name-that-cannot-fit".into();
|
||||
s.blocked_work = Some(InTheWay {
|
||||
uncommitted_files: 1,
|
||||
..Default::default()
|
||||
@@ -1112,7 +1148,12 @@ mod tests {
|
||||
let all = rows(&draw(&sb, 29, 6));
|
||||
assert!(all[3].contains("~1"), "{:?}", all[3]);
|
||||
let meta = content(&all[3]);
|
||||
assert!(meta.ends_with('…'), "command must truncate: {meta:?}");
|
||||
let ellipsis = meta.find('…').expect("command must truncate");
|
||||
let tail = meta.find("~1").unwrap();
|
||||
assert!(
|
||||
ellipsis < tail,
|
||||
"diff stat must follow the truncated command: {meta:?}"
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
|
||||
@@ -1,9 +1,8 @@
|
||||
//! `AppState` — the top-level mutable state of the running TUI.
|
||||
//!
|
||||
//! v1 keeps it small on purpose: one pane containing a session or draft form,
|
||||
//! focus split between sidebar and pane, the current input mode, and an optional overlay (kill confirm,
|
||||
//! help, transient toast). The spawn form is no longer an overlay — an empty
|
||||
//! pane is a draft pane (issue #63).
|
||||
//! v1 keeps it small on purpose: one pane containing a session, focus split
|
||||
//! between sidebar and pane, the current input mode, and an optional overlay
|
||||
//! (spawn form, kill confirm, rename, help, transient toast).
|
||||
//!
|
||||
//! v1.5 will replace `Tab::pane`'s single slot with a split tree.
|
||||
|
||||
@@ -12,7 +11,6 @@ use std::path::PathBuf;
|
||||
|
||||
use uuid::Uuid;
|
||||
|
||||
use crate::draft::DraftPane;
|
||||
use crate::keymap::Mode;
|
||||
|
||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||
@@ -31,34 +29,24 @@ pub enum SidebarItem {
|
||||
Session(Uuid),
|
||||
}
|
||||
|
||||
/// What a tab's pane slot holds: a live session, or an inline draft form.
|
||||
// The draft variant dwarfs `Session(Uuid)`; the pane is moved rarely enough
|
||||
// that boxing every access costs more than the copy does.
|
||||
#[allow(clippy::large_enum_variant)]
|
||||
#[derive(Debug, Clone, PartialEq)]
|
||||
pub enum PaneRef {
|
||||
Session(Uuid),
|
||||
Draft(DraftPane),
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone)]
|
||||
pub struct Tab {
|
||||
pub name: String,
|
||||
pub pane: Option<PaneRef>,
|
||||
pub pane: Option<Uuid>,
|
||||
}
|
||||
|
||||
impl Tab {
|
||||
/// The session this tab shows, if it shows one. Draft panes have none.
|
||||
/// The session this tab shows, if it shows one.
|
||||
pub fn session(&self) -> Option<Uuid> {
|
||||
match &self.pane {
|
||||
Some(PaneRef::Session(sid)) => Some(*sid),
|
||||
_ => None,
|
||||
}
|
||||
self.pane
|
||||
}
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||
pub enum OverlayKind {
|
||||
/// The spawn form. Its [`crate::draft::DraftPane`] lives on `App` for the
|
||||
/// same reason the rename buffer does — so this stays comparable.
|
||||
Spawn,
|
||||
KillConfirm(Uuid),
|
||||
/// Rename prompt for this session (#125). The edit buffer lives on `App`,
|
||||
/// so this stays comparable.
|
||||
@@ -138,26 +126,23 @@ impl AppState {
|
||||
/// drop straight into Insert mode so keystrokes go to the session
|
||||
/// without an extra `i` press. The leader returns to Normal.
|
||||
pub fn attach_to_focused(&mut self, session_id: Uuid) {
|
||||
self.active_tab_mut().pane = Some(PaneRef::Session(session_id));
|
||||
self.active_tab_mut().pane = Some(session_id);
|
||||
self.focus = Focus::Pane;
|
||||
self.mode = Mode::Insert;
|
||||
}
|
||||
|
||||
/// Replace the pane with a draft form. Focus lands in the pane, Insert
|
||||
/// mode on, so typing starts immediately, same flow as
|
||||
/// [`Self::attach_to_focused`].
|
||||
pub fn open_draft_pane(&mut self) {
|
||||
self.active_tab_mut().pane = Some(PaneRef::Draft(DraftPane::default()));
|
||||
self.focus = Focus::Pane;
|
||||
self.mode = Mode::Insert;
|
||||
/// Put the spawn form up. Whatever the pane was showing stays behind it,
|
||||
/// so dismissing gives that back untouched — the modal owns the keyboard
|
||||
/// while it is up, so focus and mode are left alone.
|
||||
pub fn open_spawn_modal(&mut self) {
|
||||
self.show_overlay(OverlayKind::Spawn);
|
||||
}
|
||||
|
||||
/// A draft submit succeeded: replace whatever the active tab showed with
|
||||
/// the new session in place, matching the web client's behaviour (#57).
|
||||
/// A spawn submit succeeded: the modal closes and the new session takes
|
||||
/// the pane, attached and ready to type into.
|
||||
pub fn complete_spawn(&mut self, sid: Uuid) {
|
||||
self.active_tab_mut().pane = Some(PaneRef::Session(sid));
|
||||
self.focus = Focus::Pane;
|
||||
self.mode = Mode::Insert;
|
||||
self.dismiss_overlay();
|
||||
self.attach_to_focused(sid);
|
||||
}
|
||||
|
||||
/// The session shown by the active tab's pane, if any.
|
||||
@@ -385,35 +370,28 @@ mod tests {
|
||||
assert!(state.overlay().is_none());
|
||||
}
|
||||
|
||||
/// Issue #63: `s` over an empty pane turns that pane into a draft —
|
||||
/// focused, Insert mode on, typing starts immediately.
|
||||
/// The modal covers the pane rather than replacing it: an attached
|
||||
/// session is still there once the form is dismissed.
|
||||
#[test]
|
||||
fn open_draft_reuses_the_empty_active_pane() {
|
||||
fn open_spawn_modal_leaves_the_pane_alone() {
|
||||
let mut state = AppState::new();
|
||||
state.open_draft_pane();
|
||||
assert!(matches!(state.active_tab().pane, Some(PaneRef::Draft(_))));
|
||||
assert_eq!(state.focus, Focus::Pane);
|
||||
assert_eq!(state.mode, Mode::Insert);
|
||||
assert_eq!(state.tabs.len(), 1);
|
||||
let sid = Uuid::from_u128(9);
|
||||
state.attach_to_focused(sid);
|
||||
state.open_spawn_modal();
|
||||
assert_eq!(state.overlay(), Some(&OverlayKind::Spawn));
|
||||
assert_eq!(state.active_tab().session(), Some(sid));
|
||||
|
||||
state.dismiss_overlay();
|
||||
assert_eq!(state.active_tab().session(), Some(sid));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn open_draft_over_a_session_reuses_the_pane() {
|
||||
fn complete_spawn_dismisses_the_modal_and_attaches() {
|
||||
let mut state = AppState::new();
|
||||
state.attach_to_focused(Uuid::from_u128(9));
|
||||
state.open_draft_pane();
|
||||
assert_eq!(state.tabs.len(), 1);
|
||||
assert_eq!(state.active_tab_idx, 0);
|
||||
assert!(matches!(state.active_tab().pane, Some(PaneRef::Draft(_))));
|
||||
}
|
||||
|
||||
/// Web parity (#57): submitting fills the pane in place.
|
||||
#[test]
|
||||
fn complete_spawn_replaces_the_draft_with_the_session() {
|
||||
let mut state = AppState::new();
|
||||
state.open_draft_pane();
|
||||
state.open_spawn_modal();
|
||||
let sid = Uuid::from_u128(21);
|
||||
state.complete_spawn(sid);
|
||||
assert!(state.overlay().is_none());
|
||||
assert_eq!(state.active_tab().session(), Some(sid));
|
||||
assert_eq!(state.focus, Focus::Pane);
|
||||
assert_eq!(state.mode, Mode::Insert);
|
||||
|
||||
@@ -57,6 +57,10 @@ enum Command {
|
||||
/// Kill a session by ID.
|
||||
#[cfg(feature = "cli")]
|
||||
Kill(maestro_cli::cli::KillArgs),
|
||||
/// Type text into a running session, as if it had been typed on an
|
||||
/// attached terminal.
|
||||
#[cfg(feature = "cli")]
|
||||
Send(maestro_cli::cli::SendArgs),
|
||||
/// Install or update the agent activity hook (#106).
|
||||
#[cfg(feature = "cli")]
|
||||
Hooks(maestro_cli::cli::HooksArgs),
|
||||
@@ -144,6 +148,15 @@ async fn dispatch(cli: Cli) -> Result<(), Box<dyn std::error::Error>> {
|
||||
.await?
|
||||
}
|
||||
#[cfg(feature = "cli")]
|
||||
Command::Send(args) => {
|
||||
maestro_cli::dispatch(
|
||||
maestro_cli::cli::Command::Send(args),
|
||||
cli.config,
|
||||
cli.daemon_url,
|
||||
)
|
||||
.await?
|
||||
}
|
||||
#[cfg(feature = "cli")]
|
||||
Command::Hooks(args) => {
|
||||
maestro_cli::dispatch(
|
||||
maestro_cli::cli::Command::Hooks(args),
|
||||
@@ -156,12 +169,8 @@ async fn dispatch(cli: Cli) -> Result<(), Box<dyn std::error::Error>> {
|
||||
Command::Daemon { cmd } => maestro_daemon::cli::dispatch(cli.config, cmd).await?,
|
||||
#[cfg(feature = "tui")]
|
||||
Command::Tui(args) => {
|
||||
let daemon_url = args
|
||||
.daemon_url
|
||||
.or(cli.daemon_url)
|
||||
.unwrap_or_else(|| "http://127.0.0.1:7070".to_string());
|
||||
maestro_tui::run(maestro_tui::RunConfig {
|
||||
daemon_url,
|
||||
daemon_url: args.daemon_url.or(cli.daemon_url),
|
||||
config_path: cli.config,
|
||||
})
|
||||
.await?
|
||||
@@ -190,6 +199,7 @@ fn is_cli_subcommand(command: &Option<Command>) -> bool {
|
||||
| Some(Command::Spawn(_))
|
||||
| Some(Command::Attach(_))
|
||||
| Some(Command::Kill(_))
|
||||
| Some(Command::Send(_))
|
||||
| Some(Command::Hooks(_))
|
||||
)
|
||||
}
|
||||
|
||||
+14
-7
@@ -140,7 +140,7 @@ chord_timeout_ms = 1000 # how long to hold a partial chord like `ctrl-w`
|
||||
|
||||
[tui.keymap.normal]
|
||||
"i" = "EnterInsert"
|
||||
"s" = "NewDraftPane"
|
||||
"s" = "OpenSpawnModal"
|
||||
"x" = "KillHighlighted"
|
||||
"r" = "RenameHighlighted"
|
||||
"?" = "ShowHelp"
|
||||
@@ -154,15 +154,22 @@ chord_timeout_ms = 1000 # how long to hold a partial chord like `ctrl-w`
|
||||
# want extra Insert-mode bindings)
|
||||
```
|
||||
|
||||
`theme` selects the complete TUI palette. `dark` is the default and follows
|
||||
Maestro's terminal-native dark product palette; `light` is its light peer;
|
||||
`ansi` uses the terminal's named ANSI colours for terminals without truecolour.
|
||||
The remaining presets adapt well-known editor themes, with individual colours
|
||||
lifted or darkened where the originals fall short of the WCAG AA contrast
|
||||
floors the palette tests assert:
|
||||
`theme` selects the complete TUI palette. `dark` is the default: Maestro's
|
||||
graphite palette, near-neutral chrome where the activity colours are the only
|
||||
hue on screen; `light` is its light peer; `ansi` uses the terminal's named
|
||||
ANSI colours for terminals without truecolour. Five house presets recolour
|
||||
the graphite base with an accent, and the remaining presets adapt well-known
|
||||
editor themes — in both groups individual colours are lifted or darkened
|
||||
where they would fall short of the WCAG AA contrast floors the palette tests
|
||||
assert:
|
||||
|
||||
| name | based on |
|
||||
|-------------------|------------------|
|
||||
| `ice-cyan` | graphite base, signal-cyan accent |
|
||||
| `periwinkle` | indigo base, blue-violet accent |
|
||||
| `amber-phosphor` | warm graphite, CRT-amber accent |
|
||||
| `ember` | warm graphite, orange-red accent |
|
||||
| `orchid` | violet base, muted violet accent |
|
||||
| `solarized-dark` | Solarized Dark |
|
||||
| `solarized-light` | Solarized Light |
|
||||
| `catppuccin` | Catppuccin Mocha |
|
||||
|
||||
@@ -0,0 +1,84 @@
|
||||
# Restart and upgrade contract
|
||||
|
||||
Maestro is upgraded in place: the operator reinstalls the binary and systemd
|
||||
restarts the daemon under every browser tab and TUI that is attached to it.
|
||||
tmux keeps the sessions alive across that (see `docs/INSTALL.md`), but clients
|
||||
lose their sockets. This document is the contract for what a client does about
|
||||
it — what the daemon publishes, how a client tells a restart from a blip, and
|
||||
what the user sees while it happens.
|
||||
|
||||
## What the daemon publishes
|
||||
|
||||
`GET /api/info` carries two fields beyond identity and presets:
|
||||
|
||||
| field | meaning |
|
||||
| ---------- | -------------------------------------------------------------- |
|
||||
| `build` | `{ commit, commit_date, dirty }` — the commit the binary was compiled from |
|
||||
| `instance` | uuid regenerated on every daemon start |
|
||||
|
||||
`build` is stamped at compile time by `crates/maestro-daemon/build.rs`, which
|
||||
runs `git` in the checkout it is compiled in. The Nix build has no `.git` in the
|
||||
crane-filtered source tree, so `flake.nix` passes the flake's own revision as
|
||||
`MAESTRO_BUILD_COMMIT` / `MAESTRO_BUILD_DATE` / `MAESTRO_BUILD_DIRTY`. A build
|
||||
with neither source reports empty strings — clients render that as
|
||||
"unknown release" and fall back to `instance` alone.
|
||||
|
||||
`instance` is the one that never goes missing. It says *this process*, so two
|
||||
replies that differ on it are two runs of the daemon, even when the commit did
|
||||
not change (a plain `systemctl restart`, or a crash).
|
||||
|
||||
## How a client reads them
|
||||
|
||||
Three verdicts, from comparing the reply before an outage with the one after
|
||||
(`compareIdentity` in `web/src/daemonLink.ts`, mirrored by
|
||||
`crates/maestro-tui/src/daemon_link.rs`):
|
||||
|
||||
- **upgraded** — both commits are known and differ. New server code.
|
||||
- **restarted** — commits match (or are unknown) and `instance` differs.
|
||||
- **same** — neither changed; the socket blipped, the daemon never moved.
|
||||
|
||||
Only *upgraded* is special. A browser tab is holding a bundle that the upgraded
|
||||
daemon no longer serves, so it reloads the page rather than driving new server
|
||||
code from an old bundle. The TUI is its own binary — a reload would not replace
|
||||
it — so it stays up, reconnects, and says which release it is now talking to;
|
||||
the user restarts `maestro tui` when they want the new client.
|
||||
|
||||
## What the user sees
|
||||
|
||||
The **status indicator** lives in the sidebar footer, left of the spawn button,
|
||||
in both clients. Its colour is the link state, and it names the running release
|
||||
— commit hash and commit date — on hover (web) or in the status bar (TUI).
|
||||
|
||||
| state | colour | meaning |
|
||||
| -------------- | ------ | ---------------------------------------------------- |
|
||||
| `connecting` | amber | first probe hasn't landed |
|
||||
| `online` | green | daemon answered; same process, or a resolved new one |
|
||||
| `reconnecting` | amber | socket dropped, still inside the grace window |
|
||||
| `down` | red | unreachable past the grace window — the UI blocks |
|
||||
| `updating` | red | answered on a new commit; the page is reloading |
|
||||
|
||||
`updating` is web-only, because reloading is web-only. The TUI goes straight
|
||||
back to `online` after an upgrade and puts `updated: <hash> (restart tui)` on
|
||||
its status bar instead, until the user restarts it.
|
||||
|
||||
The **restart overlay** is up for exactly `down` and `updating`. It is not
|
||||
dismissable and it swallows the app's keyboard shortcuts: everything behind it
|
||||
would act on a daemon that is not there. In the TUI the quit binding still
|
||||
resolves, so a blocked client is never a trapped one. It clears itself the
|
||||
moment a probe succeeds — there is no "retry" button, because the client is
|
||||
already retrying.
|
||||
|
||||
## Timing
|
||||
|
||||
- **Grace window** — 1200 ms between the socket dropping and the overlay
|
||||
appearing. A wifi hiccup or a laptop waking up should not throw a modal.
|
||||
- **Poll cadence** — `GET /api/info` every 700 ms while unreachable, flat, not
|
||||
backed off: a restart takes a second or two and the point is to unlock as soon
|
||||
as it is over. The events socket keeps its own exponential backoff for the
|
||||
session stream; the two are independent, and the probe is what decides state.
|
||||
|
||||
The events socket dropping is the trigger, not a timer: the daemon cannot warn
|
||||
anyone it is about to die, so its socket closing is the earliest signal there
|
||||
is. A reconnect of that socket does **not** by itself clear the state — only a
|
||||
probe does, because the socket carries no identity and reconnecting to an
|
||||
upgraded daemon must reload rather than resume.
|
||||
+81
-26
@@ -37,23 +37,47 @@ itself is not.
|
||||
Line 2 reads left to right:
|
||||
|
||||
```
|
||||
<dot> [<duration>] [<detail>] [<diff stat> | exited] <command>
|
||||
[<duration>] [<detail>] <command> [<diff stat> | exited]
|
||||
```
|
||||
|
||||
Its minimum content is therefore the dot and the command.
|
||||
Its minimum content is therefore just the command.
|
||||
|
||||
`<dot>` is a single filled glyph (`●` on both clients) carrying the activity
|
||||
state's colour, and `<duration>` follows in the same colour when shown. There
|
||||
is no state word and no second badge: the dot exists so the state is still
|
||||
legible when a row is dimmed or the terminal renders the duration in the
|
||||
default fg. The dot is an unconditional part of line 2; the bracketed
|
||||
fragments appear only when their trigger holds.
|
||||
The activity state does not render as an inline glyph on line 2 — a **rail**
|
||||
carries it instead: a coloured bar in the gutter to the left of the card, the
|
||||
space nesting already reserves for indentation. The rail paints for every
|
||||
card, `Idle` included, and is independent of whatever line 2 has to say; a
|
||||
card with nothing else to report still shows its rail next to the bare
|
||||
command. `<duration>` follows in the rail's colour when shown. There is no
|
||||
state word and no second badge: the rail exists so the state is still legible
|
||||
when a row is dimmed or the terminal renders the duration in the default fg.
|
||||
|
||||
In the **web client** the rail is a 5px bar pinned to the row's own left
|
||||
edge, square corners, spanning the full card height edge to edge — it
|
||||
shifts outward with nesting depth along with the row's own padding, since
|
||||
it is positioned relative to the row. It carries motion only for states that
|
||||
need attention (DESIGN.md's "living signals" rule): a hard blink while
|
||||
`AwaitingInput`, a fast flash while `Error`. `Active` and `Idle` are both
|
||||
solid and still — colour alone (green vs. the idle grey) is the signal for
|
||||
`Active`, so it does not also pulse. `prefers-reduced-motion` leaves every
|
||||
state as a solid bar.
|
||||
|
||||
In the **TUI** the rail is a one-column-wide block glyph (`▌`) in the state's
|
||||
palette role, leading the existing indent gutter (`INDENT`/`META_INDENT`) on
|
||||
both the name row and the meta row, so the two lines read as one continuous
|
||||
bar. Folder headers gain a matching blank leading column so labels still
|
||||
align under session names. The TUI has no render cadence to animate against,
|
||||
so its rail is always static — colour is the whole signal there, as it
|
||||
always was.
|
||||
|
||||
Either client's rail carries the accessibility duty the old inline dot did:
|
||||
it is the element whose `title`/`aria-label` names the state, so status still
|
||||
never relies on colour alone.
|
||||
|
||||
`<duration>` renders only once the session has been held in its current
|
||||
activity state longer than **30 seconds** (`activity_since` from #102) — under
|
||||
that threshold the duration is absent and the dot renders alone. A payload
|
||||
that predates #102 (no usable `activity_since`) likewise contributes no
|
||||
duration — the dot still renders. This rule now governs only the duration
|
||||
that threshold the duration is absent and the rail carries the state alone. A
|
||||
payload that predates #102 (no usable `activity_since`) likewise contributes
|
||||
no duration — the rail still renders. This rule now governs only the duration
|
||||
fragment; it no longer decides whether line 2 exists.
|
||||
|
||||
`<detail>` is an agent-reported string (#105) — e.g. why a session is in
|
||||
@@ -61,7 +85,7 @@ fragment; it no longer decides whether line 2 exists.
|
||||
while an agent-reported state is in force (see Precedence): when the report
|
||||
lapses at its TTL or is replaced, the detail goes with it. The detail
|
||||
truncates with `…` ahead of the trailing fragments — a long detail never
|
||||
pushes `<blocked work>`, `exited`, or `<command>` off the line, and neither
|
||||
pushes `<command>`, `<blocked work>`, or `exited` off the line, and neither
|
||||
client ever lets it wrap.
|
||||
|
||||
`<diff stat>` is the blocked-work breakdown (#83) in diff notation, replacing
|
||||
@@ -88,21 +112,26 @@ of `maestro_protocol::InTheWay`'s `Display` does not disappear: it is the web
|
||||
card's tooltip and the wording of the kill refusal, so no two clients describe
|
||||
the same tree differently.
|
||||
|
||||
`<command>` is unconditional and muted: the session's command line, shown on
|
||||
every card in both clients — no omission in the TUI, no name-vs-command
|
||||
comparison gating it. A session named by its command line then shows the same
|
||||
string on both lines; that is accepted, the price of a row that never changes
|
||||
height.
|
||||
`<command>` is unconditional and muted: it names the **program** the session
|
||||
runs — never its arguments. `claude --dangerously-skip-permissions` renders as
|
||||
`claude`. Flags say how a session was invoked, which is not what a card is for,
|
||||
and a long one crowds out every other fragment on the line. It shows on every
|
||||
card in both clients — no omission in the TUI, no name-vs-command comparison
|
||||
gating it. A session named by its program then shows the same string on both
|
||||
lines; that is accepted, the price of a row that never changes height.
|
||||
|
||||
In the **web client** the command's leading program is replaced by that tool's
|
||||
icon when it is one we have a mark for — Claude Code, Codex, opencode, Gemini
|
||||
CLI, Aider, Cursor, pi, and any shell — and only the remaining words of the
|
||||
command line follow as text. Recognition looks through a path, leading
|
||||
`FOO=bar` assignments and wrappers (`sudo`, `env`, `npx`, `pnpm dlx`, …); an
|
||||
unrecognised program keeps its full text, so the card never shows a mark
|
||||
standing for the wrong tool. The full command line stays in the card's tooltip
|
||||
either way. The **TUI** keeps the command as text: a terminal cannot be assumed
|
||||
to have a font carrying tool glyphs.
|
||||
The program is found by looking through a path, leading `FOO=bar` assignments
|
||||
and wrappers (`sudo`, `env`, `npx`, `pnpm dlx`, …), then taking the basename:
|
||||
`/usr/local/bin/claude -p hi` is `claude`. A line that is nothing but wrappers
|
||||
is shown as written rather than as an empty fragment.
|
||||
|
||||
In the **web client** the program is replaced by that tool's icon when it is
|
||||
one we have a mark for — Claude Code, Codex, opencode, Gemini CLI, Aider,
|
||||
Cursor, pi, and any shell — and nothing follows it as text. An unrecognised
|
||||
program keeps its name as text, so the card never shows a mark standing for the
|
||||
wrong tool. The full command line, arguments and all, stays in the card's
|
||||
tooltip either way. The **TUI** keeps the program as text: a terminal cannot be
|
||||
assumed to have a font carrying tool glyphs.
|
||||
|
||||
## Colour per activity state
|
||||
|
||||
@@ -182,6 +211,32 @@ arriving at `POST /api/sessions/:id/activity` is parsed strictly and an unknown
|
||||
state is a 4xx: an agent posting a state the daemon does not know is a bug in
|
||||
the agent, and answering 204 would hide it.
|
||||
|
||||
## Focus clears `AwaitingInput`
|
||||
|
||||
A session's pane — the pane a client's own attach view is showing, never a
|
||||
sidebar highlight — clears its `AwaitingInput` glow once it has been
|
||||
**continuously focused for 5 seconds**: the operator has looked, so the rail
|
||||
stops asking for attention and the card reads as `Idle` instead. This is a
|
||||
real state change, not a client-side paint-over — the daemon computes it, so
|
||||
every client watching the session (web, TUI, a second pane on the same
|
||||
session) sees the same colour.
|
||||
|
||||
The acknowledgement is sticky: it survives losing focus, and holds until the
|
||||
session is genuinely `Active` again — new work, not merely a refocus. Only
|
||||
after that fresh `Active` cycle does the *next* `AwaitingInput` glow again.
|
||||
Unfocusing and refocusing alone never re-arms it.
|
||||
|
||||
This applies uniformly to `AwaitingInput` from either source — the daemon's
|
||||
own inference or an agent's report (#105) — since the rail draws them
|
||||
identically. It does not touch `Error`; that state's own TTL (below) is
|
||||
unrelated and unaffected by focus.
|
||||
|
||||
Each client reports its own pane's focus with `POST /api/sessions/:id/focus`
|
||||
(`{"focused": bool}`) whenever the pane it is showing changes — on attach, on
|
||||
switching which session a pane shows, and on leaving the pane. A client
|
||||
sends `false` for the session it just left before `true` for the session it
|
||||
lands on, so a click that swaps panes never briefly reports both focused.
|
||||
|
||||
## Keyboard walk
|
||||
|
||||
`j`/`k` (and the arrow keys) move a highlight through the sidebar. Both clients
|
||||
|
||||
@@ -79,6 +79,11 @@ would have blocked. A tree whose guard is clear never needed the override, so a
|
||||
forced kill removes it as usual — force changes what happens to blocked work,
|
||||
not ordinary cleanup.
|
||||
|
||||
In the web client the kill button sends the unforced `DELETE` straight away —
|
||||
there is no pre-confirmation, because the daemon is the one that decides. Only
|
||||
the refusal raises a prompt, and that prompt names what is in the way and offers
|
||||
"Force kill", which repeats the request with `force=true`.
|
||||
|
||||
Ending a session and destroying its work are two separate acts. Maestro only
|
||||
performs the first one. Removing a tree it left behind is the operator's own
|
||||
`git worktree remove`, chosen while looking at exactly what would be lost.
|
||||
|
||||
@@ -33,6 +33,25 @@
|
||||
|
||||
version = (lib.importTOML ./Cargo.toml).workspace.package.version;
|
||||
|
||||
# Build provenance for `GET /api/info`. The Rust source tree crane
|
||||
# hands to the compiler has no `.git`, so `maestro-daemon/build.rs`
|
||||
# cannot ask git itself — the flake's own revision is passed instead.
|
||||
# A dirty tree has no `rev`, and `dirtyRev` carries a `-dirty` suffix.
|
||||
rev = inputs.self.rev or inputs.self.dirtyRev or "";
|
||||
# `lastModifiedDate` is `YYYYMMDDhhmmss` in UTC; clients want RFC 3339.
|
||||
ld = inputs.self.lastModifiedDate or "";
|
||||
iso =
|
||||
if ld == "" then
|
||||
""
|
||||
else
|
||||
"${builtins.substring 0 4 ld}-${builtins.substring 4 2 ld}-${builtins.substring 6 2 ld}"
|
||||
+ "T${builtins.substring 8 2 ld}:${builtins.substring 10 2 ld}:${builtins.substring 12 2 ld}Z";
|
||||
buildStamp = {
|
||||
MAESTRO_BUILD_COMMIT = builtins.substring 0 12 rev;
|
||||
MAESTRO_BUILD_DATE = iso;
|
||||
MAESTRO_BUILD_DIRTY = if inputs.self ? rev then "0" else "1";
|
||||
};
|
||||
|
||||
# Cargo source filtering keeps only *.rs, *.toml and Cargo.lock. The
|
||||
# SPA is built separately (below) and handed to the Rust build as a
|
||||
# path, so nothing under web/ needs to be in this source tree.
|
||||
@@ -85,6 +104,7 @@
|
||||
|
||||
maestro = craneLib.buildPackage (
|
||||
commonArgs
|
||||
// buildStamp
|
||||
// {
|
||||
inherit cargoArtifacts;
|
||||
pname = "maestro";
|
||||
|
||||
+3
-2
@@ -22,8 +22,9 @@ src/
|
||||
events.ts # `/api/events` WebSocket subscriber
|
||||
catalog.ts # session tree view (groups by working directory)
|
||||
attach.ts # xterm.js + attach WS view
|
||||
multiview.ts # tabs + split panes; draft panes host the spawn form
|
||||
multiview.ts # tabs + split panes
|
||||
spawnForm.ts # shared spawn form (preset tiles, project picker, worktree)
|
||||
spawnModal.ts # dialog chrome around the spawn form
|
||||
theme.ts # dark/light theme toggle + persistence
|
||||
types.ts # mirror of `maestro-protocol` JSON shapes
|
||||
styles.css # design-system tokens + component styles
|
||||
@@ -41,7 +42,7 @@ follows the OS by default and can be pinned via the header toggle (persisted in
|
||||
|
||||
`mock.ts` is a DEV-only fixture (stripped from production builds): visit the dev
|
||||
server with `?mock` to seed a representative catalog without a running daemon,
|
||||
`?mock&spawn` to open a draft pane, and `?theme=light|dark` to pin a theme.
|
||||
`?mock&spawn` to open the spawn modal, and `?theme=light|dark` to pin a theme.
|
||||
|
||||
Routing is hash-based:
|
||||
- `#/` → catalog
|
||||
|
||||
+48
-7
@@ -1,6 +1,7 @@
|
||||
import * as routes from "./routes.js";
|
||||
import type {
|
||||
ApiError,
|
||||
InTheWay,
|
||||
Branches,
|
||||
CreateSessionRequest,
|
||||
DaemonInfo,
|
||||
@@ -13,19 +14,38 @@ import type {
|
||||
Uuid,
|
||||
} from "./types.js";
|
||||
|
||||
/** A `/api/*` failure with the daemon's own error envelope kept intact, so a
|
||||
* caller can branch on `code` — the kill guard's `kill_guarded` (#79) — and
|
||||
* render `unsavedWork` rather than re-parsing the message. */
|
||||
export class ApiRequestError extends Error {
|
||||
readonly status: number;
|
||||
readonly code: string;
|
||||
readonly detail: string;
|
||||
readonly unsavedWork: InTheWay | null;
|
||||
|
||||
constructor(res: Response, info?: ApiError["error"], text?: string) {
|
||||
const detail = info ? `${info.code}: ${info.message}` : (text ?? "");
|
||||
super(`${res.status} ${res.statusText}${detail ? ` — ${detail}` : ""}`);
|
||||
this.name = "ApiRequestError";
|
||||
this.status = res.status;
|
||||
this.code = info?.code ?? "";
|
||||
this.detail = info?.message ?? text ?? "";
|
||||
this.unsavedWork = info?.unsaved_work ?? null;
|
||||
}
|
||||
}
|
||||
|
||||
async function jsonOrError<T>(res: Response): Promise<T> {
|
||||
if (res.ok) {
|
||||
if (res.status === 204) return undefined as unknown as T;
|
||||
return (await res.json()) as T;
|
||||
}
|
||||
let detail = "";
|
||||
try {
|
||||
const body = (await res.json()) as ApiError;
|
||||
detail = `${body.error.code}: ${body.error.message}`;
|
||||
} catch {
|
||||
detail = await res.text();
|
||||
throw new ApiRequestError(res, body.error);
|
||||
} catch (e) {
|
||||
if (e instanceof ApiRequestError) throw e;
|
||||
throw new ApiRequestError(res, undefined, await res.text().catch(() => ""));
|
||||
}
|
||||
throw new Error(`${res.status} ${res.statusText}${detail ? ` — ${detail}` : ""}`);
|
||||
}
|
||||
|
||||
export async function listSessions(): Promise<Session[]> {
|
||||
@@ -57,15 +77,36 @@ export async function renameSession(id: Uuid, name: string): Promise<Session> {
|
||||
);
|
||||
}
|
||||
|
||||
export async function killSession(id: Uuid): Promise<void> {
|
||||
/** Kill a session. With `force` (#81) the daemon overrides its refusal over a
|
||||
* worktree holding unsaved work and leaves that worktree on disk. */
|
||||
export async function killSession(id: Uuid, force = false): Promise<void> {
|
||||
const url = force
|
||||
? `${routes.session(id)}?${routes.FORCE_QUERY}=true`
|
||||
: routes.session(id);
|
||||
await jsonOrError(
|
||||
await fetch(routes.session(id), {
|
||||
await fetch(url, {
|
||||
method: "DELETE",
|
||||
credentials: "same-origin",
|
||||
}),
|
||||
);
|
||||
}
|
||||
|
||||
/** Report whether this client's pane is the one currently showing `id` — not
|
||||
* merely highlighted in a sidebar. The daemon uses this to clear an
|
||||
* `AwaitingInput` glow once the pane has been looked at long enough
|
||||
* (docs/SIDEBAR.md). Best-effort: a failure here only delays the glow
|
||||
* clearing, so callers don't need to surface it. */
|
||||
export async function setSessionFocus(id: Uuid, focused: boolean): Promise<void> {
|
||||
await jsonOrError(
|
||||
await fetch(routes.sessionFocus(id), {
|
||||
method: "POST",
|
||||
credentials: "same-origin",
|
||||
headers: { "content-type": "application/json" },
|
||||
body: JSON.stringify({ focused }),
|
||||
}),
|
||||
);
|
||||
}
|
||||
|
||||
/** List one directory's immediate subdirectories (NAP-329). `path` may be empty,
|
||||
* `~`, relative, or absolute — the daemon resolves it against its home dir. */
|
||||
export async function listDir(path: string): Promise<DirListing> {
|
||||
|
||||
+61
-16
@@ -3,9 +3,11 @@ import { Terminal } from "@xterm/xterm";
|
||||
import "@xterm/xterm/css/xterm.css";
|
||||
|
||||
import { attachWsUrl } from "./routes.js";
|
||||
import { FOCUS_SIDEBAR_EVENT } from "./catalog.js";
|
||||
import { escapeHtml } from "./html.js";
|
||||
import { INITIAL_RECONNECT_MS, MAX_RECONNECT_MS } from "./reconnect.js";
|
||||
import { applyModsToChar, cursorSeq } from "./keys.js";
|
||||
import { applyModsToChar, cursorSeq, tildeSeq } from "./keys.js";
|
||||
import { requestToggleDrawer } from "./drawer.js";
|
||||
import { splitCommand, toolIconSvg } from "./toolIcon.js";
|
||||
import type { ClientControl, Uuid } from "./types.js";
|
||||
|
||||
@@ -55,12 +57,13 @@ export interface AttachInfo {
|
||||
command: string;
|
||||
}
|
||||
|
||||
/** Header echoes the sidebar: the command's leading program becomes its tool
|
||||
* icon when we have a mark for it, remaining words stay as text. */
|
||||
/** Header echoes the sidebar: the program becomes its tool icon when we have a
|
||||
* mark for it and stays as its bare name when we do not. Arguments are
|
||||
* dropped, as on the card. */
|
||||
function commandFragment(command: string): string {
|
||||
const { tool, rest } = splitCommand(command);
|
||||
const { tool, program } = splitCommand(command);
|
||||
const icon = tool ? toolIconSvg(tool) : null;
|
||||
const text = icon ? rest : command;
|
||||
const text = icon ? "" : program;
|
||||
return `<span class="at-cmd">${icon ?? ""}${text ? escapeHtml(text) : ""}</span>`;
|
||||
}
|
||||
|
||||
@@ -80,7 +83,7 @@ export function createAttachConnection(
|
||||
const titleAttr = info ? `${info.name} · ${info.command} (${sessionId})` : sessionId;
|
||||
el.innerHTML = `
|
||||
<header class="attach-header">
|
||||
<a class="btn btn-ghost back" href="#/" aria-label="Back to catalog" title="Back to catalog">←</a>
|
||||
<button type="button" class="btn btn-ghost btn-icon sessions-btn" aria-label="Show sessions" title="Show sessions">☰</button>
|
||||
<span class="attach-title" title="${escapeHtml(titleAttr)}">${titleHtml}</span>
|
||||
<span class="attach-state" data-state="connecting">connecting…</span>
|
||||
<button class="btn btn-ghost btn-icon disconnect" type="button" aria-label="Disconnect" title="Disconnect this session">⏻</button>
|
||||
@@ -100,6 +103,12 @@ export function createAttachConnection(
|
||||
stateEl.dataset.state = kind;
|
||||
};
|
||||
|
||||
// Mobile-only (CSS hides it on desktop, where the sidebar is always in view):
|
||||
// the session list is an off-canvas drawer and this is what opens it.
|
||||
(el.querySelector(".sessions-btn") as HTMLElement).addEventListener("click", () =>
|
||||
requestToggleDrawer(),
|
||||
);
|
||||
|
||||
disconnectBtn.addEventListener("click", () => {
|
||||
opts.onRequestClose?.(sessionId);
|
||||
});
|
||||
@@ -126,6 +135,15 @@ export function createAttachConnection(
|
||||
term.loadAddon(fit);
|
||||
term.open(body);
|
||||
|
||||
// Plain Escape hands the keyboard back to the session list instead of the
|
||||
// shell/app. `false` tells xterm to skip its own handling of this event.
|
||||
term.attachCustomKeyEventHandler((e) => {
|
||||
if (e.type !== "keydown" || e.key !== "Escape") return true;
|
||||
if (e.ctrlKey || e.altKey || e.metaKey || e.shiftKey) return true;
|
||||
document.dispatchEvent(new CustomEvent(FOCUS_SIDEBAR_EVENT));
|
||||
return false;
|
||||
});
|
||||
|
||||
// Touch scrolling: xterm's built-in touch handling is jittery (drags crawl a
|
||||
// line at a time and stall), so map finger drags ourselves. Two routes:
|
||||
// • normal buffer → term.scrollLines walks the scrollback.
|
||||
@@ -135,8 +153,10 @@ export function createAttachConnection(
|
||||
// • alt screen with no mouse tracking → nothing to do; the app owns input.
|
||||
// `touch-action: none` (CSS) keeps the browser from cancelling the custom
|
||||
// gesture stream; only the terminal surface opts out of native page panning.
|
||||
// Listeners MUST sit on `.xterm`, not `.xterm-viewport`: `.xterm-screen` is a
|
||||
// later sibling of the viewport, so it paints over it and takes every touch.
|
||||
{
|
||||
const vp = el.querySelector(".xterm-viewport") as HTMLElement | null;
|
||||
const root = term.element as HTMLElement | undefined;
|
||||
const screen = el.querySelector(".xterm-screen") as HTMLElement | null;
|
||||
const cellH = () => {
|
||||
const core = (term as unknown as {
|
||||
@@ -144,11 +164,11 @@ export function createAttachConnection(
|
||||
})._core;
|
||||
return core?._renderService?.dimensions?.css?.cell?.height || 16;
|
||||
};
|
||||
if (vp) {
|
||||
if (root) {
|
||||
let lastY = 0;
|
||||
let lastX = 0;
|
||||
let remainder = 0;
|
||||
vp.addEventListener(
|
||||
root.addEventListener(
|
||||
"touchstart",
|
||||
(e) => {
|
||||
if (e.touches.length !== 1) return;
|
||||
@@ -158,7 +178,7 @@ export function createAttachConnection(
|
||||
},
|
||||
{ passive: true },
|
||||
);
|
||||
vp.addEventListener(
|
||||
root.addEventListener(
|
||||
"touchmove",
|
||||
(e) => {
|
||||
if (e.touches.length !== 1) return;
|
||||
@@ -423,11 +443,17 @@ export function createAttachConnection(
|
||||
* - `mod` is a sticky one-shot modifier toggle (Ctrl / Alt).
|
||||
* - `cursor` is a cursor/navigation key, identified by its CSI final byte, so a
|
||||
* pending modifier can promote it to the `\x1b[1;<n><final>` form.
|
||||
* - `tilde` is a `~`-terminated navigation key (PgUp/PgDn), identified by its
|
||||
* CSI parameter, whose modified form is `\x1b[<code>;<n>~`.
|
||||
* - `char` is a literal character (the symbols the soft keyboard buries behind
|
||||
* a page switch), folded through a pending modifier like typed input.
|
||||
* - `seq` is a plain key (Esc, Tab) sent verbatim.
|
||||
*/
|
||||
type KeyDef =
|
||||
| { label: string; mod: Modifier }
|
||||
| { label: string; cursor: CursorFinal }
|
||||
| { label: string; tilde: number }
|
||||
| { label: string; char: string }
|
||||
| { label: string; seq: string };
|
||||
|
||||
type Modifier = "ctrl" | "alt";
|
||||
@@ -435,14 +461,17 @@ type Modifier = "ctrl" | "alt";
|
||||
type CursorFinal = "A" | "B" | "C" | "D" | "H" | "F";
|
||||
|
||||
/**
|
||||
* The keys the mobile soft keyboard hides, ordered to flow row-major into a
|
||||
* 5-column / 2-row grid (NAP-342 review):
|
||||
* The keys the mobile soft keyboard hides, ordered to flow row-major into an
|
||||
* 8-column / 2-row grid (#7):
|
||||
*
|
||||
* Esc Tab Home ↑ End
|
||||
* Ctrl Alt ← ↓ →
|
||||
* Esc Tab Home ↑ End PgUp - /
|
||||
* Ctrl Alt ← ↓ → PgDn | ~
|
||||
*
|
||||
* — Esc/Tab + the Ctrl/Alt sticky modifiers on the left, and the cursor keys as
|
||||
* a real-keyboard inverted-T on the right, with Home/End filling its top corners.
|
||||
* — Esc/Tab + the Ctrl/Alt sticky modifiers on the left, the cursor keys as a
|
||||
* real-keyboard inverted-T in the middle with Home/End filling its top corners,
|
||||
* then the paging pair and the shell symbols that cost a soft-keyboard page
|
||||
* switch to reach. Narrower screens scroll the bar sideways rather than
|
||||
* shrinking the caps below a thumb's width.
|
||||
*/
|
||||
const KEY_DEFS: KeyDef[] = [
|
||||
{ label: "Esc", seq: "\x1b" },
|
||||
@@ -450,11 +479,17 @@ const KEY_DEFS: KeyDef[] = [
|
||||
{ label: "Home", cursor: "H" },
|
||||
{ label: "↑", cursor: "A" },
|
||||
{ label: "End", cursor: "F" },
|
||||
{ label: "PgUp", tilde: 5 },
|
||||
{ label: "-", char: "-" },
|
||||
{ label: "/", char: "/" },
|
||||
{ label: "Ctrl", mod: "ctrl" },
|
||||
{ label: "Alt", mod: "alt" },
|
||||
{ label: "←", cursor: "D" },
|
||||
{ label: "↓", cursor: "B" },
|
||||
{ label: "→", cursor: "C" },
|
||||
{ label: "PgDn", tilde: 6 },
|
||||
{ label: "|", char: "|" },
|
||||
{ label: "~", char: "~" },
|
||||
];
|
||||
|
||||
/**
|
||||
@@ -511,6 +546,16 @@ function buildKeyBar(send: (data: string) => void): KeyBar {
|
||||
send(cursorSeq(def.cursor, armed.ctrl, armed.alt));
|
||||
clearMods();
|
||||
});
|
||||
} else if ("tilde" in def) {
|
||||
btn.addEventListener("click", () => {
|
||||
send(tildeSeq(def.tilde, armed.ctrl, armed.alt));
|
||||
clearMods();
|
||||
});
|
||||
} else if ("char" in def) {
|
||||
btn.addEventListener("click", () => {
|
||||
send(applyModsToChar(def.char, armed.ctrl, armed.alt));
|
||||
clearMods();
|
||||
});
|
||||
} else {
|
||||
btn.addEventListener("click", () => {
|
||||
send(def.seq);
|
||||
|
||||
+88
-35
@@ -1,5 +1,5 @@
|
||||
// @vitest-environment happy-dom
|
||||
import { beforeAll, describe, expect, it } from "vitest";
|
||||
import { afterEach, beforeAll, describe, expect, it } from "vitest";
|
||||
|
||||
import { renderSidebar } from "./catalog.js";
|
||||
import type { CatalogListener, CatalogStore } from "./events.js";
|
||||
@@ -16,6 +16,10 @@ beforeAll(() => {
|
||||
window.fetch = () => Promise.reject(new Error("offline"));
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
document.querySelector(".kill-dialog")?.remove();
|
||||
});
|
||||
|
||||
function session(overrides: Partial<Session>): Session {
|
||||
return {
|
||||
id: "11111111-2222-3333-4444-555555555555",
|
||||
@@ -46,6 +50,11 @@ function rowFor(el: HTMLElement, id: string): HTMLElement | null {
|
||||
return el.querySelector<HTMLElement>(`[data-session-id="${id}"]`);
|
||||
}
|
||||
|
||||
/** Let the kill chain's awaits (fetch, its json body) settle. */
|
||||
async function flush(): Promise<void> {
|
||||
for (let i = 0; i < 8; i++) await Promise.resolve();
|
||||
}
|
||||
|
||||
describe("blocked-work indicator (#83)", () => {
|
||||
it("marks the row of a blocked session in diff notation", () => {
|
||||
const blocked = session({
|
||||
@@ -89,37 +98,77 @@ describe("blocked-work indicator (#83)", () => {
|
||||
expect(rowFor(el, unprobed.id)?.querySelector(".leaf-blocked")).toBeNull();
|
||||
});
|
||||
|
||||
it("restates the warning at the kill confirm", async () => {
|
||||
const confirmations: string[] = [];
|
||||
window.confirm = (msg?: string) => {
|
||||
confirmations.push(msg ?? "");
|
||||
return false;
|
||||
};
|
||||
it("kills straight away, without a first confirmation", async () => {
|
||||
const calls: string[] = [];
|
||||
window.fetch = ((url: string, init?: RequestInit) => {
|
||||
calls.push(`${init?.method ?? "GET"} ${url}`);
|
||||
return Promise.resolve(new Response(null, { status: 204 }));
|
||||
}) as typeof fetch;
|
||||
const plain = session({ id: "aaaaaaaa-0000-0000-0000-000000000005" });
|
||||
const el = renderSidebar(storeWith([plain])).el;
|
||||
rowFor(el, plain.id)?.querySelector<HTMLButtonElement>(".leaf-kill")?.click();
|
||||
await flush();
|
||||
expect(calls).toContain(`DELETE /api/sessions/${plain.id}`);
|
||||
expect(document.querySelector(".kill-dialog")).toBeNull();
|
||||
});
|
||||
|
||||
it("offers the override when the daemon refuses a guarded kill", async () => {
|
||||
const calls: string[] = [];
|
||||
window.fetch = ((url: string, init?: RequestInit) => {
|
||||
calls.push(`${init?.method ?? "GET"} ${url}`);
|
||||
if (url.includes("force=true")) return Promise.resolve(new Response(null, { status: 204 }));
|
||||
return Promise.resolve(
|
||||
new Response(
|
||||
JSON.stringify({
|
||||
error: {
|
||||
code: "kill_guarded",
|
||||
message: "worktree has unsaved work",
|
||||
unsaved_work: { untracked_files: 1 },
|
||||
},
|
||||
}),
|
||||
{ status: 409, headers: { "content-type": "application/json" } },
|
||||
),
|
||||
);
|
||||
}) as typeof fetch;
|
||||
const blocked = session({
|
||||
id: "aaaaaaaa-0000-0000-0000-000000000004",
|
||||
command: "bash",
|
||||
blocked_work: { untracked_files: 1 },
|
||||
});
|
||||
const el = renderSidebar(storeWith([blocked])).el;
|
||||
const kill = rowFor(el, blocked.id)?.querySelector<HTMLButtonElement>(".leaf-kill");
|
||||
kill?.click();
|
||||
await Promise.resolve();
|
||||
expect(confirmations).toHaveLength(1);
|
||||
expect(confirmations[0]).toContain("1 untracked file");
|
||||
expect(confirmations[0]).toContain("refused unless forced");
|
||||
rowFor(el, blocked.id)?.querySelector<HTMLButtonElement>(".leaf-kill")?.click();
|
||||
await flush();
|
||||
const dialog = document.querySelector(".kill-dialog");
|
||||
expect(dialog?.textContent).toContain("1 untracked file");
|
||||
dialog?.querySelector<HTMLButtonElement>(".kill-dialog-force")?.click();
|
||||
await flush();
|
||||
expect(calls).toContain(`DELETE /api/sessions/${blocked.id}?force=true`);
|
||||
expect(document.querySelector(".kill-dialog")).toBeNull();
|
||||
});
|
||||
|
||||
it("confirms plainly when nothing blocks", async () => {
|
||||
const confirmations: string[] = [];
|
||||
window.confirm = (msg?: string) => {
|
||||
confirmations.push(msg ?? "");
|
||||
return false;
|
||||
};
|
||||
const plain = session({ id: "aaaaaaaa-0000-0000-0000-000000000005" });
|
||||
const el = renderSidebar(storeWith([plain])).el;
|
||||
rowFor(el, plain.id)?.querySelector<HTMLButtonElement>(".leaf-kill")?.click();
|
||||
await Promise.resolve();
|
||||
expect(confirmations).toEqual(['Kill session "claude"?']);
|
||||
it("closes the override prompt without killing on cancel", async () => {
|
||||
const calls: string[] = [];
|
||||
window.fetch = ((url: string, init?: RequestInit) => {
|
||||
calls.push(`${init?.method ?? "GET"} ${url}`);
|
||||
return Promise.resolve(
|
||||
new Response(
|
||||
JSON.stringify({
|
||||
error: { code: "kill_guarded", message: "worktree has unsaved work" },
|
||||
}),
|
||||
{ status: 409, headers: { "content-type": "application/json" } },
|
||||
),
|
||||
);
|
||||
}) as typeof fetch;
|
||||
const blocked = session({
|
||||
id: "aaaaaaaa-0000-0000-0000-000000000006",
|
||||
blocked_work: { unpushed_commits: 2 },
|
||||
});
|
||||
const el = renderSidebar(storeWith([blocked])).el;
|
||||
rowFor(el, blocked.id)?.querySelector<HTMLButtonElement>(".leaf-kill")?.click();
|
||||
await flush();
|
||||
document.querySelector<HTMLButtonElement>(".kill-dialog-cancel")?.click();
|
||||
expect(document.querySelector(".kill-dialog")).toBeNull();
|
||||
expect(calls.filter((c) => c.includes("force=true"))).toHaveLength(0);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -175,9 +224,10 @@ describe("session cards (#107)", () => {
|
||||
activity_since: ago(5_000),
|
||||
});
|
||||
const el = renderSidebar(storeWith([s])).el;
|
||||
const line2 = rowFor(el, s.id)?.querySelector<HTMLElement>(".card-line2");
|
||||
const row = rowFor(el, s.id);
|
||||
const line2 = row?.querySelector<HTMLElement>(".card-line2");
|
||||
expect(line2).not.toBeNull();
|
||||
expect(line2?.querySelector(".activity-dot")).not.toBeNull();
|
||||
expect(row?.querySelector(".activity-rail")).not.toBeNull();
|
||||
expect(line2?.querySelector(".activity-duration")).toBeNull();
|
||||
expect(line2?.querySelector(".leaf-cmd")).not.toBeNull();
|
||||
});
|
||||
@@ -189,9 +239,10 @@ describe("session cards (#107)", () => {
|
||||
activity_since: ago(4 * 60_000 + 30_000),
|
||||
});
|
||||
const el = renderSidebar(storeWith([s])).el;
|
||||
const line2 = rowFor(el, s.id)?.querySelector<HTMLElement>(".card-line2");
|
||||
const row = rowFor(el, s.id);
|
||||
const line2 = row?.querySelector<HTMLElement>(".card-line2");
|
||||
expect(line2?.dataset.activity).toBe("active");
|
||||
expect(line2?.querySelector(".activity-dot")).not.toBeNull();
|
||||
expect(row?.querySelector(".activity-rail")).not.toBeNull();
|
||||
expect(line2?.querySelector(".activity-duration")?.textContent).toBe("4m");
|
||||
});
|
||||
|
||||
@@ -209,15 +260,16 @@ describe("session cards (#107)", () => {
|
||||
expect(cmd?.querySelector(".leaf-cmd-rest")).toBeNull();
|
||||
});
|
||||
|
||||
it("keeps the command's arguments as text beside the icon", () => {
|
||||
it("drops the command's arguments, keeping them in the tooltip", () => {
|
||||
const s = session({
|
||||
id: "aaaaaaaa-0000-0000-0000-00000000001c",
|
||||
command: "claude --resume",
|
||||
command: "claude --dangerously-skip-permissions",
|
||||
});
|
||||
const el = renderSidebar(storeWith([s])).el;
|
||||
const cmd = rowFor(el, s.id)?.querySelector<HTMLElement>(".card-line2 .leaf-cmd");
|
||||
expect(cmd?.querySelector(".tool-icon")?.getAttribute("data-tool")).toBe("claude");
|
||||
expect(cmd?.querySelector(".leaf-cmd-rest")?.textContent).toBe("--resume");
|
||||
expect(cmd?.querySelector(".leaf-cmd-rest")).toBeNull();
|
||||
expect(cmd?.getAttribute("title")).toBe("claude --dangerously-skip-permissions");
|
||||
});
|
||||
|
||||
it("keeps an unknown command as plain text", () => {
|
||||
@@ -228,7 +280,8 @@ describe("session cards (#107)", () => {
|
||||
const el = renderSidebar(storeWith([s])).el;
|
||||
const cmd = rowFor(el, s.id)?.querySelector<HTMLElement>(".card-line2 .leaf-cmd");
|
||||
expect(cmd?.querySelector(".tool-icon")).toBeNull();
|
||||
expect(cmd?.querySelector(".leaf-cmd-rest")?.textContent).toBe("hx src/main.rs");
|
||||
expect(cmd?.querySelector(".leaf-cmd-rest")?.textContent).toBe("hx");
|
||||
expect(cmd?.getAttribute("title")).toBe("hx src/main.rs");
|
||||
});
|
||||
|
||||
it("maps each activity state to its contract slug", () => {
|
||||
@@ -304,9 +357,9 @@ describe("session cards (#107)", () => {
|
||||
});
|
||||
const el = renderSidebar(storeWith([s])).el;
|
||||
const row = rowFor(el, s.id) as HTMLElement;
|
||||
const dot = row.querySelector<HTMLElement>(".activity-dot");
|
||||
expect(dot?.getAttribute("title")).toContain("Awaiting input");
|
||||
expect(dot?.getAttribute("aria-label")).toContain("Awaiting input");
|
||||
const rail = row.querySelector<HTMLElement>(".activity-rail");
|
||||
expect(rail?.getAttribute("title")).toContain("Awaiting input");
|
||||
expect(rail?.getAttribute("aria-label")).toContain("Awaiting input");
|
||||
expect(row.textContent).not.toMatch(/awaiting.?input/i);
|
||||
});
|
||||
|
||||
|
||||
+83
-86
@@ -1,5 +1,6 @@
|
||||
import { escapeHtml } from "./html.js";
|
||||
import { getDaemonInfo, killSession, renameSession } from "./api.js";
|
||||
import { ApiRequestError, getDaemonInfo, killSession, renameSession } from "./api.js";
|
||||
import { openForceKillDialog } from "./killDialog.js";
|
||||
import { openContextMenu } from "./contextMenu.js";
|
||||
import { isTypingTarget, toggleHelp } from "./help.js";
|
||||
import { CatalogStore } from "./events.js";
|
||||
@@ -23,9 +24,11 @@ import {
|
||||
} from "./activity.js";
|
||||
import type { TreeNode } from "./tree.js";
|
||||
import { buildTree } from "./tree.js";
|
||||
import { createThemeToggle } from "./theme.js";
|
||||
import { createPaletteSelect, createThemeToggle } from "./theme.js";
|
||||
import type { DaemonLink } from "./daemonLink.js";
|
||||
import { createStatusIndicator } from "./statusIndicator.js";
|
||||
|
||||
/** Ask the shell to open a new draft pane (#62). Handled in main.ts, where the
|
||||
/** Ask the shell to open the spawn modal. Handled in main.ts, where the
|
||||
* multi-view controller lives; dispatched from every Spawn affordance. */
|
||||
export const OPEN_SPAWN_EVENT = "catalog-open-spawn";
|
||||
export function requestOpenSpawn(): void {
|
||||
@@ -33,14 +36,26 @@ export function requestOpenSpawn(): void {
|
||||
}
|
||||
|
||||
/** Ask the shell to hand the keyboard back to the focused pane's terminal —
|
||||
* what Escape in the sidebar list does. Handled in main.ts, which owns the
|
||||
* what Tab in the sidebar list does. Handled in main.ts, which owns the
|
||||
* connection pool. */
|
||||
export const FOCUS_PANE_EVENT = "catalog-focus-pane";
|
||||
|
||||
/** Ask the shell to open a draft pane seeded from an existing session
|
||||
/** Ask the shell to hand the keyboard back to the session list — what Escape
|
||||
* does when the pane's terminal is focused. Handled in main.ts. */
|
||||
export const FOCUS_SIDEBAR_EVENT = "catalog-focus-sidebar";
|
||||
|
||||
/** Ask the shell to open the spawn modal seeded from an existing session
|
||||
* ("Spawn similar"). Detail is the session being cloned. */
|
||||
export const SPAWN_SIMILAR_EVENT = "catalog-spawn-similar";
|
||||
|
||||
/** A session row was clicked (issue #133). The row's `href` drives normal
|
||||
* hash navigation, but a split/drag can move focus without ever touching
|
||||
* `location.hash` — so a click back onto a session whose hash still
|
||||
* matches fires no `hashchange` and the app never hears about it. This
|
||||
* event is the click-driven path that doesn't depend on the hash actually
|
||||
* changing. */
|
||||
export const SESSION_SELECT_EVENT = "catalog-session-select";
|
||||
|
||||
/** The rows a keyboard walk stops on, in visual (document) order. Expanded
|
||||
* folder headers are skipped: a directory is not something to focus, and the
|
||||
* cards under it are one row away anyway. A *collapsed* folder still counts —
|
||||
@@ -55,8 +70,9 @@ const collapsed = new Set<string>();
|
||||
* would otherwise replace the field the user is typing into. */
|
||||
let renamingId: string | null = null;
|
||||
|
||||
// docs/SIDEBAR.md: the state word is never rendered — the dot's colour carries
|
||||
// it. It survives only in tooltips/aria labels so meaning is not colour-only.
|
||||
// docs/SIDEBAR.md: the state word is never rendered — the rail's colour
|
||||
// carries it. It survives only in tooltips/aria labels so meaning is not
|
||||
// colour-only.
|
||||
const STATE_WORDS: Record<string, string> = {
|
||||
active: "Active",
|
||||
idle: "Idle",
|
||||
@@ -64,24 +80,29 @@ const STATE_WORDS: Record<string, string> = {
|
||||
error: "Error",
|
||||
};
|
||||
|
||||
/** docs/SIDEBAR.md: the activity rail is pinned to the row's own left edge,
|
||||
* full height. The row's own padding (`renderNode`) shifts outward with
|
||||
* nesting depth, carrying the rail with it. */
|
||||
function activityRailMarkup(slug: string, stateWord: string): string {
|
||||
return `<span class="activity-rail" data-activity="${slug}" role="img" title="${escapeHtml(stateWord)}" aria-label="${escapeHtml(stateWord)}"></span>`;
|
||||
}
|
||||
|
||||
function metaLine(s: Session, now: number): string {
|
||||
const dead = s.status === "Dead";
|
||||
const blockers = sessionBlockers(s);
|
||||
const slug = activityColorSlug(s.activity ?? "Idle");
|
||||
const stateWord = STATE_WORDS[slug] ?? STATE_WORDS.idle;
|
||||
const held = activityHeldMs(s.activity_since, now);
|
||||
const duration =
|
||||
held !== null && held >= META_LINE_MIN_HOLD_MS ? activityDurationLabel(held) : null;
|
||||
|
||||
const fragments = [
|
||||
`<span class="activity-dot" role="img" title="${escapeHtml(stateWord)}" aria-label="${escapeHtml(stateWord)}"></span>`,
|
||||
duration ? `<span class="activity-duration">${duration}</span>` : "",
|
||||
s.activity_detail
|
||||
? `<span class="activity-detail">${escapeHtml(s.activity_detail)}</span>`
|
||||
: "",
|
||||
commandFragment(s.command),
|
||||
blockers ? blockedFragment(blockers) : "",
|
||||
dead ? `<span class="card-flag">exited</span>` : "",
|
||||
commandFragment(s.command),
|
||||
];
|
||||
return `<span class="card-line2" data-activity="${slug}">${fragments.join("")}</span>`;
|
||||
}
|
||||
@@ -96,13 +117,14 @@ function blockedFragment(blockers: InTheWay): string {
|
||||
return `<span class="card-flag leaf-blocked" title="${escapeHtml(title)}">${stats}</span>`;
|
||||
}
|
||||
|
||||
/** docs/SIDEBAR.md: the command's leading program becomes its tool icon when
|
||||
* we have a mark for it, and only the remaining words stay as text. The full
|
||||
* command line stays in the tooltip either way. */
|
||||
/** docs/SIDEBAR.md: the card names the program only — arguments never reach
|
||||
* the card. The program becomes its tool icon when we have a mark for it, and
|
||||
* stays as its bare name when we do not. The full command line, arguments and
|
||||
* all, stays in the tooltip either way. */
|
||||
function commandFragment(command: string): string {
|
||||
const { tool, rest } = splitCommand(command);
|
||||
const { tool, program } = splitCommand(command);
|
||||
const icon = tool ? toolIconSvg(tool) : null;
|
||||
const text = icon ? rest : command;
|
||||
const text = icon ? "" : program;
|
||||
return `<span class="card-flag leaf-cmd" title="${escapeHtml(command)}">${icon ?? ""}${text ? `<span class="leaf-cmd-rest">${escapeHtml(text)}</span>` : ""}</span>`;
|
||||
}
|
||||
|
||||
@@ -152,14 +174,15 @@ function renderNode(node: TreeNode, depth: number): HTMLElement {
|
||||
const running = s.status === "Running";
|
||||
row.dataset.status = running ? "running" : "dead";
|
||||
const name = sessionName(s);
|
||||
const stateWord =
|
||||
STATE_WORDS[activityColorSlug(s.activity ?? "Idle")] ?? STATE_WORDS.idle;
|
||||
const slug = activityColorSlug(s.activity ?? "Idle");
|
||||
const stateWord = STATE_WORDS[slug] ?? STATE_WORDS.idle;
|
||||
row.setAttribute(
|
||||
"aria-label",
|
||||
`${name}, ${running ? "running" : "exited"}, ${stateWord}`,
|
||||
);
|
||||
// docs/SIDEBAR.md: line 1 reserves action width, and line 2 is unconditional.
|
||||
row.innerHTML = `
|
||||
${activityRailMarkup(slug, stateWord)}
|
||||
<span class="card-line1">
|
||||
<span class="leaf-name">${escapeHtml(name)}</span>
|
||||
<span class="leaf-actions">
|
||||
@@ -179,7 +202,10 @@ function renderNode(node: TreeNode, depth: number): HTMLElement {
|
||||
killBtn.addEventListener("click", (ev) => {
|
||||
ev.preventDefault();
|
||||
ev.stopPropagation();
|
||||
void confirmAndKill(s, name);
|
||||
void requestKill(s, name);
|
||||
});
|
||||
row.addEventListener("click", () => {
|
||||
document.dispatchEvent(new CustomEvent(SESSION_SELECT_EVENT, { detail: s.id }));
|
||||
});
|
||||
row.addEventListener("contextmenu", (ev) => {
|
||||
ev.preventDefault();
|
||||
@@ -191,22 +217,31 @@ function renderNode(node: TreeNode, depth: number): HTMLElement {
|
||||
onSelect: () =>
|
||||
document.dispatchEvent(new CustomEvent(SPAWN_SIMILAR_EVENT, { detail: s })),
|
||||
},
|
||||
{ label: "Kill session", danger: true, onSelect: () => void confirmAndKill(s, name) },
|
||||
{ label: "Kill session", danger: true, onSelect: () => void requestKill(s, name) },
|
||||
]);
|
||||
});
|
||||
return row;
|
||||
}
|
||||
|
||||
/** #83: the confirm restates the warning at the moment of decision. */
|
||||
async function confirmAndKill(s: Session, name: string): Promise<void> {
|
||||
const blockers = sessionBlockers(s);
|
||||
const question = blockers
|
||||
? `Kill session "${name}"? Its worktree still has ${formatInTheWay(blockers)} — the kill will be refused unless forced.`
|
||||
: `Kill session "${name}"?`;
|
||||
if (!confirm(question)) return;
|
||||
/**
|
||||
* Kill on the first click (#81): the daemon is the one that decides whether a
|
||||
* session may go, and it refuses over a worktree holding unsaved work. Only
|
||||
* that refusal is worth a prompt, and it needs one `confirm()` cannot give —
|
||||
* a forced kill. Anything else surfaces as an alert.
|
||||
*/
|
||||
async function requestKill(s: Session, name: string): Promise<void> {
|
||||
try {
|
||||
await killSession(s.id);
|
||||
} catch (e) {
|
||||
if (e instanceof ApiRequestError && e.code === "kill_guarded") {
|
||||
openForceKillDialog({
|
||||
name,
|
||||
blockers: e.unsavedWork ?? sessionBlockers(s),
|
||||
reason: e.detail,
|
||||
onForce: () => killSession(s.id, true),
|
||||
});
|
||||
return;
|
||||
}
|
||||
alert(`Failed to kill: ${(e as Error).message}`);
|
||||
}
|
||||
}
|
||||
@@ -266,18 +301,6 @@ function beginRename(row: HTMLElement, s: Session): void {
|
||||
input.select();
|
||||
}
|
||||
|
||||
function renderStatusbar(sessions: Session[]): HTMLElement {
|
||||
const wrap = document.createElement("div");
|
||||
wrap.className = "statusbar";
|
||||
|
||||
const live = sessions.filter((s) => s.status === "Running").length;
|
||||
const tally = document.createElement("span");
|
||||
tally.className = "session-tally";
|
||||
tally.textContent = `${sessions.length} session${sessions.length === 1 ? "" : "s"} · ${live} live`;
|
||||
wrap.appendChild(tally);
|
||||
return wrap;
|
||||
}
|
||||
|
||||
function renderEmpty(filtering: boolean, onSpawn: () => void): HTMLElement {
|
||||
const el = document.createElement("div");
|
||||
el.className = "empty";
|
||||
@@ -302,51 +325,6 @@ function renderEmpty(filtering: boolean, onSpawn: () => void): HTMLElement {
|
||||
return el;
|
||||
}
|
||||
|
||||
/**
|
||||
* The global app header (full width, above the sidebar/content split): brand +
|
||||
* session tally. App-level actions (help, theme, spawn) live pinned to the
|
||||
* sidebar's foot instead — see {@link renderSidebar}.
|
||||
*/
|
||||
export function renderTopbar(store: CatalogStore, onToggleSidebar?: () => void): HTMLElement {
|
||||
const header = document.createElement("header");
|
||||
header.className = "app-header";
|
||||
header.innerHTML = `
|
||||
<button type="button" class="app-menu" title="Sessions" aria-label="Toggle session list">☰</button>
|
||||
<a class="brand" href="#/" aria-label="maestro — clear selection">
|
||||
<span class="brand-dot" aria-hidden="true"></span>
|
||||
<h1>maestro<span class="blink" aria-hidden="true">_</span></h1>
|
||||
</a>
|
||||
<div class="app-status"></div>
|
||||
<div class="app-actions"></div>
|
||||
`;
|
||||
// Mobile-only ☰ (CSS hides it on desktop) — opens the off-canvas session drawer.
|
||||
(header.querySelector(".app-menu") as HTMLElement).addEventListener("click", () =>
|
||||
onToggleSidebar?.(),
|
||||
);
|
||||
|
||||
// Session tally lives centered in the header (not the sidebar).
|
||||
const statusHost = header.querySelector(".app-status") as HTMLElement;
|
||||
const renderStatus = () => {
|
||||
const state = store.snapshot();
|
||||
statusHost.replaceChildren(renderStatusbar([...state.sessions.values()]));
|
||||
};
|
||||
store.subscribe(renderStatus);
|
||||
renderStatus();
|
||||
|
||||
const actions = header.querySelector(".app-actions") as HTMLElement;
|
||||
// DEV-only shortcut to the standalone design kit (?kit). Lets you reach it by
|
||||
// clicking inside a proxied preview (e.g. crit live) that has no address bar.
|
||||
if (import.meta.env.DEV) {
|
||||
const kit = document.createElement("a");
|
||||
kit.className = "btn btn-ghost";
|
||||
kit.href = "?kit";
|
||||
kit.textContent = "kit";
|
||||
kit.title = "Open the design kit (DEV)";
|
||||
actions.appendChild(kit);
|
||||
}
|
||||
return header;
|
||||
}
|
||||
|
||||
/** Two-tier sidebar highlight state (issue #33): which sessions are open in some
|
||||
* pane (quiet), and which one is focused (loud). */
|
||||
export interface SidebarHighlights {
|
||||
@@ -382,6 +360,9 @@ export interface SidebarOptions {
|
||||
/** Pointerdown on a session row — the multi-view controller decides drag vs
|
||||
* tap (issue #32). Tap falls through to the row's normal click (open). */
|
||||
onLeafDrag?: (sessionId: string, e: PointerEvent) => void;
|
||||
/** Daemon link behind the footer's status dot. Omitted in tests and in the
|
||||
* design kit, which render the sidebar without a daemon. */
|
||||
link?: DaemonLink;
|
||||
}
|
||||
|
||||
export function renderSidebar(store: CatalogStore, opts: SidebarOptions = {}): SidebarHandle {
|
||||
@@ -426,12 +407,27 @@ export function renderSidebar(store: CatalogStore, opts: SidebarOptions = {}): S
|
||||
helpBtn.addEventListener("click", () => toggleHelp());
|
||||
footer.appendChild(helpBtn);
|
||||
footer.appendChild(createThemeToggle());
|
||||
footer.appendChild(createPaletteSelect());
|
||||
// DEV-only shortcut to the standalone design kit (?kit). Lets you reach it by
|
||||
// clicking inside a proxied preview (e.g. crit live) that has no address bar.
|
||||
if (import.meta.env.DEV) {
|
||||
const kit = document.createElement("a");
|
||||
kit.className = "btn btn-ghost";
|
||||
kit.href = "?kit";
|
||||
kit.textContent = "kit";
|
||||
kit.title = "Open the design kit (DEV)";
|
||||
footer.appendChild(kit);
|
||||
}
|
||||
// Daemon status sits beside the spawn button: colour for the link state,
|
||||
// hover for the release the daemon is running.
|
||||
const status = opts.link ? createStatusIndicator(opts.link) : null;
|
||||
if (status) footer.appendChild(status.el);
|
||||
const spawnBtn = document.createElement("button");
|
||||
spawnBtn.type = "button";
|
||||
spawnBtn.className = "btn btn-primary spawn-btn";
|
||||
spawnBtn.textContent = "+ Spawn";
|
||||
// The keyboard pair sits right here in the tooltip (#67).
|
||||
spawnBtn.title = "Draft pane: n — fast-forward spawn: N";
|
||||
spawnBtn.title = "Spawn form: n — fast-forward spawn: N";
|
||||
spawnBtn.addEventListener("click", () => requestOpenSpawn());
|
||||
footer.appendChild(spawnBtn);
|
||||
el.appendChild(footer);
|
||||
@@ -576,7 +572,7 @@ export function renderSidebar(store: CatalogStore, opts: SidebarOptions = {}): S
|
||||
if (e.key === "j" || e.key === "ArrowDown") moveNav(1);
|
||||
else if (e.key === "k" || e.key === "ArrowUp") moveNav(-1);
|
||||
else if (e.key === "Enter") activateNav();
|
||||
else if (e.key === "Escape") document.dispatchEvent(new CustomEvent(FOCUS_PANE_EVENT));
|
||||
else if (e.key === "Tab") document.dispatchEvent(new CustomEvent(FOCUS_PANE_EVENT));
|
||||
else return;
|
||||
e.preventDefault();
|
||||
});
|
||||
@@ -614,7 +610,7 @@ export function renderSidebar(store: CatalogStore, opts: SidebarOptions = {}): S
|
||||
document.addEventListener("catalog-rerender", rerenderHandler);
|
||||
|
||||
// "Spawn similar" (#28) is dispatched here and handled in main.ts, where the
|
||||
// multi-view controller can seed a draft pane with the session's dir/command.
|
||||
// multi-view controller can seed the spawn modal with the session's dir/command.
|
||||
|
||||
const unsubscribe = store.subscribe(refresh);
|
||||
|
||||
@@ -653,6 +649,7 @@ export function renderSidebar(store: CatalogStore, opts: SidebarOptions = {}): S
|
||||
},
|
||||
dispose() {
|
||||
clearInterval(clock);
|
||||
status?.dispose();
|
||||
// An unfinished rename would otherwise leave every later sidebar
|
||||
// refusing to refresh.
|
||||
renamingId = null;
|
||||
|
||||
@@ -0,0 +1,87 @@
|
||||
// @vitest-environment happy-dom
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
import { ConnectionPool } from "./connections.js";
|
||||
|
||||
afterEach(() => {
|
||||
vi.unstubAllGlobals();
|
||||
});
|
||||
|
||||
const A = "aaaaaaaa-0000-0000-0000-0000000000ff";
|
||||
const B = "bbbbbbbb-0000-0000-0000-0000000000ff";
|
||||
|
||||
function mockFetch() {
|
||||
const fetchMock = vi.fn(() => Promise.resolve(new Response(null, { status: 204 })));
|
||||
vi.stubGlobal("fetch", fetchMock);
|
||||
return fetchMock;
|
||||
}
|
||||
|
||||
describe("ConnectionPool.setFocus", () => {
|
||||
it("reports the new session focused, none unfocused, the first time", () => {
|
||||
const fetchMock = mockFetch();
|
||||
const pool = new ConnectionPool();
|
||||
|
||||
pool.setFocus(A);
|
||||
|
||||
expect(fetchMock).toHaveBeenCalledOnce();
|
||||
const [url, init] = fetchMock.mock.calls[0] as unknown as [string, RequestInit];
|
||||
expect(url).toBe(`/api/sessions/${A}/focus`);
|
||||
expect(init.method).toBe("POST");
|
||||
expect(JSON.parse(init.body as string)).toEqual({ focused: true });
|
||||
});
|
||||
|
||||
it("unfocuses the previous session and focuses the new one on a switch", () => {
|
||||
const fetchMock = mockFetch();
|
||||
const pool = new ConnectionPool();
|
||||
pool.setFocus(A);
|
||||
fetchMock.mockClear();
|
||||
|
||||
pool.setFocus(B);
|
||||
|
||||
expect(fetchMock).toHaveBeenCalledTimes(2);
|
||||
const bodies = fetchMock.mock.calls.map(([url, init]: unknown[]) => [
|
||||
url,
|
||||
JSON.parse((init as RequestInit).body as string),
|
||||
]);
|
||||
expect(bodies).toContainEqual([`/api/sessions/${A}/focus`, { focused: false }]);
|
||||
expect(bodies).toContainEqual([`/api/sessions/${B}/focus`, { focused: true }]);
|
||||
});
|
||||
|
||||
it("reports unfocused when focus clears to null", () => {
|
||||
const fetchMock = mockFetch();
|
||||
const pool = new ConnectionPool();
|
||||
pool.setFocus(A);
|
||||
fetchMock.mockClear();
|
||||
|
||||
pool.setFocus(null);
|
||||
|
||||
expect(fetchMock).toHaveBeenCalledOnce();
|
||||
const [url, init] = fetchMock.mock.calls[0] as unknown as [string, RequestInit];
|
||||
expect(url).toBe(`/api/sessions/${A}/focus`);
|
||||
expect(JSON.parse(init.body as string)).toEqual({ focused: false });
|
||||
});
|
||||
|
||||
it("is a no-op when the focused session doesn't change", () => {
|
||||
const fetchMock = mockFetch();
|
||||
const pool = new ConnectionPool();
|
||||
pool.setFocus(A);
|
||||
fetchMock.mockClear();
|
||||
|
||||
pool.setFocus(A);
|
||||
|
||||
expect(fetchMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("does not let a fetch rejection break the pool", async () => {
|
||||
vi.stubGlobal(
|
||||
"fetch",
|
||||
vi.fn(() => Promise.reject(new Error("offline"))),
|
||||
);
|
||||
const pool = new ConnectionPool();
|
||||
|
||||
expect(() => pool.setFocus(A)).not.toThrow();
|
||||
// Let the rejected promise's `.catch` settle before the test ends.
|
||||
await Promise.resolve();
|
||||
await Promise.resolve();
|
||||
});
|
||||
});
|
||||
@@ -3,6 +3,7 @@ import {
|
||||
type AttachConnection,
|
||||
type AttachInfo,
|
||||
} from "./attach.js";
|
||||
import { setSessionFocus } from "./api.js";
|
||||
import type { Uuid } from "./types.js";
|
||||
|
||||
/**
|
||||
@@ -122,9 +123,16 @@ export class ConnectionPool {
|
||||
for (const e of entries) this.mount(e.id, e.pane, e.info);
|
||||
}
|
||||
|
||||
/** Also tells the daemon which pane is focused (docs/SIDEBAR.md's
|
||||
* `AwaitingInput` auto-clear) — the sidebar highlight never calls this,
|
||||
* only a pane actually becoming the visible view. Best-effort: a failed
|
||||
* report only delays the glow clearing. */
|
||||
setFocus(id: Uuid | null): void {
|
||||
if (id === this.focusedId) return;
|
||||
const previous = this.focusedId;
|
||||
this.focusedId = id;
|
||||
if (previous !== null) void setSessionFocus(previous, false).catch(() => {});
|
||||
if (id !== null) void setSessionFocus(id, true).catch(() => {});
|
||||
this.opts.onFocusChange?.(id);
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,193 @@
|
||||
import { describe, expect, it, vi } from "vitest";
|
||||
|
||||
import { DaemonLink, compareIdentity, formatRelease } from "./daemonLink.js";
|
||||
import type { Scheduler } from "./events.js";
|
||||
import type { DaemonInfo } from "./types.js";
|
||||
|
||||
function info(commit: string, instance: string, date = "2026-09-02T14:03:11+01:00"): DaemonInfo {
|
||||
return {
|
||||
hostname: "konishi",
|
||||
version: "0.1.0",
|
||||
presets: [],
|
||||
build: { commit, commit_date: date, dirty: false },
|
||||
instance,
|
||||
};
|
||||
}
|
||||
|
||||
/** Scheduler whose timers only fire when the test says so. */
|
||||
function manual(): Scheduler & { run(): void; pending(): number } {
|
||||
let next = 1;
|
||||
const timers = new Map<number, () => void>();
|
||||
return {
|
||||
setTimer(fn) {
|
||||
const h = next++;
|
||||
timers.set(h, fn);
|
||||
return h;
|
||||
},
|
||||
clearTimer(h) {
|
||||
timers.delete(h);
|
||||
},
|
||||
run() {
|
||||
const due = [...timers.entries()];
|
||||
timers.clear();
|
||||
for (const [, fn] of due) fn();
|
||||
},
|
||||
pending: () => timers.size,
|
||||
};
|
||||
}
|
||||
|
||||
describe("compareIdentity", () => {
|
||||
it("reads a changed commit as an upgrade", () => {
|
||||
expect(compareIdentity(info("aaa", "i1"), info("bbb", "i2"))).toBe("upgraded");
|
||||
});
|
||||
|
||||
it("reads a changed instance on the same commit as a plain restart", () => {
|
||||
expect(compareIdentity(info("aaa", "i1"), info("aaa", "i2"))).toBe("restarted");
|
||||
});
|
||||
|
||||
it("reads an unchanged process as no event at all", () => {
|
||||
expect(compareIdentity(info("aaa", "i1"), info("aaa", "i1"))).toBe("same");
|
||||
});
|
||||
|
||||
it("falls back to the instance when the build is unknown", () => {
|
||||
// A daemon built outside a checkout reports empty commits; the instance is
|
||||
// still enough to see the restart, and never claims a phantom upgrade.
|
||||
expect(compareIdentity(info("", "i1"), info("", "i2"))).toBe("restarted");
|
||||
expect(compareIdentity(info("", "i1"), info("", "i1"))).toBe("same");
|
||||
});
|
||||
});
|
||||
|
||||
describe("formatRelease", () => {
|
||||
it("pairs the short hash with a readable date", () => {
|
||||
expect(formatRelease({ commit: "f89be4a716c7", commit_date: "2026-09-02T14:03:11Z", dirty: false })).toBe(
|
||||
"f89be4a716c7 · 2026-09-02",
|
||||
);
|
||||
});
|
||||
|
||||
it("marks a dirty build", () => {
|
||||
expect(formatRelease({ commit: "f89be4a", commit_date: "", dirty: true })).toBe("f89be4a (dirty)");
|
||||
});
|
||||
|
||||
it("says so when the release is unknown", () => {
|
||||
expect(formatRelease(undefined)).toBe("unknown release");
|
||||
});
|
||||
});
|
||||
|
||||
describe("DaemonLink", () => {
|
||||
it("starts online once the first probe lands", async () => {
|
||||
const link = new DaemonLink({
|
||||
fetchInfo: async () => info("aaa", "i1"),
|
||||
scheduler: manual(),
|
||||
reload: () => {},
|
||||
});
|
||||
await link.start();
|
||||
expect(link.status().state).toBe("online");
|
||||
expect(link.status().build?.commit).toBe("aaa");
|
||||
});
|
||||
|
||||
it("holds the modal back during the grace period, then blocks", async () => {
|
||||
const sched = manual();
|
||||
const link = new DaemonLink({
|
||||
fetchInfo: async () => {
|
||||
throw new Error("down");
|
||||
},
|
||||
scheduler: sched,
|
||||
reload: () => {},
|
||||
graceMs: 1000,
|
||||
});
|
||||
link.noteDisconnected();
|
||||
// Still inside the grace window: the dot goes amber, nothing blocks.
|
||||
expect(link.status().state).toBe("reconnecting");
|
||||
sched.run();
|
||||
await Promise.resolve();
|
||||
expect(link.status().state).toBe("down");
|
||||
});
|
||||
|
||||
it("unlocks without reloading when the same build comes back", async () => {
|
||||
const sched = manual();
|
||||
const reload = vi.fn();
|
||||
let reply: DaemonInfo | null = info("aaa", "i1");
|
||||
const link = new DaemonLink({
|
||||
fetchInfo: async () => {
|
||||
if (!reply) throw new Error("down");
|
||||
return reply;
|
||||
},
|
||||
scheduler: sched,
|
||||
reload,
|
||||
});
|
||||
await link.start();
|
||||
|
||||
reply = null;
|
||||
link.noteDisconnected();
|
||||
sched.run(); // grace expires → blocked, poll scheduled
|
||||
await Promise.resolve();
|
||||
expect(link.status().state).toBe("down");
|
||||
|
||||
// Same commit, new process: a restart, not an upgrade — the page stays.
|
||||
reply = info("aaa", "i2");
|
||||
await link.probe();
|
||||
expect(reload).not.toHaveBeenCalled();
|
||||
expect(link.status().state).toBe("online");
|
||||
});
|
||||
|
||||
it("reloads the page when the daemon comes back on a new commit", async () => {
|
||||
const sched = manual();
|
||||
const reload = vi.fn();
|
||||
let reply = info("aaa", "i1");
|
||||
const link = new DaemonLink({
|
||||
fetchInfo: async () => reply,
|
||||
scheduler: sched,
|
||||
reload,
|
||||
});
|
||||
await link.start();
|
||||
|
||||
link.noteDisconnected();
|
||||
reply = info("bbb", "i2");
|
||||
await link.probe();
|
||||
expect(reload).toHaveBeenCalledTimes(1);
|
||||
// Left blocked deliberately: the reload is what ends this page's life, and
|
||||
// flashing an unlocked UI in between would let the user act on stale code.
|
||||
expect(link.status().state).toBe("updating");
|
||||
});
|
||||
|
||||
it("keeps polling on a scheduled cadence while the daemon is unreachable", async () => {
|
||||
const sched = manual();
|
||||
let attempts = 0;
|
||||
const link = new DaemonLink({
|
||||
fetchInfo: async () => {
|
||||
attempts += 1;
|
||||
throw new Error("down");
|
||||
},
|
||||
scheduler: sched,
|
||||
reload: () => {},
|
||||
});
|
||||
link.noteDisconnected();
|
||||
sched.run(); // grace → first poll
|
||||
await Promise.resolve();
|
||||
await Promise.resolve();
|
||||
const first = attempts;
|
||||
expect(first).toBeGreaterThan(0);
|
||||
sched.run(); // next poll tick
|
||||
await Promise.resolve();
|
||||
await Promise.resolve();
|
||||
expect(attempts).toBeGreaterThan(first);
|
||||
link.stop();
|
||||
});
|
||||
|
||||
it("notifies subscribers on every state change", async () => {
|
||||
const sched = manual();
|
||||
const seen: string[] = [];
|
||||
const link = new DaemonLink({
|
||||
fetchInfo: async () => info("aaa", "i1"),
|
||||
scheduler: sched,
|
||||
reload: () => {},
|
||||
});
|
||||
link.subscribe((s) => seen.push(s.state));
|
||||
await link.start();
|
||||
link.noteDisconnected();
|
||||
sched.run();
|
||||
await Promise.resolve();
|
||||
expect(seen).toContain("reconnecting");
|
||||
expect(seen[0]).toBe("connecting");
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,218 @@
|
||||
// The link to the daemon behind this page: is it up, and which release is it?
|
||||
// The sidebar's status indicator and the restart overlay both read this one
|
||||
// controller. See docs/RESTART.md for the restart contract it implements.
|
||||
|
||||
import { getDaemonInfo } from "./api.js";
|
||||
import type { Scheduler } from "./events.js";
|
||||
import type { BuildInfo, DaemonInfo } from "./types.js";
|
||||
|
||||
/**
|
||||
* - `connecting` — first probe hasn't landed yet.
|
||||
* - `online` — the daemon answered and is the same process, or a resolved new one.
|
||||
* - `reconnecting` — the socket dropped, but within the grace window; a blip
|
||||
* shouldn't throw a modal in the user's face.
|
||||
* - `down` — unreachable past the grace window: the overlay blocks the UI and
|
||||
* the poll runs until it answers.
|
||||
* - `updating` — it answered on a different commit; the page is reloading and
|
||||
* stays blocked until it does.
|
||||
*/
|
||||
export type LinkState = "connecting" | "online" | "reconnecting" | "down" | "updating";
|
||||
|
||||
export interface LinkStatus {
|
||||
state: LinkState;
|
||||
/** The release the daemon last reported. Undefined until the first probe,
|
||||
* and on a daemon too old to carry one. */
|
||||
build?: BuildInfo;
|
||||
/** Hostname the daemon reports, for the indicator's tooltip. */
|
||||
hostname?: string;
|
||||
/** How many probes have failed in the current outage — the overlay counts
|
||||
* attempts so a long restart doesn't look frozen. */
|
||||
attempts: number;
|
||||
}
|
||||
|
||||
/** What happened between two `/api/info` replies. */
|
||||
export type RestartKind = "same" | "restarted" | "upgraded";
|
||||
|
||||
/** How long a dropped socket may stay dropped before the UI blocks. Long enough
|
||||
* to ride out a wifi hiccup, short enough that a real restart is visible. */
|
||||
export const GRACE_MS = 1200;
|
||||
/** Cadence of the `/api/info` poll while the daemon is unreachable. */
|
||||
export const POLL_MS = 700;
|
||||
|
||||
const browserScheduler: Scheduler = {
|
||||
setTimer: (fn, ms) => window.setTimeout(fn, ms),
|
||||
clearTimer: (h) => window.clearTimeout(h),
|
||||
};
|
||||
|
||||
/**
|
||||
* Compare two daemon replies.
|
||||
*
|
||||
* The commit decides first: a different one means new code, which for a browser
|
||||
* means new assets. The per-process `instance` catches the rest — a restart of
|
||||
* the same build, which needs no reload. A daemon built outside a git checkout
|
||||
* reports an empty commit, so an empty-vs-empty pair never counts as an
|
||||
* upgrade; the instance still reports the restart.
|
||||
*/
|
||||
export function compareIdentity(before: DaemonInfo, after: DaemonInfo): RestartKind {
|
||||
const a = before.build?.commit ?? "";
|
||||
const b = after.build?.commit ?? "";
|
||||
if (a && b && a !== b) return "upgraded";
|
||||
if (before.instance && after.instance && before.instance !== after.instance) return "restarted";
|
||||
return "same";
|
||||
}
|
||||
|
||||
/** One line naming a release: `f89be4a716c7 · 2026-09-02`, with `(dirty)` when
|
||||
* the build carried uncommitted changes. Empty builds say so rather than
|
||||
* rendering a blank tooltip. */
|
||||
export function formatRelease(build: BuildInfo | undefined): string {
|
||||
if (!build?.commit) return "unknown release";
|
||||
const day = build.commit_date ? build.commit_date.slice(0, 10) : "";
|
||||
const parts = [build.commit];
|
||||
if (day) parts.push(`· ${day}`);
|
||||
if (build.dirty) parts.push("(dirty)");
|
||||
return parts.join(" ");
|
||||
}
|
||||
|
||||
export interface DaemonLinkOptions {
|
||||
/** Injectable for tests; defaults to `GET /api/info`. */
|
||||
fetchInfo?: () => Promise<DaemonInfo>;
|
||||
scheduler?: Scheduler;
|
||||
/** What an upgrade does. Injectable so tests don't navigate. */
|
||||
reload?: () => void;
|
||||
graceMs?: number;
|
||||
pollMs?: number;
|
||||
}
|
||||
|
||||
export type LinkListener = (status: LinkStatus) => void;
|
||||
|
||||
export class DaemonLink {
|
||||
private state: LinkState = "connecting";
|
||||
private identity: DaemonInfo | null = null;
|
||||
private attempts = 0;
|
||||
private graceTimer: number | null = null;
|
||||
private pollTimer: number | null = null;
|
||||
private readonly listeners = new Set<LinkListener>();
|
||||
private readonly fetchInfo: () => Promise<DaemonInfo>;
|
||||
private readonly scheduler: Scheduler;
|
||||
private readonly reload: () => void;
|
||||
private readonly graceMs: number;
|
||||
private readonly pollMs: number;
|
||||
|
||||
constructor(opts: DaemonLinkOptions = {}) {
|
||||
this.fetchInfo = opts.fetchInfo ?? getDaemonInfo;
|
||||
this.scheduler = opts.scheduler ?? browserScheduler;
|
||||
this.reload = opts.reload ?? (() => window.location.reload());
|
||||
this.graceMs = opts.graceMs ?? GRACE_MS;
|
||||
this.pollMs = opts.pollMs ?? POLL_MS;
|
||||
}
|
||||
|
||||
/** Record the release we started against. Everything later is a diff on it. */
|
||||
async start(): Promise<void> {
|
||||
await this.probe();
|
||||
}
|
||||
|
||||
status(): LinkStatus {
|
||||
return {
|
||||
state: this.state,
|
||||
build: this.identity?.build,
|
||||
hostname: this.identity?.hostname,
|
||||
attempts: this.attempts,
|
||||
};
|
||||
}
|
||||
|
||||
subscribe(listener: LinkListener): () => void {
|
||||
this.listeners.add(listener);
|
||||
listener(this.status());
|
||||
return () => this.listeners.delete(listener);
|
||||
}
|
||||
|
||||
/** The events socket dropped. Starts the grace timer and the poll. */
|
||||
noteDisconnected(): void {
|
||||
if (this.state === "down" || this.state === "updating") return;
|
||||
this.attempts = 0;
|
||||
this.setState("reconnecting");
|
||||
if (this.graceTimer === null) {
|
||||
this.graceTimer = this.scheduler.setTimer(() => {
|
||||
this.graceTimer = null;
|
||||
if (this.state === "reconnecting") this.setState("down");
|
||||
void this.poll();
|
||||
}, this.graceMs);
|
||||
}
|
||||
}
|
||||
|
||||
/** The events socket came back. It carries no identity of its own, so the
|
||||
* state only clears once a probe confirms *which* daemon answered — a
|
||||
* reconnect to an upgraded daemon must reload, not resume. */
|
||||
noteConnected(): void {
|
||||
if (this.state === "online" || this.state === "updating") return;
|
||||
void this.probe();
|
||||
}
|
||||
|
||||
/**
|
||||
* One `/api/info` round-trip. Resolves `true` when the daemon answered.
|
||||
*
|
||||
* A first answer becomes the baseline. A later one that differs on commit
|
||||
* reloads the page; anything else (plain restart, or the same process) puts
|
||||
* the UI back online.
|
||||
*/
|
||||
async probe(): Promise<boolean> {
|
||||
let info: DaemonInfo;
|
||||
try {
|
||||
info = await this.fetchInfo();
|
||||
} catch {
|
||||
this.attempts += 1;
|
||||
this.emit();
|
||||
return false;
|
||||
}
|
||||
const before = this.identity;
|
||||
this.identity = info;
|
||||
if (before && compareIdentity(before, info) === "upgraded") {
|
||||
// Stay blocked through the reload: an unlocked frame here would let the
|
||||
// user drive new server code from the bundle it just replaced.
|
||||
this.setState("updating");
|
||||
this.reload();
|
||||
return true;
|
||||
}
|
||||
this.attempts = 0;
|
||||
this.clearTimers();
|
||||
this.setState("online");
|
||||
return true;
|
||||
}
|
||||
|
||||
/** Stop polling. The page's own teardown; not used in normal operation. */
|
||||
stop(): void {
|
||||
this.clearTimers();
|
||||
}
|
||||
|
||||
private async poll(): Promise<void> {
|
||||
if (this.state === "online" || this.state === "updating") return;
|
||||
const ok = await this.probe();
|
||||
if (ok || this.pollTimer !== null) return;
|
||||
this.pollTimer = this.scheduler.setTimer(() => {
|
||||
this.pollTimer = null;
|
||||
void this.poll();
|
||||
}, this.pollMs);
|
||||
}
|
||||
|
||||
private clearTimers(): void {
|
||||
if (this.graceTimer !== null) {
|
||||
this.scheduler.clearTimer(this.graceTimer);
|
||||
this.graceTimer = null;
|
||||
}
|
||||
if (this.pollTimer !== null) {
|
||||
this.scheduler.clearTimer(this.pollTimer);
|
||||
this.pollTimer = null;
|
||||
}
|
||||
}
|
||||
|
||||
private setState(state: LinkState): void {
|
||||
if (this.state === state) return;
|
||||
this.state = state;
|
||||
this.emit();
|
||||
}
|
||||
|
||||
private emit(): void {
|
||||
const s = this.status();
|
||||
for (const fn of this.listeners) fn(s);
|
||||
}
|
||||
}
|
||||
@@ -9,7 +9,7 @@
|
||||
// ↑/↓ move the highlight
|
||||
// Enter accept the highlighted entry (and suppress form submit)
|
||||
// Esc close the dropdown, refocus the input, and swallow the key so it
|
||||
// can't also discard a surrounding draft pane
|
||||
// can't also discard the surrounding spawn modal
|
||||
//
|
||||
// Once dismissed (Esc or blur) the popup stays closed until the operator types
|
||||
// again — refocusing alone doesn't reopen it.
|
||||
@@ -181,8 +181,8 @@ export function attachDirAutocomplete(input: HTMLInputElement): DirAutocompleteH
|
||||
if (e.key === "Escape") {
|
||||
if (open) {
|
||||
e.preventDefault();
|
||||
// Swallow the key: an Escape that bubbles would also discard the
|
||||
// draft pane hosting this form.
|
||||
// Swallow the key: an Escape that bubbles would also close the
|
||||
// spawn modal hosting this form.
|
||||
e.stopPropagation();
|
||||
dismiss();
|
||||
input.focus();
|
||||
|
||||
@@ -8,6 +8,14 @@
|
||||
|
||||
import { OPEN_SPAWN_EVENT, SPAWN_SIMILAR_EVENT } from "./catalog.js";
|
||||
|
||||
/** Toggling the drawer from outside the shell (the pane header's ☰ on mobile),
|
||||
* without threading the controller through every view. */
|
||||
export const TOGGLE_DRAWER_EVENT = "maestro-toggle-drawer";
|
||||
|
||||
export function requestToggleDrawer(): void {
|
||||
document.dispatchEvent(new CustomEvent(TOGGLE_DRAWER_EVENT));
|
||||
}
|
||||
|
||||
export interface Drawer {
|
||||
open(): void;
|
||||
close(): void;
|
||||
@@ -31,6 +39,7 @@ export function installDrawer(
|
||||
sidebarEl.addEventListener("click", (e) => {
|
||||
if ((e.target as HTMLElement).closest(".tree-leaf")) drawer.close();
|
||||
});
|
||||
document.addEventListener(TOGGLE_DRAWER_EVENT, () => drawer.toggle());
|
||||
document.addEventListener(OPEN_SPAWN_EVENT, () => drawer.close());
|
||||
document.addEventListener(SPAWN_SIMILAR_EVENT, () => drawer.close());
|
||||
|
||||
|
||||
@@ -160,3 +160,21 @@ describe("CatalogStore reconnect", () => {
|
||||
expect(store.backoff()).toBe(INITIAL_BACKOFF_MS);
|
||||
});
|
||||
});
|
||||
|
||||
describe("connection listeners", () => {
|
||||
it("report the socket opening and dropping", () => {
|
||||
const sock = new FakeSocket();
|
||||
const store = new CatalogStore({
|
||||
socket: () => sock as unknown as WebSocket,
|
||||
scheduler: fakeScheduler(),
|
||||
});
|
||||
const seen: boolean[] = [];
|
||||
store.subscribeConnection((up) => seen.push(up));
|
||||
store.start();
|
||||
// Nothing on subscribe — the daemon link's own probe sets the first state.
|
||||
expect(seen).toEqual([]);
|
||||
sock.open();
|
||||
sock.drop();
|
||||
expect(seen).toEqual([true, false]);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -33,9 +33,15 @@ export interface CatalogStoreOptions {
|
||||
refetch?: () => Promise<Session[]>;
|
||||
}
|
||||
|
||||
/** Called with `true` when the events socket opens, `false` when it drops.
|
||||
* Drives the daemon link (daemonLink.ts) — the socket dying is the first sign
|
||||
* the daemon went down or was upgraded under the page. */
|
||||
export type ConnectionListener = (up: boolean) => void;
|
||||
|
||||
export class CatalogStore {
|
||||
private state: CatalogState = { sessions: new Map() };
|
||||
private listeners = new Set<CatalogListener>();
|
||||
private connectionListeners = new Set<ConnectionListener>();
|
||||
private ws: WebSocket | null = null;
|
||||
private reconnectTimer: number | null = null;
|
||||
private backoffMs = INITIAL_BACKOFF_MS;
|
||||
@@ -70,6 +76,13 @@ export class CatalogStore {
|
||||
}
|
||||
}
|
||||
|
||||
/** Watch the socket's up/down transitions. Not called on subscribe: the
|
||||
* caller's own probe decides the starting state. */
|
||||
subscribeConnection(listener: ConnectionListener): () => void {
|
||||
this.connectionListeners.add(listener);
|
||||
return () => this.connectionListeners.delete(listener);
|
||||
}
|
||||
|
||||
subscribe(listener: CatalogListener): () => void {
|
||||
this.listeners.add(listener);
|
||||
listener(this.snapshot());
|
||||
@@ -99,10 +112,12 @@ export class CatalogStore {
|
||||
|
||||
ws.onopen = () => {
|
||||
this.backoffMs = INITIAL_BACKOFF_MS;
|
||||
this.emitConnection(true);
|
||||
};
|
||||
|
||||
ws.onclose = () => {
|
||||
this.ws = null;
|
||||
this.emitConnection(false);
|
||||
this.scheduleReconnect();
|
||||
};
|
||||
|
||||
@@ -161,6 +176,10 @@ export class CatalogStore {
|
||||
}
|
||||
}
|
||||
|
||||
private emitConnection(up: boolean): void {
|
||||
for (const fn of this.connectionListeners) fn(up);
|
||||
}
|
||||
|
||||
private emit(): void {
|
||||
const snap = this.snapshot();
|
||||
for (const fn of this.listeners) fn(snap);
|
||||
|
||||
@@ -47,6 +47,30 @@ describe("resolveFastForward (#67)", () => {
|
||||
});
|
||||
});
|
||||
|
||||
it("prefers the focused session's project over the freshest one", () => {
|
||||
const projects = [
|
||||
project({ path: "/repos/fresh", name: "fresh", last_command: "claude" }),
|
||||
project({
|
||||
path: "/repos/current",
|
||||
name: "current",
|
||||
last_activity: "2020-01-01T00:00:00Z",
|
||||
last_command: "zsh",
|
||||
}),
|
||||
];
|
||||
const res = resolveFastForward(projects, presets, "n", "/repos/current");
|
||||
expect(res.project?.path).toBe("/repos/current");
|
||||
expect(res.command).toBe("zsh");
|
||||
});
|
||||
|
||||
it("falls back to the freshest project when the focused cwd is unknown", () => {
|
||||
const projects = [
|
||||
project({ path: "/repos/old", name: "old", last_activity: "2020-01-01T00:00:00Z" }),
|
||||
project({ path: "/repos/fresh", name: "fresh" }),
|
||||
];
|
||||
const res = resolveFastForward(projects, presets, "n", "/repos/gone");
|
||||
expect(res.project?.path).toBe("/repos/fresh");
|
||||
});
|
||||
|
||||
it("falls back to the first non-custom preset when there is no last command", () => {
|
||||
const res = resolveFastForward([project({ last_command: undefined })], presets, "n");
|
||||
expect(res.command).toBe("claude");
|
||||
|
||||
+14
-9
@@ -1,27 +1,32 @@
|
||||
// Fast-forward spawn (#67): one keystroke, every default resolved, no form.
|
||||
// Pure resolution only — the caller (main.ts) owns the fetches and the POST,
|
||||
// and falls back to a seeded draft pane when anything is missing.
|
||||
// and falls back to a seeded spawn form when anything is missing.
|
||||
|
||||
import type { CreateSessionRequest, Project, SpawnPreset } from "./types.js";
|
||||
import { sortProjects } from "./projectList.js";
|
||||
|
||||
/** What one fast-forward keystroke resolved. Anything absent means "open a
|
||||
* draft pre-filled with the rest instead of spawning". */
|
||||
* form pre-filled with the rest instead of spawning". */
|
||||
export interface FastForwardResolution {
|
||||
project?: Project;
|
||||
command?: string;
|
||||
name?: string;
|
||||
}
|
||||
|
||||
/** The defaults: most recent project (fresh-first, same ordering the picker
|
||||
* shows), its last command falling back to the first non-custom preset, and
|
||||
* a freshly generated name when the daemon supplied one. */
|
||||
/** The defaults: the currently focused session's project when it's still a
|
||||
* known project, else the most recent one (fresh-first, same ordering the
|
||||
* picker shows) — so `N` lands where the operator currently is, matching
|
||||
* what plain `n` seeds from `spawnSimilarProjectSeed`. Its last command
|
||||
* falls back to the first non-custom preset, and the name is freshly
|
||||
* generated when the daemon supplied one. */
|
||||
export function resolveFastForward(
|
||||
projects: Project[],
|
||||
presets: SpawnPreset[],
|
||||
name?: string,
|
||||
focusedCwd?: string,
|
||||
): FastForwardResolution {
|
||||
const project = sortProjects(projects, new Date())[0];
|
||||
const project =
|
||||
projects.find((p) => p.path === focusedCwd) ?? sortProjects(projects, new Date())[0];
|
||||
const lastCommand = project?.last_command?.trim();
|
||||
const command =
|
||||
lastCommand || presets.find((p) => p.command !== "")?.command || undefined;
|
||||
@@ -47,7 +52,7 @@ export function buildFastForwardRequest(
|
||||
};
|
||||
}
|
||||
|
||||
/** Seed for the fallback draft pane: whatever did resolve goes into the
|
||||
/** Seed for the fallback spawn form: whatever did resolve goes into the
|
||||
* form; the rest stays with its own defaults. */
|
||||
export function fastForwardSeed(res: FastForwardResolution) {
|
||||
return {
|
||||
@@ -55,8 +60,8 @@ export function fastForwardSeed(res: FastForwardResolution) {
|
||||
command: res.command ?? "",
|
||||
name: res.name ?? "",
|
||||
// Left undefined rather than false when nothing resolved: the form
|
||||
// defaults the toggle on, and `false` would stick, so the fallback draft
|
||||
// would disagree with both a normally-opened draft and the TUI's fast path
|
||||
// defaults the toggle on, and `false` would stick, so the fallback form
|
||||
// would disagree with both a normally-opened form and the TUI's fast path
|
||||
// (#67 review).
|
||||
worktreeEnabled: res.project ? true : undefined,
|
||||
worktreeBranch:
|
||||
|
||||
+3
-2
@@ -17,7 +17,7 @@ export const SHORTCUTS: ShortcutGroup[] = [
|
||||
{
|
||||
title: "Sessions",
|
||||
items: [
|
||||
{ keys: ["n"], description: "Open a spawn draft pane" },
|
||||
{ keys: ["n"], description: "Open the spawn form" },
|
||||
{ keys: ["N"], description: "Spawn a session with every default resolved" },
|
||||
],
|
||||
},
|
||||
@@ -31,7 +31,8 @@ export const SHORTCUTS: ShortcutGroup[] = [
|
||||
{ keys: ["j"], description: "Highlight the next session" },
|
||||
{ keys: ["k"], description: "Highlight the previous session" },
|
||||
{ keys: ["Enter"], description: "Open the highlighted session, or expand a folder" },
|
||||
{ keys: ["Esc"], description: "Hand the keyboard back to the pane" },
|
||||
{ keys: ["Tab"], description: "Send the keyboard to the pane" },
|
||||
{ keys: ["Esc"], description: "Hand the keyboard back to the session list, from the pane" },
|
||||
],
|
||||
},
|
||||
{
|
||||
|
||||
+14
-1
@@ -1,6 +1,6 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
|
||||
import { applyModsToChar, cursorSeq, toCtrl } from "./keys.js";
|
||||
import { applyModsToChar, cursorSeq, tildeSeq, toCtrl } from "./keys.js";
|
||||
|
||||
describe("toCtrl", () => {
|
||||
it("maps letters to their control code, case-insensitively", () => {
|
||||
@@ -43,3 +43,16 @@ describe("cursorSeq", () => {
|
||||
expect(cursorSeq("A", true, true)).toBe("\x1b[1;7A");
|
||||
});
|
||||
});
|
||||
|
||||
describe("tildeSeq", () => {
|
||||
it("uses the bare CSI form when unmodified", () => {
|
||||
expect(tildeSeq(5, false, false)).toBe("\x1b[5~");
|
||||
expect(tildeSeq(6, false, false)).toBe("\x1b[6~");
|
||||
});
|
||||
|
||||
it("keeps the parameter in place when modified, unlike the cursor keys", () => {
|
||||
expect(tildeSeq(5, true, false)).toBe("\x1b[5;5~");
|
||||
expect(tildeSeq(6, false, true)).toBe("\x1b[6;3~");
|
||||
expect(tildeSeq(6, true, true)).toBe("\x1b[6;7~");
|
||||
});
|
||||
});
|
||||
|
||||
+14
-2
@@ -23,6 +23,18 @@ export function applyModsToChar(ch: string, ctrl: boolean, alt: boolean): string
|
||||
* pending — `\x1b[1;<n><final>`, n = 1 + alt(2) + ctrl(4) (xterm convention). */
|
||||
export function cursorSeq(final: string, ctrl: boolean, alt: boolean): string {
|
||||
if (!ctrl && !alt) return `\x1b[${final}`;
|
||||
const n = 1 + (alt ? 2 : 0) + (ctrl ? 4 : 0);
|
||||
return `\x1b[1;${n}${final}`;
|
||||
return `\x1b[1;${modParam(ctrl, alt)}${final}`;
|
||||
}
|
||||
|
||||
/** Modifier parameter of the xterm CSI forms: n = 1 + alt(2) + ctrl(4). */
|
||||
function modParam(ctrl: boolean, alt: boolean): number {
|
||||
return 1 + (alt ? 2 : 0) + (ctrl ? 4 : 0);
|
||||
}
|
||||
|
||||
/** Sequence for the `~`-terminated navigation keys (PgUp `5`, PgDn `6`), which
|
||||
* carry modifiers as `\x1b[<code>;<n>~` rather than the cursor keys' `1;<n>`
|
||||
* form. */
|
||||
export function tildeSeq(code: number, ctrl: boolean, alt: boolean): string {
|
||||
if (!ctrl && !alt) return `\x1b[${code}~`;
|
||||
return `\x1b[${code};${modParam(ctrl, alt)}~`;
|
||||
}
|
||||
|
||||
@@ -0,0 +1,104 @@
|
||||
/**
|
||||
* Forced-kill prompt (#81).
|
||||
*
|
||||
* The daemon refuses to kill a session whose worktree still holds uncommitted
|
||||
* or unpushed work. `confirm()` can only ask the same question twice, so the
|
||||
* refusal gets its own dialog: it names what is in the way and offers the
|
||||
* override the daemon's `force=true` already implements. A kill the daemon
|
||||
* accepts never reaches here — there is nothing to warn about.
|
||||
*/
|
||||
import { formatInTheWay, type InTheWay } from "./types.js";
|
||||
|
||||
export interface ForceKillPrompt {
|
||||
/** Session name, as the sidebar shows it. */
|
||||
name: string;
|
||||
/** What the daemon reported in the way, when it reported anything. */
|
||||
blockers: InTheWay | null;
|
||||
/** Message from the daemon's refusal, shown when there is no breakdown. */
|
||||
reason: string;
|
||||
/** Run the forced kill. A rejection is rendered in the dialog, which stays
|
||||
* open so the override can be retried. */
|
||||
onForce: () => Promise<void>;
|
||||
}
|
||||
|
||||
let open: { el: HTMLElement; onKeydown: (ev: KeyboardEvent) => void } | null = null;
|
||||
|
||||
export function closeForceKillDialog(): void {
|
||||
if (!open) return;
|
||||
window.removeEventListener("keydown", open.onKeydown, true);
|
||||
open.el.remove();
|
||||
open = null;
|
||||
}
|
||||
|
||||
/** Mount the prompt. Opening while one is up replaces it, so a second refusal
|
||||
* can never stack two dialogs. */
|
||||
export function openForceKillDialog(p: ForceKillPrompt): HTMLElement {
|
||||
closeForceKillDialog();
|
||||
|
||||
const el = document.createElement("div");
|
||||
el.className = "kill-dialog";
|
||||
el.setAttribute("role", "dialog");
|
||||
el.setAttribute("aria-modal", "true");
|
||||
el.setAttribute("aria-label", `Kill ${p.name}`);
|
||||
|
||||
const panel = document.createElement("div");
|
||||
panel.className = "kill-dialog-panel";
|
||||
|
||||
const title = document.createElement("h2");
|
||||
title.className = "kill-dialog-title";
|
||||
title.textContent = `Kill "${p.name}"?`;
|
||||
|
||||
const body = document.createElement("p");
|
||||
body.className = "kill-dialog-body";
|
||||
body.textContent = p.blockers
|
||||
? `Its worktree still has ${formatInTheWay(p.blockers)}. Forcing the kill removes the session and leaves the worktree on disk.`
|
||||
: `${p.reason} Forcing the kill removes the session and leaves the worktree on disk.`;
|
||||
|
||||
const error = document.createElement("p");
|
||||
error.className = "kill-dialog-error";
|
||||
error.hidden = true;
|
||||
|
||||
const actions = document.createElement("div");
|
||||
actions.className = "kill-dialog-actions";
|
||||
const cancel = document.createElement("button");
|
||||
cancel.type = "button";
|
||||
cancel.className = "btn btn-ghost kill-dialog-cancel";
|
||||
cancel.textContent = "Cancel";
|
||||
cancel.addEventListener("click", closeForceKillDialog);
|
||||
const force = document.createElement("button");
|
||||
force.type = "button";
|
||||
force.className = "btn btn-danger kill-dialog-force";
|
||||
force.textContent = "Force kill";
|
||||
force.addEventListener("click", () => {
|
||||
force.disabled = true;
|
||||
void p
|
||||
.onForce()
|
||||
.then(closeForceKillDialog)
|
||||
.catch((e: unknown) => {
|
||||
force.disabled = false;
|
||||
error.hidden = false;
|
||||
error.textContent = `Failed to kill: ${(e as Error).message}`;
|
||||
});
|
||||
});
|
||||
actions.append(cancel, force);
|
||||
|
||||
panel.append(title, body, error, actions);
|
||||
|
||||
// A press on the scrim cancels; one inside the panel is left alone.
|
||||
el.addEventListener("click", (ev) => {
|
||||
if (!panel.contains(ev.target as Node)) closeForceKillDialog();
|
||||
});
|
||||
el.appendChild(panel);
|
||||
document.body.appendChild(el);
|
||||
|
||||
const onKeydown = (ev: KeyboardEvent): void => {
|
||||
if (ev.key !== "Escape") return;
|
||||
ev.preventDefault();
|
||||
ev.stopPropagation();
|
||||
closeForceKillDialog();
|
||||
};
|
||||
window.addEventListener("keydown", onKeydown, true);
|
||||
open = { el, onKeydown };
|
||||
cancel.focus();
|
||||
return el;
|
||||
}
|
||||
+14
-8
@@ -4,7 +4,7 @@
|
||||
// critiqued as a whole — buttons (including terminal-native variants for
|
||||
// review), inputs, chips, badges, session rows, and empty states.
|
||||
import "./kit.css";
|
||||
import { createThemeToggle } from "./theme.js";
|
||||
import { createPaletteSelect, createThemeToggle } from "./theme.js";
|
||||
|
||||
function h(tag: string, className?: string, html?: string): HTMLElement {
|
||||
const el = document.createElement(tag);
|
||||
@@ -66,12 +66,15 @@ function leafRow(opts: {
|
||||
(row as HTMLAnchorElement).href = "#/kit";
|
||||
row.dataset.status = opts.status;
|
||||
if (opts.active) row.classList.add("is-active");
|
||||
row.style.paddingLeft = `${(opts.indent ?? 0) * 16 + 8}px`;
|
||||
const depth = opts.indent ?? 0;
|
||||
row.style.paddingLeft = `${depth * 16 + 8}px`;
|
||||
const flags = [
|
||||
opts.status === "dead" ? `<span class="card-flag">exited</span>` : "",
|
||||
opts.cmd !== opts.name ? `<span class="card-flag leaf-cmd">${opts.cmd}</span>` : "",
|
||||
].join("");
|
||||
const activity = opts.activity ?? "idle";
|
||||
row.innerHTML = `
|
||||
<span class="activity-rail" data-activity="${activity}" style="left:${depth * 16 + 2}px" title="${activity}"></span>
|
||||
<span class="card-line1">
|
||||
<span class="leaf-name">${opts.name}</span>
|
||||
<span class="leaf-actions">
|
||||
@@ -79,7 +82,7 @@ function leafRow(opts: {
|
||||
<button class="leaf-act leaf-kill" type="button" title="Kill session">✕</button>
|
||||
</span>
|
||||
</span>
|
||||
${opts.activity ? `<span class="card-line2" data-activity="${opts.activity}"><span class="activity-dot" title="${opts.activity}"></span><span class="activity-duration">${opts.duration ?? ""}</span>${flags}</span>` : ""}
|
||||
${opts.activity ? `<span class="card-line2" data-activity="${opts.activity}"><span class="activity-duration">${opts.duration ?? ""}</span>${flags}</span>` : ""}
|
||||
`;
|
||||
return row;
|
||||
}
|
||||
@@ -102,7 +105,7 @@ export function renderKit(): HTMLElement {
|
||||
back.className = "btn btn-ghost";
|
||||
back.href = "?mock";
|
||||
back.textContent = "← back to app";
|
||||
headerActions.append(back, createThemeToggle());
|
||||
headerActions.append(back, createThemeToggle(), createPaletteSelect());
|
||||
header.appendChild(headerActions);
|
||||
page.appendChild(header);
|
||||
|
||||
@@ -113,7 +116,7 @@ export function renderKit(): HTMLElement {
|
||||
{
|
||||
const { el, body } = section(
|
||||
"Color tokens",
|
||||
"Slate neutrals (hue ~256) + signal-green = alive. Swap by theme toggle.",
|
||||
"Graphite neutrals; activity colours are the only hue. Swap by theme toggle + palette picker.",
|
||||
);
|
||||
body.classList.add("kit-swatches");
|
||||
const tokens = [
|
||||
@@ -201,12 +204,15 @@ export function renderKit(): HTMLElement {
|
||||
const activeLine = h(
|
||||
"span",
|
||||
"card-line2",
|
||||
`<span class="activity-dot"></span><span class="activity-duration">4m</span>`,
|
||||
`<span class="activity-duration">4m</span>`,
|
||||
);
|
||||
activeLine.setAttribute("data-activity", "active");
|
||||
const rail = h("span", "activity-rail");
|
||||
rail.dataset.activity = "active";
|
||||
rail.style.cssText = "position:static;display:inline-block;height:14px;";
|
||||
body.append(
|
||||
specimen("session-tally", h("span", "session-tally", "6 sessions · 5 live")),
|
||||
specimen("folder-count", h("span", "folder-count", "4")),
|
||||
specimen("activity-rail · active", rail),
|
||||
specimen("card-line2 · active", activeLine),
|
||||
specimen("attach-state · open", h("span", "attach-state", "live")),
|
||||
);
|
||||
@@ -226,7 +232,7 @@ export function renderKit(): HTMLElement {
|
||||
{
|
||||
const { el, body } = section(
|
||||
"Session rows — nested by host, then directory",
|
||||
"docs/SIDEBAR.md cards: line 1 is name + top-right actions (the name truncates before it can reach them); line 2 only when there's something to say — dot + duration in the state's colour, then blocked-work / exited fragments.",
|
||||
"docs/SIDEBAR.md cards: line 1 is name + top-right actions (the name truncates before it can reach them); the activity rail sits in the indent gutter to the left; line 2 carries duration in the state's colour, then blocked-work / exited fragments, whenever there's something to say.",
|
||||
);
|
||||
const list = h("div", "kit-tree");
|
||||
list.append(
|
||||
|
||||
+2
-17
@@ -11,23 +11,8 @@ import type { Uuid } from "./types.js";
|
||||
|
||||
export type Dir = "row" | "col";
|
||||
|
||||
/** Half-filled spawn-form state for a draft pane (issue #57): an empty leaf
|
||||
* renders the spawn form instead of a placeholder, and each pane's values
|
||||
* hang off its own leaf so two drafts stay independent. Never persisted —
|
||||
* a reload gives back an empty form (persistence strips it). */
|
||||
export interface Draft {
|
||||
command: string;
|
||||
cwd: string;
|
||||
name: string;
|
||||
worktreeEnabled?: boolean;
|
||||
worktreeBranch?: string;
|
||||
worktreeCleanup?: boolean;
|
||||
/** Whether the cwd lives in the raw text input (vs a picked recent row). */
|
||||
cwdRawVisible?: boolean;
|
||||
}
|
||||
|
||||
export type Node =
|
||||
| { kind: "leaf"; id: string; sessionId: Uuid | null; draft?: Draft | null }
|
||||
| { kind: "leaf"; id: string; sessionId: Uuid | null }
|
||||
| { kind: "split"; dir: Dir; a: Node; b: Node; ratio: number };
|
||||
|
||||
export type Leaf = Extract<Node, { kind: "leaf" }>;
|
||||
@@ -104,7 +89,7 @@ export function splitLeaf(
|
||||
dir: Dir,
|
||||
after: boolean,
|
||||
): string {
|
||||
const fresh: Leaf = { kind: "leaf", id: freshId("l"), sessionId, draft: null };
|
||||
const fresh: Leaf = { kind: "leaf", id: freshId("l"), sessionId };
|
||||
const rec = (n: Node): Node => {
|
||||
if (n.kind === "leaf") {
|
||||
if (n.id !== targetId) return n;
|
||||
|
||||
+106
-33
@@ -2,12 +2,14 @@ import "@fontsource/jetbrains-mono/400.css";
|
||||
import "@fontsource/jetbrains-mono/500.css";
|
||||
import "@fontsource/jetbrains-mono/600.css";
|
||||
import "@fontsource/jetbrains-mono/700.css";
|
||||
import { renderSidebar, renderTopbar } from "./catalog.js";
|
||||
import { renderSidebar } from "./catalog.js";
|
||||
import { ConnectionPool } from "./connections.js";
|
||||
import { installDrawer, installDrawerSwipe } from "./drawer.js";
|
||||
import { installDrawer, installDrawerSwipe, requestToggleDrawer } from "./drawer.js";
|
||||
import { installHudKeybind } from "./debug.js";
|
||||
import { installHelpKeybind, isHelpOpen, isTypingTarget } from "./help.js";
|
||||
import { DaemonLink } from "./daemonLink.js";
|
||||
import { CatalogStore } from "./events.js";
|
||||
import { installRestartOverlay } from "./restartOverlay.js";
|
||||
import { shouldRetryClose } from "./reconnect.js";
|
||||
import {
|
||||
createSession,
|
||||
@@ -21,12 +23,19 @@ import {
|
||||
resolveFastForward,
|
||||
} from "./fastForward.js";
|
||||
import { FALLBACK_PRESETS } from "./spawnForm.js";
|
||||
import { spawnSimilarSeed } from "./spawnSimilar.js";
|
||||
import { openSpawnModal } from "./spawnModal.js";
|
||||
import { spawnSimilarProjectSeed, spawnSimilarSeed } from "./spawnSimilar.js";
|
||||
import { mountHud, type Hud } from "./hud.js";
|
||||
import { emptyLayout, type Layout, openSessions } from "./layout.js";
|
||||
import { createMultiView, type MultiView } from "./multiview.js";
|
||||
import { loadLayout, saveLayout } from "./persistence.js";
|
||||
import { FOCUS_PANE_EVENT, OPEN_SPAWN_EVENT, SPAWN_SIMILAR_EVENT } from "./catalog.js";
|
||||
import {
|
||||
FOCUS_PANE_EVENT,
|
||||
FOCUS_SIDEBAR_EVENT,
|
||||
OPEN_SPAWN_EVENT,
|
||||
SESSION_SELECT_EVENT,
|
||||
SPAWN_SIMILAR_EVENT,
|
||||
} from "./catalog.js";
|
||||
import { initTheme } from "./theme.js";
|
||||
import { sessionName, type Project, type Session, type SpawnPreset } from "./types.js";
|
||||
import { installViewportSizing } from "./viewport.js";
|
||||
@@ -68,6 +77,15 @@ if (import.meta.env.DEV && location.search.includes("kit")) {
|
||||
async function bootApp(): Promise<void> {
|
||||
|
||||
const store = new CatalogStore();
|
||||
|
||||
// The daemon's identity and liveness: names the release in the sidebar's status
|
||||
// dot, and blocks the UI behind the restart overlay while the daemon is away
|
||||
// (docs/RESTART.md). The events socket is the trigger — it dies first.
|
||||
const link = new DaemonLink();
|
||||
installRestartOverlay(link);
|
||||
store.subscribeConnection((up) => (up ? link.noteConnected() : link.noteDisconnected()));
|
||||
void link.start();
|
||||
|
||||
store.start();
|
||||
|
||||
// Dev-only: `?mock` seeds a representative catalog so the UI can be reviewed
|
||||
@@ -88,21 +106,21 @@ shellEl.dataset.route = "catalog";
|
||||
let mv: MultiView;
|
||||
const sidebar = renderSidebar(store, {
|
||||
onLeafDrag: (id, e) => mv?.beginSessionDrag(id, e),
|
||||
link,
|
||||
});
|
||||
const content = document.createElement("section");
|
||||
content.className = "content";
|
||||
|
||||
// Mobile (issue #35): the sidebar is an off-canvas drawer toggled by the ☰ in
|
||||
// the header. `installDrawer` owns the close rules (session tap, Spawn, Spawn
|
||||
// the pane header (and the welcome state). `installDrawer` owns the close rules (session tap, Spawn, Spawn
|
||||
// similar, backdrop); on desktop the class it toggles is inert.
|
||||
const backdrop = document.createElement("div");
|
||||
backdrop.className = "mv-backdrop";
|
||||
const drawer = installDrawer(shellEl, sidebar.el, backdrop);
|
||||
installDrawerSwipe(drawer);
|
||||
const toggleDrawer = () => drawer.toggle();
|
||||
|
||||
shellEl.append(sidebar.el, content, backdrop);
|
||||
root.replaceChildren(renderTopbar(store, toggleDrawer), shellEl);
|
||||
root.replaceChildren(shellEl);
|
||||
|
||||
// The pool owns attach connections independently of the route: navigating away
|
||||
// parks a session (keeps it streaming); navigating back re-mounts it instantly.
|
||||
@@ -182,13 +200,22 @@ function renderWelcome(): HTMLElement {
|
||||
</p>
|
||||
<p class="empty-hint">Press <kbd>?</kbd> for keyboard shortcuts.</p>
|
||||
<div class="empty-actions"></div>`;
|
||||
const actions = el.querySelector(".empty-actions") as HTMLElement;
|
||||
// Mobile-only: with no pane open there is no pane header to carry the ☰, so
|
||||
// the drawer would be swipe-only. CSS hides this on desktop.
|
||||
const sessions = document.createElement("button");
|
||||
sessions.type = "button";
|
||||
sessions.className = "btn btn-ghost welcome-sessions";
|
||||
sessions.textContent = "☰ Sessions";
|
||||
sessions.addEventListener("click", () => requestToggleDrawer());
|
||||
actions.appendChild(sessions);
|
||||
const spawn = document.createElement("button");
|
||||
spawn.type = "button";
|
||||
spawn.className = "btn btn-primary";
|
||||
spawn.textContent = "+ Spawn session";
|
||||
spawn.title = "Draft pane: n — fast-forward spawn: N";
|
||||
spawn.addEventListener("click", () => requestOpenSpawn());
|
||||
(el.querySelector(".empty-actions") as HTMLElement).appendChild(spawn);
|
||||
actions.appendChild(spawn);
|
||||
return el;
|
||||
}
|
||||
|
||||
@@ -211,8 +238,8 @@ mv = createMultiView({
|
||||
infoFor,
|
||||
onDisconnect: closePane,
|
||||
renderWelcome,
|
||||
// A draft-pane submit (#57) fills its leaf in place; the shell route may flip
|
||||
// from catalog (no sessions) to attach.
|
||||
// A spawn fills a pane with its new session; the shell route may flip from
|
||||
// catalog (no sessions) to attach.
|
||||
onOpenSessionsChange: updateShellRoute,
|
||||
onLayoutChange: scheduleSave,
|
||||
});
|
||||
@@ -226,32 +253,59 @@ function showMultiView(): void {
|
||||
updateShellRoute();
|
||||
}
|
||||
|
||||
// Spawn affordances (#62): the header button, the sidebar's empty state, and
|
||||
// `?mock&spawn` all open a draft pane; "Spawn similar" seeds one from the
|
||||
// Spawn affordances: the sidebar's footer button, its empty state, and
|
||||
// `?mock&spawn` all open the spawn modal; "Spawn similar" seeds one from the
|
||||
// cloned session (see spawnSimilar.ts).
|
||||
function requestOpenSpawn(): void {
|
||||
showMultiView();
|
||||
// A new tab, not a split of the pane you were reading (#100). "Spawn
|
||||
// similar" and the fast-forward key below deliberately keep the old
|
||||
// behaviour: both act on the session in front of you, so a split beside it
|
||||
// is the point.
|
||||
mv.openDraft(undefined, { newTab: true });
|
||||
// The session lands in a new tab, not a split of the pane you were reading
|
||||
// (#100). "Spawn similar" and the fast-forward key below deliberately keep
|
||||
// the old behaviour: both act on the session in front of you, so a split
|
||||
// beside it is the point.
|
||||
// The session you were last on preselects its project: `n` then Enter spawns
|
||||
// another session there without touching the picker.
|
||||
const current = focusedSession();
|
||||
openSpawnModal({
|
||||
seed: current ? spawnSimilarProjectSeed(current) : undefined,
|
||||
onSuccess: (session) => mountSpawned(session, { newTab: true }),
|
||||
});
|
||||
}
|
||||
|
||||
/** The session the operator was last on, if any. Shared by the plain spawn
|
||||
* modal seed and fast-forward's project pick: both should land on "where I
|
||||
* currently am". */
|
||||
function focusedSession(): Session | undefined {
|
||||
const focused = mv?.focusedSessionId() ?? null;
|
||||
return focused ? store.snapshot().sessions.get(focused) : undefined;
|
||||
}
|
||||
|
||||
/** The focused session's project — its base repo for a worktree session, its
|
||||
* cwd otherwise (same rule as spawnSimilarProjectSeed). */
|
||||
function focusedProjectCwd(): string | undefined {
|
||||
const s = focusedSession();
|
||||
if (!s) return undefined;
|
||||
return s.worktree ? s.worktree.base_repo : s.cwd;
|
||||
}
|
||||
document.addEventListener(OPEN_SPAWN_EVENT, () => requestOpenSpawn());
|
||||
document.addEventListener(SPAWN_SIMILAR_EVENT, (ev) => {
|
||||
const s = (ev as CustomEvent<Session>).detail;
|
||||
showMultiView();
|
||||
mv.openDraft(spawnSimilarSeed(s));
|
||||
openSpawnModal({ seed: spawnSimilarSeed(s), onSuccess: (session) => mountSpawned(session) });
|
||||
});
|
||||
|
||||
// Fast-forward spawn (#67): the draft pane's keystroke neighbour spawns
|
||||
/** Show a freshly spawned session: bring the multi-view up (the shell may still
|
||||
* be on the catalog route) and give the session a pane. */
|
||||
function mountSpawned(session: Session, placement?: { newTab?: boolean }): void {
|
||||
showMultiView();
|
||||
mv.openSessionBeside(session.id, placement);
|
||||
updateShellRoute();
|
||||
}
|
||||
|
||||
// Fast-forward spawn (#67): the spawn modal's keystroke neighbour spawns
|
||||
// immediately with every default resolved — most recent project, its last
|
||||
// command (or the first non-custom preset), a fresh name, worktree on with
|
||||
// a new branch named after that name. Anything unresolvable (no projects
|
||||
// known yet, no command, no generated name) opens a draft pre-filled with
|
||||
// known yet, no command, no generated name) opens the form pre-filled with
|
||||
// what did resolve instead.
|
||||
async function requestFastForward(): Promise<void> {
|
||||
showMultiView();
|
||||
const [discovered, name] = await Promise.all([
|
||||
fetchProjects().catch(() => [] as Project[]),
|
||||
fetchNames(1)
|
||||
@@ -265,7 +319,7 @@ async function requestFastForward(): Promise<void> {
|
||||
} catch {
|
||||
/* keep fallbacks */
|
||||
}
|
||||
const resolved = resolveFastForward(discovered, presets, name);
|
||||
const resolved = resolveFastForward(discovered, presets, name, focusedProjectCwd());
|
||||
const req = buildFastForwardRequest(resolved);
|
||||
if (req) {
|
||||
try {
|
||||
@@ -273,18 +327,20 @@ async function requestFastForward(): Promise<void> {
|
||||
// Mount it, the way the TUI's fast path attaches. Without this the
|
||||
// keystroke creates a session and leaves the UI untouched, so it reads
|
||||
// as a dead key (#67 review).
|
||||
mv.openSessionBeside(session.id);
|
||||
updateShellRoute();
|
||||
mountSpawned(session);
|
||||
return;
|
||||
} catch {
|
||||
// A failed POST degrades to the same pre-filled draft as an
|
||||
// A failed POST degrades to the same pre-filled form as an
|
||||
// unresolvable default — never a silent dead keystroke.
|
||||
}
|
||||
}
|
||||
mv.openDraft(fastForwardSeed(resolved));
|
||||
openSpawnModal({
|
||||
seed: fastForwardSeed(resolved),
|
||||
onSuccess: (session) => mountSpawned(session),
|
||||
});
|
||||
}
|
||||
|
||||
// Keyboard pair (#67): `n` opens a draft pane, `N` fast-forwards a spawn.
|
||||
// Keyboard pair (#67): `n` opens the spawn modal, `N` fast-forwards a spawn.
|
||||
// Ignored while typing anywhere (form fields, the terminal's hidden
|
||||
// textarea, search) so an attached session's keys are never hijacked.
|
||||
document.addEventListener("keydown", (e) => {
|
||||
@@ -317,8 +373,27 @@ window.addEventListener("keydown", (e) => {
|
||||
}
|
||||
});
|
||||
|
||||
// Escape in the session list hands the keyboard back to the pane.
|
||||
// Tab in the session list hands the keyboard to the pane; Escape in the pane
|
||||
// hands it back — the pair the TUI gets from `tab` and `esc`.
|
||||
document.addEventListener(FOCUS_PANE_EVENT, () => pool.focusTerminal());
|
||||
document.addEventListener(FOCUS_SIDEBAR_EVENT, () => {
|
||||
drawer.open(); // no-op on desktop; on mobile the list is off-canvas
|
||||
sidebar.focusList();
|
||||
});
|
||||
|
||||
/** Open/focus a session and reflect it in the shell chrome. Shared by the
|
||||
* hash router and the sidebar's click-driven path (#133), which can't rely
|
||||
* on `hashchange` alone — a split or drag can move focus without the hash
|
||||
* changing, leaving a click back onto that session's row silently ignored. */
|
||||
function focusSession(sessionId: string): void {
|
||||
showMultiView();
|
||||
mv.openSession(sessionId);
|
||||
updateShellRoute();
|
||||
}
|
||||
|
||||
document.addEventListener(SESSION_SELECT_EVENT, (e) => {
|
||||
focusSession((e as CustomEvent<string>).detail);
|
||||
});
|
||||
|
||||
type Route =
|
||||
| { kind: "catalog" }
|
||||
@@ -338,9 +413,7 @@ function dispatch(): void {
|
||||
switch (route.kind) {
|
||||
case "attach":
|
||||
// Deep-link: open/focus the session, then show the layout.
|
||||
showMultiView();
|
||||
mv.openSession(route.sessionId);
|
||||
updateShellRoute();
|
||||
focusSession(route.sessionId);
|
||||
return;
|
||||
case "not-found":
|
||||
shellEl.dataset.route = "notfound";
|
||||
|
||||
+1
-1
@@ -147,7 +147,7 @@ export function seedMock(store: CatalogStore): void {
|
||||
sessions,
|
||||
});
|
||||
|
||||
// `?mock&spawn` auto-opens a draft pane for visual review, with the spawn
|
||||
// `?mock&spawn` auto-opens the spawn modal for visual review, with the spawn
|
||||
// backend endpoints stubbed so presets/projects/gitroot all render.
|
||||
if (location.search.includes("spawn")) {
|
||||
stubSpawnApi();
|
||||
|
||||
+59
-161
@@ -55,12 +55,12 @@ function makeMv(layout: Layout): MultiView {
|
||||
});
|
||||
}
|
||||
|
||||
/** Drain the microtask queue so the draft form's async seed application lands. */
|
||||
/** Drain the microtask queue so any pending async work lands. */
|
||||
async function flush(): Promise<void> {
|
||||
for (let i = 0; i < 20; i++) await Promise.resolve();
|
||||
}
|
||||
|
||||
describe("multiview openDraft (#62)", () => {
|
||||
describe("multiview empty panes", () => {
|
||||
beforeEach(() => {
|
||||
stubFetch();
|
||||
document.body.replaceChildren();
|
||||
@@ -70,144 +70,23 @@ describe("multiview openDraft (#62)", () => {
|
||||
vi.unstubAllGlobals();
|
||||
});
|
||||
|
||||
it("turns an empty tab into a draft pane", async () => {
|
||||
const layout = emptyLayout();
|
||||
const mv = makeMv(layout);
|
||||
document.body.appendChild(mv.el);
|
||||
|
||||
mv.openDraft();
|
||||
await flush();
|
||||
|
||||
const ls = leaves(layout.tabs[0].root);
|
||||
expect(ls).toHaveLength(1);
|
||||
expect(ls[0].sessionId).toBeNull();
|
||||
expect(ls[0].draft).not.toBeNull();
|
||||
expect(mv.el.querySelector(".mv-draft")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("splits the focused session pane into a fresh draft", async () => {
|
||||
it("renders a placeholder, not a spawn form", async () => {
|
||||
const layout = emptyLayout();
|
||||
const tab = layout.tabs[0];
|
||||
const first = splitLeaf(tab, "", "s1", "row", true);
|
||||
tab.focusedLeafId = first;
|
||||
tab.focusedLeafId = splitLeaf(tab, first, null, "row", true);
|
||||
const mv = makeMv(layout);
|
||||
document.body.appendChild(mv.el);
|
||||
mv.render();
|
||||
|
||||
mv.openDraft();
|
||||
await flush();
|
||||
|
||||
const ls = leaves(tab.root);
|
||||
expect(ls).toHaveLength(2);
|
||||
expect(ls[0].sessionId).toBe("s1");
|
||||
const draftLeaf = ls.find((l) => l.sessionId === null)!;
|
||||
expect(draftLeaf.draft).not.toBeNull();
|
||||
expect(tab.focusedLeafId).toBe(draftLeaf.id);
|
||||
expect(mv.el.querySelectorAll(".mv-pane")).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("reuses the focused pane when it is already empty", async () => {
|
||||
const layout = emptyLayout();
|
||||
const tab = layout.tabs[0];
|
||||
const first = splitLeaf(tab, "", "s1", "row", true);
|
||||
const empty = splitLeaf(tab, first, null, "row", true);
|
||||
tab.focusedLeafId = empty;
|
||||
const mv = makeMv(layout);
|
||||
document.body.appendChild(mv.el);
|
||||
mv.render();
|
||||
|
||||
mv.openDraft();
|
||||
await flush();
|
||||
|
||||
const ls = leaves(tab.root);
|
||||
expect(ls).toHaveLength(2);
|
||||
const target = ls.find((l) => l.id === empty)!;
|
||||
expect(target.draft).not.toBeNull();
|
||||
expect(tab.focusedLeafId).toBe(empty);
|
||||
});
|
||||
|
||||
it("keeps the draft form instance when an unrelated session closes (#68)", async () => {
|
||||
const layout = emptyLayout();
|
||||
const tab = layout.tabs[0];
|
||||
const s1 = splitLeaf(tab, "", "s1", "row", true);
|
||||
const draftLeaf = splitLeaf(tab, s1, null, "row", true);
|
||||
tab.focusedLeafId = draftLeaf;
|
||||
const mv = makeMv(layout);
|
||||
document.body.appendChild(mv.el);
|
||||
mv.render();
|
||||
await flush();
|
||||
|
||||
const nameInput = mv.el.querySelector(".mv-draft input[name=name]") as HTMLInputElement;
|
||||
nameInput.value = "wip";
|
||||
nameInput.dispatchEvent(new Event("input"));
|
||||
await flush();
|
||||
expect(leaves(tab.root).find((l) => l.id === draftLeaf)?.draft?.name).toBe("wip");
|
||||
|
||||
const formBefore = mv.el.querySelector(".mv-draft");
|
||||
mv.closeSession("s1");
|
||||
await flush();
|
||||
|
||||
expect(mv.el.querySelector(".mv-draft")).toBe(formBefore);
|
||||
expect((mv.el.querySelector(".mv-draft input[name=name]") as HTMLInputElement).value).toBe("wip");
|
||||
});
|
||||
|
||||
it("reuses an already-synced empty pane instead of splitting (#72)", async () => {
|
||||
const layout = emptyLayout();
|
||||
const tab = layout.tabs[0];
|
||||
const first = splitLeaf(tab, "", "s1", "row", true);
|
||||
const empty = splitLeaf(tab, first, null, "row", true);
|
||||
tab.focusedLeafId = empty;
|
||||
const mv = makeMv(layout);
|
||||
document.body.appendChild(mv.el);
|
||||
mv.render();
|
||||
// Let the mounted form's loadProjects() settle and auto-sync its picked
|
||||
// defaults into leaf.draft before openDraft runs (#72's dead-branch window).
|
||||
await flush();
|
||||
expect(leaves(tab.root).find((l) => l.id === empty)?.draft).not.toBeNull();
|
||||
|
||||
mv.openDraft();
|
||||
await flush();
|
||||
|
||||
expect(leaves(tab.root)).toHaveLength(2);
|
||||
expect(tab.focusedLeafId).toBe(empty);
|
||||
});
|
||||
|
||||
it("keeps a seed after reusing an already-synced empty pane (#72)", async () => {
|
||||
const layout = emptyLayout();
|
||||
const tab = layout.tabs[0];
|
||||
const first = splitLeaf(tab, "", "s1", "row", true);
|
||||
const empty = splitLeaf(tab, first, null, "row", true);
|
||||
tab.focusedLeafId = empty;
|
||||
const mv = makeMv(layout);
|
||||
document.body.appendChild(mv.el);
|
||||
mv.render();
|
||||
await flush();
|
||||
|
||||
mv.openDraft({ cwd: "/home/user/proj", command: "claude" });
|
||||
await flush();
|
||||
|
||||
const leaf = leaves(tab.root).find((l) => l.id === empty)!;
|
||||
expect(leaf.draft?.cwd).toBe("/home/user/proj");
|
||||
expect(leaf.draft?.command).toBe("claude");
|
||||
const cwdRaw = mv.el.querySelector(".mv-draft .cwd-raw") as HTMLInputElement;
|
||||
expect(cwdRaw.value).toBe("/home/user/proj");
|
||||
});
|
||||
|
||||
it("seeds a clone's cwd and command into the draft", async () => {
|
||||
const layout = emptyLayout();
|
||||
const mv = makeMv(layout);
|
||||
document.body.appendChild(mv.el);
|
||||
|
||||
mv.openDraft({ cwd: "/home/user/proj", command: "claude" });
|
||||
await flush();
|
||||
|
||||
const leaf = leaves(layout.tabs[0].root)[0];
|
||||
expect(leaf.draft?.cwd).toBe("/home/user/proj");
|
||||
expect(leaf.draft?.command).toBe("claude");
|
||||
expect(mv.el.querySelector(".mv-pane-empty")).toBeTruthy();
|
||||
expect(mv.el.querySelector(".spawn-form")).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
describe("multiview pane-drag swap (#73)", () => {
|
||||
describe("multiview pane-drag swap", () => {
|
||||
beforeEach(() => {
|
||||
stubFetch();
|
||||
document.body.replaceChildren();
|
||||
@@ -223,8 +102,8 @@ describe("multiview pane-drag swap (#73)", () => {
|
||||
* updateDock() in multiview.ts, since neither is exposed on MultiView. */
|
||||
async function dragPaneOntoCenter(sourcePane: HTMLElement, targetPane: HTMLElement): Promise<void> {
|
||||
// The real drag-start gate requires the pointerdown target to sit inside
|
||||
// an `.attach-header` (attach.ts's session title bar). Draft panes mount
|
||||
// no such element, so stand one in for the gate check itself.
|
||||
// an `.attach-header` (attach.ts's session title bar), which the fake pool
|
||||
// never mounts; stand one in for the gate check itself.
|
||||
const marker = document.createElement("div");
|
||||
marker.className = "attach-header";
|
||||
sourcePane.appendChild(marker);
|
||||
@@ -254,40 +133,26 @@ describe("multiview pane-drag swap (#73)", () => {
|
||||
await flush();
|
||||
}
|
||||
|
||||
it("moves each draft's form along with its data when two draft panes are swapped", async () => {
|
||||
it("swaps the two panes' sessions when one is dropped on the other's centre", async () => {
|
||||
const layout = emptyLayout();
|
||||
const tab = layout.tabs[0];
|
||||
const leaf1 = splitLeaf(tab, "", null, "row", true);
|
||||
const leaf2 = splitLeaf(tab, leaf1, null, "row", true);
|
||||
const leaf1 = splitLeaf(tab, "", "s1", "row", true);
|
||||
const leaf2 = splitLeaf(tab, leaf1, "s2", "row", true);
|
||||
const mv = makeMv(layout);
|
||||
document.body.appendChild(mv.el);
|
||||
mv.render();
|
||||
await flush();
|
||||
|
||||
const paneOf = (leafId: string) => mv.el.querySelector(`[data-leaf-id="${leafId}"]`) as HTMLElement;
|
||||
const nameInputOf = (leafId: string) => paneOf(leafId).querySelector("input[name=name]") as HTMLInputElement;
|
||||
|
||||
nameInputOf(leaf1).value = "west";
|
||||
nameInputOf(leaf1).dispatchEvent(new Event("input"));
|
||||
nameInputOf(leaf2).value = "east";
|
||||
nameInputOf(leaf2).dispatchEvent(new Event("input"));
|
||||
await flush();
|
||||
expect(leaves(tab.root).find((l) => l.id === leaf1)?.draft?.name).toBe("west");
|
||||
expect(leaves(tab.root).find((l) => l.id === leaf2)?.draft?.name).toBe("east");
|
||||
|
||||
await dragPaneOntoCenter(paneOf(leaf1), paneOf(leaf2));
|
||||
|
||||
// The leaf data swaps (already correct pre-fix)...
|
||||
expect(leaves(tab.root).find((l) => l.id === leaf1)?.draft?.name).toBe("east");
|
||||
expect(leaves(tab.root).find((l) => l.id === leaf2)?.draft?.name).toBe("west");
|
||||
// ...and the mounted forms must follow, not stay behind showing the old
|
||||
// pane's values (#73).
|
||||
expect(nameInputOf(leaf1).value).toBe("east");
|
||||
expect(nameInputOf(leaf2).value).toBe("west");
|
||||
expect(leaves(tab.root).find((l) => l.id === leaf1)?.sessionId).toBe("s2");
|
||||
expect(leaves(tab.root).find((l) => l.id === leaf2)?.sessionId).toBe("s1");
|
||||
expect(tab.focusedLeafId).toBe(leaf2);
|
||||
});
|
||||
});
|
||||
|
||||
describe("openDraft newTab (#100)", () => {
|
||||
describe("openSessionBeside newTab (#100)", () => {
|
||||
beforeEach(() => {
|
||||
stubFetch();
|
||||
document.body.replaceChildren();
|
||||
@@ -306,7 +171,7 @@ describe("openDraft newTab (#100)", () => {
|
||||
document.body.appendChild(mv.el);
|
||||
mv.render();
|
||||
|
||||
mv.openDraft(undefined, { newTab: true });
|
||||
mv.openSessionBeside("s2", { newTab: true });
|
||||
await flush();
|
||||
|
||||
expect(layout.tabs).toHaveLength(2);
|
||||
@@ -314,11 +179,10 @@ describe("openDraft newTab (#100)", () => {
|
||||
const original = leaves(layout.tabs[0].root);
|
||||
expect(original).toHaveLength(1);
|
||||
expect(original[0].sessionId).toBe("s1");
|
||||
// The draft is alone in the new, now-active tab.
|
||||
// The new session is alone in the new, now-active tab.
|
||||
const fresh = leaves(layout.tabs[1].root);
|
||||
expect(fresh).toHaveLength(1);
|
||||
expect(fresh[0].sessionId).toBeNull();
|
||||
expect(fresh[0].draft).not.toBeNull();
|
||||
expect(fresh[0].sessionId).toBe("s2");
|
||||
expect(layout.activeTabId).toBe(layout.tabs[1].id);
|
||||
});
|
||||
|
||||
@@ -330,7 +194,7 @@ describe("openDraft newTab (#100)", () => {
|
||||
document.body.appendChild(mv.el);
|
||||
mv.render();
|
||||
|
||||
mv.openDraft();
|
||||
mv.openSessionBeside("s2");
|
||||
await flush();
|
||||
|
||||
expect(layout.tabs).toHaveLength(1);
|
||||
@@ -399,7 +263,7 @@ describe("multiview closeSession tab cleanup (#137)", () => {
|
||||
expect(leaves(tab.root)).toHaveLength(1);
|
||||
});
|
||||
|
||||
it("keeps a tab holding a draft pane", async () => {
|
||||
it("keeps a tab holding an empty pane", async () => {
|
||||
const layout = emptyLayout();
|
||||
const tab = layout.tabs[0];
|
||||
const s1 = splitLeaf(tab, "", "s1", "row", true);
|
||||
@@ -478,7 +342,7 @@ describe("multiview mobile single pane", () => {
|
||||
expect(layout.tabs).toHaveLength(1);
|
||||
});
|
||||
|
||||
it("keeps a spawn draft in the current pane rather than a new tab", async () => {
|
||||
it("keeps a spawned session in the current pane rather than a new tab", async () => {
|
||||
const layout = emptyLayout();
|
||||
const tab = layout.tabs[0];
|
||||
tab.focusedLeafId = splitLeaf(tab, "", "s1", "row", true);
|
||||
@@ -486,14 +350,13 @@ describe("multiview mobile single pane", () => {
|
||||
document.body.appendChild(mv.el);
|
||||
mv.render();
|
||||
|
||||
mv.openDraft(undefined, { newTab: true });
|
||||
mv.openSessionBeside("s2", { newTab: true });
|
||||
await flush();
|
||||
|
||||
expect(layout.tabs).toHaveLength(1);
|
||||
const ls = leaves(tab.root);
|
||||
expect(ls).toHaveLength(1);
|
||||
expect(ls[0].sessionId).toBeNull();
|
||||
expect(ls[0].draft).not.toBeNull();
|
||||
expect(ls[0].sessionId).toBe("s2");
|
||||
});
|
||||
|
||||
it("renders one pane and no pane pills for a multi-leaf tab", () => {
|
||||
@@ -523,3 +386,38 @@ describe("multiview mobile single pane", () => {
|
||||
expect(mv.el.classList.contains("mv-mobile-solo")).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
describe("multiview solo tab bar", () => {
|
||||
beforeEach(() => {
|
||||
stubFetch();
|
||||
document.body.replaceChildren();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
vi.unstubAllGlobals();
|
||||
});
|
||||
|
||||
it("hides the tab bar while only one tab exists", () => {
|
||||
const layout = emptyLayout();
|
||||
const tab = layout.tabs[0];
|
||||
tab.focusedLeafId = splitLeaf(tab, "", "s1", "row", true);
|
||||
const mv = makeMv(layout);
|
||||
document.body.appendChild(mv.el);
|
||||
mv.render();
|
||||
|
||||
expect(mv.el.classList.contains("mv-solo-tab")).toBe(true);
|
||||
});
|
||||
|
||||
it("shows the tab bar again once a second tab appears", () => {
|
||||
const layout = emptyLayout();
|
||||
const first = layout.tabs[0];
|
||||
first.focusedLeafId = splitLeaf(first, "", "s1", "row", true);
|
||||
const second = addTab(layout);
|
||||
second.focusedLeafId = splitLeaf(second, "", "s2", "row", true);
|
||||
const mv = makeMv(layout);
|
||||
document.body.appendChild(mv.el);
|
||||
mv.render();
|
||||
|
||||
expect(mv.el.classList.contains("mv-solo-tab")).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
+27
-130
@@ -1,9 +1,8 @@
|
||||
// The multi-view renderer/controller (issues #30 splits, #31 tabs, #33
|
||||
// highlights). Owns the tab bar + canvas inside the content pane, builds the
|
||||
// active tab's split tree into DOM, and mounts a live AttachConnection into each
|
||||
// session leaf via the pool. Empty leaves are draft panes (#57): they render
|
||||
// the spawn form inline, and submitting replaces the draft with that session's
|
||||
// terminal in place. Drag-to-dock is issue #32; mobile projection is #35.
|
||||
// session leaf via the pool. Empty leaves (freshly split, not yet filled) show a
|
||||
// placeholder. Drag-to-dock is issue #32; mobile projection is #35.
|
||||
|
||||
import type { SidebarHandle } from "./catalog.js";
|
||||
import type { ConnectionPool } from "./connections.js";
|
||||
@@ -13,7 +12,6 @@ import {
|
||||
closeTab,
|
||||
findLeaf,
|
||||
type Dir,
|
||||
type Draft,
|
||||
type Layout,
|
||||
leaves,
|
||||
locateSession,
|
||||
@@ -23,7 +21,6 @@ import {
|
||||
splitLeaf,
|
||||
} from "./layout.js";
|
||||
import type { AttachInfo } from "./attach.js";
|
||||
import { createSpawnForm, type SpawnFormHandle } from "./spawnForm.js";
|
||||
|
||||
export interface MultiViewOptions {
|
||||
pool: ConnectionPool;
|
||||
@@ -35,8 +32,8 @@ export interface MultiViewOptions {
|
||||
onDisconnect: (sessionId: string) => void;
|
||||
/** Welcome content for an empty tab. */
|
||||
renderWelcome: () => HTMLElement;
|
||||
/** Called when a draft-pane submit turns an empty pane into a session pane,
|
||||
* so the shell can re-evaluate its route (sidebar vs attach layout). */
|
||||
/** Called when a spawn fills a pane with a new session, so the shell can
|
||||
* re-evaluate its route (sidebar vs attach layout). */
|
||||
onOpenSessionsChange?: () => void;
|
||||
/** Called after any layout change (structure, focus, or divider resize) so the
|
||||
* shell can persist it (issue #34). */
|
||||
@@ -48,15 +45,11 @@ export interface MultiView {
|
||||
/** Bring a session into the layout: focus it if already open, else fill the
|
||||
* focused pane (or open the first pane in an empty tab). */
|
||||
openSession: (sessionId: string) => void;
|
||||
openSessionBeside: (sessionId: string) => void;
|
||||
openSessionBeside: (sessionId: string, opts?: { newTab?: boolean }) => void;
|
||||
/** Drop the pane showing `sessionId` (the session was disconnected/killed). */
|
||||
closeSession: (sessionId: string) => void;
|
||||
/** Every session currently shown in some pane, across all tabs. */
|
||||
openSessions: () => Set<string>;
|
||||
/** Open a draft pane (issue #62): reuse the focused pane if it is already
|
||||
* empty, otherwise split the focused pane. `seed` pre-fills the form
|
||||
* ("Spawn similar" clones a session's cwd + command). */
|
||||
openDraft: (seed?: Partial<Draft>, opts?: { newTab?: boolean }) => void;
|
||||
/** Start dragging a sidebar session into the canvas (issue #32). The
|
||||
* controller owns drag-vs-tap: a tap lets the row's normal click open it, a
|
||||
* drag shows drop zones to place it. */
|
||||
@@ -70,12 +63,6 @@ export function createMultiView(opts: MultiViewOptions): MultiView {
|
||||
const { pool, layout, sidebar, infoFor, onDisconnect, renderWelcome } = opts;
|
||||
const persist = () => opts.onLayoutChange?.();
|
||||
|
||||
// Draft-pane forms (#57) carry global listeners (dir autocomplete), so forms
|
||||
// whose leaves are gone are destroyed on each render. Forms for draft leaves
|
||||
// that survive the render are reused in place (#68): rebuilding one mid-edit
|
||||
// would drop focus, caret and selection, and re-fetch info/projects/names.
|
||||
const draftForms = new Map<string, SpawnFormHandle>();
|
||||
|
||||
const el = document.createElement("div");
|
||||
el.className = "mv";
|
||||
const tabBar = document.createElement("div");
|
||||
@@ -141,38 +128,10 @@ export function createMultiView(opts: MultiViewOptions): MultiView {
|
||||
const host = document.createElement("div");
|
||||
host.className = "mv-pane-host";
|
||||
if (!leaf.sessionId) {
|
||||
// Draft pane (#57): an empty pane is a spawn form. Values hang off the
|
||||
// leaf (never persisted) so each draft keeps its own half-filled state;
|
||||
// submitting fills this leaf with the new session in place.
|
||||
const form = draftForms.get(leaf.id);
|
||||
if (form) {
|
||||
host.appendChild(form.el);
|
||||
} else {
|
||||
const created = createSpawnForm({
|
||||
seed: leaf.draft ?? undefined,
|
||||
class: "mv-draft",
|
||||
onChange: (values) => {
|
||||
leaf.draft = values;
|
||||
},
|
||||
onSuccess: (session) => {
|
||||
// The pane can be closed while the POST is in flight. Mounting the
|
||||
// session onto a leaf no longer in the tree would strand it in no
|
||||
// pane at all, so only claim the leaf while it is still there —
|
||||
// searching every tab, since the operator may have switched tabs
|
||||
// while the request was in flight.
|
||||
const host = layout.tabs.find((t) => leaves(t.root).includes(leaf));
|
||||
if (host) {
|
||||
leaf.sessionId = session.id;
|
||||
leaf.draft = null;
|
||||
host.focusedLeafId = leaf.id;
|
||||
}
|
||||
render();
|
||||
opts.onOpenSessionsChange?.();
|
||||
},
|
||||
});
|
||||
draftForms.set(leaf.id, created);
|
||||
host.appendChild(created.el);
|
||||
}
|
||||
const empty = document.createElement("div");
|
||||
empty.className = "mv-pane-empty";
|
||||
empty.textContent = "Empty pane — pick a session from the sidebar, or press n to spawn.";
|
||||
host.appendChild(empty);
|
||||
}
|
||||
|
||||
const tools = document.createElement("div");
|
||||
@@ -365,7 +324,6 @@ export function createMultiView(opts: MultiViewOptions): MultiView {
|
||||
// Fill the focused pane (VS Code style: open replaces the active group).
|
||||
const target = (tab.focusedLeafId && findLeaf(tab.root, tab.focusedLeafId)) || leaves(tab.root)[0];
|
||||
target.sessionId = sessionId;
|
||||
target.draft = null;
|
||||
tab.focusedLeafId = target.id;
|
||||
render();
|
||||
}
|
||||
@@ -375,9 +333,10 @@ export function createMultiView(opts: MultiViewOptions): MultiView {
|
||||
/// `openSession` deliberately replaces the focused pane (VS Code style) for
|
||||
/// a sidebar click, but the fast path must never do that: pressing the key
|
||||
/// while attached would drop the running session out of the layout
|
||||
/// entirely. Follows `openDraft`'s rule instead — reuse an empty pane, else
|
||||
/// split beside the focused one (#67 review).
|
||||
function openSessionBeside(sessionId: string): void {
|
||||
/// entirely. Reuses an empty pane, else splits beside the focused one
|
||||
/// (#67 review). `newTab` opens its own tab instead of halving whatever the
|
||||
/// operator was reading (#100) — what the Spawn button asks for.
|
||||
function openSessionBeside(sessionId: string, placement?: { newTab?: boolean }): void {
|
||||
const loc = locateSession(layout, sessionId);
|
||||
if (loc) {
|
||||
layout.activeTabId = loc.tab.id;
|
||||
@@ -385,6 +344,15 @@ export function createMultiView(opts: MultiViewOptions): MultiView {
|
||||
render();
|
||||
return;
|
||||
}
|
||||
// Mobile keeps a single tab and a single pane, so a new tab is not an
|
||||
// option there: the session takes over the pane below.
|
||||
if (placement?.newTab && !isMobile) {
|
||||
const fresh = addTab(layout);
|
||||
fresh.focusedLeafId = splitLeaf(fresh, "", sessionId, "row", true);
|
||||
render();
|
||||
opts.onOpenSessionsChange?.();
|
||||
return;
|
||||
}
|
||||
const tab = activeTab(layout);
|
||||
if (!tab.root || !tab.focusedLeafId || !findLeaf(tab.root, tab.focusedLeafId)) {
|
||||
tab.focusedLeafId = splitLeaf(tab, "", sessionId, "row", true);
|
||||
@@ -397,7 +365,6 @@ export function createMultiView(opts: MultiViewOptions): MultiView {
|
||||
// evicted session keeps running and stays a tap away in the sidebar.
|
||||
if (!target.sessionId || isMobile) {
|
||||
target.sessionId = sessionId;
|
||||
target.draft = null;
|
||||
} else {
|
||||
tab.focusedLeafId = splitLeaf(tab, target.id, sessionId, "row", true);
|
||||
}
|
||||
@@ -405,76 +372,21 @@ export function createMultiView(opts: MultiViewOptions): MultiView {
|
||||
opts.onOpenSessionsChange?.();
|
||||
}
|
||||
|
||||
function openDraft(seed?: Partial<Draft>, opts?: { newTab?: boolean }): void {
|
||||
const draft = (): Draft => ({ command: "", cwd: "", name: "", ...seed });
|
||||
// Mobile keeps a single tab and a single pane: the spawn form takes over the
|
||||
// current pane instead of opening a tab or a split.
|
||||
if (opts?.newTab && !isMobile) {
|
||||
// Spawn opens its own tab rather than halving whatever you were reading
|
||||
// (#100). The empty-pane reuse below still applies within a tab.
|
||||
const fresh = addTab(layout);
|
||||
fresh.focusedLeafId = splitLeaf(fresh, "", null, "row", true);
|
||||
findLeaf(fresh.root!, fresh.focusedLeafId)!.draft = draft();
|
||||
render();
|
||||
return;
|
||||
}
|
||||
const tab = activeTab(layout);
|
||||
if (!tab.root || !tab.focusedLeafId || !findLeaf(tab.root, tab.focusedLeafId)) {
|
||||
// Empty tab (or stale focus): the draft becomes the first pane.
|
||||
tab.focusedLeafId = splitLeaf(tab, "", null, "row", true);
|
||||
findLeaf(tab.root!, tab.focusedLeafId)!.draft = draft();
|
||||
render();
|
||||
return;
|
||||
}
|
||||
const target = findLeaf(tab.root, tab.focusedLeafId)!;
|
||||
if (!target.sessionId || isMobile) {
|
||||
// Empty = no session, not `!draft` (#72): the mounted form auto-syncs
|
||||
// picked defaults into `draft` once ready, so that's never reliably null.
|
||||
target.sessionId = null;
|
||||
target.draft = draft();
|
||||
const stale = draftForms.get(target.id);
|
||||
if (stale) {
|
||||
stale.destroy();
|
||||
draftForms.delete(target.id);
|
||||
}
|
||||
} else {
|
||||
// Split a fresh draft beside the focused pane.
|
||||
tab.focusedLeafId = splitLeaf(tab, target.id, null, "row", true);
|
||||
findLeaf(tab.root, tab.focusedLeafId)!.draft = draft();
|
||||
}
|
||||
render();
|
||||
}
|
||||
|
||||
// ---- top-level render ----
|
||||
|
||||
/** Destroy forms whose leaf is no longer a draft (leaf removed or filled by
|
||||
* a session). Surviving draft leaves keep their form instance (#68). */
|
||||
function pruneForms(tab: { root: Node | null }): void {
|
||||
const alive = new Set(
|
||||
tab.root
|
||||
? leaves(tab.root)
|
||||
.filter((l) => !l.sessionId)
|
||||
.map((l) => l.id)
|
||||
: [],
|
||||
);
|
||||
for (const [id, f] of draftForms) {
|
||||
if (!alive.has(id)) {
|
||||
f.destroy();
|
||||
draftForms.delete(id);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
function render(): void {
|
||||
renderTabs();
|
||||
canvas.replaceChildren();
|
||||
const tab = activeTab(layout);
|
||||
// Mobile: the tab bar is a second navigation surface we don't want, so CSS
|
||||
// collapses it; the header ☰ keeps the sidebar drawer reachable.
|
||||
// collapses it; the pane header's ☰ keeps the sidebar drawer reachable.
|
||||
el.classList.toggle("mv-mobile-solo", isMobile);
|
||||
// A lone tab has nothing to switch between, so the bar is only a strip of
|
||||
// chrome; CSS hides it until a second tab exists. Spawning still opens its
|
||||
// own tab (#100), which brings the bar back with the "+" button on it.
|
||||
el.classList.toggle("mv-solo-tab", layout.tabs.length === 1);
|
||||
|
||||
if (!tab.root) {
|
||||
pruneForms(tab);
|
||||
pool.setVisible([]);
|
||||
pool.setFocus(null);
|
||||
canvas.appendChild(renderWelcome());
|
||||
@@ -490,14 +402,12 @@ export function createMultiView(opts: MultiViewOptions): MultiView {
|
||||
|
||||
if (isMobile) {
|
||||
renderMobile(tab);
|
||||
pruneForms(tab);
|
||||
persist();
|
||||
return;
|
||||
}
|
||||
|
||||
const hosts: { id: string; host: HTMLElement; info?: AttachInfo }[] = [];
|
||||
canvas.appendChild(buildTree(tab.root, hosts));
|
||||
pruneForms(tab);
|
||||
pool.setVisible(hosts.map((h) => ({ id: h.id, pane: h.host, info: h.info })));
|
||||
syncFocus();
|
||||
persist();
|
||||
@@ -693,17 +603,6 @@ export function createMultiView(opts: MultiViewOptions): MultiView {
|
||||
if (source.kind === "pane" && self) {
|
||||
const dragged = findLeaf(tab.root, self)!;
|
||||
[dragged.sessionId, target.sessionId] = [target.sessionId, dragged.sessionId];
|
||||
[dragged.draft, target.draft] = [target.draft, dragged.draft];
|
||||
// The leaf data moved but each pane's mounted form is still keyed to
|
||||
// its old leaf (#73) — tear both down like openDraft's reuse case
|
||||
// (#72) so render() remounts fresh forms seeded from the swapped data.
|
||||
for (const id of [dragged.id, target.id]) {
|
||||
const stale = draftForms.get(id);
|
||||
if (stale) {
|
||||
stale.destroy();
|
||||
draftForms.delete(id);
|
||||
}
|
||||
}
|
||||
tab.focusedLeafId = target.id;
|
||||
} else if (sessionId) {
|
||||
const loc = locateSession(layout, sessionId);
|
||||
@@ -711,7 +610,6 @@ export function createMultiView(opts: MultiViewOptions): MultiView {
|
||||
const t2 = findLeaf(tab.root, targetLeafId);
|
||||
if (t2) {
|
||||
t2.sessionId = sessionId;
|
||||
t2.draft = null;
|
||||
tab.focusedLeafId = t2.id;
|
||||
}
|
||||
}
|
||||
@@ -737,7 +635,6 @@ export function createMultiView(opts: MultiViewOptions): MultiView {
|
||||
el,
|
||||
openSession,
|
||||
openSessionBeside,
|
||||
openDraft,
|
||||
closeSession,
|
||||
openSessions: () => openSessions(layout),
|
||||
beginSessionDrag,
|
||||
|
||||
@@ -62,7 +62,7 @@ describe("hydrate", () => {
|
||||
expect(leaves(layout!.tabs[0].root).map((l) => l.sessionId)).toEqual(["s"]);
|
||||
});
|
||||
|
||||
it("never restores draft state, even if a stale blob carries it", () => {
|
||||
it("ignores leaf fields a stale blob carries that the layout no longer has", () => {
|
||||
const layout = hydrate({
|
||||
tabs: [
|
||||
{ id: "t", root: { kind: "leaf", id: "l1", sessionId: null, draft: { command: "zsh", cwd: "/x" } } },
|
||||
@@ -74,7 +74,7 @@ describe("hydrate", () => {
|
||||
});
|
||||
|
||||
describe("serializeLayout", () => {
|
||||
it("strips draft state so a reload gives back an empty form", () => {
|
||||
it("round-trips the tree, its sessions and its split ratios", () => {
|
||||
const layout = hydrate({
|
||||
tabs: [
|
||||
{
|
||||
@@ -82,6 +82,7 @@ describe("serializeLayout", () => {
|
||||
root: {
|
||||
kind: "split",
|
||||
dir: "row",
|
||||
ratio: 0.3,
|
||||
a: { kind: "leaf", id: "l1", sessionId: "s1" },
|
||||
b: { kind: "leaf", id: "l2", sessionId: null },
|
||||
},
|
||||
@@ -89,40 +90,10 @@ describe("serializeLayout", () => {
|
||||
],
|
||||
activeTabId: "t",
|
||||
}) as Layout;
|
||||
const draftLeaf = leaves(layout.tabs[0].root).find((l) => !l.sessionId)!;
|
||||
draftLeaf.draft = { command: "claude", cwd: "/home/user/project", name: "amber-fox" };
|
||||
|
||||
const restored = hydrate(JSON.parse(serializeLayout(layout)).layout);
|
||||
expect(restored).not.toBeNull();
|
||||
for (const leaf of leaves(restored!.tabs[0].root)) {
|
||||
expect(leaf.draft ?? null).toBeNull();
|
||||
}
|
||||
expect(leaves(restored!.tabs[0].root).map((l) => l.sessionId)).toEqual(["s1", null]);
|
||||
});
|
||||
|
||||
it("keeps the draft out of the stored blob itself, not just out of hydrate", () => {
|
||||
// A draft pane only exists once a tab has split, so the strip has to walk
|
||||
// into split branches; asserting on the restored layout alone passes even
|
||||
// when the draft was written to localStorage, because hydrate drops it.
|
||||
const layout = hydrate({
|
||||
tabs: [
|
||||
{
|
||||
id: "t",
|
||||
root: {
|
||||
kind: "split",
|
||||
dir: "row",
|
||||
a: { kind: "leaf", id: "l1", sessionId: "s1" },
|
||||
b: { kind: "leaf", id: "l2", sessionId: null },
|
||||
},
|
||||
},
|
||||
],
|
||||
activeTabId: "t",
|
||||
}) as Layout;
|
||||
const draftLeaf = leaves(layout.tabs[0].root).find((l) => !l.sessionId)!;
|
||||
draftLeaf.draft = { command: "claude", cwd: "/home/user/secret-project", name: "amber-fox" };
|
||||
|
||||
const raw = serializeLayout(layout);
|
||||
expect(raw).not.toContain("secret-project");
|
||||
expect(raw).not.toContain("amber-fox");
|
||||
expect((restored!.tabs[0].root as { ratio: number }).ratio).toBe(0.3);
|
||||
});
|
||||
});
|
||||
|
||||
+1
-20
@@ -20,27 +20,8 @@ export function saveLayout(layout: Layout): void {
|
||||
}
|
||||
}
|
||||
|
||||
/** Serialise the layout for storage with draft state stripped (issue #57): a
|
||||
* reload gives back an empty form, never a stale half-filled one. */
|
||||
export function serializeLayout(layout: Layout): string {
|
||||
const clean: Layout = {
|
||||
...layout,
|
||||
tabs: layout.tabs.map((t) => ({
|
||||
...t,
|
||||
root: stripDrafts(t.root),
|
||||
})),
|
||||
};
|
||||
return JSON.stringify({ v: VERSION, layout: clean });
|
||||
}
|
||||
|
||||
function stripDrafts(node: Node | null): Node | null {
|
||||
if (!node) return node;
|
||||
// Recurse: a draft pane only exists once a tab has split, so a shallow strip
|
||||
// would persist every half-filled form it was meant to drop.
|
||||
if (node.kind === "split") {
|
||||
return { ...node, a: stripDrafts(node.a)!, b: stripDrafts(node.b)! };
|
||||
}
|
||||
return { ...node, draft: null };
|
||||
return JSON.stringify({ v: VERSION, layout });
|
||||
}
|
||||
|
||||
export function loadLayout(): Layout | null {
|
||||
|
||||
@@ -0,0 +1,93 @@
|
||||
// Blocking overlay for a daemon that went away — see docs/RESTART.md.
|
||||
//
|
||||
// Mounted while the link is `down` or `updating`, torn down the moment it is
|
||||
// back. It owns no polling of its own: DaemonLink polls, and this only renders
|
||||
// what the link reports.
|
||||
|
||||
import { formatRelease, type DaemonLink, type LinkStatus } from "./daemonLink.js";
|
||||
|
||||
export interface RestartOverlayHandle {
|
||||
dispose(): void;
|
||||
}
|
||||
|
||||
/** Mount the overlay controller. It stays subscribed for the page's lifetime. */
|
||||
export function installRestartOverlay(
|
||||
link: DaemonLink,
|
||||
host: HTMLElement = document.body,
|
||||
): RestartOverlayHandle {
|
||||
let el: HTMLElement | null = null;
|
||||
let title: HTMLElement | null = null;
|
||||
let detail: HTMLElement | null = null;
|
||||
let release: HTMLElement | null = null;
|
||||
|
||||
const unsubscribe = link.subscribe((status) => render(status));
|
||||
|
||||
function render(status: LinkStatus): void {
|
||||
const blocking = status.state === "down" || status.state === "updating";
|
||||
if (!blocking) {
|
||||
unmount();
|
||||
return;
|
||||
}
|
||||
if (!el) mount();
|
||||
const updating = status.state === "updating";
|
||||
title!.textContent = updating ? "Maestro was updated" : "Maestro is restarting";
|
||||
detail!.textContent = updating
|
||||
? "Reloading this page onto the new release…"
|
||||
: attemptText(status.attempts);
|
||||
release!.textContent = formatRelease(status.build);
|
||||
}
|
||||
|
||||
/** The poll runs while this is up; saying how many tries have gone by is what
|
||||
* separates "still restarting" from "wedged" for someone staring at it. */
|
||||
function attemptText(attempts: number): string {
|
||||
if (attempts <= 1) return "Waiting for the daemon to come back…";
|
||||
return `Waiting for the daemon to come back… (${attempts} attempts)`;
|
||||
}
|
||||
|
||||
function mount(): void {
|
||||
el = document.createElement("div");
|
||||
el.className = "modal-backdrop restart-backdrop";
|
||||
const dialog = document.createElement("div");
|
||||
dialog.className = "modal restart-modal";
|
||||
dialog.setAttribute("role", "alertdialog");
|
||||
dialog.setAttribute("aria-modal", "true");
|
||||
dialog.setAttribute("aria-labelledby", "restart-title");
|
||||
|
||||
title = document.createElement("h2");
|
||||
title.id = "restart-title";
|
||||
detail = document.createElement("p");
|
||||
detail.className = "restart-detail";
|
||||
release = document.createElement("p");
|
||||
release.className = "restart-release";
|
||||
const spinner = document.createElement("div");
|
||||
spinner.className = "restart-spinner";
|
||||
spinner.setAttribute("aria-hidden", "true");
|
||||
|
||||
dialog.append(spinner, title, detail, release);
|
||||
el.appendChild(dialog);
|
||||
host.appendChild(el);
|
||||
// The app's shortcuts live on `window`, so hiding the UI behind a backdrop
|
||||
// does not stop them: `n` would still open a spawn form against a daemon
|
||||
// that is not there. Swallow keys in the capture phase until the link is
|
||||
// back, without `preventDefault` so the browser's own chords still work.
|
||||
window.addEventListener("keydown", swallow, true);
|
||||
}
|
||||
|
||||
function swallow(e: KeyboardEvent): void {
|
||||
e.stopImmediatePropagation();
|
||||
}
|
||||
|
||||
function unmount(): void {
|
||||
if (!el) return;
|
||||
window.removeEventListener("keydown", swallow, true);
|
||||
el.remove();
|
||||
el = null;
|
||||
}
|
||||
|
||||
return {
|
||||
dispose(): void {
|
||||
unsubscribe();
|
||||
unmount();
|
||||
},
|
||||
};
|
||||
}
|
||||
@@ -18,6 +18,10 @@ export const EVENTS = "/api/events";
|
||||
/** Name of the query parameter `DIRS` and `GITROOT` both take. */
|
||||
export const PATH_QUERY = "path";
|
||||
|
||||
/** Name of the query parameter `DELETE /api/sessions/:id` takes (#81):
|
||||
* `force=true` overrides the kill refusal over a guarded worktree. */
|
||||
export const FORCE_QUERY = "force";
|
||||
|
||||
/** Name of the query parameter `NAMES` takes. */
|
||||
export const COUNT_QUERY = "count";
|
||||
|
||||
@@ -29,6 +33,10 @@ export function attach(id: Uuid): string {
|
||||
return `${API_PREFIX}/attach/${encodeURIComponent(id)}`;
|
||||
}
|
||||
|
||||
export function sessionFocus(id: Uuid): string {
|
||||
return `${session(id)}/focus`;
|
||||
}
|
||||
|
||||
/** Append the `path` query parameter `DIRS` and `GITROOT` accept. */
|
||||
export function withPathQuery(route: string, value: string): string {
|
||||
return `${route}?${PATH_QUERY}=${encodeURIComponent(value)}`;
|
||||
|
||||
@@ -109,11 +109,11 @@ describe("sidebar keyboard navigation", () => {
|
||||
expect(handle.hasListFocus()).toBe(true);
|
||||
});
|
||||
|
||||
it("Escape asks the shell for the pane back", () => {
|
||||
it("Tab asks the shell for the pane back", () => {
|
||||
const { el } = twoFolders();
|
||||
let asked = 0;
|
||||
document.addEventListener(FOCUS_PANE_EVENT, () => (asked += 1));
|
||||
press(tree(el), "Escape");
|
||||
press(tree(el), "Tab");
|
||||
expect(asked).toBe(1);
|
||||
});
|
||||
|
||||
|
||||
+25
-25
@@ -18,9 +18,9 @@ import type { BranchInfo, CreateSessionRequest, Project, Session, SpawnPreset }
|
||||
* from the repository's existing branches (#61). */
|
||||
export type WorktreeBranchMode = "new" | "existing";
|
||||
|
||||
/** Seed values for the spawn form — used by "clone" to open a draft with the
|
||||
* same cwd, command, and name as an existing session, and by draft panes to
|
||||
* restore their own half-filled state after a re-render. */
|
||||
/** Seed values for the spawn form — used by "Spawn similar" to open the modal
|
||||
* with the same cwd, command, and name as an existing session, and by the
|
||||
* fast-forward fallback to pre-fill whatever it did resolve. */
|
||||
export interface SpawnFormSeed {
|
||||
command?: string;
|
||||
cwd?: string;
|
||||
@@ -35,8 +35,7 @@ export interface SpawnFormSeed {
|
||||
cwdRawVisible?: boolean;
|
||||
}
|
||||
|
||||
/** The form's current values, reported on every change so a caller (the draft
|
||||
* pane) can hang them off its layout leaf. */
|
||||
/** The form's current values, reported on every change. */
|
||||
export interface SpawnFormValues {
|
||||
command: string;
|
||||
cwd: string;
|
||||
@@ -109,8 +108,6 @@ export interface SpawnFormHandle {
|
||||
|
||||
export interface SpawnFormOptions {
|
||||
seed?: SpawnFormSeed;
|
||||
/** Extra class(es) for the <form> root (e.g. `mv-draft` in a draft pane). */
|
||||
class?: string;
|
||||
/** Fired whenever any value changes (input, tile pick, checkbox). */
|
||||
onChange?: (values: SpawnFormValues) => void;
|
||||
/** Called with the created session after a successful submit. */
|
||||
@@ -118,19 +115,13 @@ export interface SpawnFormOptions {
|
||||
}
|
||||
|
||||
/** The spawn form itself — preset tiles, project picker, name, worktree.
|
||||
* Mounted inline by draft panes (issue #57). */
|
||||
* Mounted inside the spawn modal (spawnModal.ts). */
|
||||
export function createSpawnForm(opts: SpawnFormOptions): SpawnFormHandle {
|
||||
const prefill = opts.seed ?? {};
|
||||
|
||||
const form = document.createElement("form");
|
||||
form.className = `spawn-form${opts.class ? ` ${opts.class}` : ""}`;
|
||||
form.className = "spawn-form";
|
||||
form.innerHTML = `
|
||||
<div class="field">
|
||||
<span class="field-label">Command</span>
|
||||
<div class="tile-row cmd-tiles"></div>
|
||||
<input class="raw-input cmd-raw" name="command_raw" type="text" hidden
|
||||
placeholder="bash -l" autocomplete="off" />
|
||||
</div>
|
||||
<div class="field">
|
||||
<span class="field-label">Project</span>
|
||||
<input class="raw-input project-filter" type="text" placeholder="Filter projects…"
|
||||
@@ -142,6 +133,12 @@ export function createSpawnForm(opts: SpawnFormOptions): SpawnFormHandle {
|
||||
placeholder="/home/user/project" inputmode="text" autocomplete="off" />
|
||||
</div>
|
||||
</div>
|
||||
<div class="field">
|
||||
<span class="field-label">Command</span>
|
||||
<div class="tile-row cmd-tiles"></div>
|
||||
<input class="raw-input cmd-raw" name="command_raw" type="text" hidden
|
||||
placeholder="bash -l" autocomplete="off" />
|
||||
</div>
|
||||
<div class="field">
|
||||
<span class="field-label">Name</span>
|
||||
<div class="name-row">
|
||||
@@ -193,8 +190,8 @@ export function createSpawnForm(opts: SpawnFormOptions): SpawnFormHandle {
|
||||
<button type="submit" class="btn btn-primary">Spawn</button>
|
||||
</div>
|
||||
`;
|
||||
// Field queries are scoped to this form instance — several forms can be
|
||||
// mounted at once (one per draft pane), so ids would collide.
|
||||
// Field queries are scoped to this form instance rather than by id, so a
|
||||
// second form mounted before the first is torn down cannot collide with it.
|
||||
|
||||
const errEl = form.querySelector(".form-error") as HTMLElement;
|
||||
const cmdTiles = form.querySelector(".cmd-tiles") as HTMLElement;
|
||||
@@ -241,9 +238,7 @@ export function createSpawnForm(opts: SpawnFormOptions): SpawnFormHandle {
|
||||
// `emit` stays silent until the initial load settles and goes silent again
|
||||
// once the form is destroyed. Construction runs with `cwd === ""` and the
|
||||
// seed is only restored two fetches later, so emitting in between would
|
||||
// blank the leaf's draft; and `multiview.render()` rebuilds forms while the
|
||||
// old one's fetches are still in flight, so a destroyed form emitting would
|
||||
// clobber the live one's leaf (#57 review).
|
||||
// report blank values as if the operator had cleared the form.
|
||||
let ready = false;
|
||||
let destroyed = false;
|
||||
const branchValue = () => (branchMode === "existing" ? branchSelect.value : branchInput.value);
|
||||
@@ -341,7 +336,7 @@ export function createSpawnForm(opts: SpawnFormOptions): SpawnFormHandle {
|
||||
|
||||
// ---- command tiles ---------------------------------------------------
|
||||
// `focus` is false for the two initial applications (construction, and again
|
||||
// when `/api/info` resolves): a draft pane must not grab the caret out from
|
||||
// when `/api/info` resolves): the form must not grab the caret out from
|
||||
// under the operator seconds after it mounts.
|
||||
function selectPreset(id: string, focus = true): void {
|
||||
selectedPresetId = id;
|
||||
@@ -792,8 +787,7 @@ export function createSpawnForm(opts: SpawnFormOptions): SpawnFormHandle {
|
||||
|
||||
/** Fetch the target repo's branches once per cwd. Like every async load in
|
||||
* this form: token-guarded, and nothing touches the DOM (or emits) after
|
||||
* destroy() — a late response into a rebuilt form would corrupt that
|
||||
* form's draft (#57 review). */
|
||||
* destroy() — a late response into a closed modal would throw. */
|
||||
async function loadBranches(): Promise<void> {
|
||||
if (!cwd || !inferredBaseRepo) return;
|
||||
const token = ++branchToken;
|
||||
@@ -902,8 +896,14 @@ export function createSpawnForm(opts: SpawnFormOptions): SpawnFormHandle {
|
||||
|
||||
e.preventDefault();
|
||||
if (target === filterInput) {
|
||||
const top = visibleGroups(filterInput.value)[0];
|
||||
if (top && top.main.path !== selectedGroup?.main.path) selectProject(top);
|
||||
// Resolve the filter to a project only when the current pick isn't one
|
||||
// of the matches: a filter typed past it means the operator moved on,
|
||||
// while a pick that still matches (including the seeded one the form
|
||||
// opens with) keeps its worktree choice.
|
||||
const visible = visibleGroups(filterInput.value);
|
||||
const stillMatches =
|
||||
selectedGroup != null && visible.some((g) => g.main.path === selectedGroup?.main.path);
|
||||
if (!stillMatches && visible[0]) selectProject(visible[0]);
|
||||
}
|
||||
form.requestSubmit();
|
||||
});
|
||||
|
||||
@@ -68,9 +68,12 @@ describe("spawnForm Enter-to-submit (#97)", () => {
|
||||
for (let i = 0; i < 40; i++) await Promise.resolve();
|
||||
};
|
||||
|
||||
async function mount(projects: Project[]): Promise<HTMLFormElement> {
|
||||
async function mount(
|
||||
projects: Project[],
|
||||
seed?: Parameters<typeof createSpawnForm>[0]["seed"],
|
||||
): Promise<HTMLFormElement> {
|
||||
stubFetch(projects);
|
||||
handle = createSpawnForm({ onSuccess() {} });
|
||||
handle = createSpawnForm({ seed, onSuccess() {} });
|
||||
document.body.appendChild(handle.el);
|
||||
await drain();
|
||||
return handle.el;
|
||||
@@ -232,6 +235,24 @@ describe("spawnForm Enter-to-submit (#97)", () => {
|
||||
expect(box(form, OTHER.path).classList.contains("is-active")).toBe(true);
|
||||
});
|
||||
|
||||
it("submits in the seeded project rather than the freshest one", async () => {
|
||||
// What `n` then Enter must do: the modal opens parked on the project of
|
||||
// the session you were last on (OTHER here), even though MAESTRO's
|
||||
// worktree is the freshest row in the list.
|
||||
const form = await mount([MAESTRO, WT_A, OTHER], {
|
||||
cwd: OTHER.path,
|
||||
cwdRawVisible: false,
|
||||
});
|
||||
expect(box(form, OTHER.path).classList.contains("is-active")).toBe(true);
|
||||
const spy = submitSpy();
|
||||
form.addEventListener("submit", spy);
|
||||
|
||||
pressEnter(form.querySelector<HTMLInputElement>(".project-filter")!);
|
||||
|
||||
expect(spy).toHaveBeenCalledTimes(1);
|
||||
expect(box(form, OTHER.path).classList.contains("is-active")).toBe(true);
|
||||
});
|
||||
|
||||
it("does not clobber an already-chosen worktree when the filter still matches it", async () => {
|
||||
const form = await mount([MAESTRO, WT_A]);
|
||||
box(form, MAESTRO.path).click();
|
||||
|
||||
@@ -0,0 +1,142 @@
|
||||
// @vitest-environment happy-dom
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
import { closeSpawnModal, openSpawnModal } from "./spawnModal.js";
|
||||
import type { Session } from "./types.js";
|
||||
|
||||
function stubFetch(): void {
|
||||
vi.stubGlobal(
|
||||
"fetch",
|
||||
vi.fn(async (input: RequestInfo | URL) => {
|
||||
const url = String(input);
|
||||
const body = url.includes("/api/info")
|
||||
? { hostname: "h", version: "0", home_dir: "/home/user", presets: [] }
|
||||
: url.includes("/api/projects")
|
||||
? []
|
||||
: url.includes("/api/names")
|
||||
? { names: ["cello"] }
|
||||
: undefined;
|
||||
return new Response(JSON.stringify(body), { status: 200 });
|
||||
}),
|
||||
);
|
||||
}
|
||||
|
||||
/** Drain the microtask queue so the form's initial loads land. */
|
||||
async function flush(): Promise<void> {
|
||||
for (let i = 0; i < 20; i++) await Promise.resolve();
|
||||
}
|
||||
|
||||
const modal = () => document.getElementById("modal-host");
|
||||
|
||||
describe("spawn modal", () => {
|
||||
beforeEach(() => {
|
||||
stubFetch();
|
||||
document.body.replaceChildren();
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
closeSpawnModal();
|
||||
vi.unstubAllGlobals();
|
||||
});
|
||||
|
||||
it("mounts the shared spawn form inside a dialog", async () => {
|
||||
openSpawnModal({ onSuccess: () => {} });
|
||||
await flush();
|
||||
|
||||
const host = modal()!;
|
||||
expect(host).toBeTruthy();
|
||||
expect(host.querySelector('[role="dialog"]')).toBeTruthy();
|
||||
expect(host.querySelector("form.spawn-form")).toBeTruthy();
|
||||
expect(host.querySelector("#spawn-title")?.textContent).toBe("Spawn session");
|
||||
// The modal adds the Cancel the shared form doesn't ship.
|
||||
expect(host.querySelector(".form-actions .cancel")).toBeTruthy();
|
||||
});
|
||||
|
||||
it("opens with the project filter focused, ahead of the command tiles", async () => {
|
||||
openSpawnModal({ onSuccess: () => {} });
|
||||
await flush();
|
||||
|
||||
const form = modal()!.querySelector("form.spawn-form")!;
|
||||
expect(document.activeElement).toBe(form.querySelector(".project-filter"));
|
||||
const fields = [...form.querySelectorAll(".field .field-label")].map((el) => el.textContent);
|
||||
expect(fields.slice(0, 2)).toEqual(["Project", "Command"]);
|
||||
});
|
||||
|
||||
it("titles a seeded open as a clone", async () => {
|
||||
openSpawnModal({ seed: { command: "claude" }, onSuccess: () => {} });
|
||||
await flush();
|
||||
|
||||
expect(modal()!.querySelector("#spawn-title")?.textContent).toBe("Spawn similar");
|
||||
});
|
||||
|
||||
it("closes on Escape, on Cancel and on a backdrop click", async () => {
|
||||
for (const dismiss of [
|
||||
() => window.dispatchEvent(new KeyboardEvent("keydown", { key: "Escape" })),
|
||||
() => (modal()!.querySelector(".form-actions .cancel") as HTMLButtonElement).click(),
|
||||
() => modal()!.dispatchEvent(new MouseEvent("click", { bubbles: true })),
|
||||
() => (modal()!.querySelector(".close") as HTMLButtonElement).click(),
|
||||
]) {
|
||||
openSpawnModal({ onSuccess: () => {} });
|
||||
await flush();
|
||||
dismiss();
|
||||
expect(modal()).toBeNull();
|
||||
}
|
||||
});
|
||||
|
||||
it("leaves no stray Escape handler behind after closing", async () => {
|
||||
openSpawnModal({ onSuccess: () => {} });
|
||||
await flush();
|
||||
closeSpawnModal();
|
||||
|
||||
// A second Escape with no modal up must not throw on the torn-down form.
|
||||
window.dispatchEvent(new KeyboardEvent("keydown", { key: "Escape" }));
|
||||
expect(modal()).toBeNull();
|
||||
});
|
||||
|
||||
it("opening twice tears the first one down rather than stacking dialogs", async () => {
|
||||
openSpawnModal({ onSuccess: () => {} });
|
||||
await flush();
|
||||
openSpawnModal({ onSuccess: () => {} });
|
||||
await flush();
|
||||
|
||||
expect(document.querySelectorAll("#modal-host")).toHaveLength(1);
|
||||
expect(document.querySelectorAll("form.spawn-form")).toHaveLength(1);
|
||||
});
|
||||
|
||||
it("closes before handing the created session to its caller", async () => {
|
||||
const seen: Array<{ session: Session; stillOpen: boolean }> = [];
|
||||
vi.stubGlobal(
|
||||
"fetch",
|
||||
vi.fn(async (input: RequestInfo | URL, init?: RequestInit) => {
|
||||
const url = String(input);
|
||||
if (url.includes("/api/sessions") && init?.method === "POST") {
|
||||
return new Response(JSON.stringify({ id: "s1", cwd: "/x", command: "zsh" }), { status: 200 });
|
||||
}
|
||||
const body = url.includes("/api/info")
|
||||
? { hostname: "h", version: "0", home_dir: "/home/user", presets: [] }
|
||||
: url.includes("/api/projects")
|
||||
? []
|
||||
: url.includes("/api/names")
|
||||
? { names: ["cello"] }
|
||||
: undefined;
|
||||
return new Response(JSON.stringify(body), { status: 200 });
|
||||
}),
|
||||
);
|
||||
|
||||
openSpawnModal({
|
||||
// A plain, worktree-free spawn: the point here is where the created
|
||||
// session is handed over, not what the form validates.
|
||||
seed: { command: "zsh", cwd: "/x", cwdRawVisible: true, worktreeEnabled: false },
|
||||
onSuccess: (session) => seen.push({ session, stillOpen: modal() != null }),
|
||||
});
|
||||
await flush();
|
||||
(modal()!.querySelector("form.spawn-form") as HTMLFormElement).dispatchEvent(
|
||||
new Event("submit", { bubbles: true, cancelable: true }),
|
||||
);
|
||||
await flush();
|
||||
|
||||
expect(seen).toHaveLength(1);
|
||||
expect(seen[0].session.id).toBe("s1");
|
||||
expect(seen[0].stillOpen).toBe(false);
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,99 @@
|
||||
// The spawn modal: dialog chrome around the shared spawn form (spawnForm.ts).
|
||||
//
|
||||
// One modal at a time — opening while one is up replaces it. Escape, the ✕ and
|
||||
// a click on the backdrop all close it; the form's own Escape handlers (the
|
||||
// directory autocomplete) swallow the key first, so dismissing a dropdown never
|
||||
// also discards the form.
|
||||
|
||||
import { createSpawnForm, type SpawnFormSeed } from "./spawnForm.js";
|
||||
import type { Session } from "./types.js";
|
||||
|
||||
/** Seed values for the spawn form — used by "Spawn similar" to open the dialog
|
||||
* with the same cwd, command and name as an existing session. */
|
||||
export type SpawnPrefill = SpawnFormSeed;
|
||||
|
||||
export interface SpawnModalOptions {
|
||||
seed?: SpawnPrefill;
|
||||
/** Called with the created session after a successful submit; the modal has
|
||||
* already closed by then, so the caller decides where it lands. */
|
||||
onSuccess: (session: Session) => void;
|
||||
}
|
||||
|
||||
/** Closer for the modal currently up, so opening a second one tears the first
|
||||
* one down properly — dropping its node alone would strand the form's global
|
||||
* listeners (dir autocomplete) and the Escape handler. */
|
||||
let closeCurrent: (() => void) | null = null;
|
||||
|
||||
export function openSpawnModal(opts: SpawnModalOptions): void {
|
||||
closeSpawnModal();
|
||||
|
||||
const host = document.createElement("div");
|
||||
host.id = "modal-host";
|
||||
host.className = "modal-backdrop";
|
||||
const dialog = document.createElement("div");
|
||||
dialog.className = "modal spawn-modal";
|
||||
dialog.setAttribute("role", "dialog");
|
||||
dialog.setAttribute("aria-modal", "true");
|
||||
dialog.setAttribute("aria-labelledby", "spawn-title");
|
||||
const header = document.createElement("header");
|
||||
header.className = "modal-header";
|
||||
const title = document.createElement("h2");
|
||||
title.id = "spawn-title";
|
||||
// "Spawn similar" arrives with a seed; the title says which act this is.
|
||||
title.textContent = opts.seed ? "Spawn similar" : "Spawn session";
|
||||
const closeBtn = document.createElement("button");
|
||||
closeBtn.type = "button";
|
||||
closeBtn.className = "btn btn-icon close";
|
||||
closeBtn.setAttribute("aria-label", "Close");
|
||||
closeBtn.textContent = "✕";
|
||||
header.append(title, closeBtn);
|
||||
dialog.appendChild(header);
|
||||
host.appendChild(dialog);
|
||||
document.body.appendChild(host);
|
||||
|
||||
const form = createSpawnForm({
|
||||
seed: opts.seed,
|
||||
onSuccess: (session) => {
|
||||
close();
|
||||
opts.onSuccess(session);
|
||||
},
|
||||
});
|
||||
dialog.appendChild(form.el);
|
||||
// The project filter owns the keyboard on open: typing narrows the list and
|
||||
// Tab from here reaches the command tiles, matching the TUI's draft pane.
|
||||
form.el.querySelector<HTMLInputElement>(".project-filter")?.focus();
|
||||
|
||||
function close(): void {
|
||||
if (closeCurrent === close) closeCurrent = null;
|
||||
window.removeEventListener("keydown", onKeydown);
|
||||
form.destroy();
|
||||
host.remove();
|
||||
}
|
||||
closeCurrent = close;
|
||||
|
||||
function onKeydown(e: KeyboardEvent): void {
|
||||
if (e.key === "Escape") {
|
||||
e.preventDefault();
|
||||
close();
|
||||
}
|
||||
}
|
||||
|
||||
// The modal keeps its Cancel affordance; the shared form ships only Submit.
|
||||
const cancel = document.createElement("button");
|
||||
cancel.type = "button";
|
||||
cancel.className = "btn btn-ghost cancel";
|
||||
cancel.textContent = "Cancel";
|
||||
cancel.addEventListener("click", close);
|
||||
form.el.querySelector(".form-actions")?.prepend(cancel);
|
||||
|
||||
closeBtn.addEventListener("click", close);
|
||||
host.addEventListener("click", (e) => {
|
||||
if (e.target === host) close();
|
||||
});
|
||||
window.addEventListener("keydown", onKeydown);
|
||||
}
|
||||
|
||||
/** Close whatever spawn modal is up. No-op when none is. */
|
||||
export function closeSpawnModal(): void {
|
||||
closeCurrent?.();
|
||||
}
|
||||
@@ -1,5 +1,5 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { spawnSimilarSeed } from "./spawnSimilar.js";
|
||||
import { spawnSimilarProjectSeed, spawnSimilarSeed } from "./spawnSimilar.js";
|
||||
import type { Session } from "./types.js";
|
||||
|
||||
function session(overrides: Partial<Session> = {}): Session {
|
||||
@@ -43,3 +43,23 @@ describe("spawnSimilarSeed (#28)", () => {
|
||||
expect(seed.name).toBeUndefined();
|
||||
});
|
||||
});
|
||||
|
||||
describe("spawnSimilarProjectSeed", () => {
|
||||
it("seeds the project alone, leaving command and worktree at their defaults", () => {
|
||||
const seed = spawnSimilarProjectSeed(session());
|
||||
expect(seed.cwd).toBe("/repos/app");
|
||||
expect(seed.cwdRawVisible).toBe(false);
|
||||
expect(seed.command).toBeUndefined();
|
||||
expect(seed.worktreeEnabled).toBeUndefined();
|
||||
});
|
||||
|
||||
it("seeds a worktree session's base repository", () => {
|
||||
const seed = spawnSimilarProjectSeed(
|
||||
session({
|
||||
cwd: "/repos/app-worktrees/feature",
|
||||
worktree: { path: "/repos/app-worktrees/feature", base_repo: "/repos/app" },
|
||||
}),
|
||||
);
|
||||
expect(seed.cwd).toBe("/repos/app");
|
||||
});
|
||||
});
|
||||
|
||||
+19
-5
@@ -1,10 +1,10 @@
|
||||
// "Spawn similar" (#28): the seed a cloned session hands to a draft pane.
|
||||
// Pure — the caller owns opening the pane.
|
||||
// "Spawn similar" (#28): the seed a cloned session hands to the spawn modal.
|
||||
// Pure — the caller owns opening the dialog.
|
||||
|
||||
import type { Draft } from "./layout.js";
|
||||
import type { SpawnFormSeed } from "./spawnForm.js";
|
||||
import type { Session } from "./types.js";
|
||||
|
||||
/** Clone a session into draft values: same project, same command, same
|
||||
/** Clone a session into form values: same project, same command, same
|
||||
* worktree decision, fresh name.
|
||||
*
|
||||
* A worktree session seeds its *base repository*, not the checkout the daemon
|
||||
@@ -19,7 +19,7 @@ import type { Session } from "./types.js";
|
||||
*
|
||||
* The name is left out on purpose: a clone is a new session and takes its own
|
||||
* generated handle. */
|
||||
export function spawnSimilarSeed(s: Session): Partial<Draft> {
|
||||
export function spawnSimilarSeed(s: Session): SpawnFormSeed {
|
||||
const wt = s.worktree ?? null;
|
||||
return {
|
||||
command: s.command,
|
||||
@@ -28,3 +28,17 @@ export function spawnSimilarSeed(s: Session): Partial<Draft> {
|
||||
cwdRawVisible: false,
|
||||
};
|
||||
}
|
||||
|
||||
/** The project half of a clone: the session's repository, nothing else.
|
||||
*
|
||||
* The plain spawn modal opens on this so the picker is already parked on the
|
||||
* project you were last looking at — one Enter spawns there — while the
|
||||
* command, worktree decision and name stay at the form's own defaults. Same
|
||||
* base-repository rule as `spawnSimilarSeed`. */
|
||||
export function spawnSimilarProjectSeed(s: Session): SpawnFormSeed {
|
||||
const wt = s.worktree ?? null;
|
||||
return {
|
||||
cwd: wt ? wt.base_repo : s.cwd,
|
||||
cwdRawVisible: false,
|
||||
};
|
||||
}
|
||||
|
||||
@@ -0,0 +1,157 @@
|
||||
// @vitest-environment happy-dom
|
||||
import { describe, expect, it } from "vitest";
|
||||
|
||||
import { DaemonLink } from "./daemonLink.js";
|
||||
import { installRestartOverlay } from "./restartOverlay.js";
|
||||
import { createStatusIndicator } from "./statusIndicator.js";
|
||||
import type { DaemonInfo } from "./types.js";
|
||||
import type { Scheduler } from "./events.js";
|
||||
|
||||
function info(commit: string, instance: string): DaemonInfo {
|
||||
return {
|
||||
hostname: "konishi",
|
||||
version: "0.1.0",
|
||||
presets: [],
|
||||
build: { commit, commit_date: "2026-09-02T14:03:11Z", dirty: false },
|
||||
instance,
|
||||
};
|
||||
}
|
||||
|
||||
function manual(): Scheduler & { run(): void } {
|
||||
let next = 1;
|
||||
const timers = new Map<number, () => void>();
|
||||
return {
|
||||
setTimer(fn) {
|
||||
const h = next++;
|
||||
timers.set(h, fn);
|
||||
return h;
|
||||
},
|
||||
clearTimer(h) {
|
||||
timers.delete(h);
|
||||
},
|
||||
run() {
|
||||
const due = [...timers.values()];
|
||||
timers.clear();
|
||||
for (const fn of due) fn();
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
describe("status indicator", () => {
|
||||
it("shows the release on the tooltip once the daemon answers", async () => {
|
||||
const link = new DaemonLink({
|
||||
fetchInfo: async () => info("f89be4a716c7", "i1"),
|
||||
scheduler: manual(),
|
||||
reload: () => {},
|
||||
});
|
||||
const ind = createStatusIndicator(link);
|
||||
await link.start();
|
||||
|
||||
expect(ind.el.dataset.state).toBe("online");
|
||||
const tip = ind.el.querySelector(".status-tip")!.textContent ?? "";
|
||||
expect(tip).toContain("f89be4a716c7");
|
||||
expect(tip).toContain("2026-09-02");
|
||||
expect(tip).toContain("konishi");
|
||||
expect(ind.el.getAttribute("aria-label")).toContain("Connected");
|
||||
ind.dispose();
|
||||
});
|
||||
|
||||
it("tracks the link through a drop", async () => {
|
||||
const sched = manual();
|
||||
const link = new DaemonLink({
|
||||
fetchInfo: async () => {
|
||||
throw new Error("down");
|
||||
},
|
||||
scheduler: sched,
|
||||
reload: () => {},
|
||||
});
|
||||
const ind = createStatusIndicator(link);
|
||||
expect(ind.el.dataset.state).toBe("connecting");
|
||||
|
||||
link.noteDisconnected();
|
||||
expect(ind.el.dataset.state).toBe("reconnecting");
|
||||
sched.run();
|
||||
await Promise.resolve();
|
||||
expect(ind.el.dataset.state).toBe("down");
|
||||
ind.dispose();
|
||||
link.stop();
|
||||
});
|
||||
});
|
||||
|
||||
describe("restart overlay", () => {
|
||||
it("blocks once the daemon is unreachable and unlocks when it answers", async () => {
|
||||
const sched = manual();
|
||||
let reply: DaemonInfo | null = info("aaa", "i1");
|
||||
const link = new DaemonLink({
|
||||
fetchInfo: async () => {
|
||||
if (!reply) throw new Error("down");
|
||||
return reply;
|
||||
},
|
||||
scheduler: sched,
|
||||
reload: () => {},
|
||||
});
|
||||
const overlay = installRestartOverlay(link);
|
||||
await link.start();
|
||||
expect(document.querySelector(".restart-backdrop")).toBeNull();
|
||||
|
||||
reply = null;
|
||||
link.noteDisconnected();
|
||||
expect(document.querySelector(".restart-backdrop")).toBeNull(); // grace
|
||||
sched.run();
|
||||
await Promise.resolve();
|
||||
const dialog = document.querySelector(".restart-modal");
|
||||
expect(dialog?.textContent).toContain("Maestro is restarting");
|
||||
|
||||
// Restarted on the same build: no reload, and the overlay goes away.
|
||||
reply = info("aaa", "i2");
|
||||
await link.probe();
|
||||
expect(document.querySelector(".restart-backdrop")).toBeNull();
|
||||
overlay.dispose();
|
||||
});
|
||||
|
||||
it("swallows the app's shortcuts while it is up", async () => {
|
||||
const sched = manual();
|
||||
const link = new DaemonLink({
|
||||
fetchInfo: async () => {
|
||||
throw new Error("down");
|
||||
},
|
||||
scheduler: sched,
|
||||
reload: () => {},
|
||||
});
|
||||
const overlay = installRestartOverlay(link);
|
||||
let sawKey = false;
|
||||
window.addEventListener("keydown", () => {
|
||||
sawKey = true;
|
||||
});
|
||||
|
||||
link.noteDisconnected();
|
||||
sched.run();
|
||||
await Promise.resolve();
|
||||
window.dispatchEvent(new KeyboardEvent("keydown", { key: "n", bubbles: true }));
|
||||
expect(sawKey).toBe(false);
|
||||
|
||||
overlay.dispose();
|
||||
link.stop();
|
||||
window.dispatchEvent(new KeyboardEvent("keydown", { key: "n", bubbles: true }));
|
||||
expect(sawKey).toBe(true);
|
||||
});
|
||||
|
||||
it("says the page is reloading after an upgrade", async () => {
|
||||
const sched = manual();
|
||||
let reply = info("aaa", "i1");
|
||||
const link = new DaemonLink({
|
||||
fetchInfo: async () => reply,
|
||||
scheduler: sched,
|
||||
reload: () => {},
|
||||
});
|
||||
const overlay = installRestartOverlay(link);
|
||||
await link.start();
|
||||
link.noteDisconnected();
|
||||
reply = info("bbb", "i2");
|
||||
await link.probe();
|
||||
const dialog = document.querySelector(".restart-modal");
|
||||
expect(dialog?.textContent).toContain("Maestro was updated");
|
||||
expect(dialog?.textContent).toContain("bbb");
|
||||
overlay.dispose();
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,67 @@
|
||||
// The sidebar footer's daemon-status dot, sat next to the spawn button.
|
||||
//
|
||||
// Colour is the link state; hovering (or focusing — it is a button, so the
|
||||
// keyboard reaches it) reveals the release the daemon is running: commit hash
|
||||
// and commit date.
|
||||
|
||||
import { formatRelease, type DaemonLink, type LinkState, type LinkStatus } from "./daemonLink.js";
|
||||
|
||||
/** One human-readable phrase per link state, used for both the tooltip's first
|
||||
* line and the button's accessible name. */
|
||||
const LABELS: Record<LinkState, string> = {
|
||||
connecting: "Connecting…",
|
||||
online: "Connected",
|
||||
reconnecting: "Reconnecting…",
|
||||
down: "Daemon unreachable",
|
||||
updating: "Updated — reloading",
|
||||
};
|
||||
|
||||
export interface StatusIndicatorHandle {
|
||||
el: HTMLElement;
|
||||
dispose(): void;
|
||||
}
|
||||
|
||||
export function createStatusIndicator(link: DaemonLink): StatusIndicatorHandle {
|
||||
const el = document.createElement("button");
|
||||
el.type = "button";
|
||||
el.className = "btn btn-ghost btn-icon status-chip";
|
||||
el.setAttribute("aria-describedby", "status-tip");
|
||||
|
||||
const dot = document.createElement("span");
|
||||
dot.className = "status-dot";
|
||||
dot.setAttribute("aria-hidden", "true");
|
||||
el.appendChild(dot);
|
||||
|
||||
const tip = document.createElement("span");
|
||||
tip.className = "status-tip";
|
||||
tip.id = "status-tip";
|
||||
tip.setAttribute("role", "tooltip");
|
||||
el.appendChild(tip);
|
||||
|
||||
const unsubscribe = link.subscribe((status) => render(status));
|
||||
|
||||
function render(status: LinkStatus): void {
|
||||
const label = LABELS[status.state];
|
||||
const release = formatRelease(status.build);
|
||||
el.dataset.state = status.state;
|
||||
el.setAttribute("aria-label", `${label} — ${release}`);
|
||||
tip.textContent = "";
|
||||
tip.append(line("status-tip-state", status.hostname ? `${label} · ${status.hostname}` : label));
|
||||
tip.append(line("status-tip-release", release));
|
||||
}
|
||||
|
||||
function line(cls: string, text: string): HTMLElement {
|
||||
const span = document.createElement("span");
|
||||
span.className = cls;
|
||||
span.textContent = text;
|
||||
return span;
|
||||
}
|
||||
|
||||
return {
|
||||
el,
|
||||
dispose(): void {
|
||||
unsubscribe();
|
||||
el.remove();
|
||||
},
|
||||
};
|
||||
}
|
||||
+746
-192
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,74 @@
|
||||
// @vitest-environment happy-dom
|
||||
import { beforeAll, beforeEach, describe, expect, it } from "vitest";
|
||||
|
||||
import {
|
||||
createPaletteSelect,
|
||||
initTheme,
|
||||
PALETTES,
|
||||
resolvedPalette,
|
||||
setPalette,
|
||||
} from "./theme.js";
|
||||
|
||||
// happy-dom's vitest environment ships no localStorage global; back it with a
|
||||
// plain in-memory map so persistence is observable.
|
||||
let store = new Map<string, string>();
|
||||
beforeAll(() => {
|
||||
Object.defineProperty(window, "localStorage", {
|
||||
value: {
|
||||
getItem: (k: string) => store.get(k) ?? null,
|
||||
setItem: (k: string, v: string) => store.set(k, v),
|
||||
removeItem: (k: string) => store.delete(k),
|
||||
},
|
||||
});
|
||||
});
|
||||
|
||||
describe("palette selection", () => {
|
||||
beforeEach(() => {
|
||||
store = new Map();
|
||||
delete document.documentElement.dataset.palette;
|
||||
delete document.documentElement.dataset.theme;
|
||||
});
|
||||
|
||||
it("defaults to graphite with no data-palette attribute", () => {
|
||||
initTheme();
|
||||
expect(resolvedPalette()).toBe("graphite");
|
||||
expect(document.documentElement.dataset.palette).toBeUndefined();
|
||||
});
|
||||
|
||||
it("setPalette stamps data-palette and persists", () => {
|
||||
setPalette("ember");
|
||||
expect(document.documentElement.dataset.palette).toBe("ember");
|
||||
expect(resolvedPalette()).toBe("ember");
|
||||
|
||||
// A fresh boot re-applies the stored palette.
|
||||
delete document.documentElement.dataset.palette;
|
||||
initTheme();
|
||||
expect(document.documentElement.dataset.palette).toBe("ember");
|
||||
});
|
||||
|
||||
it("selecting graphite removes the attribute again", () => {
|
||||
setPalette("orchid");
|
||||
setPalette("graphite");
|
||||
expect(document.documentElement.dataset.palette).toBeUndefined();
|
||||
initTheme();
|
||||
expect(document.documentElement.dataset.palette).toBeUndefined();
|
||||
});
|
||||
|
||||
it("ignores an unknown stored palette", () => {
|
||||
localStorage.setItem("maestro-palette", "glorb");
|
||||
initTheme();
|
||||
expect(resolvedPalette()).toBe("graphite");
|
||||
expect(document.documentElement.dataset.palette).toBeUndefined();
|
||||
});
|
||||
|
||||
it("the picker lists every palette and applies the chosen one", () => {
|
||||
const select = createPaletteSelect();
|
||||
expect([...select.options].map((o) => o.value)).toEqual([...PALETTES]);
|
||||
expect(select.value).toBe("graphite");
|
||||
|
||||
select.value = "periwinkle";
|
||||
select.dispatchEvent(new Event("change"));
|
||||
expect(document.documentElement.dataset.palette).toBe("periwinkle");
|
||||
expect(localStorage.getItem("maestro-palette")).toBe("periwinkle");
|
||||
});
|
||||
});
|
||||
+64
-1
@@ -1,10 +1,26 @@
|
||||
// Theme: dark (default) + light, persisted. When the user hasn't pinned a
|
||||
// theme we follow the OS via CSS `prefers-color-scheme`; pinning sets an
|
||||
// explicit `data-theme` on <html> that overrides the media query.
|
||||
//
|
||||
// Palette: orthogonal to light/dark. Each palette ships both a dark and a
|
||||
// light token set in styles.css; `data-palette` on <html> selects it, and
|
||||
// graphite — the default — is the bare document with no attribute.
|
||||
|
||||
type Theme = "light" | "dark";
|
||||
const KEY = "maestro-theme";
|
||||
|
||||
/** Every `data-palette` value, in picker order. Graphite is the default. */
|
||||
export const PALETTES = [
|
||||
"graphite",
|
||||
"ice-cyan",
|
||||
"periwinkle",
|
||||
"amber-phosphor",
|
||||
"ember",
|
||||
"orchid",
|
||||
] as const;
|
||||
export type Palette = (typeof PALETTES)[number];
|
||||
const PALETTE_KEY = "maestro-palette";
|
||||
|
||||
function stored(): Theme | null {
|
||||
const v = localStorage.getItem(KEY);
|
||||
return v === "light" || v === "dark" ? v : null;
|
||||
@@ -21,18 +37,46 @@ export function resolvedTheme(): Theme {
|
||||
return stored() ?? systemTheme();
|
||||
}
|
||||
|
||||
/** Apply a pinned theme at boot (no-op when following the system). */
|
||||
function storedPalette(): Palette | null {
|
||||
const v = localStorage.getItem(PALETTE_KEY);
|
||||
return (PALETTES as readonly string[]).includes(v ?? "")
|
||||
? (v as Palette)
|
||||
: null;
|
||||
}
|
||||
|
||||
/** The palette in force (stored or the graphite default). */
|
||||
export function resolvedPalette(): Palette {
|
||||
return document.documentElement.dataset.palette as Palette | undefined
|
||||
?? storedPalette()
|
||||
?? "graphite";
|
||||
}
|
||||
|
||||
/** Pin a palette. Graphite is the bare document, so it clears the attribute. */
|
||||
export function setPalette(p: Palette): void {
|
||||
localStorage.setItem(PALETTE_KEY, p);
|
||||
if (p === "graphite") delete document.documentElement.dataset.palette;
|
||||
else document.documentElement.dataset.palette = p;
|
||||
}
|
||||
|
||||
/** Apply the pinned theme + palette at boot (no-ops when unpinned). */
|
||||
export function initTheme(): void {
|
||||
// Dev-only `?theme=light|dark` override for visual review; stripped in prod.
|
||||
if (import.meta.env.DEV) {
|
||||
const q = new URLSearchParams(location.search).get("theme");
|
||||
if (q === "light" || q === "dark") {
|
||||
document.documentElement.dataset.theme = q;
|
||||
applyStoredPalette();
|
||||
return;
|
||||
}
|
||||
}
|
||||
const pinned = stored();
|
||||
if (pinned) document.documentElement.dataset.theme = pinned;
|
||||
applyStoredPalette();
|
||||
}
|
||||
|
||||
function applyStoredPalette(): void {
|
||||
const p = storedPalette();
|
||||
if (p && p !== "graphite") document.documentElement.dataset.palette = p;
|
||||
}
|
||||
|
||||
function setTheme(t: Theme): void {
|
||||
@@ -58,3 +102,22 @@ export function createThemeToggle(): HTMLButtonElement {
|
||||
});
|
||||
return btn;
|
||||
}
|
||||
|
||||
/** A footer dropdown that picks the colour palette. */
|
||||
export function createPaletteSelect(): HTMLSelectElement {
|
||||
const select = document.createElement("select");
|
||||
select.className = "palette-select";
|
||||
select.setAttribute("aria-label", "Colour palette");
|
||||
select.title = "Colour palette";
|
||||
for (const p of PALETTES) {
|
||||
const opt = document.createElement("option");
|
||||
opt.value = p;
|
||||
opt.textContent = p;
|
||||
select.appendChild(opt);
|
||||
}
|
||||
select.value = resolvedPalette();
|
||||
select.addEventListener("change", () => {
|
||||
setPalette(select.value as Palette);
|
||||
});
|
||||
return select;
|
||||
}
|
||||
|
||||
@@ -20,12 +20,12 @@ describe("tool icons on the command fragment (docs/SIDEBAR.md)", () => {
|
||||
}
|
||||
});
|
||||
|
||||
it("keeps everything after the program as text", () => {
|
||||
expect(splitCommand("claude --resume -p hi")).toEqual({
|
||||
it("drops everything after the program", () => {
|
||||
expect(splitCommand("claude --dangerously-skip-permissions")).toEqual({
|
||||
tool: "claude",
|
||||
rest: "--resume -p hi",
|
||||
program: "claude",
|
||||
});
|
||||
expect(splitCommand(" zsh -l ")).toEqual({ tool: "shell", rest: "-l" });
|
||||
expect(splitCommand(" zsh -l ")).toEqual({ tool: "shell", program: "zsh" });
|
||||
});
|
||||
|
||||
it("looks through paths, env assignments and wrappers", () => {
|
||||
@@ -33,13 +33,13 @@ describe("tool icons on the command fragment (docs/SIDEBAR.md)", () => {
|
||||
expect(splitCommand("FOO=1 BAR=2 claude").tool).toBe("claude");
|
||||
expect(splitCommand("npx opencode").tool).toBe("opencode");
|
||||
expect(splitCommand("pnpm dlx opencode run").tool).toBe("opencode");
|
||||
expect(splitCommand("pnpm dlx opencode run").rest).toBe("run");
|
||||
expect(splitCommand("pnpm dlx opencode run").program).toBe("opencode");
|
||||
});
|
||||
|
||||
it("leaves an unrecognised program as text, mark-less", () => {
|
||||
it("leaves an unrecognised program as its bare name, mark-less", () => {
|
||||
expect(splitCommand("hx src/main.rs")).toEqual({
|
||||
tool: null,
|
||||
rest: "hx src/main.rs",
|
||||
program: "hx",
|
||||
});
|
||||
// A wrapper with nothing after it is not a tool either.
|
||||
expect(splitCommand("sudo").tool).toBeNull();
|
||||
|
||||
+17
-18
@@ -2,11 +2,11 @@
|
||||
*
|
||||
* A session's command line starts with the program that runs it, and that
|
||||
* program is nearly always one of a handful of agents or a shell. Rendering it
|
||||
* as its own mark buys back most of the fragment's width, which the sidebar
|
||||
* spends on the rest of the command line instead.
|
||||
* as its own mark buys back the whole fragment's width — the arguments are
|
||||
* dropped, so a card says which tool runs, not how it was invoked.
|
||||
*
|
||||
* Recognition is deliberately narrow: an unrecognised program keeps its text,
|
||||
* so the fragment never renders a mark that stands for the wrong tool.
|
||||
* Recognition is deliberately narrow: an unrecognised program keeps its name
|
||||
* as text, so the fragment never renders a mark that stands for the wrong tool.
|
||||
*/
|
||||
|
||||
/** Command wrappers that run another program: the tool is what follows. */
|
||||
@@ -48,15 +48,15 @@ export const TOOL_LABELS: Record<string, string> = {
|
||||
export interface CommandParts {
|
||||
/** Icon id, or `null` when the program is not one we have a mark for. */
|
||||
tool: string | null;
|
||||
/** What is left of the command line once the icon stands for the program.
|
||||
* Empty when the icon says everything the command line said. */
|
||||
rest: string;
|
||||
/** The program the command runs, basenamed and stripped of its arguments —
|
||||
* what a card shows when there is no icon to show instead. */
|
||||
program: string;
|
||||
}
|
||||
|
||||
/** Split a command line into the tool its icon stands for and the remainder.
|
||||
/** Split a command line into the tool its icon stands for and the program name.
|
||||
*
|
||||
* `claude --resume` → `{tool: "claude", rest: "--resume"}`; an unrecognised
|
||||
* `hx src/` keeps the whole line as `rest` with no tool. */
|
||||
* `claude --resume` → `{tool: "claude", program: "claude"}`; an unrecognised
|
||||
* `hx src/` keeps `hx` as the program with no tool. */
|
||||
export function splitCommand(command: string): CommandParts {
|
||||
const words = command.trim().split(/\s+/).filter(Boolean);
|
||||
let i = 0;
|
||||
@@ -68,23 +68,22 @@ export function splitCommand(command: string): CommandParts {
|
||||
i += 1;
|
||||
continue;
|
||||
}
|
||||
const program = basename(word);
|
||||
if (WRAPPERS.has(program)) {
|
||||
const wrapper = basename(word).toLowerCase();
|
||||
if (WRAPPERS.has(wrapper)) {
|
||||
i += 1;
|
||||
if ((program === "pnpm" || program === "yarn") && words[i] === "dlx") i += 1;
|
||||
if ((wrapper === "pnpm" || wrapper === "yarn") && words[i] === "dlx") i += 1;
|
||||
continue;
|
||||
}
|
||||
break;
|
||||
}
|
||||
if (i >= words.length) return { tool: null, rest: command.trim() };
|
||||
const tool = BY_PROGRAM[basename(words[i])] ?? null;
|
||||
if (!tool) return { tool: null, rest: command.trim() };
|
||||
return { tool, rest: words.slice(i + 1).join(" ") };
|
||||
if (i >= words.length) return { tool: null, program: command.trim() };
|
||||
const program = basename(words[i]);
|
||||
return { tool: BY_PROGRAM[program.toLowerCase()] ?? null, program };
|
||||
}
|
||||
|
||||
function basename(word: string): string {
|
||||
const cut = word.lastIndexOf("/");
|
||||
return (cut >= 0 ? word.slice(cut + 1) : word).toLowerCase();
|
||||
return cut >= 0 ? word.slice(cut + 1) : word;
|
||||
}
|
||||
|
||||
/** Anthropic's burst: tapered rays around a centre, long ones on the axes. */
|
||||
|
||||
+24
-1
@@ -86,6 +86,24 @@ export interface DaemonInfo {
|
||||
home_dir?: string;
|
||||
/** Command presets (claude/opencode/zsh + custom), config-resolved. */
|
||||
presets: SpawnPreset[];
|
||||
/** Which commit the daemon was built from. Absent on older daemons. */
|
||||
build?: BuildInfo;
|
||||
/** Identity of the daemon *process*, regenerated on every start — a changed
|
||||
* value across a reconnect means the daemon restarted. Absent on older
|
||||
* daemons, which the restart flow treats as "cannot tell". */
|
||||
instance?: string;
|
||||
}
|
||||
|
||||
/** Build provenance of the running daemon: what the status indicator names in
|
||||
* its tooltip, and what tells an upgrade apart from a plain restart. Every
|
||||
* field is empty when the binary was built outside a git checkout. */
|
||||
export interface BuildInfo {
|
||||
/** Abbreviated commit hash. */
|
||||
commit: string;
|
||||
/** Commit date, RFC 3339. */
|
||||
commit_date: string;
|
||||
/** Whether the tree had uncommitted changes at build time. */
|
||||
dirty: boolean;
|
||||
}
|
||||
|
||||
/** One deduplicated recent working dir for the spawn form's recents picker
|
||||
@@ -253,7 +271,12 @@ export type ClientControl =
|
||||
| { type: "Error"; code: string; message: string };
|
||||
|
||||
export interface ApiError {
|
||||
error: { code: string; message: string };
|
||||
error: {
|
||||
code: string;
|
||||
message: string;
|
||||
/** Set only by the kill guard (#79): what blocked the unforced kill. */
|
||||
unsaved_work?: InTheWay;
|
||||
};
|
||||
}
|
||||
|
||||
export function sessionName(s: Session): string {
|
||||
|
||||
Reference in New Issue
Block a user