naps62/maestro
Archived
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Select structured ACP adapters from the resolved agent command #200

New Issue
Closed
opened 2026-09-06 17:56:59 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-09-06 17:56:59 +01:00
Collaborator
Copy Link
Copy Source

Goal

Make the structured-session backend select an ACP adapter from the resolved agent command instead of always launching claude-code-acp.

Requirements

  • Introduce provider-aware adapter definitions for Claude Code and Codex, using claude-code-acp and the maintained @agentclientprotocol/codex-acp package respectively.
  • Resolve claude and codex through the repository's existing command-resolution semantics, including wrappers and path-qualified commands.
  • Use the session's persisted command to select the same adapter during daemon recovery and session/load; do not add a redundant provider field to the wire schema.
  • Make adapter lookup, child-process diagnostics, installation guidance, and authentication failures name the selected provider.
  • Reject unsupported structured commands explicitly instead of silently launching Claude.
  • Cover fresh spawn, failed spawn, shutdown, recovery, and resume selection with focused tests.

Contract

The current lifecycle is documented in docs/STRUCTURED-VIEW.md, especially “What a structured session is,” “The adapter,” and “Restart recovery.” Preserve its process ownership, bounded handshake, event-log, and cancellation guarantees.

Non-goals

  • Web or TUI spawn-form changes.
  • Codex-specific event compatibility beyond establishing the provider-aware transport.
  • Adding a general third-party ACP registry.
## Goal Make the structured-session backend select an ACP adapter from the resolved agent command instead of always launching `claude-code-acp`. ## Requirements - Introduce provider-aware adapter definitions for Claude Code and Codex, using `claude-code-acp` and the maintained `@agentclientprotocol/codex-acp` package respectively. - Resolve `claude` and `codex` through the repository's existing command-resolution semantics, including wrappers and path-qualified commands. - Use the session's persisted command to select the same adapter during daemon recovery and `session/load`; do not add a redundant provider field to the wire schema. - Make adapter lookup, child-process diagnostics, installation guidance, and authentication failures name the selected provider. - Reject unsupported structured commands explicitly instead of silently launching Claude. - Cover fresh spawn, failed spawn, shutdown, recovery, and resume selection with focused tests. ## Contract The current lifecycle is documented in `docs/STRUCTURED-VIEW.md`, especially “What a structured session is,” “The adapter,” and “Restart recovery.” Preserve its process ownership, bounded handshake, event-log, and cancellation guarantees. ## Non-goals - Web or TUI spawn-form changes. - Codex-specific event compatibility beyond establishing the provider-aware transport. - Adding a general third-party ACP registry.
naps62-yolo added this to the Codex structured sessions milestone 2026-09-06 17:56:59 +01:00
naps62-yolo added a new dependency 2026-09-06 17:57:00 +01:00
#201 Support Codex ACP configuration and lifecycle events
naps62-yolo added a new dependency 2026-09-06 17:57:00 +01:00
#202 Offer structured Codex sessions in the web spawn form
naps62-yolo added a new dependency 2026-09-06 17:57:00 +01:00
#203 Offer structured Codex sessions in the TUI spawn form
naps62-yolo added the area/daemondifficulty/hardtype/feat labels 2026-09-06 17:57:21 +01:00
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/android
area/cli
area/config
area/daemon
area/protocol
area/tui
area/web
code-review
difficulty/easy
difficulty/hard
difficulty/medium
epic
Tracks a multi-issue epic / parent work item
 tui
type/docs
type/feat
type/fix
type/refactor
type/test
No labels area/daemon difficulty/hard type/feat
Milestone
No items
No Milestone Codex structured sessions
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62-yolo (naps62-yolo (agent)) resende (Resende) naps62 (Miguel Palhas)
No Assignees
1 Participants
Due Date
No due date set.
Blocks
#201 Support Codex ACP configuration and lifecycle events
naps62/maestro
#202 Offer structured Codex sessions in the web spawn form
naps62/maestro
#203 Offer structured Codex sessions in the TUI spawn form
naps62/maestro
Reference: naps62/maestro#200