yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Seed a series without tracking its back catalogue #160

New Issue
Closed
opened 2026-08-24 11:23:46 +01:00 by naps62-yolo · 0 comments
naps62-yolo commented 2026-08-24 11:23:46 +01:00
Owner
Copy Link
Copy Source

Adding a series with auto_track on tracks every season it already has.
apply_auto_track is correct in isolation — it only touches seasons flagged
is_new — but the first metadata refresh of a newly added series flags all of
them, because the library has never seen any of them before.

Observed on the deployed build: Rick and Morty was added and came back with
S01–S09 tracked and 91 episodes wanted, and the daemon began grabbing the back
catalogue.

What to change

Per the amended §4.1: seasons revealed by a series' first refresh are never
tracked by auto_track. The rule applies from the second refresh onward.

series.metadata_refreshed_at (migration 0018_series_metadata_refresh)
already distinguishes the two — it is NULL until a refresh has stamped it. Pass
that fact into the decision rather than re-deriving it from row counts, which
would misclassify a series whose seasons had all been removed.

The decision belongs in arr-core::tracking alongside the rest of the rule.
arr-core has no IO and must not gain any: the caller supplies the fact, the
core decides.

Both callers need it:

  • crates/arr-daemon/src/series_refresh.rs — the daily refresh, the path that
    produced the bug.
  • crates/arr-api/src/series.rs — the add-a-season endpoint, which runs the
    same rule through the same function.

Done looks like

  • A series added with auto_track: true has no tracked seasons and no wanted
    episodes until a season appears that did not exist when it was added.
  • A season appearing on a later refresh of that same series is tracked, and its
    episodes arrive wanted.
  • Season 0 stays excluded on every path, as it is now.
  • Tests cover both: the seeding refresh tracking nothing, and the next refresh
    tracking a genuinely new season.

Non-goals

  • Do not change what Season.tracked does once set. Turning it on marks
    revealed episodes wanted; turning it off withdraws nothing (§4.1). That rule
    is unchanged.
  • Do not correct the existing Rick and Morty rows from code. That is a one-off
    operator action, not a migration.
  • No new column — metadata_refreshed_at is enough.

Depends on: #159

Adding a series with `auto_track` on tracks every season it already has. `apply_auto_track` is correct in isolation — it only touches seasons flagged `is_new` — but the first metadata refresh of a newly added series flags all of them, because the library has never seen any of them before. Observed on the deployed build: Rick and Morty was added and came back with S01–S09 tracked and 91 episodes wanted, and the daemon began grabbing the back catalogue. ## What to change Per the amended §4.1: seasons revealed by a series' *first* refresh are never tracked by `auto_track`. The rule applies from the second refresh onward. `series.metadata_refreshed_at` (migration `0018_series_metadata_refresh`) already distinguishes the two — it is NULL until a refresh has stamped it. Pass that fact into the decision rather than re-deriving it from row counts, which would misclassify a series whose seasons had all been removed. The decision belongs in `arr-core::tracking` alongside the rest of the rule. `arr-core` has no IO and must not gain any: the caller supplies the fact, the core decides. Both callers need it: - `crates/arr-daemon/src/series_refresh.rs` — the daily refresh, the path that produced the bug. - `crates/arr-api/src/series.rs` — the add-a-season endpoint, which runs the same rule through the same function. ## Done looks like - A series added with `auto_track: true` has no tracked seasons and no wanted episodes until a season appears that did not exist when it was added. - A season appearing on a later refresh of that same series is tracked, and its episodes arrive wanted. - Season 0 stays excluded on every path, as it is now. - Tests cover both: the seeding refresh tracking nothing, and the next refresh tracking a genuinely new season. ## Non-goals - Do not change what `Season.tracked` does once set. Turning it on marks revealed episodes wanted; turning it off withdraws nothing (§4.1). That rule is unchanged. - Do not correct the existing Rick and Morty rows from code. That is a one-off operator action, not a migration. - No new column — `metadata_refreshed_at` is enough. --- Depends on: #159
naps62-yolo added this to the Feedback pass milestone 2026-08-24 11:23:46 +01:00
naps62-yolo added the area/coredifficulty/hardtype/bugphase/6-tv labels 2026-08-24 11:23:46 +01:00
naps62-yolo added a new dependency 2026-08-24 11:23:53 +01:00
#159 Amend DESIGN.md for the feedback pass
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/core difficulty/hard phase/6-tv type/bug
Milestone
No items
No Milestone Feedback pass
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Depends on
#159 Amend DESIGN.md for the feedback pass
yolo/arr
Reference: yolo/arr#160