Add the OpenAI-compatible translation backend #191
No Assignees
Notifications
Due Date
No due date set.
Depends on
Reference: yolo/arr#191
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Implement the OpenAI-compatible translation backend behind its own cargo
feature, against the trait from #190.
One HTTP shape reaches the largest number of options: OpenAI itself,
OpenRouter, Groq, a self-hosted gateway, or a local
llama.cppserver. BaseURL and model are settings; the API key is config or environment per §10.
The prompt instructs a subtitle-appropriate translation into the exact target
variant — pt-PT is not pt-BR — and requires the reply to carry the same cue
numbering it was given, which #190 then validates. A refusal, a truncated reply
or a rate-limit response is an error the caller can distinguish, not a silent
partial translation.
Fixture responses in tests. No live endpoint.
Depends on: #190
Implemented the OpenAI-compatible translation backend behind the existing
translate-openaifeature:OpenAiincrates/arr-subs/src/openai.rsimplements thetranslate::Backendtrait from #190 against any/v1/chat/completions-shaped endpoint (OpenAI, OpenRouter, Groq, a self-hosted gateway,llama.cpp). The base URL and model are constructor arguments — settings, per the issue — whileOpenAiConfigcarries only the optional API key (bootstrap config/env, §10). Each batch travels as a JSON array of{number, text}objects and the reply is asked for in the same shape, so a multi-line cue's embedded newlines round-trip cleanly (a line-oriented reply format could not tell a multi-line cue from two cues). The system prompt names the exact target variant and, for pt-PT/pt-BR, gives concrete vocabulary the model must not reach for. A refusal, a content-filtered reply, or one cut short by the token limit each fail with a distinctError::Malformedbefore reaching validation, rather than being read as an empty or partial translation; the sharedtranslate()step still catches a mismatched cue count or numbering on its own, since this backend does not validate its own replies. 11 wiremock-backed integration tests cover the happy path, bearer auth, a markdown-fenced JSON reply, 401/429, refusal, content-filter, truncation, and the shared mismatch/unsupported-target paths; unit tests cover the prompt and code-fence stripping.just cipassed.Branch:
subtitles/191-openai-backendjust ci: passed (556 tests, 0 failed)Findings
Justfile'stestandlintrecipes) runs with default features only — no--features/--all-features. Every translation backend lands behind its own default-off feature (translate-openai, and #192/#193 to come), socargo clippyandcargo nextest runinjust cinever compile or run this code, or DeepL's/Google's once they land. I verified this backend separately withcargo check/clippy/test -p arr-subs --features translate-openai(all clean), but the shared gate gives no signal on any backend crate by itself. Whoever wires backend selection (#198) should also update thelint/testrecipes to add--all-features(or an explicit feature list) so the gate actually exercises compiled-in backends.