Configure subtitles: env secrets and database settings #198
No Assignees
Notifications
Due Date
No due date set.
Blocks
Depends on
Reference: yolo/arr#198
Reference in New Issue
Block a user
Wire subtitle configuration, split the way DESIGN.md §10 already splits it.
Config or environment — secrets and bootstrap only: OpenSubtitles and
Podnapisi credentials, translator API keys and base URLs, the remote-command
template, the
alassandffmpegbinary paths.Database, editable at runtime — everything that gets tuned: the wanted
language set, which providers are enabled and in what order, the selected
translation engine, per-provider and per-translator daily allowances, and the
per-call timeout for the remote-command backend.
Expose the database half through the API under the existing settings surface,
readable and writable, so #204 can render it. Never expose the secrets through
the API — not even masked. A key that reaches the database ends up in the
sqlite3 .backupon a timer, which §10 does not intend.A backend whose cargo feature is not compiled in must not be selectable; the
API reports which engines the running binary actually has.
Depends on: #186
Implemented the two halves of subtitle configuration DESIGN.md §15/§10 describes.
Bootstrap (config/env,
arr-daemon/src/config.rs): OpenSubtitles.com and Podnapisi credentials, the three HTTP translator backends' API keys and base URLs, the remote-command template, and thealass/ffmpegbinary paths. Secrets (all credentials and API keys) are env-only, following the existingdeny_unknown_fieldspattern — putting one in the TOML file is a parse error. Base URLs, the command template and the binary paths accept file or env, withalass/ffmpegdefaulting to a bare name resolved throughPATH.Database (migration
0025_subtitle_settings.sql+arr-api/src/subtitle_settings.rs): a single-rowsubtitle_settingstable holding the wanted language set, enabled providers in search order, the selected translation engine, per-provider and per-translator daily budgets, and the remote-command timeout. Exposed read/write atGET/PUT /api/settings/subtitles. Atranslation_engineselection is validated againstarr_subs::compiled_engines()— newpub const ENGINESandpub fn compiled_engines()inarr-subsreport which of the fourtranslate-*cargo features this binary actually has compiled in, so an uncompiled backend is a 422, not a silent no-op. The response also carriesavailable_enginesfor #204 to render. Nothing here reaches secrets: the table and its API surface never carry credentials.Not wired into
arr-daemon's reconcile loop or into actual provider/translator construction — those land with the providers themselves (#187, #188, #191–193), which weren't in scope here.Branch:
subtitles/198-subs-config, based onblitz/subtitles.just cipassed (fmt, clippy, machete, 503 tests, web-check).Findings
arr-subs'stranslate-*features are all still empty stubs (as intended per its own module docs), socompiled_engines()returns an empty list until #191/#192/#193 land — at that point the settings API will start accepting those engines with no further change needed here.