yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Add the subtitle section to settings #204

New Issue
Closed
opened 2026-08-24 21:28:40 +01:00 by naps62-yolo · 1 comment
naps62-yolo commented 2026-08-24 21:28:40 +01:00
Owner
Copy Link
Copy Source

Add the subtitle section to /settings, rendering the database half of #198:
the wanted language set, which providers are enabled and in what order, the
selected translation engine restricted to what the running binary has compiled
in, the daily allowances per provider and per translator, and the
remote-command timeout.

Secrets are not shown and not editable here — they are config and environment
per §10, and the API does not expose them at all.

The subtitle upstream lamps from #200 live in the same settings page's signal
chain section (§9.7), not in this section.

area/web: through the impeccable skill.

Depends on: #198

Add the subtitle section to `/settings`, rendering the database half of #198: the wanted language set, which providers are enabled and in what order, the selected translation engine restricted to what the running binary has compiled in, the daily allowances per provider and per translator, and the remote-command timeout. Secrets are not shown and not editable here — they are config and environment per §10, and the API does not expose them at all. The subtitle upstream lamps from #200 live in the same settings page's signal chain section (§9.7), not in this section. `area/web`: through the `impeccable` skill. Depends on: #198
naps62-yolo added this to the Subtitles milestone 2026-08-24 21:28:40 +01:00
naps62-yolo added the difficulty/easyarea/webphase/9-subtitlestype/feature labels 2026-08-24 21:28:40 +01:00
naps62-yolo added a new dependency 2026-08-24 21:29:28 +01:00
#198 Configure subtitles: env secrets and database settings
naps62-yolo commented 2026-08-25 05:09:10 +01:00
Author
Owner
Copy Link
Copy Source

Rendered the database half of subtitle config (#198) in /settings: a new SUBTITLES section with wanted languages, translation engine (dropdown restricted to available_engines, disabled with an explanatory note when no translate-* feature is compiled in), remote-command timeout, and a providers list — checkbox to enable, a daily-budget number, and up/down controls whose list order becomes providers_enabled's priority order. Translator daily budgets get one field per compiled engine. No secrets are shown or editable, per §10. Went through the impeccable skill first; reused the existing settings vocabulary (form-grid/field/chip/control-quiet) rather than inventing new components, and used up/down buttons instead of drag-and-drop for the reorder affordance since it's standard and keyboard-accessible. Verified in a live daemon via agent-browser: load, edit, save, reload round-trips correctly.

Branch: subtitles/204-subs-settings-ui
just ci: passed (685 tests, biome, tsc, token check all clean).

Findings

  • web/index.html had a pre-existing duplicate id="label-subtitles" — the missing-subtitles queue section (#202) already used that id. Because aria-labelledby resolves to document order, the settings SUBTITLES section's accessible name silently read "missing subtitles" until I renamed mine to label-settings-subtitles. Worth a quick audit for other duplicate ids introduced across the milestone's parallel branches once they land on the same tree.
Rendered the database half of subtitle config (#198) in `/settings`: a new SUBTITLES section with wanted languages, translation engine (dropdown restricted to `available_engines`, disabled with an explanatory note when no `translate-*` feature is compiled in), remote-command timeout, and a providers list — checkbox to enable, a daily-budget number, and up/down controls whose list order becomes `providers_enabled`'s priority order. Translator daily budgets get one field per compiled engine. No secrets are shown or editable, per §10. Went through the `impeccable` skill first; reused the existing settings vocabulary (`form-grid`/`field`/`chip`/`control-quiet`) rather than inventing new components, and used up/down buttons instead of drag-and-drop for the reorder affordance since it's standard and keyboard-accessible. Verified in a live daemon via `agent-browser`: load, edit, save, reload round-trips correctly. Branch: `subtitles/204-subs-settings-ui` `just ci`: passed (685 tests, biome, tsc, token check all clean). ## Findings - `web/index.html` had a pre-existing duplicate `id="label-subtitles"` — the missing-subtitles queue section (#202) already used that id. Because `aria-labelledby` resolves to document order, the settings SUBTITLES section's accessible name silently read "missing subtitles" until I renamed mine to `label-settings-subtitles`. Worth a quick audit for other duplicate ids introduced across the milestone's parallel branches once they land on the same tree.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/web difficulty/easy phase/9-subtitles type/feature
Milestone
No items
No Milestone Subtitles
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Depends on
#198 Configure subtitles: env secrets and database settings
yolo/arr
Reference: yolo/arr#204