yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Delete subtitle sidecars with their media file #218

New Issue
Closed
opened 2026-08-25 01:50:43 +01:00 by naps62-yolo · 1 comment
naps62-yolo commented 2026-08-25 01:50:43 +01:00
Owner
Copy Link
Copy Source

Deleting a season or an episode leaves its subtitle sidecars on disk with
nothing in the database pointing at them.

remove_library_files in crates/arr-api/src/series.rs resolves targets from
media_files rows, and for FileScope::Season / FileScope::Episode it
deletes the video file itself — only a whole-series delete removes the title
folder. remove_scope_files then deletes the media_files row in the same
transaction, and subtitle_files.media_file_id is ON DELETE CASCADE, so the
subtitle rows vanish while the .srt and .mt.srt files stay.

The result contradicts §7.4's audit-by-ls property in both directions: the
folder shows subtitles arr no longer believes in, and a later re-import fetches
a second copy alongside them.

The doc comment on remove_library_files — "Sidecars beside a removed episode
therefore stay; they are not rows this service wrote" — dates from #174/#175,
before #186 existed. Subtitle sidecars are rows this service wrote now, and
the comment should go with the fix.

Delete a media file's sidecars alongside the file, in the same transaction that
drops its rows.

Found while implementing #195.

Depends on: #186, #195

Deleting a season or an episode leaves its subtitle sidecars on disk with nothing in the database pointing at them. `remove_library_files` in `crates/arr-api/src/series.rs` resolves targets from `media_files` rows, and for `FileScope::Season` / `FileScope::Episode` it deletes the video file itself — only a whole-series delete removes the title folder. `remove_scope_files` then deletes the `media_files` row in the same transaction, and `subtitle_files.media_file_id` is `ON DELETE CASCADE`, so the subtitle rows vanish while the `.srt` and `.mt.srt` files stay. The result contradicts §7.4's audit-by-`ls` property in both directions: the folder shows subtitles arr no longer believes in, and a later re-import fetches a second copy alongside them. The doc comment on `remove_library_files` — "Sidecars beside a removed episode therefore stay; they are not rows this service wrote" — dates from #174/#175, before #186 existed. Subtitle sidecars *are* rows this service wrote now, and the comment should go with the fix. Delete a media file's sidecars alongside the file, in the same transaction that drops its rows. Found while implementing #195. Depends on: #186, #195
naps62-yolo added this to the Subtitles milestone 2026-08-25 01:50:43 +01:00
naps62-yolo added the area/apidifficulty/moderatetype/bugphase/9-subtitles labels 2026-08-25 01:50:43 +01:00
naps62-yolo added a new dependency 2026-08-25 01:50:50 +01:00
#195 Write subtitle sidecars into the title folder
naps62-yolo commented 2026-08-25 02:31:42 +01:00
Author
Owner
Copy Link
Copy Source

Fixed. remove_library_files (crates/arr-api/src/series.rs) now resolves and unlinks a media file's subtitle_files.path sidecars alongside the video for FileScope::Season and FileScope::Episode, using the same target-resolution pass as the video file, before the transaction that cascades the subtitle_files rows. Updated the stale doc comment that predated #186. Added a subtitle_paths query mirroring scope_paths, and two tests (removing_a_season_takes_its_subtitle_sidecars, removing_one_episode_takes_its_subtitle_sidecar) covering both scope boundaries. No migration needed — no schema change.

Branch: subtitles/218-delete-sidecars

just ci: passed (671 tests, fmt/lint/deps/web-check all green).

Findings

  • crates/arr-subs/src/translate.rs has 4 dead-code functions (strip_code_fence, language_name, variant_note, system_prompt) that trip cargo clippy -p arr-api --all-targets --all-features -- -D warnings when run standalone outside the full just ci invocation — pre-existing, unrelated to #218, not touched here.
Fixed. `remove_library_files` (`crates/arr-api/src/series.rs`) now resolves and unlinks a media file's `subtitle_files.path` sidecars alongside the video for `FileScope::Season` and `FileScope::Episode`, using the same target-resolution pass as the video file, before the transaction that cascades the `subtitle_files` rows. Updated the stale doc comment that predated #186. Added a `subtitle_paths` query mirroring `scope_paths`, and two tests (`removing_a_season_takes_its_subtitle_sidecars`, `removing_one_episode_takes_its_subtitle_sidecar`) covering both scope boundaries. No migration needed — no schema change. Branch: `subtitles/218-delete-sidecars` `just ci`: passed (671 tests, fmt/lint/deps/web-check all green). ## Findings - `crates/arr-subs/src/translate.rs` has 4 dead-code functions (`strip_code_fence`, `language_name`, `variant_note`, `system_prompt`) that trip `cargo clippy -p arr-api --all-targets --all-features -- -D warnings` when run standalone outside the full `just ci` invocation — pre-existing, unrelated to #218, not touched here.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/api difficulty/moderate phase/9-subtitles type/bug
Milestone
No items
No Milestone Subtitles
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Depends on
#195 Write subtitle sidecars into the title folder
yolo/arr
Reference: yolo/arr#218