yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Clear subtitle attempts when a language is dropped #224

New Issue
Closed
opened 2026-08-25 04:55:03 +01:00 by naps62-yolo · 1 comment
naps62-yolo commented 2026-08-25 04:55:03 +01:00
Owner
Copy Link
Copy Source

Narrowing wanted_languages in /settings leaves the subtitle_attempts
rows for the dropped language behind. Nothing deletes them, and nothing marks
them irrelevant.

Today the consequences are hidden because both readers bound their output by
the current wanted set — #201's missing_for on title detail and #202's
queue both filter dropped languages out. The rows are still there, so:

  • Re-adding a language later resurrects its old attempt history, including its
    backoff counter and last_failure, as though the attempts had just happened.
    A language dropped a month ago and re-added comes back already backed off.
  • The table grows without bound as the wanted set is edited.

Clear the attempt rows for a language when it leaves wanted_languages, in
the settings-update handler that already writes the row. Subtitle files for
that language must stay — they are on disk and §15's no-upgrade rule still
applies to them; it is only the attempt bookkeeping that should go.

Found while implementing #202.

Depends on: #186, #198, #202

Narrowing `wanted_languages` in `/settings` leaves the `subtitle_attempts` rows for the dropped language behind. Nothing deletes them, and nothing marks them irrelevant. Today the consequences are hidden because both readers bound their output by the current wanted set — #201's `missing_for` on title detail and #202's queue both filter dropped languages out. The rows are still there, so: - Re-adding a language later resurrects its old attempt history, including its backoff counter and `last_failure`, as though the attempts had just happened. A language dropped a month ago and re-added comes back already backed off. - The table grows without bound as the wanted set is edited. Clear the attempt rows for a language when it leaves `wanted_languages`, in the settings-update handler that already writes the row. Subtitle *files* for that language must stay — they are on disk and §15's no-upgrade rule still applies to them; it is only the attempt bookkeeping that should go. Found while implementing #202. Depends on: #186, #198, #202
naps62-yolo added this to the Subtitles milestone 2026-08-25 04:55:03 +01:00
naps62-yolo added the difficulty/easyarea/apiphase/9-subtitlestype/bug labels 2026-08-25 04:55:04 +01:00
naps62-yolo commented 2026-08-25 05:34:51 +01:00
Author
Owner
Copy Link
Copy Source

Implemented as scoped. PUT /api/settings/subtitles now diffs the previous
wanted_languages against the new payload before writing the row, and — in
the same transaction as the settings update — deletes every subtitle_attempts
row whose language left the wanted set. Subtitle files themselves are
untouched; only the attempt bookkeeping (backoff counter, last_failure,
state) is cleared, so re-adding a language later starts its attempts fresh
instead of resurrecting a stale backoff. Added a test seeding attempts for a
kept and a dropped language and asserting only the kept one survives the PUT.

Branch: subtitles/224-clear-attempts

just ci passed (fmt, clippy, cargo nextest — 686 passed, web check).

Findings

None outside this issue's scope.

Implemented as scoped. `PUT /api/settings/subtitles` now diffs the previous `wanted_languages` against the new payload before writing the row, and — in the same transaction as the settings update — deletes every `subtitle_attempts` row whose language left the wanted set. Subtitle files themselves are untouched; only the attempt bookkeeping (backoff counter, `last_failure`, state) is cleared, so re-adding a language later starts its attempts fresh instead of resurrecting a stale backoff. Added a test seeding attempts for a kept and a dropped language and asserting only the kept one survives the PUT. Branch: `subtitles/224-clear-attempts` `just ci` passed (fmt, clippy, cargo nextest — 686 passed, web check). ## Findings None outside this issue's scope.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/api difficulty/easy phase/9-subtitles type/bug
Milestone
No items
No Milestone Subtitles
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yolo/arr#224