yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Fetch subtitles from Podnapisi #188

New Issue
Closed
opened 2026-08-24 21:28:32 +01:00 by naps62-yolo · 1 comment
naps62-yolo commented 2026-08-24 21:28:32 +01:00
Owner
Copy Link
Copy Source

Implement the Podnapisi provider against the same Provider trait from #184,
so the trait has two real implementations rather than one and its shape is
tested by more than a single example.

Same contract as #187: search by the identifiers available, return candidates
carrying the fields #185 ranks on, download a chosen candidate to a temporary
path. Podnapisi has no moviehash lane, so its candidates rank on release-name
matching and below — which is exactly what the ranker already expresses, with
no special case for the provider.

Credentials, if any, come from config or environment per DESIGN.md §10.
Fixture responses in tests, never the live service.

Depends on: #184

Implement the Podnapisi provider against the same `Provider` trait from #184, so the trait has two real implementations rather than one and its shape is tested by more than a single example. Same contract as #187: search by the identifiers available, return candidates carrying the fields #185 ranks on, download a chosen candidate to a temporary path. Podnapisi has no `moviehash` lane, so its candidates rank on release-name matching and below — which is exactly what the ranker already expresses, with no special case for the provider. Credentials, if any, come from config or environment per DESIGN.md §10. Fixture responses in tests, never the live service. Depends on: #184
naps62-yolo added this to the Subtitles milestone 2026-08-24 21:28:32 +01:00
naps62-yolo added the area/subsphase/9-subtitlestype/featuredifficulty/moderate labels 2026-08-24 21:28:32 +01:00
naps62-yolo added a new dependency 2026-08-24 21:29:27 +01:00
#184 Add the arr-subs crate with the provider trait
naps62-yolo added a new dependency 2026-08-24 21:29:27 +01:00
#196 Close the subtitle gap in the reconcile loop
naps62-yolo added a new dependency 2026-08-24 21:29:28 +01:00
#199 Serve the subtitle API
naps62-yolo commented 2026-08-24 22:57:28 +01:00
Author
Owner
Copy Link
Copy Source

Implemented the Podnapisi.net Provider: search hits search/advanced (keyworded on the file's release name, since Podnapisi has no id-based lookup), paginates and dedupes by pid, and maps results to Candidate with hash_match always false per the issue. Release group and source are recovered by running arr_parse::parse over the matched release name (reusing the existing arr_parse::Source -> arr_core::Source conversion), and pt-PT/pt-BR is resolved through arr_core::lang::resolve_portuguese, using the release name's language markers and Podnapisi's own language tag as evidence — the same signal machinery arr-probe already uses. Download unzips the single-file archive Podnapisi serves and maps the extension to SubtitleFormat. The candidate id round-trips the resolved language ({pid}|{language}) so download doesn't need a second lookup to know what language it's returning.

No credentials are used — the real API (verified against subliminal's current, maintained provider) is unauthenticated for both search and download. Added Error::Config to arr-subs's shared error type for provider construction failures (bad base URL, HTTP client build failure); reusable by future providers.

Branch: subtitles/188-podnapisi. just ci passed (537/537 tests).

Findings

  • ARR_PODNAPISI_USERNAME/ARR_PODNAPISI_PASSWORD exist in arr-daemon's config (#198) but nothing in this provider consumes them — Podnapisi's search/download API doesn't require login in the reference implementation I checked. If there's a known login flow that raises Podnapisi's daily download cap, it needs its own issue; I didn't want to guess an unverified auth flow into this crate.
  • Candidate.rating and Candidate.download_count are always None for Podnapisi — I found no documented field for either in its JSON API. Ranking's tiebreakers are effectively unavailable for this provider; worth a follow-up if Podnapisi does expose them under a different key.
  • No provider is wired into arr-daemon yet (neither this one nor OpenSubtitles) — reconcile-loop construction from config/settings is still open work, outside this issue's scope.
Implemented the Podnapisi.net `Provider`: search hits `search/advanced` (keyworded on the file's release name, since Podnapisi has no id-based lookup), paginates and dedupes by pid, and maps results to `Candidate` with `hash_match` always `false` per the issue. Release group and source are recovered by running `arr_parse::parse` over the matched release name (reusing the existing `arr_parse::Source -> arr_core::Source` conversion), and pt-PT/pt-BR is resolved through `arr_core::lang::resolve_portuguese`, using the release name's language markers and Podnapisi's own `language` tag as evidence — the same signal machinery `arr-probe` already uses. Download unzips the single-file archive Podnapisi serves and maps the extension to `SubtitleFormat`. The candidate id round-trips the resolved language (`{pid}|{language}`) so `download` doesn't need a second lookup to know what language it's returning. No credentials are used — the real API (verified against `subliminal`'s current, maintained provider) is unauthenticated for both search and download. Added `Error::Config` to `arr-subs`'s shared error type for provider construction failures (bad base URL, HTTP client build failure); reusable by future providers. Branch: `subtitles/188-podnapisi`. `just ci` passed (537/537 tests). ## Findings - `ARR_PODNAPISI_USERNAME`/`ARR_PODNAPISI_PASSWORD` exist in `arr-daemon`'s config (#198) but nothing in this provider consumes them — Podnapisi's search/download API doesn't require login in the reference implementation I checked. If there's a known login flow that raises Podnapisi's daily download cap, it needs its own issue; I didn't want to guess an unverified auth flow into this crate. - `Candidate.rating` and `Candidate.download_count` are always `None` for Podnapisi — I found no documented field for either in its JSON API. Ranking's tiebreakers are effectively unavailable for this provider; worth a follow-up if Podnapisi does expose them under a different key. - No provider is wired into `arr-daemon` yet (neither this one nor OpenSubtitles) — reconcile-loop construction from config/settings is still open work, outside this issue's scope.
naps62-yolo added a new dependency 2026-08-25 00:41:34 +01:00
#215 Drop or use the unused Podnapisi credentials
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/subs difficulty/moderate phase/9-subtitles type/feature
Milestone
No items
No Milestone Subtitles
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#196 Close the subtitle gap in the reconcile loop
yolo/arr
#199 Serve the subtitle API
yolo/arr
#215 Drop or use the unused Podnapisi credentials
yolo/arr
Depends on
#184 Add the arr-subs crate with the provider trait
yolo/arr
Reference: yolo/arr#188