yolo/arr
3
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Drop or use the unused Podnapisi credentials #215

New Issue
Closed
opened 2026-08-25 00:41:21 +01:00 by naps62-yolo · 1 comment
naps62-yolo commented 2026-08-25 00:41:21 +01:00
Owner
Copy Link
Copy Source

arr-daemon's config carries podnapisi_username and podnapisi_password
(#198), but nothing reads them. arr_subs::Podnapisi has no credential
surface at all — PodnapisiBuilder takes a base URL and a timeout.

Both #188 and #199 reported this independently. #188 checked the reference
implementation (subliminal's maintained provider) and found search and
download unauthenticated, so the fields were speculative.

Either drop the two fields, or — if logging in demonstrably raises Podnapisi's
daily download cap — give the provider a credential surface and use them.
Do not leave config the operator can set and the service ignores: §10's
bootstrap config is meant to be the honest list of what arr reads.

Depends on: #188, #198

`arr-daemon`'s config carries `podnapisi_username` and `podnapisi_password` (#198), but nothing reads them. `arr_subs::Podnapisi` has no credential surface at all — `PodnapisiBuilder` takes a base URL and a timeout. Both #188 and #199 reported this independently. #188 checked the reference implementation (`subliminal`'s maintained provider) and found search and download unauthenticated, so the fields were speculative. Either drop the two fields, or — if logging in demonstrably raises Podnapisi's daily download cap — give the provider a credential surface and use them. Do not leave config the operator can set and the service ignores: §10's bootstrap config is meant to be the honest list of what arr reads. Depends on: #188, #198
naps62-yolo added this to the Subtitles milestone 2026-08-25 00:41:21 +01:00
naps62-yolo added the area/subsdifficulty/easyphase/9-subtitlestype/chore labels 2026-08-25 00:41:21 +01:00
naps62-yolo added a new dependency 2026-08-25 00:41:34 +01:00
#188 Fetch subtitles from Podnapisi
naps62-yolo commented 2026-08-25 06:49:01 +01:00
Author
Owner
Copy Link
Copy Source

Dropped the unused Podnapisi credentials rather than wiring them in. #188 established that Podnapisi's search and download are unauthenticated (matching subliminal's maintained provider), and demonstrating that login raises the daily cap would require testing against the live tracker, so there was no basis for a credential surface on arr_subs::Podnapisi. Removed ARR_PODNAPISI_USERNAME/ARR_PODNAPISI_PASSWORD and their Config, EnvOverrides and SubtitleBootstrap fields — §10's bootstrap list is again exactly what arr reads. One commit, feat(arr): drop unused podnapisi credentials, only crates/arr-daemon/src/config.rs touched.

Branch: subtitles/215-podnapisi-creds

just ci passed via the gate script (704 tests, fmt, clippy, biome, token check).

Findings

  • The health lamp's "unconfigured" detail text (crates/arr-api/src/health.rs:279) says "{id} is enabled but not configured — credentials are bootstrap config". For podnapisi that wording is wrong: it takes no credentials and is always attached in production, so this branch is only reachable for opensubtitles (or in tests). Cosmetic; worth a reword if anyone touches that file.
Dropped the unused Podnapisi credentials rather than wiring them in. #188 established that Podnapisi's search and download are unauthenticated (matching subliminal's maintained provider), and demonstrating that login raises the daily cap would require testing against the live tracker, so there was no basis for a credential surface on `arr_subs::Podnapisi`. Removed `ARR_PODNAPISI_USERNAME`/`ARR_PODNAPISI_PASSWORD` and their `Config`, `EnvOverrides` and `SubtitleBootstrap` fields — §10's bootstrap list is again exactly what arr reads. One commit, `feat(arr): drop unused podnapisi credentials`, only `crates/arr-daemon/src/config.rs` touched. Branch: `subtitles/215-podnapisi-creds` `just ci` passed via the gate script (704 tests, fmt, clippy, biome, token check). ## Findings - The health lamp's "unconfigured" detail text (`crates/arr-api/src/health.rs:279`) says "*{id}* is enabled but not configured — credentials are bootstrap config". For podnapisi that wording is wrong: it takes no credentials and is always attached in production, so this branch is only reachable for opensubtitles (or in tests). Cosmetic; worth a reword if anyone touches that file.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
arr-api
 area/ci
CI and test harness
 area/compat
arr-compat
 area/core
arr-core
 area/daemon
arr-daemon
 area/db
arr-db
 area/dl
arr-dl
 area/indexer
arr-indexer
 area/infra
workspace and tooling
 area/meta
arr-meta
 area/parse
arr-parse
 area/probe
arr-probe
 area/subs
arr-subs crate: providers, extraction, translation, sync
 area/web
web/
 difficulty/easy
bounded, obvious approach, few files
 difficulty/hard
subtle correctness or cross-cutting
 difficulty/moderate
multiple files, judgement, an interface to design
 difficulty/trivial
one file, mechanical, no design decisions
 phase/1-skeleton
workspace, CI, config, database, empty API and SPA
 phase/2-logic
parsing and policy engine, pure, no network
 phase/3-sourcing
TMDB and Prowlarr, read-only
 phase/4-movies
movies end to end
 phase/5-ui
search, buckets, library views, queues
 phase/6-tv
seasons, episodes, tracking, derived status
 phase/7-people
owner tags and notifications
 phase/8-compat
Jellyseerr shim
 phase/9-subtitles
build order: subtitles, DESIGN.md §15
 type/bug
type/chore
type/feature
type/test
No labels area/subs difficulty/easy phase/9-subtitles type/chore
Milestone
No items
No Milestone Subtitles
Projects
Clear projects
No projects
Assignees
Clear assignees
hermes (Hermes (agent)) naps62 (Miguel Palhas) naps62-yolo (naps62-yolo (agent))
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Depends on
#188 Fetch subtitles from Podnapisi
yolo/arr
Reference: yolo/arr#215